Re: [Devel] [RFC PATCH vz9 v6 42/62] dm-ploop: properly end pios attached to piwb pios

2025-01-20 Thread Alexander Atanasov
On 17.01.25 10:23, Pavel Tikhomirov wrote: Seems like an excess patch (leads to double ploop_pio_endio), as the only caller of ploop_data_pio_end already does: Agree, dropped     if (pio->is_data_alloc) {     completed = ploop_data_pio_end(pio);     if (!compl

Re: [Devel] [RFC PATCH vz9 v6 42/62] dm-ploop: properly end pios attached to piwb pios

2025-01-17 Thread Pavel Tikhomirov
Seems like an excess patch (leads to double ploop_pio_endio), as the only caller of ploop_data_pio_end already does: if (pio->is_data_alloc) { completed = ploop_data_pio_end(pio); if (!completed) return; } ploop_pio

[Devel] [RFC PATCH vz9 v6 42/62] dm-ploop: properly end pios attached to piwb pios

2024-12-05 Thread Alexander Atanasov
Fix a bug in ploop_data_pio_end. If piwb is already completed, which can happen if we attach a flush pio to it, pio is not added to the list and ploop_pio_endio is never called on it. This results in a hang since pio is never completed. Avoid this by calling ploop_pio_endio directly in case piwb