Re: Strangeness in 842 Fix

2025-04-18 Thread Hal Murray via devel
matthew.sel...@twosigma.com said: > Sounds good (either commenting or trying this again). I'll proceed with > cu= tting the release very late tonight. Great. Thanks. ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo

Re: Strangeness in 842 Fix

2025-04-17 Thread Hal Murray via devel
Fred Wright said: > If that's really true, then SCM_TIMESTAMPNS_OLD should be defined any > time that SO_TIMESTAMPNS_OLD is defined, so using the correct macro > should work. If SCM_TIMESTAMPNS_OLD is *not* defined in this case (but > the correct value is known) There are a couple of shoulds in t

Re: Strangeness in 842 Fix

2025-04-16 Thread Matt Selsky via devel
Hi Hal, Sounds good (either commenting or trying this again). I'll proceed with cutting the release very late tonight. Thanks, -Matt ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel

Re: Strangeness in 842 Fix

2025-04-15 Thread Fred Wright via devel
On Mon, 14 Apr 2025, Hal Murray wrote: If the values are identical, then it's not functionally incorrect, but it's certainly conceptually incorrect to compare an SO_* value to a cmsg_type field. And if the values are identical, it wouldn't change the behavior to use the correct name. Sorry

Re: Strangeness in 842 Fix

2025-04-15 Thread Hal Murray via devel
> If the values are identical, then it's not functionally incorrect, but > it's certainly conceptually incorrect to compare an SO_* value to a > cmsg_type field. And if the values are identical, it wouldn't change the > behavior to use the correct name. Sorry, I guess my previous message wasn

Re: Strangeness in 842 Fix

2025-04-14 Thread Matt Selsky via devel
On Mon, Apr 14, 2025 at 03:16:46PM -0700, Fred Wright via devel wrote: > > I was just looking at recent changes, and came across commit 4756b6317. I > don't know anything specifically about the *_TIMESTAMPNS_OLD stuff, but I do > know that the SO_* symbols are for the socket options and the SCM_*

Re: Strangeness in 842 Fix

2025-04-14 Thread James Browning via devel
On Monday, April 14, 2025 3:16:46 PM Pacific Daylight Time Fred Wright via devel wrote: > I was just looking at recent changes, and came across commit 4756b6317. > I don't know anything specifically about the *_TIMESTAMPNS_OLD stuff, but > I do know that the SO_* symbols are for the socket options

Strangeness in 842 Fix

2025-04-14 Thread Fred Wright via devel
I was just looking at recent changes, and came across commit 4756b6317. I don't know anything specifically about the *_TIMESTAMPNS_OLD stuff, but I do know that the SO_* symbols are for the socket options and the SCM_* symbols are for the CMSG types, so I don't see how this could possibly be

Re: Strangeness in 842 Fix

2025-04-14 Thread Fred Wright via devel
On Mon, 14 Apr 2025, Hal Murray wrote: I do know that the SO_* symbols are for the socket options and the SCM_* symbols are for the CMSG types, so I don't see how this could possibly be correct. Note the code immediately above it. The OLD stuff is a mess. I did it the way you expect, but

Re: Strangeness in 842 Fix

2025-04-14 Thread Hal Murray via devel
> I do know that the SO_* symbols are for the socket options and the SCM_* > symbols are for the CMSG types, so I don't see how this could possibly be > correct. Note the code immediately above it. The OLD stuff is a mess. I did it the way you expect, but that didn't work because SCM_TIMESTA