Re: I think we can drop the Jupiter driver.

2017-04-25 Thread Eric S. Raymond via devel
Hal Murray : > > >> You could use it as an example of how to do it right. > > Er, *what*? > > Fix the code. Do it right and cleanly. Add a comment pointing to the page > with a full description of the whole mess. Have that page point back there > as an example of how to fix the GPS week rol

Re: I think we can drop the Jupiter driver.

2017-04-25 Thread Eric S. Raymond via devel
Mark Atwood via devel : > I find it unlikely we're going to find a real Jupiter to test against, if > nobody has raised this issue against NTP Classic. I do, too. Seventeen years! *plonk* -- http://www.catb.org/~esr/";>Eric S. Raymond Please consider contributing to my Patreon p

Re: I think we can drop the Jupiter driver.

2017-04-25 Thread Trevor N. via devel
I created a loop like that for the Trimble driver. The algorithm is pretty simple so I'm probably missing something; please check out the merge request I made a few days ago. I still need to test the changes with my simulator and with ntpd started with date offsets. >Hal Murray hmurray at megapa

Re: I think we can drop the Jupiter driver.

2017-04-25 Thread Mark Atwood via devel
I find it unlikely we're going to find a real Jupiter to test against, if nobody has raised this issue against NTP Classic. ..m On Tue, Apr 25, 2017 at 5:22 PM Gary E. Miller via devel wrote: > Yo Hal! > > On Tue, 25 Apr 2017 17:16:58 -0700 > Hal Murray via devel wrote: > > > >> You could use

Re: I think we can drop the Jupiter driver.

2017-04-25 Thread Gary E. Miller via devel
Yo Hal! On Tue, 25 Apr 2017 17:16:58 -0700 Hal Murray via devel wrote: > >> You could use it as an example of how to do it right. > > Er, *what*? > > Fix the code. Do it right and cleanly. I'm all for that, but until we find a real Jupiter user we can't test, and are fixing it to no purp

Re: I think we can drop the Jupiter driver.

2017-04-25 Thread Hal Murray via devel
>> You could use it as an example of how to do it right. > Er, *what*? Fix the code. Do it right and cleanly. Add a comment pointing to the page with a full description of the whole mess. Have that page point back there as an example of how to fix the GPS week roll over problem. It's not a

Re: I think we can drop the Jupiter driver.

2017-04-25 Thread Eric S. Raymond via devel
Hal Murray : > > devel@ntpsec.org said: > > I think we can drop the Jupiter driver. I looked for rollover compensation > > and didn't find it. Instead there's this at line 1019: > > You could use it as an example of how to do it right. Er, *what*? --

Re: I think we can drop the Jupiter driver.

2017-04-25 Thread Hal Murray via devel
devel@ntpsec.org said: > I think we can drop the Jupiter driver. I looked for rollover compensation > and didn't find it. Instead there's this at line 1019: You could use it as an example of how to do it right. -- These are my opinio

I think we can drop the Jupiter driver.

2017-04-25 Thread Eric S. Raymond via devel
I think we can drop the Jupiter driver. I looked for rollover compensation and didn't find it. Instead there's this at line 1019: instance->timecode = GPS_EPOCH + (instance->gweek * WEEKSECS) + sweek; I think that means this driver will have timewarp