I think we can drop the Jupiter driver. I looked for rollover compensation and didn't find it. Instead there's this at line 1019:
instance->timecode = GPS_EPOCH + (instance->gweek * WEEKSECS) + sweek; I think that means this driver will have timewarped as of the GPS rollover in August 1999 and it's been busted for *18 years.* Jeez. Is there no end to the undetected lossage in this codebase? Other GPS-based refclocks will have to be checked for the same issue. The magnavox, oncore, trimble, truetime, and spectracom drivers might well be broken the same way, and I'd like to hear Hal weigh in on hpgps. Hal, Gary, would you please be additional eyeballs on this? -- <a href="http://www.catb.org/~esr/">Eric S. Raymond</a> The whole of the Bill [of Rights] is a declaration of the right of the people at large or considered as individuals... It establishes some rights of the individual as unalienable and which consequently, no majority has a right to deprive them of. -- Albert Gallatin, Oct 7 1789 _______________________________________________ devel mailing list devel@ntpsec.org http://lists.ntpsec.org/mailman/listinfo/devel