Re: Buggy WNRO fixup

2022-02-12 Thread Hal Murray via devel
Thanks for testing. > With these changes I see no WNRO messages thus far... Would you please check again. I expect 1 each time you start ntpd. -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org

Re: Buggy WNRO fixup

2022-02-12 Thread Gary E. Miller via devel
Yo Udo! On Sat, 12 Feb 2022 12:35:43 +0100 Udo van den Heuvel wrote: > On 12-02-2022 07:36, Gary E. Miller via devel wrote: > > A capture of the raw NMEA would be helpful. > > The other gps18x does not show the wrong date. > So would a reset of the 'wrong date' gps18x work? > Powerdown/up? Y

Re: Buggy WNRO fixup

2022-02-12 Thread Udo van den Heuvel via devel
On 12-02-2022 08:37, Hal Murray wrote: Please try git head. I fixed my test case. Updated git again a few minutes ago. With these changes I see no WNRO messages thus far... If this was the intended behaviour: THANKS! Udo ___ devel mailing list dev

Re: Buggy WNRO fixup

2022-02-12 Thread Udo van den Heuvel via devel
On 12-02-2022 07:36, Gary E. Miller via devel wrote: A capture of the raw NMEA would be helpful. The other gps18x does not show the wrong date. So would a reset of the 'wrong date' gps18x work? Powerdown/up? Udo ___ devel mailing list devel@ntpsec.or

Re: Buggy WNRO fixup

2022-02-12 Thread Udo van den Heuvel via devel
On 12-02-2022 08:37, Hal Murray wrote: Please try git head. I fixed my test case. Feb 12 12:17:10 plnksrf ntpd[148641]: INIT: ntpd ntpsec-1.2.1: Starting Feb 12 12:17:10 plnksrf ntpd[148641]: INIT: Command line: /usr/sbin/ntpd -u ntp:ntp -x -N -p /var/run/ntpd.pid Feb 12 12:17:10 plnksrf nt

Re: Buggy WNRO fixup

2022-02-11 Thread Hal Murray via devel
Please try git head. I fixed my test case. -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel

Re: Buggy WNRO fixup

2022-02-11 Thread Hal Murray via devel
> A capture of the raw NMEA would be helpful. But don't work too hard on it. I have a test case. Fix soon. -- These are my opinions. I hate spam. ___ devel mailing list devel@ntpsec.org https://lists.ntpsec.org/mailman/listinfo/devel

Re: Buggy WNRO fixup

2022-02-11 Thread Gary E. Miller via devel
Yo Udo! A capture of the raw NMEA would be helpful. On Sat, 12 Feb 2022 06:52:47 +0100 Udo van den Heuvel via devel wrote: > On 12-02-2022 06:45, Hal Murray wrote: > > > > devel@ntpsec.org said: > >> Is this an effect? I get loads of these: > >> Feb 6 00:00:28 srfplnk2 ntpd[510014]: REFCLOC

Re: Buggy WNRO fixup

2022-02-11 Thread Udo van den Heuvel via devel
On 12-02-2022 06:45, Hal Murray wrote: devel@ntpsec.org said: Is this an effect? I get loads of these: Feb 6 00:00:28 srfplnk2 ntpd[510014]: REFCLOCK: NMEA(0) date advanced by 0 weeks, WNRO That's a bug. Looks like it's alternating between 0 and 1024. Which sentence(s) are you using? Wha

Re: Buggy WNRO fixup

2022-02-11 Thread Hal Murray via devel
devel@ntpsec.org said: > Is this an effect? I get loads of these: > Feb 6 00:00:28 srfplnk2 ntpd[510014]: REFCLOCK: NMEA(0) date advanced by 0 > weeks, WNRO That's a bug. Looks like it's alternating between 0 and 1024. Which sentence(s) are you using? What's your server line? (the mode pa

Re: Buggy WNRO fixup

2022-02-11 Thread Udo van den Heuvel via devel
On 20-12-2021 21:51, Hal Murray via devel wrote: I have a NMEA unit that's off by 1024 weeks. Somebody is fixing it twice. Anybody know where that fixup code is located? I took a quick scan in the NMEA driver but didn't find it. Is this an effect? I get loads of these: Feb 6 00:00:28 sr

Re: Buggy WNRO fixup

2021-12-29 Thread Gary E. Miller via devel
Yo Hal! On Wed, 29 Dec 2021 13:31:44 -0800 Hal Murray via devel wrote: > Gary said: > >> The code I was expecting doesn't know anything about leaps. > >> It would be close to: > >> while (t < PIVOT) t += 1024*7*86400 > > > Which will break after 1024 weeks. Which sounds like a lot, but > >

Re: Buggy WNRO fixup

2021-12-29 Thread Hal Murray via devel
Gary said: >> The code I was expecting doesn't know anything about leaps. >> It would be close to: >> while (t < PIVOT) t += 1024*7*86400 > Which will break after 1024 weeks. Which sounds like a lot, but there are a > lot of GPS that are more than 1024 weeks old since their firmware was cut.

Re: Buggy WNRO fixup

2021-12-29 Thread Gary E. Miller via devel
Yo Hal! On Wed, 29 Dec 2021 03:02:00 -0800 Hal Murray via devel wrote: > Gary said: > > Basically, if the GPS reports more the 17 leap seconds, then the > > time has to be aster 1 Jan 2017. > > Thanks. > > I assume the leap second tangle is so avoid breaking some very old > test cases by bum

Re: Buggy WNRO fixup

2021-12-29 Thread Hal Murray via devel
rlaa...@wiktel.com said: > This is what you're thinking of (slightly trimmed): ... Thanks. I wonder how long it would have taken me to find that. Gary said: > Basically, if the GPS reports more the 17 leap seconds, then the time has to > be aster 1 Jan 2017. Thanks. I assume the leap secon

Re: Buggy WNRO fixup

2021-12-29 Thread Richard Laager via devel
On 12/28/21 3:35 PM, Hal Murray via devel wrote: Is there any magic not-before date in the ntpsec environment? I think we used to have the build date in the version string but that was removed to make builds reproducable. I thought we added something in a #define someplace with the idea that it

Re: Buggy WNRO fixup

2021-12-29 Thread Gary E. Miller via devel
Yo Hal! On Tue, 28 Dec 2021 13:35:33 -0800 Hal Murray wrote: > > That is the important part. gpsd handles that just fine: > > Is there anything tricky about the fixup code? Nope. gpsd/timebase.c, line 322. Here is the meat: /* sanity check unix time against leap second. * Does n

Re: Buggy WNRO fixup

2021-12-28 Thread Hal Murray via devel
> That is the important part. gpsd handles that just fine: Is there anything tricky about the fixup code? I was expecting a few lines of code. The existing code is much much more complicated than that. --- Is there any magic not-before date in the ntpsec environment? I think we used t

Re: Buggy WNRO fixup

2021-12-25 Thread Gary E. Miller via devel
Yo Hal! On Fri, 24 Dec 2021 12:01:50 -0800 Hal Murray wrote: > >> I have a NMEA unit that's off by 1024 weeks. Somebody > >> is fixing it twice. > > How do you know that? > > The time on that system got set to Nov 4 2023 > > The "twice" part was sloppy, but something strange was going o

Re: Buggy WNRO fixup

2021-12-25 Thread Hal Murray via devel
>> I have a NMEA unit that's off by 1024 weeks. Somebody >> is fixing it twice. > How do you know that? The time on that system got set to Nov 4 2023 The "twice" part was sloppy, but something strange was going on. The log message says -4096 weeks which just adds to my confusion. 20 Dec 12:

Re: Buggy WNRO fixup

2021-12-24 Thread Hal Murray via devel
[The lists have a 2 day delay. Please be sure to cc me if you have anything helpful to contribute.] The code is in ntpd/ntp_wrapdate.c Is anybody familiar with that code? I've looked a bit but haven't figured out what is supposed to happen and/or what is going wrong. Does anybody have a de

Re: Buggy WNRO fixup

2021-12-24 Thread Gary E. Miller via devel
Yo Hal! On Mon, 20 Dec 2021 12:51:53 -0800 Hal Murray via devel wrote: > I have a NMEA unit that's off by 1024 weeks. Somebody is fixing it > twice. How do you know that? > Anybody know where that fixup code is located? I took a quick scan > in the NMEA driver but didn't find it. I don't th

Buggy WNRO fixup

2021-12-22 Thread Hal Murray via devel
I have a NMEA unit that's off by 1024 weeks. Somebody is fixing it twice. Anybody know where that fixup code is located? I took a quick scan in the NMEA driver but didn't find it. -- These are my opinions. I hate spam. ___ devel mailing list