Re: Is it time to --enable-warnings?

2025-02-11 Thread Richard Laager via devel
On 2025-02-11 20:08, Hal Murray via devel wrote: --disable-Werror will turn it off. My expectation is that with a few fixes like yours we won't have many problems. If that turns out to be wrong, we can change the default. I haven't been following this closely, so I'm not sure what you changed

Re: Is it time to --enable-warnings?

2025-02-11 Thread Hal Murray via devel
> I've certainly seen warnings without that option, so it probably just > means "enable *more* warnings". Correct. I fixed that comment too. > For example, I just submitted an MR to fix a warning for something which > is perfectly legal, but which broke the build here due to -Werror. Thank

Re: Is it time to --enable-warnings?

2025-02-11 Thread Fred Wright via devel
On Sat, 8 Feb 2025, Hal Murray via devel wrote: waf configure --help says: --enable-warnings Enable annoying CC warnings Are they really annoying? My normal build script turns it on without problems. I've certainly seen warnings without that option, so it probably just means "enabl

Re: Is it time to --enable-warnings?

2025-02-11 Thread Hal Murray via devel
It's on now, and -Werror too. Gitlab is happy. openSUSE still has an old old Bison. I had to fix a few printf errors. Mostly %ld getting a long long. I think those are harmless on little endian but would break on big endian. (That's assuming the value fits in a long.) -- These are my opi