On 2025-02-11 20:08, Hal Murray via devel wrote:
--disable-Werror will turn it off.  My expectation is that with a few
fixes like yours we won't have many problems.  If that turns out to be
wrong, we can change the default.

I haven't been following this closely, so I'm not sure what you changed.

I don't think -Werror should be the default. That can break things that are perfectly fine, especially if someone is trying to build an existing release on a newer compiler that added a new warning.

If you made -Werror the default in release builds, please revert that immediately.

If you made the CI jobs use -Werror to catch things, that could be reasonable. There, I would agree with "If that turns out to be [too much pain], we can change [it]."

--
Richard

_______________________________________________
devel mailing list
devel@ntpsec.org
https://lists.ntpsec.org/mailman/listinfo/devel

Reply via email to