On Thu, Oct 26, 2023 at 03:15:06PM +0100, Daniel P. Berrangé wrote:
> On Thu, Oct 26, 2023 at 06:48:28AM -0700, Andrea Bolognani wrote:
> > Since we're just a few months away from the 10.0.0 release, I thought
> > it would be a good time to bring up this idea.
> >
>
Signed-off-by: Andrea Bolognani
---
src/libvirt-domain.c | 4
1 file changed, 4 deletions(-)
diff --git a/src/libvirt-domain.c b/src/libvirt-domain.c
index 6616294fc1..58e1e5ea8d 100644
--- a/src/libvirt-domain.c
+++ b/src/libvirt-domain.c
@@ -4221,10 +4221,6 @@ virDomainMigrate3
On Tue, Oct 31, 2023 at 12:13:14PM +0100, Michal Prívozník wrote:
> On 10/26/23 15:48, Andrea Bolognani wrote:
> > Since we're just a few months away from the 10.0.0 release, I thought
> > it would be a good time to bring up this idea.
> >
> > Can we move to date-
On Tue, Oct 31, 2023 at 11:58:01AM +, Daniel P. Berrangé wrote:
> On Tue, Oct 31, 2023 at 04:20:24AM -0700, Andrea Bolognani wrote:
> > systemd is in a similar position as us, where they can't really break
> > compatibility because too much stuff is built on top, so they
to allow migration in such a
configuration while still not going quite as far as
VIR_MIGRATE_UNSAFE does and losing all handrails.
[1] https://issues.redhat.com/browse/CNV-34322
Andrea Bolognani (3):
include: Introduce VIR_MIGRATE_ASSUME_SHARED_STORAGE
qemu: Implement
Signed-off-by: Andrea Bolognani
---
src/qemu/qemu_migration.c | 5 +
src/qemu/qemu_migration.h | 1 +
2 files changed, 6 insertions(+)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index ac58aa1a8c..bf6f1de310 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu
Signed-off-by: Andrea Bolognani
---
docs/manpages/virsh.rst | 5 -
tools/virsh-domain.c| 5 +
2 files changed, 9 insertions(+), 1 deletion(-)
diff --git a/docs/manpages/virsh.rst b/docs/manpages/virsh.rst
index 3e7a4c6c22..849933fa2e 100644
--- a/docs/manpages/virsh.rst
+++ b/docs
Signed-off-by: Andrea Bolognani
---
include/libvirt/libvirt-domain.h | 14 ++
1 file changed, 14 insertions(+)
diff --git a/include/libvirt/libvirt-domain.h b/include/libvirt/libvirt-domain.h
index a1902546bb..37c55c5ae8 100644
--- a/include/libvirt/libvirt-domain.h
+++ b/include
Tests are disabled so this combination never made any sense,
but with recent changes it has turned into a build failure.
Fixes: 8ce0decc372051d616018f57ae268e2f03082eec
Reported-by: Cole Robinson
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 2 +-
1 file changed, 1 insertion(+), 1
https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/440
Andrea Bolognani (11):
rpm: Disable expensive tests for MinGW builds
rpm: Explicitly enable NLS support
rpm: Rename module-init-tools -> kmod
rpm: Explain a couple of BuildRequires
rpm: Add libxml2 BuildRequires for xmlli
We want it both for native builds and MinGW ones.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 342a88024a..f21f76b256 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
The old package name is only kept around for compatibility
reasons.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index f21f76b256..d16d622153 100644
--- a/libvirt.spec.in
+++ b
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index d16d622153..8248e2ca80 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -292,6 +292,7 @@ BuildRequires: xen-devel
%endif
BuildRequires: glib2
It's already been dragged in by the -devel package, but since
we use the command line tool directly as part of our build
process it's more correct to explicitly depend on the runtime
package.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 2 ++
1 file changed, 2 insertions(+)
Move all dependencies that are needed both for native builds and
for MinGW ones near the top of the list. This will make future
patches nicer.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/libvirt.spec.in
This is functionally equivalent and will make future patches
nicer.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index dc67ffabcc..6a999860f5 100644
--- a/libvirt.spec.in
+++ b
.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 49 -
1 file changed, 36 insertions(+), 13 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 6a999860f5..75fd0a2771 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -203,9
Now that the spec file supports selectively disabling the native,
mingw32 and mingw64 parts, we can add coverage for the MinGW RPM
builds.
Signed-off-by: Andrea Bolognani
---
.gitlab-ci.yml | 11 ---
ci/jobs.sh | 19 ++-
2 files changed, 26 insertions(+), 4 deletions
The native version of gettext is now included in MinGW containers.
Signed-off-by: Andrea Bolognani
---
ci/buildenv/fedora-38-cross-mingw32.sh| 1 +
ci/buildenv/fedora-38-cross-mingw64.sh| 1 +
ci/buildenv/fedora-rawhide-cross-mingw32.sh | 1 +
ci
The new _without_native knob makes it possible to skip the native
build completely and build for MinGW only.
Best viewed with 'git show -w'.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 395 +---
1 file changed, 210 insertio
as well. Anyone else seeing this? meson
> >> 1.2.3 and 1.2.2 both affected
> >
> > That will be exposed by
> >
> > ommit 8ce0decc372051d616018f57ae268e2f03082eec
> > Author: Andrea Bolognani
> > Date: Tue Oct 3 14:53:08 2023 +0200
> >
> > me
supported
in C2x [-Werror,-Wdeprecated-non-prototype] xdr_virNetMessageType(xdrs, objp)
Andrea Bolognani (2):
rpc: Drop support for portable-rpcgen
rpc: Make rpcgen produce ANSI C code
meson.build| 12 +---
src/rpc/genprotocol.pl | 5 ++---
2 files changed, 3 insertions(+), 14
We use the native version of rpcgen everywhere.
Signed-off-by: Andrea Bolognani
---
meson.build| 12 +---
src/rpc/genprotocol.pl | 3 ---
2 files changed, 1 insertion(+), 14 deletions(-)
diff --git a/meson.build b/meson.build
index dc0969abcc..158a7cae01 100644
--- a
ed-off-by: Andrea Bolognani
---
src/rpc/genprotocol.pl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/rpc/genprotocol.pl b/src/rpc/genprotocol.pl
index 6c664f48e7..5eb654cb7c 100755
--- a/src/rpc/genprotocol.pl
+++ b/src/rpc/genprotocol.pl
@@ -39,6 +39,8 @@ my $target = shift;
unlin
T_ENCODING, which is set by MacOS. */
s/MacOS/macOS/ (in the commit message too)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
On Fri, Nov 03, 2023 at 03:11:07AM -0700, Andrea Bolognani wrote:
> On Fri, Nov 03, 2023 at 12:00:30AM -0400, Laine Stump wrote:
> > [*] There may be a better way to suppress this environment setting
> > (maybe something done to prevent it from ever being added to the
> &g
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1060019687
Changes from [v1]
* retain portable-rpcgen support.
[v1]
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/2A3KKLCQQ3BAVV3KGW2FLKZ42WF2ERD3/
Andrea Bolognani (1):
rpc: Make rpcgen produce ANSI C
ed-off-by: Andrea Bolognani
---
src/rpc/genprotocol.pl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/src/rpc/genprotocol.pl b/src/rpc/genprotocol.pl
index adf3991d7a..37216303dc 100755
--- a/src/rpc/genprotocol.pl
+++ b/src/rpc/genprotocol.pl
@@ -41,6 +41,8 @@ unlink $target;
if ($rpcgen =~
On Fri, Nov 03, 2023 at 08:55:27AM +, Daniel P. Berrangé wrote:
> On Fri, Nov 03, 2023 at 12:37:17AM +0100, Andrea Bolognani wrote:
> > We use the native version of rpcgen everywhere.
>
> This is true of our CI systems, but not true of user
> environments.
>
> For ou
On Fri, Nov 03, 2023 at 10:47:11AM +, Daniel P. Berrangé wrote:
> On Fri, Nov 03, 2023 at 10:41:51AM +, Daniel P. Berrangé wrote:
> > On Fri, Nov 03, 2023 at 03:19:17AM -0700, Andrea Bolognani wrote:
> > > ld: warning: ignoring duplicate libraries: '-lxml2'
On Fri, Nov 03, 2023 at 10:14:55AM +, Daniel P. Berrangé wrote:
> On Thu, Nov 02, 2023 at 11:37:22PM +0100, Andrea Bolognani wrote:
> > The openSUSE Leap 15 job failed, but that's caused by an unrelated
> > packaging issue:
> >
> > $ pkg-config --cflags lib
On Fri, Nov 03, 2023 at 11:17:03AM +, Daniel P. Berrangé wrote:
> On Fri, Nov 03, 2023 at 04:13:12AM -0700, Andrea Bolognani wrote:
> > On Fri, Nov 03, 2023 at 10:47:11AM +, Daniel P. Berrangé wrote:
> > > On Fri, Nov 03, 2023 at 10:41:51AM +, Daniel P. Berrangé wro
d files already have examples of adding an
> option to the ld commandline if it's available.
>
> Signed-off-by: Laine Stump
> ---
> meson.build | 4
> src/meson.build | 1 +
> tests/meson.build | 1 +
> tools/meson.build | 1 +
> 4 files changed, 7 ins
| 4 -
> 5 files changed, 270 deletions(-)
> delete mode 100644 ci/buildenv/debian-sid-cross-mipsel.sh
> delete mode 100644 ci/containers/debian-sid-cross-mipsel.Dockerfile
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
_
6_64
> variables:
>RPM: skip
> + # Keep until fix for:
> https://bugzilla.opensuse.org/show_bug.cgi?id=1216862
> + CFLAGS: -Wno-missing-include-dirs
Thanks for filing the bug.
Assuming that you have tried this in CI and it did what it was
sup
> Using index info to reconstruct a base tree...
> error: patch failed: ci/gitlab/builds.yml:332
> error: ci/gitlab/builds.yml: patch does not apply
> error: patch failed: ci/manifest.yml:205
Yeah, both me and Laine noticed this the other day. Patches look fine
in mutt, but if you
On Mon, Nov 06, 2023 at 09:58:02AM +, Daniel P. Berrangé wrote:
> On Mon, Nov 06, 2023 at 01:47:20AM -0800, Andrea Bolognani wrote:
> > On Mon, Nov 06, 2023 at 10:37:28AM +0100, Martin Kletzander wrote:
> > > Ah, since the switch to the new ML I cannot apply any patch
On Mon, Nov 06, 2023 at 10:26:36AM +, Daniel P. Berrangé wrote:
> On Mon, Nov 06, 2023 at 02:21:16AM -0800, Andrea Bolognani wrote:
> > So does that mean that the issue is server-side? I'm pretty sure
> > Laine, Martin and I are all fetching emails using different tool
We no longer use rpcgen.
Signed-off-by: Andrea Bolognani
---
ci/gitlab/builds.yml | 2 +-
ci/manifest.yml | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ci/gitlab/builds.yml b/ci/gitlab/builds.yml
index 2beca51767..8297adbc5f 100644
--- a/ci/gitlab/builds.yml
+++ b
Signed-off-by: Andrea Bolognani
---
ci/cirrus/macos-13.vars | 16
ci/gitlab/builds.yml| 16
ci/manifest.yml | 7 +++
3 files changed, 39 insertions(+)
create mode 100644 ci/cirrus/macos-13.vars
diff --git a/ci/cirrus/macos-13.vars b/ci/cirrus
Signed-off-by: Andrea Bolognani
---
ci/cirrus/macos-14.vars | 16
ci/gitlab/builds.yml| 16
ci/manifest.yml | 7 +++
3 files changed, 39 insertions(+)
create mode 100644 ci/cirrus/macos-14.vars
diff --git a/ci/cirrus/macos-14.vars b/ci/cirrus
Signed-off-by: Andrea Bolognani
---
ci/cirrus/macos-12.vars | 16
ci/gitlab/builds.yml| 16
ci/manifest.yml | 7 ---
3 files changed, 39 deletions(-)
delete mode 100644 ci/cirrus/macos-12.vars
diff --git a/ci/cirrus/macos-12.vars b/ci/cirrus
because they conflict with OS-supplied packages. Right now it
doesn't really do anything, because it hasn't been updated with the
switch to aarch64. I'm going to look into it later, but for now I've
left it as-is as reminder/documentation.
Andrea Bolognani (5):
ci: Update gen
Gain native gettext for MinGW containers, lose rpcgen everywhere.
Signed-off-by: Andrea Bolognani
---
ci/buildenv/almalinux-8.sh| 1 -
ci/buildenv/alpine-317.sh | 1 -
ci/buildenv/alpine-edge.sh| 1 -
ci
On Thu, Nov 02, 2023 at 04:40:28PM +0100, Peter Krempa wrote:
> CCW addresses need to be also checked for ABI stability.
>
> Signed-off-by: Peter Krempa
> ---
> src/conf/domain_conf.c | 13 -
> 1 file changed, 12 insertions(+), 1 deletion(-)
Reviewed-by
On Mon, Nov 06, 2023 at 12:42:58PM +, Daniel P. Berrangé wrote:
> On Mon, Nov 06, 2023 at 12:04:09PM +0100, Andrea Bolognani wrote:
> > Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1062214982
> >
> > Assumes that
> >
> > http
eful.
>
> Fixes: 19b1c0d31988a3a10c4694c10c27eb15c018f450
> Signed-off-by: Ján Tomko
> ---
> src/conf/domain_conf.c | 14 ++
> 1 file changed, 6 insertions(+), 8 deletions(-)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
We recently unified all services and sockets, except a couple
were missed. Finish the job.
Signed-off-by: Andrea Bolognani
---
src/remote/virt-guest-shutdown.target | 4 ++--
tools/libvirt-guests.service.in | 6 +++---
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/src
, they would also
> need to rebuild libvirt to enable nbdkit support. By introducing a
> configure option (storage_use_nbdkit), we can build packages with nbdkit
> support but have it disabled by default.
>
> Signed-off-by: Jonathon Jongsma
> ---
>
> Suggested as an option for
On Wed, Nov 01, 2023 at 12:52:15PM +, Daniel P. Berrangé wrote:
> On Tue, Oct 31, 2023 at 06:12:59PM +0100, Andrea Bolognani wrote:
> > if ((rc = virFileIsSharedFS(src)) < 0) {
> > return false;
> > } else if (rc == 0) {
> &
The need to remove the and elements in order
to make the firmware autoselection process kick in again is
not exactly intuitive, so document it explicitly.
Signed-off-by: Andrea Bolognani
---
docs/kbase/secureboot.rst | 30 +-
1 file changed, 25 insertions(+), 5
opped;
* the last patch has been tweaked a bit and the changes contained
in it are now documented with a code comment.
[v1]
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/Y2W2PMWBS2EGGFNEMEZM5L5XNQ2EJSUJ/
Andrea Bolognani (5):
rpm: Shuffle BuildRequires around
rpm: Split
This is functionally equivalent and will make future patches
nicer.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 1f90a36f22..5b0b316543 100644
--- a/libvirt.spec.in
+++ b
Move all dependencies that are needed both for native builds and
for MinGW ones near the top of the list. This will make future
patches nicer.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/libvirt.spec.in
.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 49 -
1 file changed, 36 insertions(+), 13 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 5b0b316543..7e2da8506a 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -203,9
Now that the spec file supports selectively disabling the native,
mingw32 and mingw64 parts, we can add coverage for the MinGW RPM
builds.
Signed-off-by: Andrea Bolognani
---
.gitlab-ci.yml | 11 ---
ci/jobs.sh | 23 ++-
2 files changed, 30 insertions(+), 4
The new _without_native knob makes it possible to skip the native
build completely and build for MinGW only.
Best viewed with 'git show -w'.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 395 +---
1 file changed, 210 insertio
https://gitlab.com/libvirt/libvirt/-/merge_requests/290
Thanks: Guilhem Moulin
Thanks: Kunwu Chan
Signed-off-by: Andrea Bolognani
---
src/rpc/virnetsocket.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
index b58f7a6b8f..151077c2dd 100644
See patch 5/6 for details.
Andrea Bolognani (6):
docs: The Polkit access driver is disabled by default
docs: Document org.libvirt.unix.* actions
rpc: Introduce virNetServerHasGranularPolkit()
remote: Set granularPolkit if applicable
remote: Expose granularPolkit attribute to rules
This might not be immediately obvious to someone who ended up
on the page without passing through acl.html first.
Signed-off-by: Andrea Bolognani
---
docs/aclpolkit.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/docs/aclpolkit.rst b/docs/aclpolkit.rst
index 07f4735001
Signed-off-by: Andrea Bolognani
---
src/remote/remote_daemon.c | 20 +---
1 file changed, 17 insertions(+), 3 deletions(-)
diff --git a/src/remote/remote_daemon.c b/src/remote/remote_daemon.c
index 59170373cb..fc5e543470 100644
--- a/src/remote/remote_daemon.c
+++ b/src/remote
t
broker access to subsequent API calls anymore, user "fred" now
has full administrative access to all drivers.
Rewriting the check seen above as
if (action.id == "org.libvirt.unix.manage" &&
action.lookup("granular") == "true") {
return p
Before any of the API can be executed, the client needs to be
authenticated by allowing one of these special actions.
Signed-off-by: Andrea Bolognani
---
docs/aclpolkit.rst | 17 +
1 file changed, 17 insertions(+)
diff --git a/docs/aclpolkit.rst b/docs/aclpolkit.rst
index
Signed-off-by: Andrea Bolognani
---
docs/aclpolkit.rst | 9 +
1 file changed, 9 insertions(+)
diff --git a/docs/aclpolkit.rst b/docs/aclpolkit.rst
index 9b0a374c53..fe825c504b 100644
--- a/docs/aclpolkit.rst
+++ b/docs/aclpolkit.rst
@@ -70,6 +70,15 @@ to be approved by Polkit before any
It's always set to false for now.
Signed-off-by: Andrea Bolognani
---
src/libvirt_remote.syms| 1 +
src/locking/lock_daemon.c | 6 --
src/logging/log_daemon.c | 6 --
src/lxc/lxc_controller.c | 3 ++-
src/remote/remote_daemon.c | 6 --
src/rpc/virnetserver.c
+return false;
This does the right thing if nbdkit support is compiled in but
disabled at the configuration file level. However, what about the
opposite scenario, where someone tries to enable nbdkit in the
configuration file but it's not been compiled in? We'd be silentl
It only has a single, trivial caller.
Signed-off-by: Andrea Bolognani
---
src/security/security_dac.c | 21 -
1 file changed, 4 insertions(+), 17 deletions(-)
diff --git a/src/security/security_dac.c b/src/security/security_dac.c
index c07e488db7..35b9b56c66 100644
--- a
We no longer use it, so commit a62486b95fee correctly dropped
the Build-Requires; shortly afterwards, however, I accidentally
re-introduced it by mistake.
Fixes: 3df8cc658ed0ac2f84089ad0db61ba20eb8b8aa7
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 1 -
1 file changed, 1 deletion
ccess.redhat.com/documentation/en-us/red_hat_enterprise_linux/9/html/deploying_web_servers_and_reverse_proxies/setting-apache-http-server_deploying-web-servers-and-reverse-proxies#setting-up-a-single-instance-apache-http-server_setting-apache-http-server
[2] https://src.fedoraproject.org/rpms/fedora-release/p
rated.
I haven't looked into that failure at all, but it looks like
something that we might want to fix before 9.10.0 is released?
libvirt itself seems to build fine, so perhaps it's just the test
suite that needs fixing. I leave the call to people who are more
familiar with the rpcgen situa
Some of the files used by test_demo.c can only be regenerated
when pytest is present, but we have pre-generated copies in the
repository, so overall we just need the C compiler to build and
run that specific test program.
Signed-off-by: Andrea Bolognani
---
scripts/rpcgen/meson.build | 3 +--
1
Signed-off-by: Andrea Bolognani
---
scripts/rpcgen/meson.build | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/scripts/rpcgen/meson.build b/scripts/rpcgen/meson.build
index d8d0e03784..9e766a2a37 100644
--- a/scripts/rpcgen/meson.build
+++ b/scripts
These are currently the only tests that are not part of any
suite.
Signed-off-by: Andrea Bolognani
---
scripts/rpcgen/meson.build | 1 +
scripts/rpcgen/tests/meson.build | 1 +
2 files changed, 2 insertions(+)
diff --git a/scripts/rpcgen/meson.build b/scripts/rpcgen/meson.build
index
Signed-off-by: Andrea Bolognani
---
scripts/rpcgen/meson.build| 16
scripts/rpcgen/rpcgen/meson.build | 10 +-
scripts/rpcgen/tests/meson.build | 30 +++---
3 files changed, 28 insertions(+), 28 deletions(-)
diff --git a/scripts/rpcgen
This adds pytest everywhere.
Signed-off-by: Andrea Bolognani
---
ci/buildenv/almalinux-8.sh| 1 +
ci/buildenv/alpine-317.sh | 1 +
ci/buildenv/alpine-edge.sh| 1 +
ci/buildenv/centos-stream-8.sh
On Wed, Nov 29, 2023 at 06:18:27PM +0100, Andrea Bolognani wrote:
> Right now we don't have pytest installed in any of the CI build
> environments, and tests are only executed when pytest is present, so
> the test coverage is exactly zero.
>
> This series changes things so that
On Wed, Nov 29, 2023 at 10:49:23AM +, Richard W.M. Jones wrote:
> On Wed, Nov 29, 2023 at 05:44:59AM -0500, Andrea Bolognani wrote:
> > On Wed, Nov 29, 2023 at 10:09:36AM +, Richard W.M. Jones wrote:
> > > Why is it exactly that the socket doesn't work after insta
here.
Signed-off-by: Andrea Bolognani
---
scripts/rpcgen/tests/test_demo.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/scripts/rpcgen/tests/test_demo.c b/scripts/rpcgen/tests/test_demo.c
index a48ceccd58..931f25f982 100644
--- a/scripts/rpcgen/tests/test_demo.c
+
IUC demo.{c,h} are generated from demo.x, so wouldn't this be
overwritten the next time we regenerate them?
Also both Linux and macOS have xdr_u_int64_t, and we already seem to
use the u_ variant for other things (u_short, u_int), so couldn't we
just use xdr_u_int64_t eve
On Thu, Nov 30, 2023 at 09:24:45AM +, Daniel P. Berrangé wrote:
> On Wed, Nov 29, 2023 at 06:18:27PM +0100, Andrea Bolognani wrote:
> > Right now we don't have pytest installed in any of the CI build
> > environments, and tests are only executed when pytest is present, so
&
On Thu, Nov 30, 2023 at 09:40:47AM +0100, Martin Kletzander wrote:
> On Wed, Nov 29, 2023 at 12:30:19PM -0600, Andrea Bolognani wrote:
> > On Wed, Nov 29, 2023 at 10:49:23AM +, Richard W.M. Jones wrote:
> > > On Wed, Nov 29, 2023 at 05:44:59AM -0500, Andrea Bolognani wrote
On Thu, Nov 30, 2023 at 11:40:17AM +, Daniel P. Berrangé wrote:
> On Thu, Nov 30, 2023 at 05:17:09AM -0500, Andrea Bolognani wrote:
> > On Thu, Nov 30, 2023 at 09:24:15AM +, Daniel P. Berrangé wrote:
> > > +++ b/scripts/rpcgen/tests/demo.c
> > > +#ifde
eding uint64_t anywhere in our RPC protocol.
As a short-term solution, it's fine :)
Reviewed-by: Andrea Bolognani
--
Andrea Bolognani / Red Hat / Virtualization
___
Devel mailing list -- devel@lists.libvirt.org
To unsubscribe send an email to devel-le...@lists.libvirt.org
On Thu, Nov 30, 2023 at 09:30:28AM -0500, Andrea Bolognani wrote:
> On Thu, Nov 30, 2023 at 02:07:55PM +, Daniel P. Berrangé wrote:
> > +++ b/scripts/rpcgen/tests/test_demo.c
> > @@ -3,6 +3,10 @@
> > #include
> > #include
> >
> > +#ifdef __APPLE__
&
On Thu, Nov 30, 2023 at 04:10:00PM +0100, Michal Prívozník wrote:
> On 11/30/23 16:05, Andrea Bolognani wrote:
> > On Thu, Nov 30, 2023 at 09:30:28AM -0500, Andrea Bolognani wrote:
> >> On Thu, Nov 30, 2023 at 02:07:55PM +, Daniel P. Berrangé wrote:
> >>> +++ b/sc
On Thu, Nov 30, 2023 at 03:17:10PM +, Daniel P. Berrangé wrote:
> On Thu, Nov 30, 2023 at 04:10:00PM +0100, Michal Prívozník wrote:
> > On 11/30/23 16:05, Andrea Bolognani wrote:
> > > On Thu, Nov 30, 2023 at 09:30:28AM -0500, Andrea Bolognani wrote:
> > >> On T
Based on:
https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/GLJL2PBMYTKKJVFXRZ4AEWY6LZCNTBF2/
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1091405064
Since we're supposed to tag 9.10.0 tomorrow, go for the
quick and dirty workaround.
Andrea Bologna
e git repository.
In the long run, we need to find a better way to handle this,
but since 9.10.0 is going to be released very soon and we don't
want it to have a broken test suite on macOS, simply skip the
generator tests on that platform for now.
Signed-off-by: Andrea Bolognani
---
scri
On Thu, Nov 30, 2023 at 10:27:34AM -0500, Andrea Bolognani wrote:
> > > > > As a short-term solution, it's fine :)
> > > >
> > > > Never mind, this very obviously doesn't pass muster:
> > > >
> > > > E AssertionError:
On Fri, Dec 01, 2023 at 11:58:05AM +, Daniel P. Berrangé wrote:
> On Thu, Nov 30, 2023 at 08:29:55PM +0100, Andrea Bolognani wrote:
> > The generator can produce different code on Linux and macOS:
> > specifically, on the former we want to use xdr_uint64_t while
>
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
NEWS.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/NEWS.rst b/NEWS.rst
index 29b977565b..c0a6d180a2 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -89,6 +89,7 @@ v9.9.0 (2023-11-01)
The ``virsh create --console
Signed-off-by: Andrea Bolognani
---
Pushed as trivial.
NEWS.rst | 39 ---
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/NEWS.rst b/NEWS.rst
index c0a6d180a2..dc40602c72 100644
--- a/NEWS.rst
+++ b/NEWS.rst
@@ -176,10 +176,10 @@ v9.6.0 (2023
Having the name of the project as part of the prefix was useful
back when we used the mailing list for all subprojects, but
these days the only patches that are sent to the list are for
the main library so it no longer makes sense to include this.
Signed-off-by: Andrea Bolognani
---
.gitpublish
We only use it at runtime, not during the build process.
Signed-off-by: Andrea Bolognani
---
meson.build| 1 -
src/util/virutil.c | 2 ++
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index 5fb827cca8..fdff8dcb97 100644
--- a/meson.build
+++ b
We only use it at runtime, not during the build process.
Signed-off-by: Andrea Bolognani
---
meson.build| 1 -
src/storage/storage_util.c | 1 +
2 files changed, 1 insertion(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index fdff8dcb97..fa4062df2f 100644
--- a
We only use it at runtime, not during the build process.
Signed-off-by: Andrea Bolognani
---
meson.build | 1 -
src/qemu/qemu_passt.c | 3 +++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/meson.build b/meson.build
index fa4062df2f..4d96b32e58 100644
--- a/meson.build
Test pipeline: https://gitlab.com/abologna/libvirt/-/pipelines/1092535621
lcitool changes: https://gitlab.com/libvirt/libvirt-ci/-/merge_requests/447
Andrea Bolognani (9):
rpm: Drop MinGW BuildRequires on libgcrypt/libgpg-error
meson: Stop looking for udevadm at build time
meson: Stop
We currently have a BuildDepends on it, which doesn't help
ensuring that the tool is available at runtime, when the storage
driver might need to spawn it.
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libvirt.spec.in b/libvirt.sp
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 2 --
1 file changed, 2 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 6f58ed3899..5a5adf86bc 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -408,8 +408,6 @@ BuildRequires: systemtap-sdt-devel
BuildRequires: util
Signed-off-by: Andrea Bolognani
---
libvirt.spec.in | 3 ---
1 file changed, 3 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in
index 5a5adf86bc..1d0ec5073d 100644
--- a/libvirt.spec.in
+++ b/libvirt.spec.in
@@ -391,9 +391,6 @@ BuildRequires: libssh2-devel >= 1.3.0
%en
1 - 100 of 698 matches
Mail list logo
