On Thu, Nov 30, 2023 at 02:07:55PM +0000, Daniel P. Berrangé wrote: > +++ b/scripts/rpcgen/tests/test_demo.c > @@ -3,6 +3,10 @@ > #include <rpc/xdr.h> > #include <stdbool.h> > > +#ifdef __APPLE__ > +# define xdr_uint64_t xdr_u_int64_t > +#endif
For the long run, I think it would make more sense to have this workaround as part of the generator's output, so that using VIR_TEST_REGENERATE_OUTPUT will produce the same results regardless of whether it's run on Linux or macOS. It would also avoid the need to add a similar workaround somewhere in the library code the day we start needing uint64_t anywhere in our RPC protocol. As a short-term solution, it's fine :) Reviewed-by: Andrea Bolognani <abolo...@redhat.com> -- Andrea Bolognani / Red Hat / Virtualization _______________________________________________ Devel mailing list -- devel@lists.libvirt.org To unsubscribe send an email to devel-le...@lists.libvirt.org
