Re: [PATCH] virdevmapper: Always use device name for finding targets

2025-07-02 Thread Bhavin via Devel
This was sent from a wrong mail address by mistake, sorry for the noise. Can be ignored as a duplicate.

[PATCH] virdevmapper: Always use device name for finding targets

2025-07-02 Thread bhavin192--- via Devel
From: Bhavin Gandhi DM_TABLE_DEPS expects a device name in dm_ioctl.name. In one of the cases, full path of the device was getting returned causing the ioctl call to fail with `ENXIO (No such device or address)`. Also rename the function and variable names to better reflect that we are dealing w

Re: [PATCH 05/15] tests: Fix mocking of open()

2025-07-02 Thread Michal Prívozník via Devel
On 7/2/25 12:23, Ján Tomko wrote: > On a Thursday in 2025, Michal Privoznik via Devel wrote: >> From: Michal Privoznik >> >> In some cases (well, majority), open() is either rewritten to >> open64(), either by plain '#define open open64') or at assembly >> level (using __REDIRECT macro). See for

Re: [PATCH v5 5/5] qemu: add default_cpu_deprecated_features configuration option

2025-07-02 Thread Boris Fiuczynski
On 7/1/25 18:35, Daniel P. Berrangé via Devel wrote: On Tue, Jul 01, 2025 at 03:58:02PM +0200, Boris Fiuczynski wrote: On 7/1/25 10:46, Daniel P. Berrangé via Devel wrote: On Sun, Jun 29, 2025 at 11:19:30PM -0400, Collin Walling wrote: From: Boris Fiuczynski Allow to define the default for d

Re: [PATCH 00/15] virt-aa-helper: Misc improvements

2025-07-02 Thread Ján Tomko via Devel
On a Thursday in 2025, Michal Privoznik via Devel wrote: Inspired by a patchset against virt-aa-helper that I reviewed recently: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/QQXMAK56H2CXCIZPALG5BHDNTKT3OQKZ/ Green pipeline: https://gitlab.com/MichalPrivoznik/libvirt/-

Re: [PATCH v5 5/5] qemu: add default_cpu_deprecated_features configuration option

2025-07-02 Thread Daniel P . Berrangé via Devel
On Wed, Jul 02, 2025 at 12:05:45PM +0200, Boris Fiuczynski wrote: > On 7/1/25 18:35, Daniel P. Berrangé via Devel wrote: > > On Tue, Jul 01, 2025 at 03:58:02PM +0200, Boris Fiuczynski wrote: > > > On 7/1/25 10:46, Daniel P. Berrangé via Devel wrote: > > > > On Sun, Jun 29, 2025 at 11:19:30PM -0400,

Re: [PATCH 05/15] tests: Fix mocking of open()

2025-07-02 Thread Ján Tomko via Devel
On a Thursday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik In some cases (well, majority), open() is either rewritten to open64(), either by plain '#define open open64') or at assembly level (using __REDIRECT macro). See for more info. This didn't really matter to us, bec

Re: [PATCH 00/15] virt-aa-helper: Misc improvements

2025-07-02 Thread Michal Prívozník via Devel
On 7/2/25 12:12, Ján Tomko wrote: > On a Thursday in 2025, Michal Privoznik via Devel wrote: >> Inspired by a patchset against virt-aa-helper that I reviewed recently: >> >> https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/ >> thread/QQXMAK56H2CXCIZPALG5BHDNTKT3OQKZ/ >> >> Green pipe

Re: [PATCH 01/15] log_cleaner: Use virFileCanonicalizePath()

2025-07-02 Thread Michal Prívozník via Devel
On 7/2/25 12:22, Ján Tomko wrote: > On a Thursday in 2025, Michal Privoznik via Devel wrote: >> From: Michal Privoznik >> >> While use of realpath() is not forbidden, our some of our mocks >> already have a test friendly reimplementation of >> virFileCanonicalizePath(). Use the latter. >> > > Tha

Re: [PATCH 2/2] network: introduce Packet Filter firewall backend

2025-07-02 Thread Roman Bogorodskiy
Daniel P. Berrangé wrote: > On Sat, Apr 26, 2025 at 09:42:36AM +0200, Roman Bogorodskiy wrote: > > Implement NAT networking support based on the Packet Filter (pf) > > firewall in FreeBSD. At this point, the implementation is very basic. > > It creates: > > > > - Essential NAT translation rule

Re: [PATCH] qemu: Switch to virtio-scsi on ARM

2025-07-02 Thread Andrea Bolognani via Devel
On Thu, Jun 26, 2025 at 03:29:58PM -0600, Jim Fehlig via Devel wrote: > Similar to x86, the default SCSI controller model for ARM is lsilogic. > But unlike x86, the ARM virt machine type prefers virtio devices. Switch > the default controller model for ARM from lsilogic to virtio-scsi. > > Signed-o

Re: [libvirt PATCH] docs: clarify how to build without -Werror

2025-07-02 Thread Andrea Bolognani via Devel
On Tue, Jun 24, 2025 at 05:48:52PM +0200, Ján Tomko via Devel wrote: > +++ b/docs/compiling.rst > @@ -105,8 +105,8 @@ Notes: > ~~ > > By default when the ``meson`` is run from within a GIT checkout, it will turn > -on -Werror for builds. This can be disabled with --werror=false, but this is >

Re: [PATCH v5 5/5] qemu: add default_cpu_deprecated_features configuration option

2025-07-02 Thread Boris Fiuczynski
On 7/2/25 12:20, Daniel P. Berrangé via Devel wrote: On Wed, Jul 02, 2025 at 12:05:45PM +0200, Boris Fiuczynski wrote: On 7/1/25 18:35, Daniel P. Berrangé via Devel wrote: On Tue, Jul 01, 2025 at 03:58:02PM +0200, Boris Fiuczynski wrote: On 7/1/25 10:46, Daniel P. Berrangé via Devel wrote: On

[PATCH] virdevmapper: Always use device name for finding targets

2025-07-02 Thread Bhavin via Devel
From: Bhavin Gandhi DM_TABLE_DEPS expects a device name in dm_ioctl.name. In one of the cases, full path of the device was getting returned causing the ioctl call to fail with `ENXIO (No such device or address)`. Also rename the function and variable names to better reflect that we are dealing w

Re: [PATCH] qemu: Switch to virtio-scsi on ARM

2025-07-02 Thread Jim Fehlig via Devel
On 7/2/25 10:11, Andrea Bolognani wrote: On Thu, Jun 26, 2025 at 03:29:58PM -0600, Jim Fehlig via Devel wrote: Similar to x86, the default SCSI controller model for ARM is lsilogic. But unlike x86, the ARM virt machine type prefers virtio devices. Switch the default controller model for ARM from

Re: [PATCH 01/15] log_cleaner: Use virFileCanonicalizePath()

2025-07-02 Thread Ján Tomko via Devel
On a Thursday in 2025, Michal Privoznik via Devel wrote: From: Michal Privoznik While use of realpath() is not forbidden, our some of our mocks already have a test friendly reimplementation of virFileCanonicalizePath(). Use the latter. That's a good enough reason to forbid it in syntax-check