Re: [PATCH v2 1/1] NEWS: qemu: support block disk along with throttle filters

> On 3/25/25 11:57, Harikumar Rajkumar wrote: > > Reviewed-by: Michal Privoznik > and merged. > > Michal Thank you for merging this.

Re: [PATCH v2 0/1] NEWS: qemu: Support for Block Disk Along with Throttle Filters

Hi Team, Could someone kindly review and include the details in the NEWS section. Your assistance would be greatly appreciated. release news for the patch: https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/5YHQI4R7UUU7FVPE6VCZ4BDXPRZIOFGZ/ Best regards, Harikumar R

[PATCH v2 0/1] NEWS: qemu: Support for Block Disk Along with Throttle Filters

NEWS: qemu: Support for Block Disk Along with Throttle Filters Harikumar Rajkumar (1): NEWS: qemu: support block disk along with throttle filters NEWS.rst | 8 1 file changed, 8 insertions(+) -- 2.48.1

[PATCH v2 1/1] NEWS: qemu: support block disk along with throttle filters

Signed-off-by: Harikumar Rajkumar --- NEWS.rst | 8 1 file changed, 8 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 18d45656b8..e33308693a 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -75,6 +75,14 @@ v11.2.0 (unreleased) system are printed. A user may specify ``--all`` to also

[PATCH 1/1] NEWS: Support block disk along with throttle filters

--- NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 1fc80e2496..c1be44a357 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -67,6 +67,12 @@ v11.2.0 (unreleased) restore. Using multiple channels can reduce the time required to save and restore domains.

[PATCH] NEWS: qemu: Support for Block Disk Along with Throttle Filters

NEWS: qemu: Support for Block Disk Along with Throttle Filters Harikumar Rajkumar (1): NEWS: Support block disk along with throttle filters NEWS.rst | 6 ++ 1 file changed, 6 insertions(+) -- 2.48.1

Re: [PATCH v8 15/18] test_driver: Test throttle group lifecycle APIs

Thanks for the update and for your efforts on the review. We understand your approach and we'll wait until it's completed.

Re: [PATCH v8 15/18] test_driver: Test throttle group lifecycle APIs

> On Wed, Feb 19, 2025 at 22:27:19 +0530, Harikumar Rajkumar wrote: > > For the sake of not prolonging the review any more I'm dropping this > patch for now. Please submit it once we're done with the qemu driver > impl. Could you kindly confirm if the patch review has

Re: [PATCH v8 00/18] *** qemu: block: Support block disk along with throttle filters ***

Thank you for the update. I understand that the review process is complex, and the feature potentially requiring ongoing maintenance. I appreciate the effort and work that has been invested so far.

Re: [PATCH v8 00/18] *** qemu: block: Support block disk along with throttle filters ***

Hi Team, Could we please get an ETA on when the review will be completed? We would greatly appreciate it if the review could be completed as soon as possible. Apologies for the urgency, but we have a dependency on these changes. Thank you for your understanding! Best regards, Harikumar R

Re: [PATCH v8 00/18] *** qemu: block: Support block disk along with throttle filters ***

> On Mon, Mar 03, 2025 at 15:23:15 -0000, Harikumar Rajkumar wrote: > > Sorry I was busy. I'll pick this up. > > Please do not send any new versions until I'm done; I'll be updating > version info and ohter small things. If something larger turns up I'll >

Re: [PATCH v8 00/18] *** qemu: block: Support block disk along with throttle filters ***

> Hi Team, > > Could you kindly confirm if the new version of the code is currently under > review? > > Thanks and Regards, > Harikumar R I just wanted to follow up on my previous message regarding the new version of the code. Could you kindly confirm if it’s currently under review? I would

Re: [PATCH v8 00/18] *** qemu: block: Support block disk along with throttle filters ***

Hi Team, Could you kindly confirm if the new version of the code is currently under review? Thanks and Regards, Harikumar R

[PATCH v8 07/18] remote: New APIs for ThrottleGroup lifecycle management

referenced by some throttlefilter Signed-off-by: Chun Feng Wu * Reimplement getter API to fetch data from XML. * Apply suggested coding style changes. * Update of code documentation comments. * Update the version to 11.1.0. Signed-off-by: Harikumar Rajkumar --- include/libvirt/libvirt-domain.h

[PATCH v8 04/18] config: Introduce ThrottleFilter and corresponding XML parsing

qemu_domain.c when processing qemuDomainDiskPrivate and qemuDomainDiskPrivate Signed-off-by: Chun Feng Wu * Error handling for null throttle group. * Update of code documentation comments. * Apply suggested coding style changes. Signed-off-by: Harikumar Rajkumar ---

[PATCH v8 09/18] qemu: Implement qemu driver for throttle API

tThrottleGroup Signed-off-by: Chun Feng Wu * Apply suggested coding style changes. * cleanup qemu Get ThrottleGroup. * Update the version to 11.1.0. Signed-off-by: Harikumar Rajkumar --- src/qemu/qemu_driver.c | 243 + 1 file changed, 243 insertions(+) d

[PATCH v8 02/18] schema: Add new domain elements to support multiple throttle filters

s feature in qemu is described at https://gitlab.com/qemu-project/qemu/blob/master/docs/throttle.txt Signed-off-by: Chun Feng Wu * Update the version to 11.1.0. * Update the commit message URI. Signed-off-by: Harikumar Rajkumar --- docs/formatdomain.rst | 21 +++

[PATCH v8 18/18] virsh: Add option "throttle-groups" to "attach_disk"

From: Chun Feng Wu Update "attach_disk" to support new option: throttle-groups to form filter chain in QEMU for specific disk Signed-off-by: Chun Feng Wu * apply suggested coding style changes. Signed-off-by: Harikumar Rajkumar --- docs/manpages/virsh.rst| 3 ++- t

[PATCH v8 17/18] virsh: Add support for throttle group operations

is used by domthrottlegroupset, domthrottlegroupinfo, domthrottlegroupdel Signed-off-by: Chun Feng Wu * Update of code documentation comments. * Reimplement Get throttle group from XML. Signed-off-by: Harikumar Rajkumar --- docs/manpages/virsh.rst| 134 +++ tools/virsh-completer-doma

[PATCH v8 16/18] virsh: Refactor iotune options for re-use

From: Chun Feng Wu Define macro for iotune options, this macro is used by opts_blkdeviotune and later throttle group opts Signed-off-by: Chun Feng Wu --- tools/virsh-domain.c | 308 ++- 1 file changed, 156 insertions(+), 152 deletions(-) diff --git a/to

[PATCH v8 15/18] test_driver: Test throttle group lifecycle APIs

oTuneMax * Test "Set": testDomainSetThrottleGroup * Test "Get": testDomainGetThrottleGroup * Test "Del": testDomainDelThrottleGroup Signed-off-by: Chun Feng Wu * Cleanup Test "Get": testDomainGetThrottleGroup * Update the version to 11.1.0. Signed-o

[PATCH v8 14/18] qemustatusxml2xmldata: Add 'throttlefilter' tests

* Add tests for throttlefilter nodename parse and format for statusxml (disk/privateData/nodenames/nodename with type='throttle-filter') * Add iotune limited disk tests to make sure iotune refactory works Signed-off-by: Chun Feng Wu * Isolate status xml test Signed-off-by: Harikuma

[PATCH v8 13/18] qemuxmlconftest: Add 'throttlefilter' tests

configured together with throttle filters Signed-off-by: Chun Feng Wu * Isolate domain xml test Signed-off-by: Harikumar Rajkumar --- .../throttlefilter-invalid.x86_64-latest.err | 1 + .../throttlefilter-invalid.xml| 89 +++ .../throttlefilter.x86_64-latest.args

[PATCH v8 12/18] config: validate: Verify iotune, throttle group and filter

ups, which in turn calls "virDomainDiskIoTuneValidate" * Make sure referenced throttle group exists * Use "iotune" and "throttlefilters" exclusively for specific disk * Throttle filters cannot be used together with CDROM Signed-off-by: Chun Feng Wu * Update of code

[PATCH v8 11/18] qemu: block: Support block disk along with throttle filters

ctCommandlineFromJSON", which is to build "-object" option For throttle filter commandline * Add qemuBuildDiskThrottleFiltersCommandLine in qemuBuildDiskCommandLine to add "blockdev" Signed-off-by: Chun Feng Wu * Apply suggested coding style changes. * Update of cod

[PATCH v8 10/18] qemu: helper: throttle filter nodename and preparation processing

k Signed-off-by: Chun Feng Wu * Apply suggested coding style changes. * Update of code documentation comments. Signed-off-by: Harikumar Rajkumar --- src/qemu/qemu_block.c | 136 src/qemu/qemu_block.h | 49 +++ src/qemu/qemu_command.c

[PATCH v8 08/18] qemu: Refactor qemuDomainSetBlockIoTune to extract common methods

mainCheckBlockIoTuneMax", which is to check "max" rules within iotune Signed-off-by: Chun Feng Wu * Apply suggested coding style changes. Signed-off-by: Harikumar Rajkumar --- src/qemu/qemu_driver.c | 229 + 1 file changed, 141 insertio

[PATCH v8 06/18] tests: Test qemuMonitorJSONGetThrottleGroup and qemuMonitorJSONUpdateThrottleGroup

From: Chun Feng Wu Within "testQemuMonitorJSONqemuMonitorJSONUpdateThrottleGroup" * Test qemuMonitorJSONGetThrottleGroup * Test qemuMonitorJSONUpdateThrottleGroup, which updates limits through "qom-set" Signed-off-by: Chun Feng Wu * fix test Signed-off-by: Harikumar

[PATCH v8 05/18] qemu: monitor: Add support for ThrottleGroup operations

bject" * ThrottleGroup is added by reusing "qemuMonitorAddObject" * "qemuMonitorMakeThrottleGroupLimits" will be used by building qemu cmd as well Signed-off-by: Chun Feng Wu * change throttle group config conversions P to U allow zero. * Apply suggested coding style cha

[PATCH v8 03/18] config: Introduce ThrottleGroup and corresponding XML parsing

DomainDef to include virDomainThrottleGroupDef * Support new resource "Parse" and "Format" for operations between struct and DOM XML * Make sure "group_name" is defined in xml Signed-off-by: Chun Feng Wu * Validation check for zero throttle groups. * Update of code document

[PATCH v8 01/18] schema: Add new domain elements to support multiple throttle groups

ferences "iotune" Signed-off-by: Chun Feng Wu * Update the version to 11.1.0. Signed-off-by: Harikumar Rajkumar --- docs/formatdomain.rst | 26 +++ src/conf/schemas/domaincommon.rng | 274 -- 2 files changed, 174 insertions(+), 126 delet

[PATCH v8 00/18] *** qemu: block: Support block disk along with throttle filters ***

ilter' tests test_driver: Test throttle group lifecycle APIs virsh: Refactor iotune options for re-use virsh: Add support for throttle group operations virsh: Add option "throttle-groups" to "attach_disk" Harikumar Rajkumar (1): qemustatusxml2xmldata: Add 'thrott

Re: [PATCH v7 03/18] config: Introduce ThrottleGroup and corresponding XML parsing

> On Wed, Feb 12, 2025 at 04:05:22PM +0530, Harikumar Rajkumar wrote: > > When this patch was posted in v6: > > > https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/V... > > The authorship was credited to Chun Feng Wu, and also had > their sig

Re: [PATCH v7 00/18] *** [PATCH v7 00/18] qemu: block: Support block disk along with throttle filters ***

> https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/V...), https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/message/AKDGMLKQ5BKSU6Y7R5OO46GIY2SYNDXF/

Re: [PATCH v5 00/18] *** qemu: block: Support block disk along with throttle filters ***

> On Mon, Nov 18, 2024 at 19:24:08 +0530, Harikumar R wrote: > > The review is done now. There are few bits. > > Please note that I didn't point out *all* places needing a version > number update, so make sure to check everything explicitly. Please use > 11.1.0 for next posting. > > One importan

Re: [PATCH v7 00/18] *** [PATCH v7 00/18] qemu: block: Support block disk along with throttle filters ***

> On Wed, Feb 12, 2025 at 04:05:19PM +0530, Harikumar Rajkumar wrote: > > It is helpful to provide a slightly more detailed summary of > what the patch series is doing when posting such a large > series. > > Also when posting repeated new versions of a series, can you >

[PATCH v7 02/18] schema: Add new domain elements to support multiple throttle filters

described at https://gitlab.com/qemu-project/qemu/blob/master/docs/throttle.txt Signed-off-by: Harikumar Rajkumar --- docs/formatdomain.rst | 21 + src/conf/schemas/domaincommon.rng | 19 ++- 2 files changed, 39 insertions(+), 1 deletion(-

[PATCH v7 16/18] virsh: Refactor iotune options for re-use

Define macro for iotune options, this macro is used by opts_blkdeviotune and later throttle group opts Signed-off-by: Harikumar Rajkumar --- tools/virsh-domain.c | 308 ++- 1 file changed, 156 insertions(+), 152 deletions(-) diff --git a/tools/virsh

[PATCH v7 18/18] virsh: Add option throttle-groups to attach_disk

Update "attach_disk" to support new option: throttle-groups to form filter chain in QEMU for specific disk Signed-off-by: Harikumar Rajkumar --- docs/manpages/virsh.rst| 3 ++- tools/virsh-completer-domain.c | 27 +++ tools/virsh-completer-dom

[PATCH v7 17/18] virsh: Add support for throttle group operations

legroupset, domthrottlegroupinfo, domthrottlegroupdel Signed-off-by: Harikumar Rajkumar --- docs/manpages/virsh.rst| 134 +++ tools/virsh-completer-domain.c | 55 + tools/virsh-completer-domain.h | 11 + tools/virsh-domain.c | 405 - 4 files ch

[PATCH v7 15/18] test_driver: Test throttle group lifecycle APIs

t;: testDomainSetThrottleGroup * Test "Del": testDomainDelThrottleGroup Signed-off-by: Harikumar Rajkumar --- src/test/test_driver.c | 367 +++-- 1 file changed, 245 insertions(+), 122 deletions(-) diff --git a/src/test/test_driver.c b/src/test/te

[PATCH v7 14/18] qemustatusxml2xmldata: Add 'throttlefilter' tests

* Add tests for throttlefilter nodename parse and format for statusxml (disk/privateData/nodenames/nodename with type='throttle-filter') * Add iotune limited disk tests to make sure iotune refactory works Signed-off-by: Harikumar Rajkumar --- .../throttlefilter-in.xml

[PATCH v7 13/18] qemuxmlconftest: Add 'throttlefilter' tests

with throttle filters Signed-off-by: Harikumar Rajkumar --- .../throttlefilter-invalid.x86_64-latest.err | 1 + .../throttlefilter-invalid.xml| 89 +++ .../throttlefilter.x86_64-latest.args | 55 + .../throttlefilter.x86_64-latest.xml | 105

[PATCH v7 12/18] config: validate: Verify iotune, throttle group and filter

which in turn calls "virDomainDiskIoTuneValidate" * Make sure referenced throttle group exists * Use "iotune" and "throttlefilters" exclusively for specific disk * Throttle filters cannot be used together with CDROM Signed-off-by: Harikumar Rajkumar --- src/conf/domain_conf

[PATCH v7 11/18] qemu: block: Support block disk along with throttle filters

mJSON", which is to build "-object" option For throttle filter commandline * Add qemuBuildDiskThrottleFiltersCommandLine in qemuBuildDiskCommandLine to add "blockdev" Signed-off-by: Harikumar Rajkumar --- src/qemu/qemu_command.c | 99 +

[PATCH v7 10/18] qemu: helper: throttle filter nodename and preparation processing

prepare throttle filter node name * Define method qemuBlockThrottleFilterGetProps, which is used by both hotplug and command to build throttle object for QEMU * Define methods for throttle filter attach/detach/rollback Signed-off-by: Harikumar Rajkumar --- src/qemu/qemu_block.c | 136 +++

[PATCH v7 09/18] qemu: Implement qemu driver for throttle API

27;s not used anymore * Check flag "QEMU_CAPS_OBJECT_JSON" during qemuDomainSetThrottleGroup when vm is active, throttle group feature requries such flag * "objectAddNoWrap"("props") check is done by reusing qemuMonitorAddObject in q

[PATCH v7 08/18] qemu: Refactor qemuDomainSetBlockIoTune to extract common methods

ot;, which is to check "max" rules within iotune Signed-off-by: Harikumar Rajkumar --- src/qemu/qemu_driver.c | 229 + 1 file changed, 141 insertions(+), 88 deletions(-) diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c index 78b

[PATCH v7 07/18] remote: New APIs for ThrottleGroup lifecycle management

throttlefilter Signed-off-by: Harikumar Rajkumar --- include/libvirt/libvirt-domain.h| 14 src/driver-hypervisor.h | 14 src/libvirt-domain.c| 122 src/libvirt_private.syms| 8 ++ src/libvirt_public.syms

[PATCH v7 06/18] tests: Test qemuMonitorJSONGetThrottleGroup and qemuMonitorJSONUpdateThrottleGroup

Within "testQemuMonitorJSONqemuMonitorJSONUpdateThrottleGroup" * Test qemuMonitorJSONGetThrottleGroup * Test qemuMonitorJSONUpdateThrottleGroup, which updates limits through "qom-set" Signed-off-by: Harikumar Rajkumar --- tests/qemumonitorjsontest.c | 86

[PATCH v7 05/18] qemu: monitor: Add support for ThrottleGroup operations

ottleGroup is added by reusing "qemuMonitorAddObject" * "qemuMonitorMakeThrottleGroupLimits" will be used by building qemu cmd as well Signed-off-by: Harikumar Rajkumar --- src/qemu/qemu_monitor.c | 34 + src/qemu/qemu_monitor.h

[PATCH v7 04/18] config: Introduce ThrottleFilter and corresponding XML parsing

sing qemuDomainDiskPrivate and qemuDomainDiskPrivate Signed-off-by: Harikumar Rajkumar --- src/conf/domain_conf.c | 99 + src/conf/domain_conf.h | 20 + src/conf/virconftypes.h | 2 + 3 files changed, 121 insertions(+) diff --git a/src/conf/domain_c

[PATCH v7 03/18] config: Introduce ThrottleGroup and corresponding XML parsing

mainThrottleGroupDef * Support new resource "Parse" and "Format" for operations between struct and DOM XML * Make sure "group_name" is defined in xml Signed-off-by: Harikumar Rajkumar --- src/conf/domain_conf.c | 300 src/conf/

[PATCH v7 01/18] schema: Add new domain elements to support multiple throttle groups

Introduce schema for defining '' element which configures throttling groups which can be configured for multiple disks. * Refactor "diskIoTune" to extract common schema "iotune" * Add new elements '' * contains defintion, which references "iotune&q

[PATCH v7 00/18] *** [PATCH v7 00/18] qemu: block: Support block disk along with throttle filters ***

*** Support block disk along with throttle filters *** Harikumar Rajkumar (18): schema: Add new domain elements to support multiple throttle groups schema: Add new domain elements to support multiple throttle filters config: Introduce ThrottleGroup and corresponding XML parsing config

Re: [PATCH v5 07/18] remote: New APIs for ThrottleGroup lifecycle management

> On Fri, Feb 07, 2025 at 04:59:49 -0000, Harikumar Rajkumar wrote: > It is an implementation detail how that is achieved, based on what qemu > provides: > - explicitly request qemu to revert to default > - query the default and set the same value as default > - refu

Re: [PATCH v5 07/18] remote: New APIs for ThrottleGroup lifecycle management

> On Mon, Nov 18, 2024 at 19:24:15 +0530, Harikumar R wrote: > I don't think we should do the 'change a subset of' semantics any more. > It was proven that it doesn't make sense. Specifically it's not possible > to distinguish between "I don't want to change this field" and "I want > to delete/reve

Re: [PATCH v5 16/18] virsh: Add support for throttle group operations

> On Mon, Nov 18, 2024 at 19:24:24 +0530, Harikumar R wrote: > This will most likely need to be reimplemented by querying the data from > the XML as the API itself IMO doesn't make too much sense to exist as it > simply queries what we've set. are you suggesting to use qemuDomainGetXMLDesc() to ge

Re: [PATCH v5 00/18] *** qemu: block: Support block disk along with throttle filters ***

Hi Peter Krempa, Could you please prioritize reviews for remaining commits so we can create new patch request with all fix. We have a requirement which depends on this change and we are currently blocked.