> On Mon, Nov 18, 2024 at 19:24:08 +0530, Harikumar R wrote: > > The review is done now. There are few bits. > > Please note that I didn't point out *all* places needing a version > number update, so make sure to check everything explicitly. Please use > 11.1.0 for next posting. > > One important bit is that IMO the getter API makes IMO no sense to be > added as the data can simply be queried from the XML. Having a special > API is a bit overkill. > > Few other things I've pointed out: > - some coding style issues > - some pointless comments
I have addressed the feedbacks and submitted new patch version 7. https://lists.libvirt.org/archives/list/devel@lists.libvirt.org/thread/TV3HJ74I5CTDUHKZTDLF2VKEKACSDTHR/
