Re: fedora-review complains about gschema files in an RPM package

2017-03-23 Thread Andrew Toskin
Just realized I never posted my final update to this thread, so in case anyone else ever wanders here looking for answers: Any precompiled glib schema file is not needed -- if the *.gschema.xml file(s) are moved to %{buildroot}/%{_datadir}/glib-2.0/schemas/ at the end of the %install section

Re: fedora-review complains about gschema files in an RPM package

2017-02-26 Thread Jens Lody
Am Sun, 26 Feb 2017 05:12:38 - schrieb "Andrew Toskin" : > > On Feb 25, 2017 16:15, "Michael Catanzaro" > > > > > Interesting... guess I'm wrong then! > > > > I think that can be deleted? > > > > > > It's possible that the extension searches for the schema source > > (not sure if I'm gett

Re: fedora-review complains about gschema files in an RPM package

2017-02-25 Thread Andrew Toskin
> On Feb 25, 2017 16:15, "Michael Catanzaro" > Interesting... guess I'm wrong then! > > I think that can be deleted? > > > It's possible that the extension searches for the schema source (not sure > if I'm getting the terminology right) in a specific directory. Something > like some extension

Re: fedora-review complains about gschema files in an RPM package

2017-02-25 Thread Krzesimir Nowak
On Feb 25, 2017 16:15, "Michael Catanzaro" wrote: On Sat, 2017-02-25 at 07:57 +, Andrew Toskin wrote: > > > * if the package includes *precompiled* gschema... remove it? > > > > No, because these don't exist (at least I don't think so). All > > installed gschemas are compiled at once based on

Re: fedora-review complains about gschema files in an RPM package

2017-02-25 Thread Michael Catanzaro
On Sat, 2017-02-25 at 07:57 +, Andrew Toskin wrote: > > > * if the package includes *precompiled* gschema... remove it?  > > > > No, because these don't exist (at least I don't think so). All > > installed gschemas are compiled at once based on the schemas > > installed > > on the system, and

Re: fedora-review complains about gschema files in an RPM package

2017-02-24 Thread Andrew Toskin
> > * if the package includes *precompiled* gschema... remove it? > No, because these don't exist (at least I don't think so). All > installed gschemas are compiled at once based on the schemas installed > on the system, and there are no precompiled schemas. A few of packages' sources include a g

Re: fedora-review complains about gschema files in an RPM package

2017-02-24 Thread Michael Catanzaro
On Sat, 2017-02-25 at 01:04 +, Andrew Toskin wrote: > I'd just like to confirm what actions I need to take for my RPM > specs, then, if any. Does this sound right? > > * if the package source includes a .gschema.xml file, it's okay, and > needed, so leave it alone. Yes. > * if the package so

Re: fedora-review complains about gschema files in an RPM package

2017-02-24 Thread Andrew Toskin
I'd just like to confirm what actions I need to take for my RPM specs, then, if any. Does this sound right? * if the package source includes a .gschema.xml file, it's okay, and needed, so leave it alone. * if the package source includes a Makefile, which compiles the gschema file, then the sche

Re: fedora-review complains about gschema files in an RPM package

2017-02-24 Thread Andrew Toskin
> It used to be important. The review criteria should be updated. Do you > want to file a bug with fedora-review? Looks like there's already an open bug report: https://bugzilla.redhat.com/show_bug.cgi?id=1409315 ___ devel mailing list -- devel@lists.fed

Re: fedora-review complains about gschema files in an RPM package

2017-02-24 Thread Neal Gompa
On Fri, Feb 24, 2017 at 5:09 PM, Michael Catanzaro wrote: > On Fri, 2017-02-24 at 21:15 +, Andrew Toskin wrote: >> But then why is this such a prominent "Issue" in the output >> review.txt file? > > It used to be important. The review criteria should be updated. Do you > want to file a bug wit

Re: fedora-review complains about gschema files in an RPM package

2017-02-24 Thread Michael Catanzaro
On Fri, 2017-02-24 at 21:15 +, Andrew Toskin wrote: > But then why is this such a prominent "Issue" in the output > review.txt file? It used to be important. The review criteria should be updated. Do you want to file a bug with fedora-review? > And why does it warn me even when nothing in th

Re: fedora-review complains about gschema files in an RPM package

2017-02-24 Thread Andrew Toskin
> gsettings schema compilation is automatically handled these days with an > rpm file trigger that glib2 sets up. There's no need to add > glib-compile-schemas %postun and %postrans scripts any more (but they > won't hurt either and are required for EPEL7 if you want to keep the > same spec file).

Re: fedora-review complains about gschema files in an RPM package

2017-02-24 Thread Björn 'besser82' Esser
Am 24.02.2017 um 06:19 schrieb Andrew Toskin: I'm a new Fedora packager; my very first packages have not yet been accepted. I'm working on RPM packages for a few GNOME Shell extensions. Things are mostly going well, except that `fedora-review` complains about gschemas in the packages, and I'm

Re: fedora-review complains about gschema files in an RPM package

2017-02-23 Thread Kalev Lember
On 02/24/2017 06:20 AM, Andrew Toskin wrote: > I'm a new Fedora packager; my very first packages have not yet been accepted. > I'm working on RPM packages for a few GNOME Shell extensions. Things are > mostly going well, except that `fedora-review` complains about gschemas in > the packages, and

Re: fedora-review complains about gschema files in an RPM package

2017-02-23 Thread Andrew Toskin
> I could help edit the wiki if only someone ...if only someone would explain to me what this is about ** ___ devel mailing list -- devel@lists.fedoraproject.org To unsubscribe send an email to devel-le...@lists.fedoraproject.org

fedora-review complains about gschema files in an RPM package

2017-02-23 Thread Andrew Toskin
I'm a new Fedora packager; my very first packages have not yet been accepted. I'm working on RPM packages for a few GNOME Shell extensions. Things are mostly going well, except that `fedora-review` complains about gschemas in the packages, and I'm not entirely sure what this is supposed to be te

fedora-review complains about gschema files in an RPM package

2017-02-23 Thread Andrew Toskin
I'm a new Fedora packager; my very first packages have not yet been accepted. I'm working on RPM packages for a few GNOME Shell extensions. Things are mostly going well, except that `fedora-review` complains about gschemas in the packages, and I'm not entirely sure what this is supposed to be te