Re: Use cases for 'fedpkg scratch-build'

2023-01-21 Thread Otto Liljalaakso
Otto Liljalaakso kirjoitti 16.1.2023 klo 23.31: Miro Hrončok kirjoitti 16.1.2023 klo 16.05: On 16. 01. 23 14:57, Richard Shaw wrote: Since `fedpkg scratch-build` bombs out with an error if you've made local changes I propose a slight modification: If no changes are made then it does a norma

Re: Use cases for 'fedpkg scratch-build'

2023-01-17 Thread Otto Liljalaakso
Vít Ondruch kirjoitti 17.1.2023 klo 13.34: Dne 16. 01. 23 v 21:59 Otto Liljalaakso napsal(a): Vít Ondruch kirjoitti 16.1.2023 klo 16.50: I don't oppose to change of the defaults. However, I am also using `fedpkg scratch-build --srpm some.rpm`. So how would the proposed change influence this

Re: Use cases for 'fedpkg scratch-build'

2023-01-17 Thread Vít Ondruch
Dne 16. 01. 23 v 21:59 Otto Liljalaakso napsal(a): Vít Ondruch kirjoitti 16.1.2023 klo 16.50: I don't oppose to change of the defaults. However, I am also using `fedpkg scratch-build --srpm some.rpm`. So how would the proposed change influence this command? I do not intend to change that be

Re: Use cases for 'fedpkg scratch-build'

2023-01-16 Thread Otto Liljalaakso
Miro Hrončok kirjoitti 16.1.2023 klo 16.05: On 16. 01. 23 14:57, Richard Shaw wrote: Since `fedpkg scratch-build` bombs out with an error if you've made local changes I propose a slight modification: If no changes are made then it does a normal scratch build for the "does this still build /

Re: Use cases for 'fedpkg scratch-build'

2023-01-16 Thread Otto Liljalaakso
Michael J Gruber kirjoitti 16.1.2023 klo 14.46: `--srpm` is named misleadingly, by the way, because it names the "transport of the source" when indeed it implies a potentially different source version. That's another reasons why removing it (the name) and making it the mode of operation for `

Re: Use cases for 'fedpkg scratch-build'

2023-01-16 Thread Otto Liljalaakso
Vít Ondruch kirjoitti 16.1.2023 klo 16.50: I don't oppose to change of the defaults. However, I am also using `fedpkg scratch-build --srpm some.rpm`. So how would the proposed change influence this command? I do not intend to change that behavior in any way. __

Re: Use cases for 'fedpkg scratch-build'

2023-01-16 Thread Vít Ondruch
I don't oppose to change of the defaults. However, I am also using `fedpkg scratch-build --srpm some.rpm`. So how would the proposed change influence this command? Vít Dne 16. 01. 23 v 8:56 Otto Liljalaakso napsal(a): Hello everybody, I would like to gather different use cases for the 'fe

Re: Use cases for 'fedpkg scratch-build'

2023-01-16 Thread Richard Shaw
On Mon, Jan 16, 2023 at 8:06 AM Miro Hrončok wrote: > On 16. 01. 23 14:57, Richard Shaw wrote: > > > > Since `fedpkg scratch-build` bombs out with an error if you've made > local > > changes I propose a slight modification: > > > > If no changes are made then it does a normal scratch build for th

Re: Use cases for 'fedpkg scratch-build'

2023-01-16 Thread Miro Hrončok
On 16. 01. 23 14:57, Richard Shaw wrote: Since `fedpkg scratch-build` bombs out with an error if you've made local changes I propose a slight modification: If no changes are made then it does a normal scratch build for the "does this still build / not build" 1% use case If there are local

Re: Use cases for 'fedpkg scratch-build'

2023-01-16 Thread Richard Shaw
On Mon, Jan 16, 2023 at 3:38 AM Sandro wrote: > On 16-01-2023 08:56, Otto Liljalaakso wrote: > > Above change seems like a clear improvement to me, making the most used > > option the default. But I have noticed that workflows differ wildly > > between packagers, so before submitting any code for

Re: Use cases for 'fedpkg scratch-build'

2023-01-16 Thread Richard W.M. Jones
On Mon, Jan 16, 2023 at 09:56:31AM +0200, Otto Liljalaakso wrote: > Hello everybody, > > I would like to gather different use cases for the 'fedpkg > scratch-build' command. > > Currently, this is exactly the same as 'fedpkg build --scratch', > meaning that is performs a scratch build of the push

Re: Use cases for 'fedpkg scratch-build'

2023-01-16 Thread Michael J Gruber
Yes, testing local changes with `srpm` is the main use case. I would even say that using `scratch-build` without `--srpm` is a typical mistake for new packagers - thinking they test before they push, when in effect they don't. Testing (scratch-building) the pushed head makes sense when there are

Re: Use cases for 'fedpkg scratch-build'

2023-01-16 Thread Chris Kelley
For me it is: 99% "I want to check if local changes build" - fedpkg scratch-build --srpm 1% "Something changed in Rawhide and I want to see if X still builds" - fedpkg scratch-build I didn't know "fedpkg build" has a scratch option, TIL. Cheers, Chris On Mon, 16 Jan 2023 at 10:52, Daniel P. Be

Re: Use cases for 'fedpkg scratch-build'

2023-01-16 Thread Daniel P . Berrangé
On Mon, Jan 16, 2023 at 09:56:31AM +0200, Otto Liljalaakso wrote: > Hello everybody, > > I would like to gather different use cases for the 'fedpkg scratch-build' > command. > > Currently, this is exactly the same as 'fedpkg build --scratch', meaning > that is performs a scratch build of the push

Re: Use cases for 'fedpkg scratch-build'

2023-01-16 Thread Artur Frenszek-Iwicki
> At least in my workflow, I only do scratch builds before pushing, > to ensure that what I am about to push builds correctly in Koji. Same here. Some of my packages are prone to break and in need of patching on non-x86_64, so that's my main use case as well. Never used "fedpkg scratch-build" sinc

Re: Use cases for 'fedpkg scratch-build'

2023-01-16 Thread Sandro
On 16-01-2023 08:56, Otto Liljalaakso wrote: Above change seems like a clear improvement to me, making the most used option the default. But I have noticed that workflows differ wildly between packagers, so before submitting any code for review, I would like to hear if somebody regularly uses the

Re: Use cases for 'fedpkg scratch-build'

2023-01-16 Thread Dan Čermák
Otto Liljalaakso writes: > Hello everybody, > > I would like to gather different use cases for the 'fedpkg > scratch-build' command. > > Currently, this is exactly the same as 'fedpkg build --scratch', meaning > that is performs a scratch build of the pushed head of the current > branch. At le

Use cases for 'fedpkg scratch-build'

2023-01-15 Thread Otto Liljalaakso
Hello everybody, I would like to gather different use cases for the 'fedpkg scratch-build' command. Currently, this is exactly the same as 'fedpkg build --scratch', meaning that is performs a scratch build of the pushed head of the current branch. At least in my workflow, I only do scratch b