[389-devel] Re: Deref plugin entries == NULL #4525

2021-01-15 Thread thierry bordaz
:53 AM thierry bordaz <mailto:tbor...@redhat.com>> wrote: On 1/14/21 12:32 PM, Pierre Rogier wrote: Hi William, > It's a scenario we will need to fix via your BE work because of the MVCC transaction model that > LMDB will force us to adopt :) As I see

[389-devel] Re: Deref plugin entries == NULL #4525

2021-01-15 Thread thierry bordaz
On 1/14/21 12:32 PM, Pierre Rogier wrote: Hi William, > It's a scenario we will need to fix via your BE work because of the MVCC transaction model that > LMDB will force us to adopt :) As I see things in the early phases the lmdb read txn will probably only be managed at the db plugin level

[389-devel] Re: Deref plugin entries == NULL #4525

2021-01-15 Thread thierry bordaz
On 1/13/21 1:44 AM, William Brown wrote: Hey there, https://github.com/389ds/389-ds-base/pull/4525/files I had a look and I can see a few possible contributing factors, but without a core and the exact state I can't be sure if this is correct. It's all just hypothetical from reading the cod

[389-devel] Please review lib389 48984: support environment variable to define defaults.inf

2016-12-05 Thread thierry bordaz
While testing in a prefix install I found it useful: https://fedorahosted.org/389/attachment/ticket/48984/0003-Ticket-48984-support-of-environment-variable-for-def.patch ___ 389-devel mailing list -- 389-de...@lists.fedoraproject.org To unsubscribe send

[389-devel] 389-DS ACI improvement to control MODDN

2014-02-25 Thread thierry bordaz
Hello, Ticket https://fedorahosted.org/389/ticket/47553, is a 389-ds enhancement to allow a finer access control during a MODDN (new superior) operation. The use case being to allow/deny a bound user to move an entry from one specified part of the DIT to an other part. This without

Re: [389-devel] Design review: Access control on entries specified in MODDN operation (ticket 47553)

2014-02-25 Thread thierry bordaz
On 02/24/2014 11:35 PM, Rich Megginson wrote: On 02/24/2014 02:47 PM, Noriko Hosoi wrote: Rich Megginson wrote: On 02/24/2014 09:00 AM, thierry bordaz wrote: Hello, IPA team filled this ticket https://fedorahosted.org/389/ticket/47553. It requires an ACI improvement so that

[389-devel] Please review (take #2) ticket 47676: Replication of the schema fails 'master branch' -> 1.2.11 or 1.3.1

2014-01-29 Thread thierry bordaz
In the previous review, the policies (to be applied during replication of the schema) were hardcoded. This new review, is to define them into specific entries under 'cn=replSchema,cn=config" so that it will be configurable. https://fedorahosted.org/389/attachment/ticket/47676/0002-Ticket-ticket

Re: [389-devel] Please review: various lib389 cleanups

2013-11-21 Thread thierry bordaz
On 11/21/2013 04:22 PM, Rich Megginson wrote: On 11/21/2013 01:58 AM, thierry bordaz wrote: Hi, The changes look very good. I have a question regarding start/stop in Replica class. Why do not you use the function self.agreement.schedule(agmdn, interval='start') and self.agreemen

[389-devel] Please review ticket 47595 (lib389) - fail to detect/reinit already existing instance/backup

2013-11-21 Thread thierry bordaz
https://fedorahosted.org/389/attachment/ticket/47595/0001-Ticket-47595-fail-to-detect-reinit-already-existing-.patch -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

Re: [389-devel] Please review: various lib389 cleanups

2013-11-21 Thread thierry bordaz
On 11/21/2013 05:34 PM, Rich Megginson wrote: On 11/21/2013 08:36 AM, thierry bordaz wrote: On 11/21/2013 04:22 PM, Rich Megginson wrote: On 11/21/2013 01:58 AM, thierry bordaz wrote: Hi, The changes look very good. I have a question regarding start/stop in Replica class. Why do not you

[389-devel] Please review bug 47586: CI tests: test case for 47490

2013-11-21 Thread thierry bordaz
This second review takes differs from the previous one with: * use common.py instead of _common.py * initialization of the topology. This has been widely rewritten from previous review in order to run whatever it exists or not instance (started or not) and exists backups. https://fedorah

[389-devel] Please review ticket 47590 (take #3): add/split functions around replication

2013-11-18 Thread thierry bordaz
This review takes into account the recommendations of previous review: * Create a Agreement class in brooker * mv init/status/schedule/create in that new class * mv createDefaultReplMgr into the brooker replica class with the function create_repl_manager() * Handling of error condition wit

[389-devel] Please review bug 47586: CI tests: test case for 47490

2013-11-15 Thread thierry bordaz
https://fedorahosted.org/389/attachment/ticket/47586/0001-Ticket-47586-CI-tests-test-case-for-47490.patch -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review ticket 47590: add/split functions around replication

2013-11-13 Thread thierry bordaz
In order to implement the first CI test with replication instances, I reorganised lib389 functions related to replication setup. https://fedorahosted.org/389/attachment/ticket/47590/0001-Ticket-47590-CI-tests-add-split-functions-around-rep.patch -- 389-devel mailing list 389-de...@lists.fedor

[389-devel] Please review lib389 ticket 47584 (take #4): CI tests: add backup/restore of an instance

2013-11-07 Thread thierry bordaz
This review takes into account the following recommendations * skip verbose option (use of log.level). * use glob.glob to retrieve files matching rather that os.walk * fix a bug in instanceBackupFS that did not return an already existing backup * add two functions to handle instance backup

[389-devel] Please review lib389 ticket 47584 (take #3): CI tests: add backup/restore of an instance

2013-11-07 Thread thierry bordaz
This review differs from previous with: * skip verbose option (use of log.level). * use glob.glob to retrieve files matching rather that os.walk * fix a bug in instanceBackupFS that did not return an already existing backup * add two functions to handle instance backup: clearInstanceBackup

Re: [389-devel] Please review lib389 ticket 47584 (take #2): CI tests: add backup/restore of an instance

2013-11-06 Thread thierry bordaz
, "backup*.tar.gz") return glob.glob(backup_pattern) It should return an empty list in case of unexistent path On Wednesday 06 November 2013 18:31:40 thierry bordaz wrote: Thanks Roberto and Rich for reviewing this. This second patch takes into account your recommendation to let t

[389-devel] Please review lib389 ticket 47584 (take #2): CI tests: add backup/restore of an instance

2013-11-06 Thread thierry bordaz
Thanks Roberto and Rich for reviewing this. This second patch takes into account your recommendation to let the logging mechanism to choose rather that to use 'verbose' flag. https://fedorahosted.org/389/attachment/ticket/47584/0002-Ticket-47584-CI-tests-add-backup-restore-of-an-insta.patch --

[389-devel] Please review lib389 ticket 47578 (take #2): removal of 'sudo' and absolute path in lib389

2013-11-06 Thread thierry bordaz
This review enhances the previous fix with the handling of non SELinux platforms. https://fedorahosted.org/389/attachment/ticket/47578/0002-Ticket-47578-CI-tests-removal-of-sudo-and-absolute-p.patch -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mai

[389-devel] Please review (take #2) ticket 47575: add test case for ticket47560

2013-11-05 Thread thierry bordaz
Hi All, This review is new proposal to implement CI test cases inside 389-DS. The layout of the tests will be: /dirsrvtests/ tickets/ ticket_abc_test.py ticket_xyz_test.py ... finalizer testsuites/ acl_test.py

Re: [389-devel] Please review lib389 ticket 47578: removal of 'sudo' and absolute path in lib389

2013-10-30 Thread thierry bordaz
relevant things together. +1 On 10/30/2013 05:57 PM, thierry bordaz wrote: https://fedorahosted.org/389/attachment/ticket/47578/0001-Ticket-47578-CI-tests-removal-of-sudo-and-absolute-p.patch -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman

Re: [389-devel] Please review lib389 ticket 47578: removal of 'sudo' and absolute path in lib389

2013-10-30 Thread thierry bordaz
hat would reasonably group relevant things together. Right, it was my first intention. But then I had this idea to group the tickets per deployment module. I don't know if it is a good idea, but it seems to be confusing :-[ On 10/30/2013 05:57 PM, thierry bordaz wrote: https://fedora

Re: [389-devel] Please review lib389 ticket 47575: add test case for ticket47560

2013-10-30 Thread thierry bordaz
On 10/30/2013 06:59 PM, Rich Megginson wrote: On 10/30/2013 10:47 AM, thierry bordaz wrote: Hello, This tickets implement a test case and propose a layout of the CI tests in the 389-ds. The basic idea is to put CI tests under: /dirsrvtests/ tickets

Re: [389-devel] Proof of concept: mocking DS in lib389

2013-10-29 Thread thierry bordaz
ng with all methods is in file tests/test_dsmodules/conftest.py line 7. Thank you, Jan On 10/28/2013 12:02 PM, thierry bordaz wrote: Hi Jan, That is very impressive POC, far above my skill in python. Thanks for sharing this. I have a novice question. This implementation ove

Re: [389-devel] Please review lib389 ticket 47568: Rename DSAdmin class (2nd)

2013-10-25 Thread thierry bordaz
On 10/25/2013 11:38 AM, Roberto Polli wrote: On Friday 25 October 2013 11:18:53 thierry bordaz wrote: lib389/brooker.py:795: python variable naming convention: I would get stick with the "_" instead of camelCase and change whenever possible. If you prefer to use '_' also f

[389-devel] Please review lib389 ticket 47568: Rename DSAdmin class

2013-10-23 Thread thierry bordaz
https://fedorahosted.org/389/attachment/ticket/47568/0001-Ticket-47568-Rename-DSAdmin-class.patch -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review Ticket 47566: Initial import of DSadmin into lib389 repos

2013-10-21 Thread thierry bordaz
lib389 implements a python library for 389-ds administrative operations. This review is the push of DSadmin ( https://github.com/richm/dsadmin ) into lib389 with few adaptation fixes. https://fedorahosted.org/389/attachment/ticket/47566/0001-Ticket-ticket47566-Initial-import-of-DSadmin-into-38.p

Re: [389-devel] new python management library for 389

2013-10-18 Thread thierry bordaz
On 10/18/2013 10:14 AM, Roberto Polli wrote: Hi @all, I've just check out https://git.fedorahosted.org/cgit/389/lib389.git/ and I'll check the layout nkinder set up. Then I'll ask you how to import the first tests using py.test. Peace, R: Hi Roberto, After some differents evaluations we

[389-devel] Please review ticket 47398: memberOf on a user is converted to lowercase

2013-10-14 Thread thierry bordaz
https://fedorahosted.org/389/attachment/ticket/47398/0002-Ticket-47398-memberOf-on-a-user-is-converted-to-lowe.patch https://fedorahosted.org/389/ticket/47398 -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] Please review 2nd (fix regression) ticket 512: improve performance of vattr code

2013-08-14 Thread thierry bordaz
This review takes into account remarks done by Ludwig and Rich https://fedorahosted.org/389/attachment/ticket/512/0006-Ticket-512-improve-performance-of-vattr-code.patch https://fedorahosted.org/389/ticket/512 -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraprojec

[389-devel] Please review ticket 512: improve performance of vattr code

2013-04-10 Thread thierry bordaz
https://fedorahosted.org/389/ticket/512 https://fedorahosted.org/389/attachment/ticket/512/0001-Ticket-512-improve-performance-of-vattr-code.patch -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] please review: Ticket 618 - Crash at shutdown while stopping replica agreements

2013-03-21 Thread thierry bordaz
https://fedorahosted.org/389/ticket/618 https://fedorahosted.org/389/attachment/ticket/618/0001-Ticket-618-Crash-at-shutdown-while-stopping-replica-.patch -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] please review: Ticket 616 - High contention on computed attribute lock

2013-03-20 Thread thierry bordaz
https://fedorahosted.org/389/ticket/616 https://fedorahosted.org/389/attachment/ticket/616/0001-Ticket-616-High-contention-on-computed-attribute-loc.patch -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel

[389-devel] please review: Ticket 600 - Server should return unavailableCriticalExtension when processing a badly formed critical control

2013-03-13 Thread thierry bordaz
https://fedorahosted.org/389/ticket/600 https://fedorahosted.org/389/attachment/ticket/600/0001-Ticket-600-Server-should-return-unavailableCriticalE.patch -- 389-devel mailing list 389-de...@lists.fedoraproject.org https://admin.fedoraproject.org/mailman/listinfo/389-devel