Hi Liming,
Is this feature been tested and reviewed these two weeks? 😊
Thanks,
Christine
From: devel@edk2.groups.io On Behalf Of Yuwei Chen
Sent: Monday, November 13, 2023 8:32 AM
To: Gao, Liming ; 'Rebecca Cran' ;
Gao, Liming ; Zimmer, Vincent
; Kinney, Michael D ;
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112216): https://edk2.groups.io/g/devel/message/112216
Mute This Topic: https://groups.io/mt/103051162/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/dev
istine ;
> > > Feng, Bob C
> > > Cc: 'Rebecca Cran' ; Guo, Gua
>
> > > Subject: 回复: [edk2-devel] [Patch V2 1/4] BaseTools: fixing FMMT
> > ShrinkFv
> > > issue
> > >
> > > Yuwei:
> > > Please update commit m
+Cc Yang, Yuting2
> -Original Message-
> From: Yang, Yuting2
> Sent: Tuesday, December 12, 2023 5:01 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Gao, Liming
> ; Feng, Bob C ; Chen,
> Christine
> Subject: [Patch V2] BaseTools: VfrCompiler Adds DefaultValueError Feature
>
> Add --c
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4624
Currently, Python FMMT tool does not support automatically
select FMMTConf.ini file which saves GuidTool settings.
This patch supports this features.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
Edk2-basetools repo PR link:
https://github.com/tianocore/edk2-basetools/pull/100
Thanks,
Christine
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
> Sent: Friday, December 15, 2023 5:12 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Ga
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Liu, Liqi
> Sent: Tuesday, December 12, 2023 4:42 PM
> To: devel@edk2.groups.io
> Cc: Liu, Liqi ; Chen, Christine ;
> Feng, Bob C ; Chaganty, Rangasai V
> ; Gao, Liming
> Subject: [PATCH V2 1/1] Silicon/Int
Reviewed-by: Yuwei Chen
> -Original Message-
> From: S, Ashraf Ali
> Sent: Monday, December 25, 2023 11:28 PM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali ; Chen, Christine
> ; Rebecca Cran ; Gao, Liming
> ; Feng, Bob C ; Chan,
> Amy ; Chaganty, Rangasa
Hi Joey,
Thanks for fixing.
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Joey Vagedes
> Sent: Friday, December 29, 2023 12:48 AM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Gao, Liming
> ; Feng, Bob C ; Chen,
> Christine
> Subject: [PATCH v1
Hi Liming and Cran,
We should merge this fixing patch asap as it influences BaseTool's usage.
Thanks,
Christine
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
> Sent: Monday, January 8, 2024 9:16 AM
> To: Joey Vagedes ; devel@edk2.gro
Christine:
Is this a regression issue? Or does it resolve new usage? I am curious why it
is not reported before.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io<mailto:devel@edk2.groups.io>
> mailto:devel@edk2.groups.io>> 代表 Yuwei Chen
> 发送时间: 2024年1月
> > C ; Yang, Yuting2 ;
> > Hartung, Stephen
> > Subject: Re: [edk2-devel] [edk2-stable202311][PATCH] BaseTools: Python
> > VfrCompiler implementation
> >
> > On Thu, Dec 7, 2023 at 9:08 AM Yuwei Chen
> wrote:
> > >
> > > Hi Liming,
>
Reviewed-by: Yuwei Chen
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Wednesday, October 18, 2023 9:05 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Kinney, Michael D
> ; Rebecca Cran ; Sean
> Brogan ; Chen, Christine
>
Hi Liming,
I know your point. Would you like to start reviewing it and give us more
feedbacks? We really hope it can be merged as soon as possible.
We can do the merging after the stable tag, but just like you said, maybe we
need to review it firstly.
Looking forward to your feedbacks, and I th
The patch is good for me.
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Pierre Gondois
> Sent: Wednesday, November 22, 2023 9:15 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Gao, Liming
> ; Feng, Bob C ; Chen,
> Christine ; Sami Mujawar
> ; yeore
i
> Mujawar ; yeoreum@arm.com
> Subject: RE: [edk2-devel] [PATCH 1/1] BaseTools/Scripts/PatchCheck.py: Check
> for Change-id
>
> It's good. But I am curious why --ignore-change-id is needed?
>
> Thanks,
> Ray
> > -Original Message-
> > Fr
Reviewed-by: Yuwei Chen
> -Original Message-
> From: mikub...@linux.microsoft.com
> Sent: Wednesday, November 29, 2023 3:49 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Rebecca Cran ; Chen,
> Christine
> Subject: [PATCH v1 1/1] BaseTools/C
Hi Liming and Cran,
I have created the Edk2 PR for this one:
https://github.com/tianocore/edk2/pull/5009
As it has been reviewed, please help merge that. Thanks~
Thanks,
Yuwei (Christine)
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
>
I will add push
> label for this patch set.
>
> Thanks
> Liming
> > -邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Yuwei Chen
> > 发送时间: 2023年11月29日 16:26
> > 收件人: Gao, Liming ; Feng, Bob C
> >
> > 抄送: 'Rebecca Cran' ; devel@edk2.groups.io; Ch
Thanks a lot Rebecca~~
Thanks,
Christine
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Michael
> D Kinney
> Sent: Saturday, February 17, 2024 1:24 AM
> To: Rebecca Cran ; Joey Vagedes
> ; Rebecca Cran
> ; devel@edk2.groups.io; Sean
> ; Michael Kubacki
>
> Cc: Kinney, Mi
Ali, please also create PR in BaseTools repo.
Reviewed-by: Yuwei Chen
> -Original Message-
> From: S, Ashraf Ali
> Sent: Wednesday, February 28, 2024 5:57 PM
> To: devel@edk2.groups.io
> Cc: S, Ashraf Ali ; Rebecca Cran
> ; Liming Gao ; Feng, Bob
> C ; Chen, C
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Yang, Yuting2
> Sent: Wednesday, March 27, 2024 4:43 PM
> To: devel@edk2.groups.io
> Cc: Rebecca Cran ; Liming Gao
> ; Feng, Bob C ; Chen,
> Christine
> Subject: [Patch V2] [edk2-staging] BaseTools:
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/FMMT/FMMT.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/BaseTools/Source/Python/FMMT/FMMT.py
b/BaseTools/Source/Python/FMMT/FMMT.py
index 26fc4c5792..d9f1c265a7 100644
--- a
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Kuo, Ted
> Sent: Friday, July 5, 2024 5:32 PM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Feng, Bob C
> ; Chen, Christine
> Subject: [edk2-devel][PATCH][edk2-staging] BaseTools: Fix BaseTools
> compi
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3938
With this patch "-e" parameter supports extract FV function.
Usage: FMMT -e Inputfile TargetFv Outputfile
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/FMMT/FMMT.py | 3 +-
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3938
This function is used to remove the useless FV free space.
Usage: FMMT -s Inputfile Outputfile
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/FMMT/FMMT.py | 7 +
.../Source/Python/FMMT
For replace function, when target Ffs and new ffs are with
same size, the output file can not be generated successfully.
This patch fixes this issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
edk2basetools/FMMT/core/BiosTree.py | 4 ++--
edk2basetools/FMMT/core/FvHandler.py
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Feng, Bob C
> Sent: Sunday, October 16, 2022 8:11 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine
> Subject: [PATCH 1/1] pip-requirement: Upgrade the edk2-basetools version
&g
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4081
INF [Sources] section Feature Flag Expressions do not use
override values from build --pcd option currently.
This patch fix this issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
edk2basetools/Workspace/InfBuildData.py
: I29b52663613286c6210d99eaaa09338677a21b31
Signed-off-by: Yuwei Chen
Cc: Bob Feng
Cc: Liming Gao
---
.../Source/Python/AutoGen/WorkspaceAutoGen.py | 24 +++
BaseTools/Source/Python/Common/GlobalData.py | 1 +
BaseTools/Source/Python/GenFds/FdfParser.py | 14 ++-
3 files
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2762
The Fv Section in the FDF files use hard coding Guid values
which is inconvenient to manage. This patch adds Guid name
support in GenFfs to solve this problem.
Signed-off-by: Yuwei Chen
---
.../Source/Python/AutoGen/WorkspaceAutoGen.py
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2762
The Fv Section in the FDF files use hard coding Guid values
which is inconvenient to manage. This patch adds Guid name
support in GenFfs to solve this problem.
v5 modified the format without fuctional change.
Signed-off-by: Yuwei Chen
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> Zhiguang Liu
> Sent: Monday, July 6, 2020 2:38 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> Subject: [edk2-devel] [PATCH] Using LLVM compiler set to build
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang,
> Shenglei
> Sent: Thursday, July 16, 2020 11:14 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> Subject: [edk2-devel] [PATCH] BaseTools/PatchCheck.py: Sk
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> PierreGondois
> Sent: Tuesday, July 7, 2020 4:35 PM
> To: devel@edk2.groups.io
> Cc: Pierre Gondois ; Feng, Bob C
> ; Gao, Liming ;
> tomas.pi...@arm.com; n...@arm.com
> S
Add 'Yuwei Chen' as a reviewer for Edk2\BaseTools.
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
---
Maintainers.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 599f94d57a3d..da09b0be1b96 100644
--- a/Maintainers
Add 'Yuwei Chen' as a reviewer for
Edk2-platforms\Platform\Intel\Tools and
Edk2-platforms\Silicon\Intel\Tools.
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
---
Maintainers.txt | 2 ++
1 file changed, 2 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Cole
> Sent: Wednesday, August 12, 2020 1:28 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Cole Robinson
> Subject: [edk2-devel] [PATCH 1/2] BaseTools: fix u
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Cole
> Sent: Wednesday, August 12, 2020 1:28 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Cole Robinson
> Subject: [edk2-devel] [PATCH 2/2] B
Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/Trim/Trim.py | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/BaseTools/Source/Python/Trim/Trim.py
b/BaseTools/Source/Python/Trim/Trim.py
index c5638376e41a..776474b20349 100644
--- a/BaseTools
Hi, Shenglei
Since the input arguments number of the getText() function changed, the build
failed. May be you should check about the getText() function's input.
While how to choose the CParser4 and CParser3, I am not familiar with it, would
you like to explain for me?
Thanks,
Yuwei
> -Origi
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Zhang,
> Shenglei
> Sent: Friday, June 5, 2020 5:22 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> Subject: [edk2-devel] [PATCH v4] BaseTools/PatchCheck.p
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Feng,
> YunhuaX
> Sent: Saturday, May 9, 2020 3:01 PM
> To: devel@edk2.groups.io
> Cc: Ni, Ray ; Gao, Liming ; Feng,
> Bob C
> Subject: [edk2-devel] [PATCH] BaseTools/Fmmt
Hi, Michael
This patch looks good. While I have a little format suggestion: the Bugzilla
link "https://bugzilla.tianocore.org/show_bug.cgi?id=2797"; could be written as
"REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2797";.
Reviewed-by: Yuwei Chen
Thanks,
Yuwei
>
Hi, abner
I have a little suggestion for the patch format, it would be better if the
length of each commit line is less than 70 characters.
You can follow the Commit Message Format in the wiki of tianocore.
Thanks,
Yuwei
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Ab
> ; Leif Lindholm
> Subject: RE: [edk2-devel] [BaseTools PATCH v1] BaseTools: Add OpenSBI
> external definitions for RISC-V assembly build
>
> Sure YuWei, v2 patch is sent.
>
> Thanks
> Abner
>
> > -Original Message-
> > From: devel@edk2.groups.io [mailto:d
Hi, Pierre
The patch looks good.
Thanks,
Yuwei
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of
> PierreGondois
> Sent: Thursday, June 18, 2020 10:27 PM
> To: devel@edk2.groups.io
> Cc: Pierre Gondois ; sami.muja...@arm.com;
> tomas.pi...@arm.com; Feng, Bob C ; Gao, Liming
Reivewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Irene
> Park
> Sent: Wednesday, June 3, 2020 5:59 AM
> To: devel@edk2.groups.io
> Cc: Irene Park
> Subject: [edk2-devel] [PATCH] BaseTools/build.py: Exit with 1 when AutoGen
>
Currently when parse VFR files to get the struct info,
BOOLEAN type struct is ignored, which caused offset errors.
This patch fixed these bugs.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Scripts/ConvertFceToStructurePcd.py | 4 ++--
1 file changed, 2 insertions(+), 2
Hi everyone,
I would like to propose the new FMMT Python tool, which is used to replace the
origin C version tool.
Currently the FMMT C tool is saved in edk2-staging repo, but its quality and
coding style can't meet the Edk2 quality, which is hard to maintain
(Hard/Duplicate Code; Regression bu
oups.io
> Cc: Feng, Bob C
> Subject: 回复: [PATCH 1/1] BaseTools: Fix StructurePcd offset error.
>
> Yuwei:
>
> > -邮件原件-
> > 发件人: Yuwei Chen
> > 发送时间: 2021年10月27日 18:00
> > 收件人: devel@edk2.groups.io
> > 抄送: Bob Feng ; Liming Gao
> >
> >
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Feng, Bob C
> Sent: Monday, February 1, 2021 6:29 PM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Chen, Christine
>
> Subject: [Patch 1/1 V2] BaseTools: fix the split output files root dir
>
> If the out
Reviewed-by: Yuwei Chen
> -Original Message-
> From: matthewfcarl...@gmail.com
> Sent: Tuesday, February 9, 2021 8:51 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Liming Gao
> ; Chen, Christine ;
> Matthew Carlson
> Subject: [PATCH v5 1/1] BaseTools: Use pip
Hi Pierre,
There seems already have a Bugzilla link for this issue:
https://bugzilla.tianocore.org/show_bug.cgi?id=3094
And a personally concern: Some of the current codes still use "_***_H_", such
as " __PEI_APRIORI_FILE_NAME_H__ ". If the ECC check only support the coding
standard you mention
Currently the struct parser for StructPcd Generation does not
fliter the types such as UINT8 which should be ignored successfully.
This patch modifies this issue.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Scripts/ConvertFceToStructurePcd.py | 2 ++
1 file changed, 2
From: mliang2x
Update the pcdparser method in Dec and DSC files.
Signed-off-by: Mingyue Liang
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
---
.../Ecc/MetaFileWorkspace/MetaFileParser.py | 464 ++
1 file changed, 265 insertions(+), 199 deletions(-)
diff --git a/BaseTools
This patch looks good to me.
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Feng, Bob C
> Sent: Friday, December 24, 2021 10:50 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
> ; Chen, Christine
> Subject: [Patch] BaseTools: Fix the bug of -
This patch looks good to me.
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Lou, Yun
> Sent: Monday, January 10, 2022 11:13 PM
> To: devel@edk2.groups.io
> Cc: Lou, Yun ; Feng, Bob C ;
> Gao, Liming ; Chen, Christine
>
> Subject: [PATCH v2 6/6] BaseTools
s and Linux systems.
Signed-off-by: Mingyue Liang
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
---
BaseTools/BuildEnv | 24 +---
BaseTools/toolsetup.bat | 6 ++
2 files changed, 27 insertions(+), 3 deletions(-)
diff --git a/BaseTools/BuildEnv b/BaseTools/BuildEnv
-defined exception class should
be imported.
Signed-off-by: Mingyue Liang
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
---
BaseTools/Source/Python/build/build.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/BaseTools/Source/Python/build/build.py
b/BaseTools/Source/Python/build/build.py
This patch reduces compilation time , it looks good to me.
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Feng, Bob C
> Sent: Tuesday, March 15, 2022 8:17 PM
> To: devel@edk2.groups.io
> Cc: Gao, Liming ; Chen, Christine
>
> Subject: [Patch] BaseTools:
Hi Hoffmann,
I received some reports that some platforms are using gcc5.4. With this patch,
these platform builds are still broken.
Would you like to revert the original commits?
Thanks,
Christine (Yuwei)
> -Original Message-
> From: Gerd Hoffmann
> Sent: Tuesday, March 29, 2022 4:38 P
hristine (Yuwei)
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
> Sent: Thursday, March 31, 2022 8:51 AM
> To: Gerd Hoffmann ; devel@edk2.groups.io
> Cc: Feng, Bob C ; Rebecca Cran
> ; Pawel Polawski ; Oliver
> Steffen ; Gao, Liming
&g
From: mliang2x
Update the pcdparser method in Dec and DSC files.
Signed-off-by: Mingyue Liang
Cc: Bob Feng
Cc: Liming Gao
Cc: Yuwei Chen
---
.../Ecc/MetaFileWorkspace/MetaFileParser.py | 464 ++
1 file changed, 265 insertions(+), 199 deletions(-)
diff --git a/BaseTools
Please ignore this patch, sorry for wrong sending.
Thanks,
Yuwei
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
> Sent: Thursday, April 1, 2021 3:04 PM
> To: devel@edk2.groups.io
> Cc: Liang, MingyueX ; Feng, Bob C
> ; Liming Gao
&
Currently, when using GCC toolchain and loging the StdOut into files,
the StdErr will also be logged into files without shown in screen.
This patch fixes this issue.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3278
Cc: Bob Feng
Cc: Liming Gao
Cc: Wenyi Xie
Signed-off-by: Yuwei Chen
; Feng, Bob C
; Liming Gao
Subject: RE: [EXTERNAL] [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Update
structpcd parsing method.
What does "update" mean in this context? What behavior is changing?
- Bret
From: Yuwei Chen via groups.io<mailto:yuwei.chen=intel@groups.io>
Sent: T
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Kinney, Michael D
> Sent: Saturday, April 10, 2021 6:00 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Liming Gao
> ; Chen, Christine
> Subject: [Patch 1/1] BaseTools/Conf: Fix MAKE_FLAGS typos in
> too
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Kinney, Michael D
> Sent: Saturday, April 10, 2021 5:49 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Liming Gao
> ; Chen, Christine
> Subject: [Patch 1/1] BaseTools/PlatformAutoGen: MAKE_FLAGS and
>
l Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
> Sent: Monday, April 12, 2021 9:48 AM
> To: Kinney, Michael D ; devel@edk2.groups.io
> Cc: Feng, Bob C ; Liming Gao
>
> Subject: Re: [edk2-devel] [Patch 1/1] BaseTools/Conf: Fix MAKE_FLAGS typos
> in t
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Kinney, Michael D
> Sent: Monday, April 26, 2021 8:50 AM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Liming Gao
> ; Chen, Christine
> Subject: [Patch 1/1] BaseTools/GenMake: Sort generated makefile tool
&
Currently, the ConvertFceToStructurePcd.py tool generate StructurePcd
dsc file with comments including non-ascii character circle R. This
patch changes the non-ascii character circle R to (R) when adding the
comment.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Scripts
ls.
>
> Mike
>
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Yuwei
> > Chen
> > Sent: Wednesday, April 28, 2021 1:45 AM
> > To: devel@edk2.groups.io
> > Cc: Feng, Bob C ; Liming Gao
> >
> > Subject: [edk2-deve
river UNI file. It may
> have non-ascii character.
>
> Thanks
> Liming
> > -----邮件原件-
> > 发件人: devel@edk2.groups.io 代表 Yuwei Chen
> > 发送时间: 2021年4月29日 8:25
> > 收件人: Kinney, Michael D ;
> > devel@edk2.groups.io
> > 抄送: Feng, Bob C ; Liming G
called again until both input stream is depleted and encoder has no
more output after the method is called.
This patch fixes this issue based on the Brotli document.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
.../Source/C/BrotliCompress/BrotliCompress.c | 61 ---
1
This patch looks good to me.
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Cole
> Sent: Saturday, July 24, 2021 4:02 AM
> To: devel@edk2.groups.io
> Cc: Cole Robinson
> Subject: [edk2-devel] [PATCH 3/3] BaseTools: Drop check f
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Feng, Bob C
> Sent: Wednesday, July 28, 2021 7:45 PM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Chen, Christine
>
> Subject: [Patch] BaseTools: use shutil.copyfile instead shutil.copy2
>
> In Split tool,
Hi Robinson,
When we doing the internal test, the issue is found that py27 is blocked by
this patch.
You can reproduce the error with below steps:
For Linux:
[Error Reproduce steps]
$ export PYTHON3_ENABLE=FALSE
$ export PYTHON_COMMAND=/usr/bin/python2.7
$ build -p OvmfPkg/OvmfPkgIa32X64.dsc -
EFI_FFS_FILE_HEADER2, the Fv FileSystemGuid does not changed
consistent with Ffs type.That caused build issue.
This patch fixes this issue.
As FileSystemGuid3 is compatible with FileSystemGuid2, change all
the Fv header to FileSystemGuid3.
Signed-off-by: Yuwei Chen
Cc: Bob Feng
Cc: Liming Gao
---
BaseTools
: Yuwei Chen
Cc: Bob Feng
Cc: Liming Gao
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
---
BaseTools/Source/C/GenFv/GenFv.c | 2 +-
BaseTools/Source/Python/GenFds/GenFdsGlobalVariable.py | 2 ++
2 files changed, 3 insertions(+), 1 deletion(-)
diff --git a
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Feng, Bob C
> Sent: Tuesday, May 25, 2021 2:20 PM
> To: devel@edk2.groups.io
> Cc: Liming Gao ; Chen, Christine
>
> Subject: [Patch] [edk2-staging] BaseTools: Add checkpoint for that there is
> no fv ext_header
From: Mingyue Liang
Currently script Python interpreter is inconsistent with the
interpreter specified by Python home. This patch is to change
pythonhome to sys.executable.
Signed-off-by: MingYue Liang
Cc: Yuwei Chen
Cc: Bob Feng
Cc: Liming Gao
---
.../Tools/Fsp
circle R to (R).
Signed-off-by: Yuwei Chen
Cc: Bob Feng
Cc: Liming Gao
---
BaseTools/Scripts/ConvertFceToStructurePcd.py | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/BaseTools/Scripts/ConvertFceToStructurePcd.py
b/BaseTools/Scripts/ConvertFceToStructurePcd.py
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Srinivasan, ManickamX
> Sent: Wednesday, August 23, 2023 3:29 PM
> To: devel@edk2.groups.io
> Cc: Srinivasan, ManickamX ; Feng, Bob C
> ; Gao, Liming ; Chen,
> Christine ; T V, Krishnamoorthy
>
> Subj
From: Chen, Christine
> > Sent: Thursday, June 29, 2023 11:34 AM
> > To: devel@edk2.groups.io
> > Cc: Rebecca Cran ; Gao, Liming
> > ; Feng, Bob C
> > Subject: [Patch V2 1/4] BaseTools: fixing FMMT ShrinkFv issue
> >
> > 1. FvLength not change issue;
> >
Reviewed-by: Yuwei Chen
> -Original Message-
> From: Srinivasan, ManickamX
> Sent: Wednesday, September 13, 2023 4:56 PM
> To: devel@edk2.groups.io
> Cc: Srinivasan, ManickamX ; Feng, Bob C
> ; Gao, Liming ; Chen,
> Christine ; T V, Krishnamoorthy
>
> Subj
As the error is changed to warning, Trim.py will skip the build
error when the source code have exactly issue.
This patch change warning to error to opens the checking.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/Trim/Trim.py | 4 ++--
1
Cc Mike.
Thanks,
Christine
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
> Sent: Tuesday, October 25, 2022 4:51 PM
> To: devel@edk2.groups.io
> Cc: Feng, Bob C ; Gao, Liming
>
> Subject: [edk2-devel] [PATCH] BaseTools: Fix bu
Add new build option "--vfr-yaml-enable" for Python VfrCompiler
extended output yaml file generation.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/AutoGen/DataPipe.py | 2 ++
BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 8
Add new build option "--gen-default-variable-bin" for Variable
default value generation from Python VFR tool's extended json
output file.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/AutoGen/DataPipe.py | 2 ++
BaseTools/Source
Add new build option "--vfr-yaml-enable" for Python VfrCompiler
extended output yaml file generation.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/AutoGen/DataPipe.py | 2 ++
BaseTools/Source/Python/AutoGen/ModuleAutoGen.py | 8
Add new build option "--gen-default-variable-bin" for Variable
default value generation from Python VFR tool's extended json
output file.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/AutoGen/DataPipe.py | 2 ++
BaseTools/Source
Add new build option "--vfr-yaml-enable" for Python VfrCompiler
extended output yaml file generation.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
edk2basetools/AutoGen/DataPipe.py | 2 ++
edk2basetools/AutoGen/ModuleAutoGen.py | 8
edk2baseto
Add new build option "--gen-default-variable-bin" for Variable
default value generation from Python VFR tool's extended json
output file.
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
edk2basetools/AutoGen/DataPipe.py | 2 ++
edk2basetools/AutoGen/G
For replace function, when target Ffs and new ffs are with
same size, the output file can not be generated successfully.
This patch fixes this issue.
Cc: Rebecca Cran
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/FMMT/core/BiosTree.py | 4 ++--
BaseTools
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#103156): https://edk2.groups.io/g/devel/message/103156
Mute This Topic: https://groups.io/mt/98340352/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/deve
- ImageId
UPLD Buffer
'''
Cc: Rebecca Cran
Cc: Bob Feng
Cc: Liming Gao
Signed-off-by: Yuwei Chen
---
BaseTools/Source/Python/FMMT/FMMT.py | 2 ++
BaseTools/Source/Python/FMMT/core/BinaryFactoryProduct.py | 36
+++-
BaseT
For edk2-basetools repo, have made a PR for these three patches:
https://github.com/tianocore/edk2-basetools/pull/95
Thanks,
Christine (Yuwei)
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Yuwei
> Chen
> Sent: Tuesday, April 18, 2023 5:53 PM
> To: devel
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Bob
> Feng
> Sent: Thursday, June 30, 2022 12:11 PM
> To: devel@edk2.groups.io
> Cc: Kinney, Michael D ; Kubacki, Michael
>
> Subject: [edk2-devel] [Patch V2] pip-requiremen
Reviewed-by: Yuwei Chen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Lin,
> Jason1
> Sent: Friday, July 1, 2022 11:10 PM
> To: devel@edk2.groups.io
> Cc: Lin, Jason1 ; Feng, Bob C ;
> Gao, Liming ; Chen, Christine
> ; Oram, Isaac W ;
> Ch
1 - 100 of 160 matches
Mail list logo
