forcibly allocated
below 4G in system address map. Otherwise the allocation fails on
platforms that do not have any memory below the 4G mark and the drive
initialisation fails.
Cc: Ray Ni
Cc: Ard Biesheuvel
Cc: Leif Lindholm
Signed-off-by: Tomas Pilar
---
.../Bus/Pci/NvmExpressDxe/NvmExpress.c
I've commented on the bug, SFC adapters will be fine, but I am sure there is a
vendor out there that will be affected. Bugs due to memory corruption during OS
load that depend on the network externalities are notoriously difficult to
diagnose.
We need to make sure this is properly communicated
Hi Vikash,
If I remember correctly, those BIOSes have a binary CMS choice for CSM with
regards to options ROMs. Either you permit legacy option ROMs or you permit
UEFI option ROMs and there is not way to permit both at the same time. Make
sure that these settings are configured correctly.
Al
I don't know about clangd but I am successfully using the vscode intellisense
with EDKII including the multiple workspaces.
It took some time to configure things with paths and includes to make it work
correctly but the only problem I have at the moment is to get it to use the
correct AutoGen.h
Oh but I am using clang-format to get vscode to format things according to
proper code style.
From: Tomas Pilar
Sent: 24 December 2019 12:36
To: Devel EDK2 ; 'ray...@intel.com'
Subject: RE: [edk2-devel] Anyone successfully enabled clangd in edk2 code?
I don't know about
Sorry Guys, I did not see the previous email. I don't claim my clang-format is
perfect, you might need to tweak it a little.
---
BasedOnStyle: LLVM
AlignAfterOpenBracket: Align
AlignConsecutiveDeclarations: false
AlignEscapedNewlines: Left
AlignOperand
This package is for Solarflare Communications drivers and utilities.
Signed-off-by: Tomas Pilar
Cc: Leif Lindholm
Cc: Michael D Kinney
---
Drivers/SfcPkg/Readme.md | 11 +++
Maintainers.txt | 4
Readme.md| 7 +++
3 files changed, 22 insertions
for me.
Tomas Pilar (1):
SfcPkg: Add new package
Drivers/SfcPkg/Readme.md | 11 +++
Maintainers.txt | 4
Readme.md| 7 +++
3 files changed, 22 insertions(+)
create mode 100644 Drivers/SfcPkg/Readme.md
--
2.21.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
Hi Liming,
I think the very general idea is that UEFI spec requires language based
DriverModel protocol members
to always check if the language is supported and return EFI_UNSUPPORTED
otherwise. The procotols
such as ComponentName2, DriverDiagnostics2, etc. usually also publish a member
string
Hi,
We also implement capsules to update optionROMs that use an embedded
driver in the capsule. The main reason for us is space - crypto library
is too large to fit into our flash so we don't provide fully functional
FMP in the optionROM driver, only a stub FMP that is enough to populate
the
I skimmed the my emails and my eyes registered 'Ard Biesheuvel' and 'death' and
my brain went 'but but but I've seen him just yesterday!'. Hope you are happy.
T
-Original Message-
From: devel@edk2.groups.io On Behalf Of Leif Lindholm
Sent: 09 April 2019 08:46
To: devel@edk2.groups.io
Su
Fish via
Groups.Io wrote:
Tom,
Looks like the mailing list stripped your
attachment.
Thanks,
Andrew Fish
On May 22, 2019, at 4:19 AM, Tomas Pilar
(tpilar
original
parent device?
In either way, the device path search using NII is fairly ingenious!
On 22/05/2019 23:26, Michael Brown wrote:
> On 22/05/2019 11:40, Tomas Pilar (tpilar) wrote:
>> Yeah, I just AllocateCopyPool the static struct on heap for each device. I
>> can hones
Hi,
I am trying to create kvm instance using libvirt and Qemu and OVMF that also
has SMBIOS included. My current version of Qemu only supports type 0 and type 1
SMBIOS tables so I specify those. However, when I use smbiosview in the UEFI
shell, I get back "SMBIOS not found".
I attach my curren
On 28/05/2019 18:06, Laszlo Ersek wrote:
> On 05/28/19 17:18, Tomas Pilar (tpilar) wrote:
>> Hi,
>>
>> I am trying to create kvm instance using libvirt and Qemu and OVMF that also
>> has SMBIOS included. My current version of Qemu only supports type 0 and
>>
Switching to this library enables capsule support for FMP devices. Simple
tests show that a capsule with an embedded driver now updates using
CapsuleApp.
Cc: Jordan Justen
Cc: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Tomas Pilar
---
OvmfPkg/OvmfPkgX64.dsc | 2 +-
1 file changed, 1
On 24/06/2019 12:15, Ard Biesheuvel wrote:
> On Mon, 24 Jun 2019 at 12:33, Tomas Pilar wrote:
>> Switching to this library enables capsule support for FMP devices. Simple
>> tests show that a capsule with an embedded driver now updates using
>> CapsuleApp.
>>
: Laszlo Ersek
Cc: Ard Biesheuvel
Signed-off-by: Tomas Pilar
---
OvmfPkg/OvmfPkgX64.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc
index 39ac791565..4c41e59a75 100644
--- a/OvmfPkg/OvmfPkgX64.dsc
+++ b/OvmfPkg/OvmfPkgX64.dsc
shell in that VM and pass the capsule as first
parameter. That's all there is to it.
I can share my libvirt XML containing the hostdev configuration if you'd like.
Cheers,
Tom
-Original Message-
From: Philippe Mathieu-Daudé
Sent: 25 June 2019 15:52
To: Devel EDK2 ;
On 24/06/2019 22:28, Laszlo Ersek wrote:
> (+Mike)
>
> On 06/24/19 17:53, Tomas Pilar (tpilar) wrote:
>> Switching to this library enables capsule support for FMP devices.
>> This will allow testing of FMP for PCI devices using OVMF and PCI
>> passthrough as well as so
Fair enough, I'll spin a new patch.
-Original Message-
From: Laszlo Ersek
Sent: 03 July 2019 15:46
To: Tomas Pilar ; Devel EDK2
Cc: jordan.l.jus...@intel.com; Ard Biesheuvel ;
Michael Kinney
Subject: Re: [edk2-devel] [PATCH v2] OvmfPkg: Use DxeRuntimeCapsuleLib from
DxeCapsuleL
Hi,
I have a bit of an esoteric problem. When I configure the software iscsi
intiator that is part of EDK2 platform network stack, the platform network
stack with install iBFT table into the ACPI tables so that the configuration
can be picked up by further boot loaders and the OS. So far so goo
I am going to commit the cardinal sin of online dev support.
'Never mind, found the problem'
From: Tomas Pilar
Sent: 20 May 2019 16:57
To: 'devel@edk2.groups.io'
Subject: iSCSI and iBFT
Hi,
I have a bit of an esoteric problem. When I configure the software iscsi
intiator
; Tomas Pilar
Subject: Re: [edk2-devel] iSCSI and iBFT
On 05/21/19 16:54, Tomas Pilar (tpilar) wrote:
> I am going to commit the cardinal sin of online dev support.
heh :)
> 'Never mind, found the problem'
What was it?
I didn't ignore your original email -- I looked
also be fine.
The whole NII and UNDI drivers vs. SNP drivers compatibility across OEMs/IBVs
and IHVs is a painful trash fire and this is just the last problem in a very
long line of annoyances.
On 22/05/2019 11:19, Laszlo Ersek wrote:
> On 05/22/19 11:55, Tomas Pilar wrote:
>> iPXE ident
Hi Pavan,
I am currently playing around with setting up a OVMF based test framework
myself. You likely need to tell qemu to use OVMF as it's firmware. I attach my
current working libvirt XML file for creating UEFI VMs (diskless) - note the
and the elements within the element.
You want to ad
Extract error and warning logging into separate methods. Fold
highlighting and other output properties into the logging methods.
Change-Id: I46bba2afc6fe8d7bc0c92ec7054f2af2d2254441
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 5
The dump variable helper functions are refactored into
a separate header file as inline functions to declutter code.
Change-Id: I9c43c9ce1e9809813949b4f45b1b19b6265e18c4
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 212
The AcpiView core method is refactored to take format
and parameters rather than a fully formatted string. This
allows for far more flexible parser writing.
Change-Id: I02c30939f2c5ad98da7174303ae241839d2c8eba
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
Modify the DumpFile error message to be more in line
with the rest of the error messages in the same file.
Change-Id: I8f074178154e13db06a67f2158448fc625ee4216
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c | 4 +---
1
Remove superfluous accessor methods for error and warning
counters.
Change-Id: I23df0aa10cfc757f37d83dee7ecce8a188a3ad1c
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 54 ++-
.../UefiShellAcpiViewCommandLib
local variable declarations.
Return macro to access 2D array items.
Patch series also available on github:
https://github.com/tpilar/edk2/tree/acpiview-error-logging-v2
Tomas Pilar (8):
ShellPkg/AcpiView: Extract configuration struct
ShellPkg/AcpiView: Declutter error counters
ShellPkg
Refactor logging using the AcpiViewLog facility.
Trim some of the source to more elegant state.
Change-Id: I98b2c49b155e8c8b91aaf9bbd2ab21ebad5b36f0
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 225
: Id19058caf875c5502f5a21ecec2db8b77361cb08
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 18 +-
.../AcpiTableParser.c | 4 +-
.../UefiShellAcpiViewCommandLib/AcpiView.c| 67 +++
.../AcpiViewConfig.c
: Ica35c9ca1d9ef155927a4be3f16418f6755be8e6
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 25 --
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 18 --
.../Arm/SbbrValidator.c | 65 +++---
.../Parsers/Dbg2/Dbg2Parser.c
Remove superfluous accessor methods for error and warning
counters.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 54 ++-
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 4 ++
.../UefiShellAcpiViewCommandLib
The AcpiView core method is refactored to take format
and parameters rather than a fully formatted string. This
allows for far more flexible parser writing.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 30
Modify the DumpFile error message to be more in line
with the rest of the error messages in the same file.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff
Extract error and warning logging into separate methods. Fold
highlighting and other output properties into the logging methods.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 5 +-
.../UefiShellAcpiViewCommandLib/AcpiViewLog.c
Refactor logging using the AcpiViewLog facility.
Trim some of the source to more elegant state.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 225 --
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 6
Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 18 +-
.../AcpiTableParser.c | 4 +-
.../UefiShellAcpiViewCommandLib/AcpiView.c| 67 +++
.../AcpiViewConfig.c | 180
The dump variable helper functions are refactored into
a separate header file as inline functions to declutter code.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 212 ---
.../UefiShellAcpiViewCommandLib/AcpiParser.h
This patch series refactors the error logging in the AcpiView
functionality to a newly created logging facility.
The new error logging facility in AcpiViewLog.[ch] contains
helper functions to log messages of various types and severities,
enumerations of known error types as well as common abstrac
: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 25 ---
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 18 --
.../Arm/SbbrValidator.c | 65 +++---
.../Parsers/Dbg2/Dbg2Parser.c | 119 ---
.../Parsers/Fadt
(change of email)
Hi Zhichao,
I've amended the patches and respun a v3 version. Any chance you could have a
look to see if I've fixed the issues correctly?
Cheers,
Tom
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#63443): https://edk
bitwise-ORed with their
corresponding namespace.
This means we no longer need to use macros to compose and decompose
CmObjectIds. The macros are adjusted so that they result in NOP.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Signed-off-by: Tomas Pilar
---
.../Include/ArmNameSpaceObjects.h
Add functions abstracting adding and removing of objects using
the ConfigurationManagerProtocol to TableHelperLib. Also add
helpers for writing component library constructors for component
libraries populating a ConfigurationManager.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Signed-off-by: Tomas
-off-by: Tomas Pilar
---
DynamicTablesPkg/DynamicTablesPkg.dsc | 1 +
1 file changed, 1 insertion(+)
diff --git a/DynamicTablesPkg/DynamicTablesPkg.dsc
b/DynamicTablesPkg/DynamicTablesPkg.dsc
index 02f04447ff..346fa8ccdd 100644
--- a/DynamicTablesPkg/DynamicTablesPkg.dsc
+++ b/DynamicTablesPkg
: Sami Mujawar
Cc: Alexei Fedorov
Signed-off-by: Tomas Pilar
--
Tomas Pilar (8):
DynamicTablesPkg: Include BaseStackCheckLib
DynamicTablesPkg: Fold Namespaces into CmObjectId Enums
DynamicTablesPkg: Add ConfigurationManagerDumpApp
DynamicTablesPkg: Update ConfigurationManagerProtocol
FreeObject function is provided for the ease
of transition for v1.0 managers.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Signed-off-by: Tomas Pilar
---
.../Protocol/ConfigurationManagerProtocol.h | 83 ++-
1 file changed, 80 insertions(+), 3 deletions(-)
diff --git a/DynamicTablesPkg
Add user friendly strings for CmObjectIds to TableHelperLib
and add debug print invocations to common helper methods.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Signed-off-by: Tomas Pilar
---
.../ConfigurationManagerDumpApp.c | 13 +--
.../ConfigurationManagerDumpApp.h | 8
.
Cc: Sami Mujawar
Cc: Alexei Fedorov
Signed-off-by: Tomas Pilar
---
.../ConfigurationManagerDumpApp.c | 76 +++
.../ConfigurationManagerDumpApp.h | 8 ++
.../ConfigurationManagerDumpApp.inf | 42 ++
.../ConfigurationObjectStrings.c
-off-by: Tomas Pilar
---
.../DynamicTableManagerDxe.c | 20 ++--
.../Include/Library/TableHelperLib.h | 23 ++---
.../Acpi/Arm/AcpiDbg2LibArm/Dbg2Generator.c | 10 +-
.../Acpi/Arm/AcpiFadtLibArm/FadtGenerator.c | 12 +--
.../Acpi/Arm/AcpiGtdtLibArm/GtdtGenerator.c
Hi Sami,
Could you possibly have a look at my dynamic tables patches I submitted
last week?
Cheers,
Tom
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#63775): https://edk2.groups.io/g/devel/message/63775
Mute This Topic: https://groups.
The error and warning counters are reset in the AcpiView main method.
This improves reusability of the main method.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8
1 file changed, 4 insertions(+), 4 deletions
Parsing command line parameters is done in the shell
command wrapper. This declutters the core code and improves
modular design.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c|
205
: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c|
1 +
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c |
1 +
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
'acpiview'
command in the internal build of the UEFI shell. Furthermore,
this application can then be integrated in larger firmware
testing frameworks.
---
Cc: Ray Ni
Cc: Zhichao Gao
Tomas Pilar (6):
ShellPkg/AcpiView: Move log reset to main method
ShellPkg/AcpiView: Refactor conf
The table count module level symbols are now reset when
executing the core method, rather than the shell command
wrapper.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 +---
1 file changed, 5 insertions(+), 3
urthermore, this app can be integrated into more comprehensive
testing frameworks as a single component of a more thorough
specification compliance validation strategy.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Application/AcpiViewApp/AcpiViewApp
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c|
35 +--
ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c |
58
Well, it looks like the settings for send-email don't Just Work (tm), I'll
clean up the series and resubmit. Apologies for spamming the list.
Tom
-Original Message-
From: devel@edk2.groups.io On Behalf Of Tomas Pilar
(tpilar) via groups.io
Sent: 21 May 2020 19:16
To:
'acpiview'
command in the internal build of the UEFI shell. Furthermore,
this application can then be integrated in larger firmware
testing frameworks.
---
v2: Patch formatting
Cc: Ray Ni
Cc: Zhichao Gao
Tomas Pilar (6):
ShellPkg/AcpiView: Move log reset to main method
ShellPk
The error and warning counters are reset in the AcpiView main method.
This improves reusability of the main method.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8
1 file changed, 4 insertions(+), 4 deletions
The table count module level symbols are now reset when
executing the core method, rather than the shell command
wrapper.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 +---
1 file changed, 5 insertions(+), 3
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c|
1 +
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiTableParser.c |
1 +
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c |
237
-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c|
35 +--
ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.c |
58 ++
ShellPkg/Library
Parsing command line parameters is done in the shell
command wrapper. This declutters the core code and improves
modular design.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c|
205
, this app can be integrated into more comprehensive
testing frameworks as a single component of a more thorough
specification compliance validation strategy.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Application/AcpiViewApp/AcpiViewApp
I actually agree with you, when we migrated from reviewboard to github pull
requests, I was sorely disappointed with the PR functionality and ergonomics.
Tomas Pilar
-Original Message-
From: r...@edk2.groups.io On Behalf Of Rebecca Cran via
groups.io
Sent: 14 May 2020 22:47
To: r
Based on the output, am I correct in assuming that the generated
ABCPPSupportLib makefile does not have a rule for making ABCPPSupportLib.obj?
Tom
From: devel@edk2.groups.io On Behalf Of David F. via
groups.io
Sent: 25 May 2020 08:56
To: devel@edk2.groups.io
Subject: [edk2-devel] Updating to l
This will probably be down to the [send-email] section of git config, do you
have smtpEncryption enabled by any chance?
You could also try updating the required package:
perl -MCPAN -e 'install "IO::Socket::SSL"'
From: devel@edk2.groups.io On Behalf Of Bret Barkelew
via groups.io
Sent: 27 May
Hi,
Any chance you had time to look at my AcpiView patches?
Cheers,
Tom
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#60396): https://edk2.groups.io/g/devel/message/60396
Mute This Topic: https://groups.io/mt/74519195/21656
Group Owner
Hi Zhichao,
Thank you very much, I am just trying to make sure things don't slip through
the cracks.
Cheers,
Tom
From: Gao, Zhichao
Sent: 29 May 2020 01:31
To: Tomas Pilar ; devel@edk2.groups.io; Ni, Ray
Cc: nd
Subject: RE: AcpiView Patches
Sorry, Pilar. I am busy at other things. Pl
Hi,
By no means a complete answer but some important points below.
There are two important concepts in UEFI that you absolutely need to get
comfortable with. These two are Handles and Protocols.
You can think of a protocol as an implementation of a well defined API that
allows you to do someth
enumeration of devices and creating the controller handles with low
lever IO protocols and hardware device paths is done by the platform, I
wouldn’t worry too much about that at this point.
Cheers,
Tom
From: Kumar G
Sent: 08 June 2020 19:10
To: Tomas Pilar
Cc: devel@edk2.groups.io; nd
Subject: Re
Krzysztof has moved on to other pastures, I'll respin the patches accordingly.
Cheers,
Tom
-Original Message-
From: devel@edk2.groups.io On Behalf Of Gao, Zhichao via
groups.io
Sent: 11 June 2020 08:43
To: Krzysztof Koch ; devel@edk2.groups.io
Cc: Ni, Ray ; Sami Mujawar ;
Laura.Moretta
To: devel@edk2.groups.io; Tomas Pilar
Cc: nd ; Ni, Ray
Subject: RE: [edk2-devel] [PATCH v2 6/6] ShellPkg/AcpiView: Add application
wrapper
(1)
There is one more easy with to add the help info.
Put the help string in the uni file that has the same name with the module file
name.
See below ex
The table count module level symbols are now reset when
executing the core method, rather than the shell command
wrapper.
Cc: Ray Ni
Cc: Zhichao Gao
Reviewed-by: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 +---
1 file changed, 5
The error and warning counters are reset in the AcpiView main method.
This improves reusability of the main method.
Cc: Ray Ni
Cc: Zhichao Gao
Reviewed-by: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8
1 file changed, 4
named library. Tidy help text shell hook in standalone app.
v2: Patch formatting
Cc: Ray Ni
Cc: Zhichao Gao
Tomas Pilar (7):
ShellPkg/AcpiView: Move log reset to main method
ShellPkg/AcpiView: Refactor configuration
ShellPkg/AcpiView: Move table count reset
ShellPkg/AcpiView: Mo
by pulling UefiShellAcpiViewCommandLib
as a NULL library to preserve the modularity of shell builds.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../Library/AcpiViewCommandLib.h} | 15 ---
.../UefiShellAcpiViewCommandLib/AcpiView.c| 2
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 1 +
.../AcpiTableParser.c | 1 +
.../UefiShellAcpiViewCommandLib/AcpiView.c| 237 +++--
.../UefiShellAcpiViewCommandLib/AcpiView.h| 95 ---
.../AcpiViewConfig.c
-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiView.c| 38 +---
.../UefiShellAcpiViewCommandLib.c | 59 +++
.../UefiShellAcpiViewCommandLib.h | 17 +-
3 files changed, 76 insertions(+), 38 deletions(-)
diff --git a/ShellPkg/Library
Parsing command line parameters is done in the shell
command wrapper. This declutters the core code and improves
modular design.
Cc: Ray Ni
Cc: Zhichao Gao
Reviewed-by: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiView.c| 205
urthermore, this app can be integrated into more comprehensive
testing frameworks as a single component of a more thorough
specification compliance validation strategy.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../Application/AcpiViewApp/AcpiViewApp.c | 40 ++
.../App
Hi Ray, Zhichao,
Do you have any opinions on the respun patches?
Cheers,
Tom
-Original Message-
From: devel@edk2.groups.io On Behalf Of Tomas Pilar
(tpilar) via groups.io
Sent: 15 June 2020 15:04
To: devel@edk2.groups.io
Cc: nd ; Ray Ni ; Zhichao Gao
Subject: [edk2-devel] [PATCH v3
The error and warning counters are reset in the AcpiView main method.
This improves reusability of the main method.
Cc: Ray Ni
Cc: Zhichao Gao
Reviewed-by: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8
1 file changed, 4
tion.
Furthermore, this app can be integrated into more comprehensive
testing frameworks as a single component of a more thorough
specification compliance validation strategy.
Cc: Ray Ni
Cc: Zhichao Gao
Reviewed-by: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../Application/AcpiV
The table count module level symbols are now reset when
executing the core method, rather than the shell command
wrapper.
Cc: Ray Ni
Cc: Zhichao Gao
Reviewed-by: Zhichao Gao
Signed-off-by: Tomas Pilar
---
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 8 +---
1 file changed, 5
Parsing command line parameters is done in the shell
command wrapper. This declutters the core code and improves
modular design.
Cc: Ray Ni
Cc: Zhichao Gao
Reviewed-by: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiView.c| 205
Reviewed-by: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiView.c| 38 +---
.../UefiShellAcpiViewCommandLib.c | 59 +++
.../UefiShellAcpiViewCommandLib.h | 17 +-
3 files changed, 76 insertions(+), 38
: Zhichao Gao
Reviewed-by: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 1 +
.../AcpiTableParser.c | 1 +
.../UefiShellAcpiViewCommandLib/AcpiView.c| 237 +++--
.../UefiShellAcpiViewCommandLib/AcpiView.h
ndLib and convert to
named library. Tidy help text shell hook in standalone app.
v2: Patch formatting
Cc: Ray Ni
Cc: Zhichao Gao
Tomas Pilar (7):
ShellPkg/AcpiView: Move log reset to main method
ShellPkg/AcpiView: Refactor configuration
ShellPkg/AcpiView: Move table count reset
She
built by pulling UefiShellAcpiViewCommandLib
as a NULL library to preserve the modularity of shell builds.
Cc: Ray Ni
Cc: Zhichao Gao
Reviewed-by: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../Library/AcpiViewCommandLib.h} | 15
Hi Ray, Zhichao,
I've created a pull request with the standalone acpiview patches for your
convenience. Could you please merge it once it passes the CI checks?
Cheers,
Tom
IMPORTANT NOTICE: The contents of this email and any attachments are
confidential and may also be privileged. If you are no
Oh, it looks like any pull requests created by non-maintainers get auto-closed
by mergify. Nevermind then.
From: devel@edk2.groups.io On Behalf Of Tomas Pilar
(tpilar) via groups.io
Sent: 29 June 2020 15:11
To: devel@edk2.groups.io
Cc: Ray Ni ; Zhichao Gao ; Sami
Mujawar
Subject: [edk2-devel
Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 18 +-
.../AcpiTableParser.c | 4 +-
.../UefiShellAcpiViewCommandLib/AcpiView.c| 67 +++
.../AcpiViewConfig.c | 180
Remove superfluous accessor methods for error and warning
counters.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 54 ++-
.../UefiShellAcpiViewCommandLib/AcpiParser.h | 4 ++
.../UefiShellAcpiViewCommandLib
Extract error and warning logging into separate methods. Fold
highlighting and other output properties into the logging methods.
Cc: Ray Ni
Cc: Zhichao Gao
Signed-off-by: Tomas Pilar
---
.../UefiShellAcpiViewCommandLib/AcpiParser.c | 5 +-
.../UefiShellAcpiViewCommandLib/AcpiViewLog.c
1 - 100 of 120 matches
Mail list logo
