On 11/29/2023 1:06 AM, G Edhaya Chandran wrote:
Hi Rebecca,
Thank you for these updates.
Just a matter of style, but can we do HowToBuild*SCT*.txt instead of
HowToBuild*Sct*.txt?
Sure! I can make that change just before I push the series.
--
Rebecca Cran
I don't appear to have permission to push to the edk2-test repo.
Could somebody merge my change please?
Thanks.
Rebecca
On 11/10/2023 12:08 PM, Rebecca Cran wrote:
Some improvements to the edk2-test repository.
Since buildzip.sh creates output that appears more useful for running o
On 12/11/2023 6:17 PM, Laszlo Ersek wrote:
On 12/9/23 01:33, Rebecca Cran via groups.io wrote:
On 12/8/2023 5:19 PM, Rebecca Cran wrote:
Add the new DEBUG_MANAGEABILITY debug level to MdePkg.dec and MdePkg.uni.
Improve the wording of the description of the DEBUG_MANAGEABILITY
level in
On 4/7/2023 10:58 AM, Rebecca Cran wrote:
Could I get some reviews on this please? It was sent out back in
February.
I'm not sure how we should solve the CI breakage, since as I noted in
the v1 revision it contains fields that begin with a lower-case letter
following the style of the
Could someone push these changes to the edk2-test repo please?
On 11/10/2023 12:08 PM, Rebecca Cran wrote:
Some improvements to the edk2-test repository.
Since buildzip.sh creates output that appears more useful for running on
the target machine, I wonder if we might want to mention it in the
think to follow the style guide, it should have a "" at the end,
though most files with copyrights from individuals don't have that.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112635): https://e
Reviewed-by: Rebecca Cran
On 12/20/2023 12:31 PM, Jake Garver wrote:
In the R_AARCH64_ADR_GOT_PAGE case on AARCH64, we may encounter an ADR
instead of an ADRP when the toolchain is working around Cortex-A53
erratum #843419. If that's the case, be sure to calculate the offset
appropri
Reviewed-by: Rebecca Cran
On 12/15/2023 2:11 AM, Yuwei Chen wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4624
Currently, Python FMMT tool does not support automatically
select FMMTConf.ini file which saves GuidTool settings.
This patch supports this features.
Cc: Rebecca Cran
Queued as https://github.com/tianocore/edk2/pull/5177 .
On 12/19/2023 6:02 AM, gaoliming wrote:
The change is good.
Reviewed-by: Liming Gao
-邮件原件-
发件人: devel@edk2.groups.io 代表 Guo, Gua
发送时间: 2023年12月19日 15:32
收件人: devel@edk2.groups.io; Chen, Christine ;
Rebecca Cran ; Gao, Liming
ge-id').
With that fixed:
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 12/12/2023 2:38 AM, Pierre Gondois wrote:
Hello BaseTools maintainers,
Just a ping in case you have any comment for this patch,
Regards,
Pierre
On 11/29/23 10:37, Sami Mujawar wrote:
Hi Ray,
On 29/11/2023, 00:5
Thanks.
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 12/6/2023 1:27 PM, Joey Vagedes wrote:
Switches regex patterns to raw text to resolve python 3.12 syntax
warnings in regards to invalid escape sequences, as is suggested by the
re (regex) module in python.
Cc: Rebecca Cran
Cc: Liming Gao
I see two patches with the same subject line sent within about 15
minutes of each other.
Could you confirm whether I should review this one (1:43am) or the other
(1:27am) please?
Thanks.
Rebecca Cran
On 12/12/2023 1:43 AM, Yuting Yang wrote:
Add --catch_default option
Raise a
re module
in python suggests that when creating regex patterns, to use raw text.
This patch series adds the r prefix to any regex pattern that uses an
invalid escape sequence.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Signed-off-by: Joey Vagedes
Joey Vagedes (1
On 1/9/2024 11:52 PM, Huang, Yanbo wrote:
@Gao, Liming <mailto:gaolim...@byosoft.com.cn> @'Rebecca Cran'
<mailto:rebe...@bsdio.com>
Could you please help to merge this PR?
BaseTools: Fix raw strings containing valid escape characters by
YuweiChen1110 · Pull Request
Originally posted at
https://twitter.com/UEFIForum/status/1745518769232077208
The Multi-ISA Driver Compatibility Survey is at
https://docs.google.com/forms/d/e/1FAIpQLScXjwaSBgLeqB1coEDxCPxho5JWF3AMqshOTJ2wd6Tf0He4LA/viewform
From that page:
Did you know Tiano today supports four 64-bit arch
Table
//
gDxeCoreST = AllocateRuntimeCopyPool (sizeof (EFI_SYSTEM_TABLE),
&mEfiSystemTableTemplate);
ASSERT (gDxeCoreST != NULL);
I'm wondering which is wrong: should AllocateRuntimeCopyPool be
returning a 4KB-aligned pointer, or is the script's assumption wrong?
--
Rebecca Cran
-=-=-=-=-=
already allocated pages.
Thanks. I'll update the script to require users to pass in the address
of the EFI_SYSTEM_TABLE instead of searching for it!
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#114149):
Sorry for the extreme delay!
No need to send a v2 - I can commit this.
--
Rebecca Cran
On 10/8/23 04:20, Mike Maslenkin wrote:
On Thu, Aug 31, 2023 at 3:32 PM Rebecca Cran wrote:
On 8/29/2023 8:05 PM, Richard Ho (何明忠) wrote:
Hi Rebecca,
We have tried the patch. It works on my device.
I
Pushed as:
https://github.com/tianocore/edk2/commit/e07948255cfafb75fa9cbe4555bfe3421488dd9a
https://github.com/tianocore/edk2/commit/03d6569f70939d2a1653265367121212459a6b89
--
Rebecca Cran
On 8/25/23 19:57, Mike Maslenkin wrote:
Please review small improvements to UsbNetwork
Here is
Reviewed-by: Rebecca Cran
Looks like this is still waiting to be merged by an ArmPkg maintainer.
--
Rebecca Cran
On 6/29/23 14:46, Jeff Brasen wrote:
Add EFI_NOT_READY return if the CPU can not be enabled if the
processor is already on.
This can occur in normal use if the CPU is still
It looks like this still needs reviewed and merged.
I'm working on the BaseTools patch (2/2) in this series.
--
Rebecca Cran
On 7/13/23 09:24, Joey Vagedes via groups.io wrote:
Add the bit masks for DLL Characteristics, used within the optional
header of a PE, to the PeImage.h header
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 7/13/23 09:24, Joey Vagedes wrote:
Automatically set the nxcompat flag in the DLL Characteristics field of
the Optional Header of the PE32+ image. For this flag to be set
automatically, the section alignment must be evenly divisible
by 4K
ght not be what's desired.
--
Rebecca Cran
On 8/1/23 09:57, Joey Vagedes wrote:
Hello BaseTools maintainers. I'm still looking for feedback and a
review for the changes made to GenFw to automatically set the NXCOMPAT
flag if the requirements are met. Drivers can opt out of the flag
MdePkg maintainers: could you review this, and I'll be happy to
merge/commit it.
--
Rebecca Cran
On 7/13/23 09:24, Joey Vagedes via groups.io wrote:
Add the bit masks for DLL Characteristics, used within the optional
header of a PE, to the PeImage.h header file.
Update the Visual S
change I made to add the nonxcompat flag already creates a large diff
to the rtf manual. The rtf format does not really support git diff/
readability.
Thanks,
Joey
On Tue, Oct 17, 2023 at 3:34 PM Rebecca Cran wrote:
Unfortunately the patch doesn't pass CI because
BaseTo
Reviewed-by: Rebecca Cran
On 9/22/23 00:47, Yuwei Chen wrote:
As the error is changed to warning, Trim.py will skip the build
error when the source code have exactly issue.
This patch change warning to error to opens the checking.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Signed-off-by
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 10/12/23 11:11, levi.yun wrote:
The patch "[PATCH v3 1/2] StandaloneMmPkg: Make StandaloneMmCpu driver
architecture independent" (https://edk2.groups.io/g/devel/message/109178)
removed ArmPkg/ArmPkg.dec from the Packages section in th
Allow .rtf files created by applications such as Notepad to be committed
as-is without further manual editing by skipping the requirements for
CRLF, no tabs and no trailing whitespace.
Signed-off-by: Rebecca Cran
---
BaseTools/Scripts/PatchCheck.py | 5 -
1 file changed, 4 insertions(+), 1
I'm still working on this! The last hurdle is fixing PatchCheck.py to
allow .rtf files written by Notepad etc. to be committed as-is, without
requiring line endings to be fixed, trailing whitespace to be removed etc.
Once that's in, I'll merge these two patches.
--
Rebecca
Liming, could you review this please? It's blocking another patch from
being committed.
--
Rebecca
On 11/1/2023 6:20 PM, Rebecca Cran wrote:
Allow .rtf files created by applications such as Notepad to be committed
as-is without further manual editing by skipping the requirements for
CRL
I just noticed the Bitbucket mirror that's listed in Maintainers.txt
hasn't had any new commits since March 2022.
EDK II
--
W: http://www.tianocore.org/edk2/
L: https://edk2.groups.io/g/devel/
T: git - https://github.com/tianocore/edk2.git
T: git (mirror) - https://bitbucket.org/tianocore/e
. It just has one watcher, Jordan,
so I'd guess he did set it up.
It has two forks, neither of which have been updated recently:
https://bitbucket.org/kevintruong/edk2/src/master/ (last updated:
2015-04-18)
https://bitbucket.org/cn_taoye/edk2/src/master/ (last updated:
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 11/6/2023 1:12 PM, Joey Vagedes wrote:
Clarify to users that they should review the build log when make
(POSIX-like system) or nmake (Windows) fails to compile basetools.
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Signed-off
EFI_IMAGE_SCN_MEM_EXECUTE and EFI_IMAGE_SCN_MEM_WRITE
Cc: Rebecca Cran
Cc: Liming Gao
Cc: Bob Feng
Cc: Yuwei Chen
Joey Vagedes (2):
MdePkg: IndustryStandard: Add DLL Characteristics
BaseTools: GenFw: auto-set nxcompat flag
MdePkg/Include/IndustryStandard/PeImage.h| 17 +-
BaseTools
Reviewed-by: Rebecca Cran
On 10/31/2023 12:23 AM, Joey Vagedes wrote:
Resolves an invalid escape sequence in a regex string that occurs
because the string was not marked as a raw string, so backslash
characters create unexpected escape sequences.
This was brought to light due to Python 3.12
we delete it?
Finally, is the TianoCore Contribution Agreement still relevant? I know
it is for the edk2 docs repositories, but not sure if edk2-test should
be updated to match the other code repos like edk2 and edk2-platforms?
Rebecca Cran (4):
Unbreak buildzip.sh
Rename files in HowToBuild to
Unbreak buildzip.sh by removing the line sourcing edksetup.sh: unless
WORKSPACE and PACKAGES_PATH are already configured, edksetup.sh will
error out.
Signed-off-by: Rebecca Cran
Contributed-under: TianoCore Contribution Agreement 1.1
---
uefi-sct/SctPkg/buildzip.sh | 3 ---
1 file changed, 3
Rename the text files in the HowToBuild directory to remove the spaces
and use CamelCase instead.
Signed-off-by: Rebecca Cran
Contributed-under: TianoCore Contribution Agreement 1.1
---
uefi-sct/HowToBuild/{How to accelerate SCT execution.txt =>
HowToAccelerateSctExecution.txt} | 0
uefi-
If edk2-test-parser doesn't exist, tell the user where they can clone it
from.
Signed-off-by: Rebecca Cran
Contributed-under: TianoCore Contribution Agreement 1.1
---
uefi-sct/SctPkg/buildzip.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/uefi-sct/SctPkg/buildzip.sh b/uefi-sct/S
Fix the URL for the edk2-test repo: the uefi-sct is a directory inside
the repo.
Signed-off-by: Rebecca Cran
Contributed-under: TianoCore Contribution Agreement 1.1
---
Maintainers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index
It looks like Maintainers.txt also needs to be updated since I got
bounces from Eric Jin and Arvin Chen's email addresses.
On 11/10/23 12:01, Rebecca Cran wrote:
Some improvements to the edk2-test repository.
Since buildzip.sh creates output that appears more useful for running on
the t
to buildzip.sh
Rebecca Cran (4):
Unbreak buildzip.sh
Rename files in HowToBuild to avoid spaces in filenames
Point users to the URL for edk2-test-parser if it doesn't exist
Fix the URL for the edk2-test repo
Maintainer
Unbreak buildzip.sh by removing the line sourcing edksetup.sh: unless
WORKSPACE and PACKAGES_PATH are already configured, edksetup.sh will
error out.
Signed-off-by: Rebecca Cran
Contributed-under: TianoCore Contribution Agreement 1.1
---
uefi-sct/SctPkg/buildzip.sh | 3 ---
1 file changed, 3
Rename the text files in the HowToBuild directory to remove the spaces
and use CamelCase instead.
Signed-off-by: Rebecca Cran
Contributed-under: TianoCore Contribution Agreement 1.1
---
uefi-sct/HowToBuild/{How to accelerate SCT execution.txt =>
HowToAccelerateSctExecution.txt} | 0
uefi-
If edk2-test-parser doesn't exist, tell the user where they can clone it
from.
Signed-off-by: Rebecca Cran
Contributed-under: TianoCore Contribution Agreement 1.1
---
uefi-sct/SctPkg/buildzip.sh | 1 +
1 file changed, 1 insertion(+)
diff --git a/uefi-sct/SctPkg/buildzip.sh b/uefi-sct/S
Fix the URL for the edk2-test repo: the uefi-sct is a directory inside
the repo.
Signed-off-by: Rebecca Cran
Contributed-under: TianoCore Contribution Agreement 1.1
---
Maintainers.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Maintainers.txt b/Maintainers.txt
index
For the series:
Acked-by: Rebecca Cran
On 11/10/23 12:30, Leif Lindholm wrote:
OK, so this a bit of a backwards review, but I figured I might as
well show how I would prefer the split. I'm adding a patch that
changes internal returns to dictionaries instead of multiple return
values.
/introducing_black_to_your_project.html#avoiding-ruining-git-blame
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#79): https://edk2.groups.io/g/devel/message/79
Mute This Topic: https://groups.io/mt/102559740/21656
Group Owner: devel+ow
. We don't know why it's causing
issues yet. However, using the same IO port range in EDKII fixes the
issue and is a good idea anyway.
Reviewed-by: Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#111408): https://ed
ion in the archive.
Similarly, I've been running an public-inbox instance at
https://openfw.io/edk2-devel/ for a while.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#115522): https://edk2.groups.io/g/devel/message/1
I noticed the advisory at
https://github.com/advisories/GHSA-h9v6-q439-p7j2 is labeled "Unreviewed".
Should it be updated, and should the 'package', 'affected' and 'patched'
fields be updated?
--
Rebecca Cran
On 2/13/2024 11:46 AM, Doug Flick via g
up-steps.yml to require Python 3.10
Disable codecov to fix CI and due to very low coverage
--
Rebecca Cran
On 2/13/24 12:42, Joey Vagedes wrote:
I agree - there are multiple blocking issues that will require some fixes - One
additional thing I noted is that multiple areas still perform relativ
Could someone review Fix build-publish-whl-steps.yml: we no longer use
setup.py by bcran · Pull Request #117 · tianocore/edk2-basetools ·
GitHub <https://github.com/tianocore/edk2-basetools/pull/117> please?
It should be the last change needed to fix publishing releases.
--
Rebecca Cran
Thanks. I've merged that PR, but there's another problem - the 'build'
package isn't available.
I've created another PR to fix it:
https://github.com/tianocore/edk2-basetools/pull/118
--
Rebecca Cran
On 2/23/24 07:48, Rebecca Cran wrote:
Could someon
Reviewed-by: Rebecca Cran
On 2/20/2024 8:21 AM, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
Checks that an offset used to access array elements is within the
expected range before accessing the array item.
Cc: Liming Gao
Cc: Ray Ni
Cc: Rebecca Cran
Cc: Richard Ho
Signed
Invalid or non-existent authentication information. See
https://pypi.org/help/#invalid-auth for more information.
##[error]Cmd.exe exited with code '1'.
Finishing: Publish to PyPI
--
Rebecca Cran
On 2/13/24 12:42, Joey Vagedes wrote:
I agree - there are multiple blocking issues that
Reviewed-by: Rebecca Cran
On 2/20/2024 9:22 PM, mikub...@linux.microsoft.com wrote:
From: Michael Kubacki
Currently, if an INF path is an absolute path on Linux (begins with
"/"), the "/" character will be removed. If the path is an absolute
system path, this creates
Merged as e59a40b92ce92f17e3d8d99917868c5678d408b7.
--
Rebecca Cran
On 2/12/2024 10:41 AM, Leif Lindholm via groups.io wrote:
On Sun, Feb 11, 2024 at 16:10:32 -0700, Rebecca Cran wrote:
I'm guessing there haven't been any reviews because so few people are
familiar with the PRACTICE
For the series:
Reviewed-by: Rebecca Cran
--
Rebecca Cran
On 2/18/2024 1:59 PM, Michael D Kinney wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4680
* Reject patches that match Author email "devel@edk2.groups.io"
* Update the current check for " via Groups.I
Merged as
dae8c29dab546fad2801e70967855a9f6ae14ae0...6d571c0070161b1b96049410f8584c0955d73536
--
Rebecca Cran
On 2/18/2024 1:59 PM, Michael D Kinney via groups.io wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4679
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4680
REF
edk2-basetools v0.1.50 has just been published so we're back up and running.
I'll work my way through the backlog of BaseTools changes in the next
few days.
--
Rebecca Cran
On 2/24/24 13:59, Laszlo Ersek wrote:
v1 posting:
https://edk2.groups.io/g/devel/message/11519
Merged as 3e91e421365027ee3e655feab33c67a4f544c777.
--
Rebecca Cran
On 2/6/24 00:02, Jayaprakash N wrote:
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4666
This commit fixes the issue reported through BZ4666.
The Syntax warning related to invalid escape sequence
for \C is seen on
.
Previously it fetched the list of releases from PyPI and incremented the
version number before publishing a new version, while it now depends on
the git repo being tagged.
Should I work on migrating the old code and figuring out how to make it
work with pyproject.toml?
--
Rebecca Cran
Thanks.
Since Sean commented on
https://github.com/tianocore/edk2-basetools/issues/85, adding him for
more context around the original request.
--
Rebecca Cran
On 2/28/24 04:35, Gerd Hoffmann wrote:
On Wed, Feb 28, 2024 at 09:27:57AM +0100, Laszlo Ersek wrote:
On 2/28/24 02:15, Rebecca
Reviewed-by: Rebecca Cran
On 3/5/2024 4:38 AM, Laszlo Ersek wrote:
The edk2-basetools commit that corresponds to edk2 commit bac9c74080cf
("BaseTools/AutoGen: declare ProcessLibraryConstructorList() for SEC
modules", 2024-02-29) is 5b7161de22ee ("BaseTools/A
our
> help to reach the PR to maintainer.
>
> Thanks,
> Gua
>
> -Original Message-
> From: Guo, Gua
> Sent: Monday, April 22, 2024 9:06 AM
> To: devel@edk2.groups.io; Liming Gao ;
> Rebecca Cran
> Cc: Kasbekar, Saloni
> Subject: RE: [PATCH v1 0/
On Wed, May 1, 2024, at 11:43 AM, Michael D Kinney wrote:
> * The Pull Request submitter is required to invite the required
> maintainers and reviewers to the pull request. This is the same
> set of maintainers and reviewers that are required to be listed in
> Cc: tags in today's process.
T
On 5/1/2024 10:45 AM, Michael D Kinney wrote:
Please let me know if you have any topics for the TianoCore Community
Meeting this month.
People might not see this since you replied to the thread about the
March meeting instead of starting a new discussion.
--
Rebecca Cran
ps://github.com/tianocore/edk2/pull/4835.diff
Also, there's a command-line interface available via the 'gh' command -
https://cli.github.com/ (see https://cli.github.com/manual/gh_pr for the
PR related commands).
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You
There's a GitHub Project for this at
https://github.com/orgs/tianocore/projects/5 which it looks like Michael
Kubacki created last year. I suspect it's obsolete though, since it
looks like the tasks haven't been updated recently.
--
Rebecca Cran
On 5/1/24 11:43 AM, Michael
already be added?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119359): https://edk2.groups.io/g/devel/message/119359
Mute This Topic: https://groups.io/mt/106355103/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscr
ommit
waiting to be submitted:
commit e6d4d2a8cf995a7f4f60e7f55ff2ab494308f939
Author: Rebecca Cran
Date: Wed May 15 09:10:54 2024 -0600
ArmPkg: Add new function OemGetPhysicalBiosSize to OemMiscLib
The FD size often isn't the same as the physical size of the SPI-NOR
EEPROM
These are a set of bug fixes I made to the Mt Jade and common Ampere
code while working on updating and improving ADLINK's edk2_aadp
project.
Rebecca Cran (6):
Silicon/Ampere: Fix capitalization of Cache strings in PlatformInfoDxe
Silicon/Ampere: Reduce DEBUG_INFO spam in PciSegmentL
Signed-off-by: Rebecca Cran
---
Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoStrings.uni
| 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git
a/Silicon/Ampere/AmpereAltraPkg/Drivers/PlatformInfoDxe/PlatformInfoStrings.uni
b/Silicon/Ampere/AmpereAltraPkg
Reduce the spam when DEBUG_INFO is enabled by switching DEBUG prints in
PciSegmentLibPci from DEBUG_INFO to DEBUG_VERBOSE.
Signed-off-by: Rebecca Cran
---
Silicon/Ampere/AmpereAltraPkg/Library/PciSegmentLibPci/PciSegmentLib.c | 24
++--
1 file changed, 12 insertions(+), 12
The NOOPT build was failing because MicroSecondDelay is called but
TimerLib wasn't included in DwGpioLib.inf
Signed-off-by: Rebecca Cran
---
Silicon/Ampere/AmpereAltraPkg/Library/DwGpioLib/DwGpioLib.inf | 1 +
1 file changed, 1 insertion(+)
diff --git a/Silicon/Ampere/AmpereAltraPkg/Li
In AcpiPatchDsdtTable if the call to OpenSdt fails, don't try and
close the TableHandle since it causes a crash.
Signed-off-by: Rebecca Cran
---
Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiDsdt.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/Platform/Ampere/JadePkg/Dr
On entry into ArmPlatformGetPlatformPpiList, *PpiList _can_ be NULL
since it's set within the function. So remove the bogus ASSERT.
Signed-off-by: Rebecca Cran
---
Silicon/Ampere/AmpereAltraPkg/Library/ArmPlatformLib/ArmPlatformLib.c | 1 -
1 file changed, 1 deletion(-)
diff --git
a/Si
According to the SMBIOS specification, the firmware version major/minor
values should be set to 0xFF if they're not applicable.
Update AmpereSiliconPkg.dec to default to 0xFF instead of 0.
Signed-off-by: Rebecca Cran
---
Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 4 ++--
1
(Monday) Tools call?
--
Rebecca Cran
On 6/5/24 5:27 PM, Michael D Kinney wrote:
The Merge button may not work in that case either if there is
parallel activity by other developers or Mergify. Using the
"push" label is recommended so Maintainers do not have to wait
and rebase.
I und
ExceptionHandler.c(343):
((BOOLEAN)(0==1))
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119591): https://edk2.groups.io/g/devel/message/119591
Mute This Topic: https://groups.io/mt/106711998/21656
Group Owner: deve
It looks like we need to require users creating PRs to enable the "Allow
edits from maintainers" settin*g?*
*
*
*--
Rebecca Cran
*
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119593): https://edk2.groups.io/g/devel/message/1195
lease?
I've looked through mu_basecore and from
BaseTools/NugetPublishing/Mu-Basetools.md it looks like it's a manual
process? If anyone needs access to an AArch64 system I can provide a
remote login to an Ubuntu VM.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links:
9000200
0010007F41920: 45037614462CAA21 312366F4B68A6E83 01000753D098
ASSERT [ArmCpuDxe] DefaultExceptionHandler.c(343): ((BOOLEAN)(0==1))
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (
Add edk2-devel
On 6/23/24 11:38 AM, Rebecca Cran wrote:
I have two items I'd like to discuss for tomorrow (Monday's) Tools,
CI, Code base construction meeting:
1. Enabling the PR process for edk2-platforms and other TianoCore
repositories.
2. Status of the BaseTools C
NumBlocks, offsets etc.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119729): https://edk2.groups.io/g/devel/message/119729
Mute This Topic: https://groups.io/mt/106820121/21656
Group Owner: devel+ow...@edk2.groups.io
oncerns or issues people might have with it.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119747): https://edk2.groups.io/g/devel/message/119747
Mute This Topic: https://groups.io/mt/106986207/21656
Group Owner: devel+
On 7/1/24 13:16, Rebecca Cran via groups.io wrote:
Now that edk2 has been using PRs for a few weeks, I'd like to propose
enabling the same workflow for edk2-platfoms.
As maintainers or reviewers of platforms in the edk2-platforms repo, I'd
like to get any feedback on moving from e
+60,4 @@
gEfiRedfishPkgTokenSpaceGuid.PcdRedfishPlatformConfigDebugProperty
[Depex]
- TRUE
+ gEfiRegularExpressionProtocolGuid^M
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119815): https://edk2.groups.io/g/devel/message/119815
Mute This
I'm ok keeping the current behavior as long as the DEBUG_ERROR message
is removed or downgraded to DEBUG_INFO. As it is, it makes it look as
though the driver has failed when error messages are highlighted during
the boot.
--
Rebecca Cran
On 7/8/24 21:53, Nickle Wang wrote:
Shoul
On 7/9/24 14:01, Michael D Kinney wrote:
What do you mean by drop?
Remove from CI or remove from both CI and tools_def.txt?
I'm thinking remove it from both.
--
Rebecca Cran
Mike
-Original Message-
From: devel@edk2.groups.io On Behalf Of Oliver Smith-
Denny
Sent: Tuesday,
: Rebecca Cran
Cc: Michael D Kinney
Cc: Jayaprakash N
Signed-off-by: Jayaprakash N
---
.gitattributes | 2 ++
1 file changed, 2 insertions(+)
create mode 100644 .gitattributes
diff --git a/.gitattributes b/.gitattributes
new file mode 100644
index 000..3fd9ec8
--- /dev/null
+++ b
ewers and their email addresses and
github usernames? Then we can eventually delete Maintainers.txt.
e.g.
| Name | e-mail address | Github username |
| Rebecca Cran | rebe...@bsdio.com| @bcran |
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Grou
On 7/24/24 20:35, Michael Kubacki wrote:
A change was just pushed to edk2 to automatically add reviewers to pull
request based on those listed in Maintainers.txt.
For more details and in case of any issues, I put some information on
this wiki page:
https://github.com/tianocore/tianocore.gith
](https://github.com/chuongtranle) |
+| Rebecca Cran | rebe...@os.amperecomputing.com |
[@rcran-ampere](https://github.com/rcran-ampere) |
+|| rebe...@bsdio.com|
[@bcran](https://github.com/bcran)|
+| Thomas Abraham
Platform/Intel/TigerlakeOpenBoardPkg and
Silicon/Intel/TigerlakeSiliconPkg
Tomas Abraham for Platform/ARM
Graeme Gregory for {Platform,Silicon}/Qemu/SbsaQemu
--
Rebecca Cran
On 7/26/24 7:20 AM, Rebecca Cran wrote:
Migrate data from Maintainers.txt to the GitHub standard CODEOWNERS
files plu
CONTRIBUTORS.md to delete the second email address.
Updated the commit message to indicate that this change is to enable the
GitHub PR workflow, not just in preparation for it.
Rebecca Cran (1):
Move to the GitHub Pull Request workflow
.github/workflows/AssignReviewers.yml | 28 ++
CODEOWNERS
/AssignReviewers.yml which adds reviewers to a
Pull Request based on the content of the REVIEWERS file.
Signed-off-by: Rebecca Cran
---
.github/workflows/AssignReviewers.yml | 28 ++
CODEOWNERS| 146 +++
CONTRIBUTORS.md | 68 +++
Maintainers.txt
n a strong reluctance against using anything that isn't
cloud-based.
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120057): https://edk2.groups.io/g/devel/message/120057
Mute This Topic: https://groups.io/mt/107567
-point code.
I know in CmockaLib.inf it says "VALID_ARCHITECTURES = IA32 X64" but do
we want it to be able to build on other platforms too?
--
Rebecca Cran
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#120066): https://edk2.g
1 - 100 of 1526 matches
Mail list logo
