[edk2-devel] CI: GCC13 and lcov problem

2024-02-28 Thread Oliver Steffen
Hi, I am working on switching the Linux CI jobs over to the Fedora 39 image which comes with gcc 13. Unfortunately, some jobs fail due to some error related to lcov / geninfo, see below. Does anybody know from the top of the head what this is about / what to do? PR: https://github.com/tianocore/

[edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of flash space when writing variables

2024-03-04 Thread Oliver Steffen
Cc: Gerd Hoffmann Cc: Laszlo Ersek Cc: Liming Gao Cc: Rebecca Cran Cc: Yuwei Chen Signed-off-by: Oliver Steffen --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c b

[edk2-devel] [PATCH v1 0/1] MdeModulePkg: Warn if out of flash space when writing variables

2024-03-04 Thread Oliver Steffen
; 0) PR: https://github.com/tianocore/edk2/pull/5435 Cc: Bob Feng Cc: Gerd Hoffmann Cc: Laszlo Ersek Cc: Liming Gao Cc: Rebecca Cran Cc: Yuwei Chen Oliver Steffen (1): MdeModulePkg: Warn if out of flash space when writing variables MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c

Re: 回复: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Warn if out of flash space when writing variables

2024-03-05 Thread Oliver Steffen
s, Oliver > > Thanks > > Liming > >> -\u90ae\u4ef6\u539f\u4ef6- > >> \u53d1\u4ef6\u4eba: devel@edk2.groups.io > >> \u4ee3\u8868 Oliver Steffen > >> \u53d1\u9001\u65f6\u95f4: 2024\u5e743\u67084\u65e5 23:18 > >> \u6536\u4ef6\u4eba: de

[edk2-devel] [PATCH v2 0/1] MdeModulePkg: Warn if out of space when writing variables

2024-04-15 Thread Oliver Steffen
ull/5435 Changes since v1: - Mention "variable space" instead of "flash space" - Emit DEBUG_ERROR instead of DEBUG_WARN Cc: Bob Feng Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Laszlo Ersek Cc: Liming Gao Cc: Rahul Kumar Cc: Rebecca Cran Cc: Yuwei Chen Oliver Steffen (1): Md

[edk2-devel] [PATCH v2 1/1] MdeModulePkg: Warn if out of space when writing variables

2024-04-15 Thread Oliver Steffen
Feng Cc: Gerd Hoffmann Cc: Jiewen Yao Cc: Laszlo Ersek Cc: Liming Gao Cc: Rahul Kumar Cc: Rebecca Cran Cc: Yuwei Chen Signed-off-by: Oliver Steffen Reviewed-by: Laszlo Ersek --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[edk2-devel] [PATCH v2 0/1] MdeModulePkg: Warn if out of space when writing variables

2024-05-10 Thread Oliver Steffen
ull/5435 Changes since v1: - Mention "variable space" instead of "flash space" - Emit DEBUG_ERROR instead of DEBUG_WARN Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu Oliver Steffen (1): MdeModulePkg: Warn if out of space when writing variables MdeModulePkg/Univer

[edk2-devel] [PATCH v2 0/1] MdeModulePkg: Warn if out of space when writing variables

2024-05-10 Thread Oliver Steffen
ull/5435 Changes since v1: - Mention "variable space" instead of "flash space" - Emit DEBUG_ERROR instead of DEBUG_WARN Cc: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu Oliver Steffen (1): MdeModulePkg: Warn if out of space when writing variables MdeModulePkg/Univer

[edk2-devel] [PATCH v2 1/1] MdeModulePkg: Warn if out of space when writing variables

2024-05-10 Thread Oliver Steffen
: Liming Gao Cc: Michael D Kinney Cc: Zhiguang Liu Signed-off-by: Oliver Steffen Reviewed-by: Laszlo Ersek Reviewed-by: Gerd Hoffmann --- MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c

[edk2-devel] [PATCH v5 0/4] CI: Use Fedora 35 container for Linux jobs

2022-09-20 Thread Oliver Steffen
: - Thread: https://edk2.groups.io/g/devel/message/89058 - Images were hosted at https://github.com/osteffenrh/edk2-build-images Signed-off-by: Oliver Steffen Acked-by: Ard Biesheuvel Acked-by: Gerd Hoffmann Oliver Steffen (4): CI: don't force python verison (Linux only) CI: add ~/.local/bin

[edk2-devel] [PATCH v5 1/4] CI: don't force python verison (Linux only)

2022-09-20 Thread Oliver Steffen
Use the Python supplied by the container image. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 1 + .azurepipelines/templates/pr-gate-steps.yml| 1 + 2 files changed, 2 insertions(+) diff --git a/.azurepipelines/templates/platform-build

[edk2-devel] [PATCH v5 2/4] CI: add ~/.local/bin to PATH (Linux only)

2022-09-20 Thread Oliver Steffen
Fix pip install. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 6 ++ .azurepipelines/templates/pr-gate-steps.yml| 6 ++ 2 files changed, 12 insertions(+) diff --git a/.azurepipelines/templates/platform-build-run-steps.yml b

[edk2-devel] [PATCH v5 3/4] CI: Use Fedora 35 container (Linux only)

2022-09-20 Thread Oliver Steffen
run apt-get in CI jobs to install qemu and gcc dependencies. Assume the container image provides these. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/basetools-build-steps.yml| 9 - .azurepipelines/templates/pr-gate-build-job.yml| 3 +++ ArmVirtPkg/PlatformCI

[edk2-devel] [PATCH v5 4/4] BaseTools: Remove ext. gcc dependencies (Linux only)

2022-09-20 Thread Oliver Steffen
Remove BaseTools/Bin/gcc*_linux_ext_dep.yaml to stop downloading gcc from external locations; use the toolchains provided by the container image instead. The image needs to set the GCC5_*_PREFIX accordingly. Signed-off-by: Oliver Steffen --- BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21

Re: [edk2-devel] [PATCH 1/1] ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot

2022-09-21 Thread Oliver Steffen
Hi all, Is anybody still interested in this? Rohit's "Invoke constructors for SEC phase" patch was merged. Link to the original thread: https://edk2.groups.io/g/devel/message/4 Regards, Oliver On Thu, Jul 21, 2022 at 6:24 PM Sami Mujawar wrote: > Hi Rebecca, Ard, > > On Tue, May 3, 2022

[edk2-devel] [PATCH v6 3/5] CI: Allow running in a container.

2022-09-26 Thread Oliver Steffen
Add a parameter of the pr-gate-build-job template to specify a container image URL. If the value is not '' (default), then the jobs will be run inside a container based on that image. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/pr-gate-build-job.yml | 4 1 file

[edk2-devel] [PATCH v6 0/5] CI: Use Fedora 35 container for Linux jobs

2022-09-26 Thread Oliver Steffen
/tianocore/containers v1: - Thread: https://edk2.groups.io/g/devel/message/89058 - Images were hosted at https://github.com/osteffenrh/edk2-build-images Signed-off-by: Oliver Steffen Acked-by: Ard Biesheuvel Acked-by: Gerd Hoffmann Oliver Steffen (5): CI: make Python version configurable

[edk2-devel] [PATCH v6 5/5] BaseTools: Remove ext. gcc dependencies (Linux only)

2022-09-26 Thread Oliver Steffen
Remove BaseTools/Bin/gcc*_linux_ext_dep.yaml to stop downloading gcc from external locations; use the toolchains provided by the container image instead. The image needs to set the GCC5_*_PREFIX accordingly. Signed-off-by: Oliver Steffen --- BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21

[edk2-devel] [PATCH v6 2/5] CI: add ~/.local/bin to PATH (Linux only)

2022-09-26 Thread Oliver Steffen
Fix pip install under certain conditions. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 6 ++ .azurepipelines/templates/pr-gate-steps.yml| 6 ++ 2 files changed, 12 insertions(+) diff --git a/.azurepipelines/templates/platform

[edk2-devel] [PATCH v6 1/5] CI: make Python version configurable

2022-09-26 Thread Oliver Steffen
mage will be used. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 6 +- .azurepipelines/templates/pr-gate-build-job.yml| 2 ++ .azurepipelines/templates/pr-gate-steps.yml| 6 -- 3 files changed, 11 insertions(+), 3 deletions

[edk2-devel] [PATCH v6 4/5] CI: Use Fedora 35 container (Linux only)

2022-09-26 Thread Oliver Steffen
run apt-get in CI jobs to install qemu and gcc dependencies. Assume the container image provides these. Use Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen --- .azurepipelines/Ubuntu-GCC5.yml| 2 ++ .azurepipelines/templates

Re: [edk2-devel] [PATCH v2 1/1] ArmPlatformPkg/PrePeiCore: Print the firmware version early in boot

2022-10-07 Thread Oliver Steffen
+(CHAR16 *)PcdGetPtr (PcdFirmwareVersionString), > +__TIME__, > +__DATE__ > + ); > +SerialPortWrite ((UINT8 *)Buffer, CharCount); > > // Initialize the Debug Agent for Source Level Debugging

[edk2-devel] [PATCH 1/2] OvmfPkg: allow setting Firmware Version from build command line

2022-10-12 Thread Oliver Steffen
IRMARE_VER=... Signed-off-by: Oliver Steffen --- OvmfPkg/OvmfPkgIa32.dsc| 1 + OvmfPkg/OvmfPkgIa32X64.dsc | 1 + OvmfPkg/OvmfPkgX64.dsc | 1 + OvmfPkg/OvmfXen.dsc| 1 + 4 files changed, 4 insertions(+) diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc index e9

[edk2-devel] [PATCH 2/2] ArmVirtPkg: allow setting Firmware Version from build command line

2022-10-12 Thread Oliver Steffen
ne with -D FIRMARE_VER=... Signed-off-by: Oliver Steffen --- ArmVirtPkg/ArmVirtCloudHv.dsc| 1 + ArmVirtPkg/ArmVirtKvmTool.dsc| 1 + ArmVirtPkg/ArmVirtQemu.dsc | 1 + ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 + 4 files changed, 4 insertions(+) diff --git a/ArmVirtPkg/ArmVirtCloudHv.dsc b/

[edk2-devel] [PATCH 0/2] Set Firmware Version from build command line

2022-10-12 Thread Oliver Steffen
ArmVirtXen.dsc allows setting the firmware version string in gEfiMdeModulePkgTokenSpaceGuid.PcdFirmwareVersionString via FIRMWARE_VER variable conveniently on the build command line. These two patches add this behavior to all .dsc files in ArmVirtPkg and OvmfPkg. Signed-off-by: Oliver Steffen

[edk2-devel] [PATCH v2 0/2] Set Firmware Version from build command line

2022-10-14 Thread Oliver Steffen
/edk2/pull/3476 v2: Address comments by Sami and Gerd: - Only set PCD if FIRMWARE_VER is defined - ArmVirt: move logic to ArmVirt.dsc.inc v1: https://edk2.groups.io/g/devel/message/95057 Signed-off-by: Oliver Steffen Oliver Steffen (2): OvmfPkg: allow setting Firmware Version from build

[edk2-devel] [PATCH v2 2/2] ArmVirtPkg: allow setting Firmware Version from build command line

2022-10-14 Thread Oliver Steffen
ARE_VER is actually defined. This allows specifying the firmware version string on the build command line with -D FIRMARE_VER=... Signed-off-by: Oliver Steffen --- ArmVirtPkg/ArmVirt.dsc.inc | 4 ArmVirtPkg/ArmVirtXen.dsc | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/

[edk2-devel] [PATCH v2 1/2] OvmfPkg: allow setting Firmware Version from build command line

2022-10-14 Thread Oliver Steffen
ld command line with -D FIRMARE_VER=... Signed-off-by: Oliver Steffen --- OvmfPkg/OvmfPkgIa32.dsc| 3 +++ OvmfPkg/OvmfPkgIa32X64.dsc | 3 +++ OvmfPkg/OvmfPkgX64.dsc | 3 +++ OvmfPkg/OvmfXen.dsc| 3 +++ 4 files changed, 12 insertions(+) diff --git a/OvmfPkg/OvmfPkgIa32.dsc

[edk2-devel] [PATCH 0/4] Http Fixes

2022-03-04 Thread Oliver Steffen
fter a 404-error is encountered. It also prevents triggering the TCP issue described in https://bugzilla.tianocore.org/show_bug.cgi?id=3735 when booting from HTTP/1.0 servers. PR: https://github.com/tianocore/edk2/pull/2564 Oliver Steffen (4): NetworkPkg/HttpDxe: Decofigure Tcp4 before rec

[edk2-devel] [PATCH 2/4] NetworkPkg/HttpDxe: Add ConnectionClose flag fo HTTP_PROTOCOL

2022-03-04 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Add ConnectionClose flag fo HTTP_PROTOCOL. This boolean is FALSE by default. If set to TRUE, a reconfigure of the Http instance is forced on the next request. The flag is then reset. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe

[edk2-devel] [PATCH 4/4] NetworkPkg/HttpDxe: Detect non-HTTP/1.1 servers

2022-03-04 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Force connecton close before the next request if the server does not identify as version 1.1. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe/HttpImpl.c | 8 1 file changed, 8 insertions(+) diff --git a/NetworkPkg/HttpDxe

[edk2-devel] [PATCH 3/4] NetworkPkg/HttpDxe: Detect 'Connection: close' header

2022-03-04 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Force connecton close before the next request if the server sends the 'Connection: close' header. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe/HttpImpl.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/

[edk2-devel] [PATCH 1/4] NetworkPkg/HttpDxe: Decofigure Tcp4 before reconfiguring

2022-03-04 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Check if the state of the HTTP instance is HTTP_STATE_TCP_CONNECTED, or HTTP_STATE_TCP_CLOSED and de-configure the Tcp4 instance before configuring it again. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe/HttpProto.c | 12

[edk2-devel] [PATCH v2 0/4] Http Fixes

2022-03-08 Thread Oliver Steffen
fter a 404-error is encountered. It also prevents triggering the TCP issue described in https://bugzilla.tianocore.org/show_bug.cgi?id=3735 when booting from HTTP/1.0 servers. PR: https://github.com/tianocore/edk2/pull/2564 Oliver Steffen (4): NetworkPkg/HttpDxe: Decofigure Tcp4 before rec

[edk2-devel] [PATCH v2 1/4] NetworkPkg/HttpDxe: Decofigure Tcp4 before reconfiguring

2022-03-08 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Check if the state of the HTTP instance is HTTP_STATE_TCP_CONNECTED, or HTTP_STATE_TCP_CLOSED and de-configure the Tcp4 instance before configuring it again. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe/HttpProto.c | 12

[edk2-devel] [PATCH v2 4/4] NetworkPkg/HttpDxe: Detect HTTP/1.0 servers

2022-03-08 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Force connection close before the next request if the server identifies as version 1.0. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe/HttpImpl.c | 8 1 file changed, 8 insertions(+) diff --git a/NetworkPkg/HttpDxe

[edk2-devel] [PATCH v2 2/4] NetworkPkg/HttpDxe: Add ConnectionClose flag fo HTTP_PROTOCOL

2022-03-08 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Add ConnectionClose flag to HTTP_PROTOCOL. This boolean is FALSE by default. If set to TRUE, a reconfigure of the Http instance is forced on the next request. The flag is then reset. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe

[edk2-devel] [PATCH v2 3/4] NetworkPkg/HttpDxe: Detect 'Connection: close' header

2022-03-08 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Force connection close before the next request if the server sends the 'Connection: close' header. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe/HttpImpl.c | 11 +++ 1 file changed, 11 insertions(+) di

[edk2-devel] [PATCH v3 2/5] NetworkPkg/HttpDxe: Decofigure Tcp6 before reconfiguring

2022-03-15 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Check if the state of the HTTP instance is HTTP_STATE_TCP_CONNECTED, or HTTP_STATE_TCP_CLOSED and de-configure the Tcp6 instance before configuring it again. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe/HttpProto.c | 12

[edk2-devel] [PATCH v3 4/5] NetworkPkg/HttpDxe: Detect 'Connection: close' header

2022-03-15 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Force connection close before the next request if the server sends the 'Connection: close' header. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe/HttpImpl.c | 11 +++ 1 file changed, 11 insertions(+) di

[edk2-devel] [PATCH v3 3/5] NetworkPkg/HttpDxe: Add ConnectionClose flag fo HTTP_PROTOCOL

2022-03-15 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Add ConnectionClose flag to HTTP_PROTOCOL. This boolean is FALSE by default. If set to TRUE, a reconfigure of the Http instance is forced on the next request. The flag is then reset. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe

[edk2-devel] [PATCH v3 5/5] NetworkPkg/HttpDxe: Detect HTTP/1.0 servers

2022-03-15 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Force connection close before the next request if the server identifies as version 1.0. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe/HttpImpl.c | 8 1 file changed, 8 insertions(+) diff --git a/NetworkPkg/HttpDxe

[edk2-devel] [PATCH v3 1/5] NetworkPkg/HttpDxe: Decofigure Tcp4 before reconfiguring

2022-03-15 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Check if the state of the HTTP instance is HTTP_STATE_TCP_CONNECTED, or HTTP_STATE_TCP_CLOSED and de-configure the Tcp4 instance before configuring it again. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe/HttpProto.c | 12

[edk2-devel] [PATCH v3 0/5] Http Fixes

2022-03-15 Thread Oliver Steffen
fter a 404-error is encountered. It also prevents triggering the TCP issue described in https://bugzilla.tianocore.org/show_bug.cgi?id=3735 when booting from HTTP/1.0 servers. PR: https://github.com/tianocore/edk2/pull/2564 Oliver Steffen (5): NetworkPkg/HttpDxe: Decofigure Tcp4 before rec

[edk2-devel] [PATCH v3 1/5] NetworkPkg/HttpDxe: Decofigure Tcp4 before reconfiguring

2022-03-22 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Check if the state of the HTTP instance is HTTP_STATE_TCP_CONNECTED, or HTTP_STATE_TCP_CLOSED and de-configure the Tcp4 instance before configuring it again. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe/HttpProto.c | 12

[edk2-devel] [PATCH v3 0/5] Http Fixes (Take Two)

2022-03-22 Thread Oliver Steffen
fter a 404-error is encountered. It also prevents triggering the TCP issue described in https://bugzilla.tianocore.org/show_bug.cgi?id=3735 when booting from HTTP/1.0 servers. PR: https://github.com/tianocore/edk2/pull/2564 Oliver Steffen (5): NetworkPkg/HttpDxe: Decofigure Tcp4 before rec

[edk2-devel] [PATCH v3 2/5] NetworkPkg/HttpDxe: Decofigure Tcp6 before reconfiguring

2022-03-22 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Check if the state of the HTTP instance is HTTP_STATE_TCP_CONNECTED, or HTTP_STATE_TCP_CLOSED and de-configure the Tcp6 instance before configuring it again. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe/HttpProto.c | 12

[edk2-devel] [PATCH v3 5/5] NetworkPkg/HttpDxe: Detect HTTP/1.0 servers

2022-03-22 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Force connection close before the next request if the server identifies as version 1.0. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe/HttpImpl.c | 8 1 file changed, 8 insertions(+) diff --git a/NetworkPkg/HttpDxe

[edk2-devel] [PATCH v3 4/5] NetworkPkg/HttpDxe: Detect 'Connection: close' header

2022-03-22 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Force connection close before the next request if the server sends the 'Connection: close' header. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe/HttpImpl.c | 11 +++ 1 file changed, 11 insertions(+) di

[edk2-devel] [PATCH v3 3/5] NetworkPkg/HttpDxe: Add ConnectionClose flag fo HTTP_PROTOCOL

2022-03-22 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2720 Add ConnectionClose flag to HTTP_PROTOCOL. This boolean is FALSE by default. If set to TRUE, a reconfigure of the Http instance is forced on the next request. The flag is then reset. Signed-off-by: Oliver Steffen --- NetworkPkg/HttpDxe

Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg:Add variable store is full debug info

2023-09-07 Thread Oliver Steffen
; > CommonVariableSpace = 0x3FF9C - CommonVariableTotalSize = 0x3FF98 > > > > Synchronous Exception at 0x00023CA60374 > > .. > > ASSERT_EFI_ERROR (Status = Out of Resources) > > ASSERT /builddir/build/BUILD/edk2-ba91d0292e59/OvmfPkg/Library/ > >

Re: [edk2-devel] [PATCH v6 5/5] BaseTools: Remove ext. gcc dependencies (Linux only)

2022-11-28 Thread Oliver Steffen
arted a discussion on github about that [0]. But I have to admit that I was very busy recently and had little time to work on this (sorry). Thanks, Oliver [0] https://github.com/tianocore/edk2-pytool-extensions/discussions/323 > > Thanks, > > Chris > > On 9/26/2022 9:31 AM, Oli

[edk2-devel] [PATCH v7 0/6] CI: Use Fedora 35 container for Linux jobs

2022-11-29 Thread Oliver Steffen
ganization https://github.com/tianocore/containers v1: - Thread: https://edk2.groups.io/g/devel/message/89058 - Images were hosted at https://github.com/osteffenrh/edk2-build-images Signed-off-by: Oliver Steffen Acked-by: Ard Biesheuvel Acked-by: Gerd Hoffmann Reviewed-by: Chris Fernal

[edk2-devel] [PATCH v7 2/6] CI: add ~/.local/bin to PATH (Linux only)

2022-11-29 Thread Oliver Steffen
Fix pip install under certain conditions. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 6 ++ .azurepipelines/templates/pr-gate-steps.yml| 6 ++ 2 files changed, 12 insertions(+) diff --git a/.azurepipelines/templates/platform

[edk2-devel] [PATCH v7 3/6] CI: Allow running in a container.

2022-11-29 Thread Oliver Steffen
Add a parameter of the pr-gate-build-job template to specify a container image URL. If the value is not '' (default), then the jobs will be run inside a container based on that image. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/pr-gate-build-job.yml | 4 1 file

[edk2-devel] [PATCH v7 1/6] CI: make Python version configurable

2022-11-29 Thread Oliver Steffen
mage will be used. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 6 +- .azurepipelines/templates/pr-gate-build-job.yml| 2 ++ .azurepipelines/templates/pr-gate-steps.yml| 6 -- 3 files changed, 11 insertions(+), 3 deletions

[edk2-devel] [PATCH v7 4/6] CI: Use Fedora 35 container (Linux only)

2022-11-29 Thread Oliver Steffen
run apt-get in CI jobs to install qemu and gcc dependencies. Assume the container image provides these. Use Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen --- .azurepipelines/Ubuntu-GCC5.yml| 2 ++ .azurepipelines/templates

[edk2-devel] [PATCH v7 6/6] CI: use latest vm_image (Linux only)

2022-11-29 Thread Oliver Steffen
Switch over to `ubuntu-latest` as the vm_image for Linux CI jobs (EmulatorPkg, ArmVirtPkg, OvmfPkg). The previously used ubuntu-18.04 will not be available after Dec 1st 2022. Signed-off-by: Oliver Steffen --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +- EmulatorPkg/PlatformCI

[edk2-devel] [PATCH v7 5/6] BaseTools: Remove ext. gcc dependencies (Linux only)

2022-11-29 Thread Oliver Steffen
Remove BaseTools/Bin/gcc*_linux_ext_dep.yaml to stop downloading gcc from external locations; use the toolchains provided by the container image instead. The image needs to set the GCC5_*_PREFIX accordingly. Signed-off-by: Oliver Steffen --- BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21

Re: [edk2-devel] [PATCH v7 1/6] CI: make Python version configurable

2022-11-30 Thread Oliver Steffen
I fear this might delay these patches too much and go for a minimal version for now. Maybe we have a chance to merge something before the CI stops working tomorrow. Thanks, Oliver > Thanks, > Michael > > On 11/29/2022 2:26 PM, Oliver Steffen wrote: > > Add a new parameter &

Re: [edk2-devel] [PATCH v7 0/6] CI: Use Fedora 35 container for Linux jobs

2022-11-30 Thread Oliver Steffen
Sean, Quoting Sean Brogan (2022-11-30 01:28:45) > Oliver, > > Thanks for this changeset and i think this is getting closer but over the past > few months there have been a few changes that I don't think this series takes > into account. > > A few comments i hope we can address quickly (since 18.0

[edk2-devel] [PATCH v8 00/12] CI: Use Fedora 35 container for Linux jobs

2022-11-30 Thread Oliver Steffen
ild-images Signed-off-by: Oliver Steffen Acked-by: Ard Biesheuvel Acked-by: Gerd Hoffmann Reviewed-by: Chris Fernald Oliver Steffen (12): CI: make Python version configurable OvmfPkg: CI: use Python version from defaults template EmulatorPkg: CI: use Python version from defaults template CI:

[edk2-devel] [PATCH v8 05/12] CI: Allow running in a container.

2022-11-30 Thread Oliver Steffen
Add a parameter of the pr-gate-build-job template to specify a container image URL. If the value is not '' (default), then the jobs will be run inside a container based on that image. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/pr-gate-build-job.yml | 4 1 file

[edk2-devel] [PATCH v8 02/12] OvmfPkg: CI: use Python version from defaults template

2022-11-30 Thread Oliver Steffen
container image, so these changes are for Windows only. Signed-off-by: Oliver Steffen --- OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/OvmfPkg/PlatformCI/.azurepipelines

[edk2-devel] [PATCH v8 03/12] EmulatorPkg: CI: use Python version from defaults template

2022-11-30 Thread Oliver Steffen
container image, so these changes are for Windows only. Signed-off-by: Oliver Steffen --- EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 4 1 file changed, 4 insertions(+) diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/EmulatorPkg/PlatformCI

[edk2-devel] [PATCH v8 07/12] ArmVirtPkg: CI: Use Fedora 35 container (Linux only)

2022-11-30 Thread Oliver Steffen
run apt-get in CI jobs to install qemu and gcc dependencies. Assume the container image provides these. Use Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 7 +++ 1 file changed, 3 insertions

[edk2-devel] [PATCH v8 01/12] CI: make Python version configurable

2022-11-30 Thread Oliver Steffen
ally, add a template .azurepipelines/templates/defaults.yml, from which the default Pyhton version string can be obtained. Signed-off-by: Oliver Steffen --- .azurepipelines/Windows-VS2019.yml | 4 .azurepipelines/templates/defaults.yml | 3 +++ .azur

[edk2-devel] [PATCH v8 08/12] OvmfPkg: CI: Use Fedora 35 container (Linux only)

2022-11-30 Thread Oliver Steffen
run apt-get in CI jobs to install qemu and gcc dependencies. Assume the container image provides these. Use Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen --- OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 7 +++ 1 file changed, 3 insertions

[edk2-devel] [PATCH v8 04/12] CI: add ~/.local/bin to PATH (Linux only)

2022-11-30 Thread Oliver Steffen
Fix pip install under certain conditions. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 6 ++ .azurepipelines/templates/pr-gate-steps.yml| 6 ++ 2 files changed, 12 insertions(+) diff --git a/.azurepipelines/templates/platform

[edk2-devel] [PATCH v8 06/12] BaseTools: CI: Use Fedora 35 container (Linux only)

2022-11-30 Thread Oliver Steffen
image instead. The container image sets the variable GCC5_*_PREFIX accordingly. Signed-off-by: Oliver Steffen --- .azurepipelines/Ubuntu-GCC5.yml | 2 ++ .../templates/basetools-build-steps.yml | 9 BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21

[edk2-devel] [PATCH v8 09/12] EmulatorPkg: CI: Use Fedora 35 container (Linux only)

2022-11-30 Thread Oliver Steffen
Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen --- EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/EmulatorPkg/PlatformCI/.azurepipelines

[edk2-devel] [PATCH v8 12/12] CI: use latest vm_image (Linux only)

2022-11-30 Thread Oliver Steffen
Switch over to `ubuntu-latest` as the vm_image for Linux CI jobs (EmulatorPkg, ArmVirtPkg, OvmfPkg). The previously used ubuntu-18.04 will not be available after Dec 1st 2022. Signed-off-by: Oliver Steffen --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +- EmulatorPkg/PlatformCI

[edk2-devel] [PATCH v8 11/12] .pytool: CISettings.py: don't add scopes for GCC

2022-11-30 Thread Oliver Steffen
All ext_dep.yml files for gcc have been removed and gcc is expected to be installed on the system (GCC5_*_PREFIX may indicate the location). No need to adjust the toolchain scopes for Linux builds anymore. Signed-off-by: Oliver Steffen --- .pytool/CISettings.py | 9 - 1 file changed, 9

[edk2-devel] [PATCH v8 10/12] CI: Don't install cspell

2022-11-30 Thread Oliver Steffen
cspell is already included in the container image. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/spell-check-prereq-steps.yml | 4 1 file changed, 4 deletions(-) diff --git a/.azurepipelines/templates/spell-check-prereq-steps.yml b/.azurepipelines/templates/spell-check

Re: [edk2-devel] [PATCH v8 10/12] CI: Don't install cspell

2022-11-30 Thread Oliver Steffen
tall should not do much if cspell is already there. We can clean this up later, and track this in an issue / BZ. - Oliver > On 11/30/2022 12:01 PM, Oliver Steffen wrote: > > cspell is already included in the container image. > > > > Signed-off-by: Oliver Steffen > > ---

Re: [edk2-devel] [PATCH v8 12/12] CI: use latest vm_image (Linux only)

2022-11-30 Thread Oliver Steffen
quot;always" work. But better be safe than sorry. -Oliver > > Thanks, > > Mike > > > -Original Message- > > From: devel@edk2.groups.io On Behalf Of Oliver > > Steffen > > Sent: Wednesday, November 30, 2022 12:01 PM > > To: devel@edk2.

[edk2-devel] [PATCH v9 01/12] CI: make Python version configurable

2022-11-30 Thread Oliver Steffen
ally, add a template .azurepipelines/templates/defaults.yml, from which the default Pyhton version string can be obtained. Signed-off-by: Oliver Steffen --- .azurepipelines/Windows-VS2019.yml | 4 .azurepipelines/templates/defaults.yml | 3 +++ .azur

[edk2-devel] [PATCH v9 02/12] OvmfPkg: CI: use Python version from defaults template

2022-11-30 Thread Oliver Steffen
container image, so these changes are for Windows only. Signed-off-by: Oliver Steffen --- OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 5 + 1 file changed, 5 insertions(+) diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/OvmfPkg/PlatformCI/.azurepipelines

[edk2-devel] [PATCH v9 03/12] EmulatorPkg: CI: use Python version from defaults template

2022-11-30 Thread Oliver Steffen
container image, so these changes are for Windows only. Signed-off-by: Oliver Steffen --- EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 4 1 file changed, 4 insertions(+) diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/EmulatorPkg/PlatformCI

[edk2-devel] [PATCH v9 04/12] CI: add ~/.local/bin to PATH (Linux only)

2022-11-30 Thread Oliver Steffen
Fix pip install under certain conditions. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 6 ++ .azurepipelines/templates/pr-gate-steps.yml| 6 ++ 2 files changed, 12 insertions(+) diff --git a/.azurepipelines/templates/platform

[edk2-devel] [PATCH v9 05/12] CI: Allow running in a container.

2022-11-30 Thread Oliver Steffen
Add a parameter of the pr-gate-build-job template to specify a container image URL. If the value is not '' (default), then the jobs will be run inside a container based on that image. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/pr-gate-build-job.yml | 4 1 file

[edk2-devel] [PATCH v9 06/12] BaseTools: CI: Use Fedora 35 container (Linux only)

2022-11-30 Thread Oliver Steffen
image instead. The container image sets the variable GCC5_*_PREFIX accordingly. Signed-off-by: Oliver Steffen --- .azurepipelines/Ubuntu-GCC5.yml | 2 ++ .../templates/basetools-build-steps.yml | 9 BaseTools/Bin/gcc_aarch64_linux_ext_dep.yaml | 21

[edk2-devel] [PATCH v9 07/12] ArmVirtPkg: CI: Use Fedora 35 container (Linux only)

2022-11-30 Thread Oliver Steffen
run apt-get in CI jobs to install qemu and gcc dependencies. Assume the container image provides these. Use Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 7 +++ 1 file changed, 3 insertions

[edk2-devel] [PATCH v9 08/12] OvmfPkg: CI: Use Fedora 35 container (Linux only)

2022-11-30 Thread Oliver Steffen
run apt-get in CI jobs to install qemu and gcc dependencies. Assume the container image provides these. Use Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen --- OvmfPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 7 +++ 1 file changed, 3 insertions

[edk2-devel] [PATCH v9 09/12] EmulatorPkg: CI: Use Fedora 35 container (Linux only)

2022-11-30 Thread Oliver Steffen
Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen --- EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b/EmulatorPkg/PlatformCI/.azurepipelines

[edk2-devel] [PATCH v9 10/12] .pytool: CISettings.py: don't add scopes for GCC

2022-11-30 Thread Oliver Steffen
All ext_dep.yml files for gcc have been removed and gcc is expected to be installed on the system (GCC5_*_PREFIX may indicate the location). No need to adjust the toolchain scopes for Linux builds anymore. Signed-off-by: Oliver Steffen --- .pytool/CISettings.py | 9 - 1 file changed, 9

[edk2-devel] [PATCH v9 11/12] CI: use latest vm_image (Linux only)

2022-11-30 Thread Oliver Steffen
Switch over to `ubuntu-latest` as the vm_image for Linux CI jobs (EmulatorPkg, ArmVirtPkg, OvmfPkg). The previously used ubuntu-18.04 will not be available after Dec 1st 2022. Signed-off-by: Oliver Steffen --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 2 +- EmulatorPkg/PlatformCI

[edk2-devel] [PATCH v9 12/12] do not merge: modify *.dsc to trigger CI

2022-11-30 Thread Oliver Steffen
Modify all *.dsc files to make sure all parts of the CI actually run. This is only needed to trigger the CI in the PR and shall not be merged. Signed-off-by: Oliver Steffen --- ArmPkg/ArmPkg.dsc | 1 + ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.dsc

[edk2-devel] [PATCH v9 00/12] CI: Use Fedora 35 container for Linux jobs

2022-11-30 Thread Oliver Steffen
s://edk2.groups.io/g/devel/message/89058 - Images were hosted at https://github.com/osteffenrh/edk2-build-images Signed-off-by: Oliver Steffen Acked-by: Ard Biesheuvel Acked-by: Gerd Hoffmann Reviewed-by: Chris Fernald Oliver Steffen (12): CI: make Python version configurable OvmfPkg: CI: u

Re: [edk2-devel] [PATCH v9 12/12] do not merge: modify *.dsc to trigger CI

2022-11-30 Thread Oliver Steffen
Please ignore this patch. I did not intend to send it. -Oliver On Wed, Nov 30, 2022 at 11:01 PM Oliver Steffen wrote: > > Modify all *.dsc files to make sure all parts of the CI actually run. > This is only needed to trigger the CI in the PR and shall not be merged. > > Signed

[edk2-devel] [PATCH v10 00/17] CI: Use Fedora 35 container for Linux jobs

2022-12-01 Thread Oliver Steffen
hosted at https://github.com/osteffenrh/edk2-build-images Signed-off-by: Oliver Steffen Acked-by: Ard Biesheuvel Acked-by: Gerd Hoffmann Reviewed-by: Chris Fernald Oliver Steffen (17): CI: make Python version configurable ArmVirtPkg: CI: use Python version from defaults template

[edk2-devel] [PATCH v10 01/17] CI: make Python version configurable

2022-12-01 Thread Oliver Steffen
ally, add a template .azurepipelines/templates/defaults.yml, from which the default Pyhton version string can be obtained. Signed-off-by: Oliver Steffen --- .azurepipelines/Ubuntu-GCC5.yml | 4 .azurepipelines/Windows-VS2019.yml| 4 .azur

[edk2-devel] [PATCH v10 02/17] ArmVirtPkg: CI: use Python version from defaults template

2022-12-01 Thread Oliver Steffen
Use the default Python version from the defaults template (.azurepipelines/templates/defaults.yml) in the Windows and Linux CI jobs. Previous changes to the CI job templates make it necessary to specify a version number, if Python shall be pulled at CI runtime. Signed-off-by: Oliver Steffen

[edk2-devel] [PATCH v10 03/17] EmulatorPkg: CI: use Python version from defaults template

2022-12-01 Thread Oliver Steffen
Use the default Python version from the defaults template (.azurepipelines/templates/defaults.yml) in the Windows and Linux CI jobs. Previous changes to the CI job templates make it necessary to specify a version number, if Python shall be pulled at CI runtime. Signed-off-by: Oliver Steffen

[edk2-devel] [PATCH v10 04/17] OvmfPkg: CI: use Python version from defaults template

2022-12-01 Thread Oliver Steffen
Use the default Python version from the defaults template (.azurepipelines/templates/defaults.yml) in the Windows and Linux CI jobs. Previous changes to the CI job templates make it necessary to specify a version number, if Python shall be pulled at CI runtime. Signed-off-by: Oliver Steffen

[edk2-devel] [PATCH v10 05/17] CI: add ~/.local/bin to PATH (Linux only)

2022-12-01 Thread Oliver Steffen
Without adding ~/.local/bin to PATH, `pip install` will throw an error when running inside a container. Containers will be introduced to the CI in the following commits. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- .azurepipelines/templates/platform-build-run-steps.yml | 6

[edk2-devel] [PATCH v10 06/17] CI: Allow running in a container.

2022-12-01 Thread Oliver Steffen
Add a parameter of the pr-gate-build-job template to specify a container image URL. If the value is not '' (default), then the jobs will be run inside a container based on that image. Signed-off-by: Oliver Steffen Reviewed-by: Michael Kubacki --- .azurepipelines/templates/pr-

[edk2-devel] [PATCH v10 07/17] CI: Use Fedora 35 container (Linux only)

2022-12-01 Thread Oliver Steffen
run apt-get in CI jobs to install qemu and gcc dependencies. Assume the container image provides these. Use Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen --- .azurepipelines/Ubuntu-GCC5.yml | 6 ++ .azurepipelines/templates

[edk2-devel] [PATCH v10 08/17] ArmVirtPkg: CI: Use Fedora 35 container (Linux only)

2022-12-01 Thread Oliver Steffen
run apt-get in CI jobs to install qemu and gcc dependencies. Assume the container image provides these. Use Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen --- ArmVirtPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 11 +++ 1 file changed, 3

[edk2-devel] [PATCH v10 09/17] EmulatorPkg: CI: Use Fedora 35 container (Linux only)

2022-12-01 Thread Oliver Steffen
Python from the container image, do not download at runtime. Signed-off-by: Oliver Steffen Acked-by: Ray Ni --- EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/EmulatorPkg/PlatformCI/.azurepipelines/Ubuntu-GCC5.yml b

  1   2   3   >