On Wed, Nov 30, 2022 at 9:45 PM Chris Fernald <chris.fern...@outlook.com> wrote: > > I apologize as I think I mislead you on this. I think we can only remove > this operation for the builds using the container. I believe Windows > builds will still require this step for the time being. The Windows > pipeline on your PR is currently failing to find cspell. Sorry for not > being clear on this originally.
No worries. Sorry for misunderstanding. I'll drop this patch for now. Don't have a simple and good way to skip this on Linux only. I also don't think this is too critical now, the install should not do much if cspell is already there. We can clean this up later, and track this in an issue / BZ. - Oliver > On 11/30/2022 12:01 PM, Oliver Steffen wrote: > > cspell is already included in the container image. > > > > Signed-off-by: Oliver Steffen <ostef...@redhat.com> > > --- > > .azurepipelines/templates/spell-check-prereq-steps.yml | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/.azurepipelines/templates/spell-check-prereq-steps.yml > > b/.azurepipelines/templates/spell-check-prereq-steps.yml > > index 226909d54c4e..66354ad78b5c 100644 > > --- a/.azurepipelines/templates/spell-check-prereq-steps.yml > > +++ b/.azurepipelines/templates/spell-check-prereq-steps.yml > > @@ -16,7 +16,3 @@ steps: > > versionSpec: '14.x' > > #checkLatest: false # Optional > > condition: and(gt(variables.pkg_count, 0), succeeded()) > > - > > -- script: npm install -g cspell@5.20.0 > > - displayName: 'Install cspell npm' > > - condition: and(gt(variables.pkg_count, 0), succeeded()) > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96765): https://edk2.groups.io/g/devel/message/96765 Mute This Topic: https://groups.io/mt/95366779/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
