Introduce DumpHiiStatementValue() and DumpRedfishValue() to
RedfishDebugLib. Application uses these functions to debug
print the value of HII_STATEMENT_VALUE and EDKII_REDFISH_VALUE.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
---
RedfishPkg/Include/Library/RedfishDebugLib.
RedfishRestExDxe driver failed to uninstall service binding protocol
when driver binding stop is called. Application drivers may still
use RedfishRestExDxe after it is disconnected in system.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Abner Ch
Change debug message level of showing ordered list op-code
to REDFISH_PLATFORM_CONFIG_DEBUG.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../RedfishPlatformConfigDxe.h| 2 +-
.../RedfishPlatformConfigDxe.c| 24 +
-Add JsonObjectClear() interface for application to clear
all elements in JSON object.
-Fix typo.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
Reviewed-by: Abner Chang
---
RedfishPkg/Include/Library/JsonLib.h | 33 +--
RedfishPkg/Librar
with
> RestExSb->RestExChildrenNum.
> At first glance it appears this field must be decremented also. But I see no
> usage
> for RestExChildrenNum at all, may be it can be eliminated?
>
> Regards,
> MIke.
>
> On Wed, Jul 5, 2023 at 9:56 AM Nickle Wang via groups.io
]
> > > RedfishPkg/RedfishRestExDxe: fix
> > CPU
> > > exception in RedfishRestExDxe
> > >
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > Just one note:
> > > All manipulations with this
> > Thanks,
> > Saloni
> >
> > -Original Message-
> > From: devel@edk2.groups.io On Behalf Of Nickle
> > Wang via groups.io
> > Sent: Tuesday, June 27, 2023 5:56 PM
> > To: devel@edk2.groups.io; Nickle Wang
> > Cc: Maciej Rabeda ; Siyua
Call ResetHttpTslSession() to reset HTTP session when TCP timeout
failure happens. So that application can perform retry to the same URI.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../RedfishRestExDxe/RedfishRestExInternal.h | 14 ++
There are two definitions for strncpy() function in RedfishCrtLib.h
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
RedfishPkg/Include/Library/RedfishCrtLib.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/RedfishPkg/Include/Librar
StatementValue->Buffer is converted from ASCII to Unicode by caller
already so we don't have to convert it again.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 6 +-
1 file changed, 5 inse
Return unsupported HTTP status code to caller so caller can handle
HTTP error status code. Current implementation only return EFI error
to caller. Without knowing the HTTP status code, caller has trouble
to handle HTTP request failure.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchyts
- Add NTOHL() for coverting IP address from EFI_IPv4_ADDRESS to
IP4_ADDR so that IP4_IS_VALID_NETMASK() return correct value.
- Add DumpIpv4Address() in RedfishDebugLib and print IP address
when invalid IP or subnet mask address is detected.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Ku
Hi Igor,
Thanks for your review. I think this is feasible. Let me try it and provide
version 2 patch.
Thanks,
Nickle
> -Original Message-
> From: Igor Kulchytskyy
> Sent: Monday, July 24, 2023 9:49 AM
> To: Nickle Wang ; devel@edk2.groups.io
> Cc: Abner Chang ; Nick Ramirez
>
> Subjec
> Subject: Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP
> status code to caller.
>
> External email: Use caution opening links or attachments
>
>
> On Sat, Jul 22, 2023 at 11:18 AM Nickle Wang via groups.io
> wrote:
> >
> > Return unsupported
char *).
> I would suggest to remove this declaration at all.
> BTW there are duplicated declaration for memcmp, memset, strncmp.
>
> On Sat, Jul 22, 2023 at 11:18 AM Nickle Wang via groups.io
> wrote:
> >
> > There are two definitions for strncpy() function in Re
RedfishHostInterfaceDxe does not close protocol notify event in
event callback function. This could cause multiple version of
type 42 records issue if the protocol is installed more than once.
Close the event in callback function so we only create one type 42
record.
Signed-off-by: Nickle Wang
Cc
Bug fix:
- function stack fault
- config handler driver requires the dependency of Redfish Credential
Protocol
- incorrect caller id installation when failed to perform init()
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../RedfishConfigHandler/Redfi
Bug fix:
- function stack fault
- properly handle "SubnetAddrInfoIPv6" when there is no IPv6 support
- copy-n-paste error in RedfishGetHostInterfaceProtocolData()
Enhancement:
- Redfish discover driver now can configure host IP address based on
the information from SMBIOS type 42 record. This sav
When BMC server uses self-signed certificate and BIOS can not get
root CA, we need a way of disabling TLS host verify in HTTPs
connection. Some tool like "curl" has this ability to NOT verify
host certificate. Adding this option to HttpDxe driver helps BIOS
Redfish driver to communicate with BMC
Provide an option for caller to disable TLS host verify in HttpDxe
driver. When web server uses self-signed certificate and caller has no
way to get root CA from web server, caller can use this option to
disable TLS host verify function. This option is similar to the "-k"
option in "curl" tool.
Si
Introduce PCD PcdRedfishTlsHostVerifyDisabled to RedfishDiscoverDxe
driver. Setting this PCD to true will turn off TLS host verify in
HTTPS connection between host and BMC.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
RedfishPkg/RedfishPkg.dec
Introduce RedfishDebugLib to RedfishPkg. This library provides several
debugging functions for Redfish application. Redfish drivers rely on
Rest Ex protocol to communicate with BMC and the communication data
may be big and complicated. Use RedfishDebugLib in RedfishRestExDxe to
simplify debugging p
, Nickle Wang via groups.io wrote:
> diff --git a/MdePkg/Include/Protocol/Http.h b/MdePkg/Include/Protocol/Http.h
> index 28e6221593..21a782eaac 100644
> --- a/MdePkg/Include/Protocol/Http.h
> +++ b/MdePkg/Include/Protocol/Http.h
> @@ -6,6 +6,7 @@
>
> Copyright (c) 2016 - 20
2/2023 11:06, Nickle Wang via groups.io wrote:
> Thanks for catching this. To prevent the change to data structure,
> would you suggest me to create new interface in EFI_HTTP_PROTOCOL and
> disable TLS host verify?
Adding an interface to EFI_HTTP_PROTOCOL would also break the ABI by chan
Hi Igor,
It seems to me that AMI copyrights header is missing in these files. Could you
please check this?
Thanks,
Nickle
-Original Message-
From: Chang, Abner
Sent: Sunday, February 5, 2023 12:01 AM
To: devel@edk2.groups.io; ig...@ami.com
Cc: Nickle Wang
Subject: RE: [PATCH] Redfish
RedfishRestExDriverBindingStop() does not uninstall service
binding protocol and release resource because:
- RestExDestroyChildEntryInHandleBuffer() does not remove entry
when NetIsInHandleBuffer() return false. So the linked list
is not empty.
- When NumberOfChildrenis 0, binding stop function ret
When failure happens in HttpDxeStart, the error handling code
release the memory buffer but it does not uninstall HTTP service
bindnig protocol. As the result, application can still locate
this protocol and invoke service binding fucntions in released
memory pool.
Signed-off-by: Nickle Wang
Cc: M
When system configuration is updated from RESTful interface, we need a
system reboot so that the changes can be applied. Introduce PCD
"PcdSystemRebootRequired" to RedfishClientPkg. RedfishFeatureUtility
library will enable this flag when system config is updated.
RedfishFeatureCore driver will che
When system configuration is updated from RESTful interface, we need a
system reboot so that the changes can be applied. Introduce PCD
"PcdSystemRebootRequired" to RedfishClientPkg. RedfishFeatureUtility
library will enable this flag when system config is updated.
RedfishFeatureCore driver will che
Thanks for your review, Abner. Version 2 patch is sent. I also fixed uncrustify
issue together.
Regards,
Nickle
-Original Message-
From: Chang, Abner
Sent: Thursday, February 16, 2023 8:56 PM
To: Nickle Wang ; devel@edk2.groups.io
Cc: Igor Kulchytskyy ; Nick Ramirez
Subject: RE: [edk2
Add BIOS feature driver version 1.2.0 and Computer System feature
driver version 1.17.0. Move the function of handling
"@Redfish.Settings" to RedfishFeatureUtilityLib because it is called
multiple times in different feature drivers. The missing of FreePool()
calls are fixed together.
Signed-off-
- Add new interface GetPendingSettings() to check and see if
"Redfish.Settings" is in the JSON data or not. If "Redfish.Settings"
is found, return the URI and the context to Redfish pending settings.
- Fix missing FreePool() and uncrustify issues.
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: I
- Add latest BIOS schema version 1.2.0
- Follow early fix in Bios.V1_0_9.c and add fix to Bios.V1_2_0.c
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../src/Bios/Bios.V1_2_0/Bios.V1_2_0.c| 1341 +
.../Features/Bios/v1_2_0/Common/
Add Computer System schema version 1.17.0
Signed-off-by: Nickle Wang
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nick Ramirez
---
.../v1_17_0/Common/ComputerSystemCommon.c | 1636 +
.../v1_17_0/Common/ComputerSystemCommon.h | 29 +
.../v1_17_0/Dxe/ComputerSystemDxe.c
Hi tdoedline,
For the UEFI Redfish design and implementation, please check below links:
*
Redfish foundation support:
https://github.com/tianocore/edk2/tree/master/RedfishPkg
*
Redfish application implementation by using RedfishPkg:
https://github.com/tianocore/edk2-redfish-client/tree/mai
501 - 535 of 535 matches
Mail list logo
