Thanks Abner. Will create a separated patch to remove
"RestExSb->RestExChildrenNum".
Regards,
Nickle
> -----Original Message-----
> From: Chang, Abner <abner.ch...@amd.com>
> Sent: Thursday, July 6, 2023 7:01 PM
> To: Nickle Wang <nick...@nvidia.com>; Mike Maslenkin
> <mike.maslen...@gmail.com>; devel@edk2.groups.io
> Cc: Igor Kulchytskyy <ig...@ami.com>; Nick Ramirez <nrami...@nvidia.com>
> Subject: RE: [edk2-devel] [PATCH v2 1/3] RedfishPkg/RedfishRestExDxe: fix CPU
> exception in RedfishRestExDxe
>
> External email: Use caution opening links or attachments
>
>
> [AMD Official Use Only - General]
>
> I am also ok to remove this. However please have another patch for this, thus
> the
> purpose of change is clear.
>
> Thanks
> Abner
>
> > -----Original Message-----
> > From: Nickle Wang <nick...@nvidia.com>
> > Sent: Thursday, July 6, 2023 4:08 PM
> > To: Mike Maslenkin <mike.maslen...@gmail.com>; devel@edk2.groups.io;
> > Chang, Abner <abner.ch...@amd.com>
> > Cc: Igor Kulchytskyy <ig...@ami.com>; Nick Ramirez
> > <nrami...@nvidia.com>
> > Subject: RE: [edk2-devel] [PATCH v2 1/3] RedfishPkg/RedfishRestExDxe:
> > fix CPU exception in RedfishRestExDxe
> >
> > Caution: This message originated from an External Source. Use proper
> > caution when opening attachments, clicking links, or responding.
> >
> >
> > I am ok to remove it since we don't use it. @Abner Chang, comment as
> > driver author?
> >
> > Thanks,
> > Nickle
> >
> > > -----Original Message-----
> > > From: Mike Maslenkin <mike.maslen...@gmail.com>
> > > Sent: Wednesday, July 5, 2023 4:43 PM
> > > To: devel@edk2.groups.io; Nickle Wang <nick...@nvidia.com>
> > > Cc: Abner Chang <abner.ch...@amd.com>; Igor Kulchytskyy
> > <ig...@ami.com>;
> > > Nick Ramirez <nrami...@nvidia.com>
> > > Subject: Re: [edk2-devel] [PATCH v2 1/3]
> > > RedfishPkg/RedfishRestExDxe: fix
> > CPU
> > > exception in RedfishRestExDxe
> > >
> > > External email: Use caution opening links or attachments
> > >
> > >
> > > Just one note:
> > > All manipulations with this list are going in conjunction with
> > > RestExSb->RestExChildrenNum.
> > > At first glance it appears this field must be decremented also. But
> > > I see no
> > usage
> > > for RestExChildrenNum at all, may be it can be eliminated?
> > >
> > > Regards,
> > > MIke.
> > >
> > > On Wed, Jul 5, 2023 at 9:56 AM Nickle Wang via groups.io
> > > <nicklew=nvidia....@groups.io> wrote:
> > > >
> > > > RedfishRestExDxe driver failed to uninstall service binding
> > > > protocol when driver binding stop is called. Application drivers
> > > > may still use RedfishRestExDxe after it is disconnected in system.
> > > >
> > > > Signed-off-by: Nickle Wang <nick...@nvidia.com>
> > > > Cc: Abner Chang <abner.ch...@amd.com>
> > > > Cc: Igor Kulchytskyy <ig...@ami.com>
> > > > Cc: Nick Ramirez <nrami...@nvidia.com>
> > > > Reviewed-by: Abner Chang <abner.ch...@amd.com>
> > > > ---
> > > > RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c | 4 +++-
> > > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c
> > > > b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c
> > > > index ad65ae213ae0..7036aed42683 100644
> > > > --- a/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c
> > > > +++ b/RedfishPkg/RedfishRestExDxe/RedfishRestExDriver.c
> > > > @@ -3,6 +3,7 @@
> > > >
> > > > Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> > > > (C) Copyright 2020 Hewlett Packard Enterprise Development
> > > > LP<BR>
> > > > + Copyright (c) 2023, NVIDIA CORPORATION & AFFILIATES. All rights
> > reserved.
> > > >
> > > > SPDX-License-Identifier: BSD-2-Clause-Patent
> > > >
> > > > @@ -57,6 +58,7 @@ RestExDestroyChildEntryInHandleBuffer (
> > > > ChildHandleBuffer =
> > ((RESTEX_DESTROY_CHILD_IN_HANDLE_BUF_CONTEXT
> > > > *)Context)->ChildHandleBuffer;
> > > >
> > > > if (!NetIsInHandleBuffer (Instance->ChildHandle,
> > > > NumberOfChildren,
> > > > ChildHandleBuffer)) {
> > > > + RemoveEntryList (&Instance->Link);
> > > > return EFI_SUCCESS;
> > > > }
> > > >
> > > > @@ -563,7 +565,7 @@ RedfishRestExDriverBindingStop (
> > > > );
> > > > }
> > > >
> > > > - if ((NumberOfChildren == 0) && IsListEmpty
> > > > (&RestExSb->RestExChildrenList)) {
> > > > + if (IsListEmpty (&RestExSb->RestExChildrenList)) {
> > > > gBS->UninstallProtocolInterface (
> > > > NicHandle,
> > > > &gEfiRestExServiceBindingProtocolGuid,
> > > > --
> > > > 2.17.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#106697): https://edk2.groups.io/g/devel/message/106697
Mute This Topic: https://groups.io/mt/99960360/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
