[edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

2020-02-19 Thread Nickle Wang
>From the function description of GetIfrBinaryData(), FormSetGuid can be NULL. >However, FormSetGuid is passed to IsZeroGuid(). This causes exception when >FormSetGuid is NULL. Signed-off-by: Nickle Wang --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 3 ++- 1 file changed, 2 i

[edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

2020-02-20 Thread Nickle Wang
>From the function description of GetIfrBinaryData(), FormSetGuid can be NULL. However, FormSetGuid is passed to IsZeroGuid(). This causes exception when FormSetGuid is NULL. Signed-off-by: Nickle Wang --- MdeModulePkg/Universal/SetupBrowserDxe/Setup.c | 3 ++- 1 file changed, 2 inserti

Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

2020-02-20 Thread Nickle Wang
-Format, Line length of commit message should be less than 76 characters when possible. Please address it when submit the patch. Reviewed-by: Dandan Bi Thanks, Dandan > -Original Message- > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of > Nickle Wang > Sen

Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

2020-02-20 Thread Nickle Wang
andan > > > -Original Message- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf > > Of Nickle Wang > > Sent: Wednesday, February 19, 2020 10:23 PM > > To: devel@edk2.groups.io; nickle.w...@hpe.com > > Cc: Bi, Dandan > >

Re: [edk2-devel] [PATCH] MdeModulePkg/SetupBrowserDxe: Fix IsZeroGuid() ASSERT.

2020-02-20 Thread Nickle Wang
om/tianocore/tianocore.github.io/wiki/Commit-Message > > -Format, Line length of commit message should be less than > 76 characters when possible. > > Please address it when submit the patch. > > Reviewed-by: Dandan Bi > > > > > > Thanks, > > Dandan &g

[edk2-devel] [PATCH] EmulatorPkg/WinHost: Enable network support.

2020-03-26 Thread Nickle Wang
Follow the implementation from Unix host to implement SNP EMU_IO_THUNK_PROTOCOL and EMU_SNP_PROTOCOL. The network IO driver is the same one as Nt32. Please refer to NETWORK-IO Subproject for network Io driver(SnpNt32Io.dll). Signed-off-by: Nickle Wang Signed-off-by: Derek Lin --- EmulatorPkg

[edk2-devel] [PATCH v2] EmulatorPkg/WinHost: Enable network support.

2020-04-08 Thread Nickle Wang
Follow the implementation from Unix host to implement SNP EMU_IO_THUNK_PROTOCOL and EMU_SNP_PROTOCOL. The network IO driver is the same one as Nt32. Please refer to NETWORK-IO Subproject for network Io driver(SnpNt32Io.dll). Signed-off-by: Nickle Wang Signed-off-by: Derek Lin --- EmulatorPkg

Re: [edk2-devel] [PATCH v2] EmulatorPkg/WinHost: Enable network support.

2020-04-20 Thread Nickle Wang
Hi Justen, Andrew, Ray, Could you please help me to review my change? This is version 2 patch to address the comment from TianoDesign meeting on 04/03. Thanks, Nickle -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Nickle Wang Sent: Thursday

[edk2-devel] [PATCH 0/1] RedfishClientPkg: Facilities of EDK2 Redfish Feature Driver

2021-10-13 Thread Nickle Wang
Redfish client feature drivers. - Redfish client package token space: the GUID definition of Redfish client package token space. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Liming Gao Nickle Wang (1): RedfishClientPkg: Facilities of EDK2 Redfish Feature driver Env. .../Include/Guid

[edk2-devel] [PATCH 1/1] RedfishClientPkg: Facilities of EDK2 Redfish Feature driver Env.

2021-10-13 Thread Nickle Wang
Initial common header file and meta files for feature drivers. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Liming Gao --- .../Include/Guid/RedfishClientPkgTokenSpace.h | 20 +++ .../EdkIIRedfishResourceConfigProtocol.h | 129 ++ .../Include/RedfishCollectionCommon.h

[edk2-devel] [PATCH V2 1/1] staging/RedfishClientPkg: Facilities of EDK2 Redfish Feature driver Env.

2021-10-24 Thread Nickle Wang
Initial common header file and meta files for feature drivers. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Liming Gao --- .../Include/Guid/RedfishClientPkgTokenSpace.h | 20 +++ .../EdkIIRedfishResourceConfigProtocol.h | 129 ++ .../Include/RedfishCollectionCommon.h

[edk2-devel] [PATCH V2 0/1] staging/RedfishClientPkg: Facilities of EDK2 Redfish Feature driver Env.

2021-10-24 Thread Nickle Wang
are the common definition of Redfish client feature drivers. - Redfish client package token space: the GUID definition of Redfish client package token space. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Liming Gao Nickle Wang (1): staging/RedfishClientPkg: Facilities of EDK2 Redfish

Re: [edk2-devel] [PATCH 1/1] RedfishClientPkg: Facilities of EDK2 Redfish Feature driver Env.

2021-10-24 Thread Nickle Wang
header file and meta files for feature drivers. > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Liming Gao > --- > .../Include/Guid/RedfishClientPkgTokenSpace.h | 20 +++ > .../EdkIIRedfishResourceConfigProtocol.h | 129 ++ > .../Include/

Re: [edk2-devel] [PATCH 1/2] staging/RedfishClientPkg: Add EDKII ETag driver

2021-10-25 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle From: Chang, Abner (HPS SW/FW Technologist) Sent: Monday, October 25, 2021 15:41 To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao Subject: [PATCH 1/2] staging/RedfishClientPkg: Add EDKII ETag driver

Re: [edk2-devel] [PATCH 2/2] staging/RedfishClientPkg: Add EDKII ETag driver to build

2021-10-25 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle From: Chang, Abner (HPS SW/FW Technologist) Sent: Monday, October 25, 2021 15:41 To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao Subject: [PATCH 2/2] staging/RedfishClientPkg: Add EDKII ETag driver to

[edk2-devel] [PATCH] RedfishPkg: Update link to staging/RedfishClientPkg in Readme.md

2021-10-28 Thread Nickle Wang
Redfish feature DXE drivers are contributed to staging/RedfishClientPkg. Add link to Readme.md in staging/RedfishClientPkg. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Liming Gao --- RedfishPkg/Readme.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishPkg

Re: [edk2-devel] [PATCH] edk2-staging/RedfishClientPkg: Add the helper library

2021-10-29 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, October 28, 2021 10:02 PM To: devel@edk2.groups.io Cc: Chang, Abner (HPS SW/FW Technologist) ; Wang, Nickle (HPS SW) ; Liming Gao Subject: [PATCH] edk2-staging

Re: [edk2-devel] [PATCH] RedfishPkg: Add more information to Readme.md

2021-10-30 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle From: Chang, Abner (HPS SW/FW Technologist) Sent: Saturday, October 30, 2021 11:23 To: devel@edk2.groups.io Cc: Chang, Abner (HPS SW/FW Technologist) ; Wang, Nickle (HPS SW) ; Liming Gao Subject: [PATCH] RedfishPkg: Add

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix build errors

2021-02-17 Thread Nickle Wang
function to load a NULL terminated-string JSON > - json_string_value() in JsonValueGetAsciiString () is removed > by accident. > > Signed-off-by: Abner Chang > > Cc: Leif Lindholm > Cc: Nickle Wang > Cc: Michael D Kinney > --- > RedfishPkg/Library/J

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Fix the mistake of removing code by a accident

2021-02-17 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle > -Original Message- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Friday, January 29, 2021 12:20 PM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Wang, Nickle (HPS SW) > ; Michael D Kinney > Subject: [PATCH] Re

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Ignore the build error of assignment within conditional expression

2021-02-17 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle > -Original Message- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Friday, January 29, 2021 12:20 PM > To: devel@edk2.groups.io > Cc: Leif Lindholm ; Wang, Nickle (HPS SW) > ; Michael D Kinney > Subject: [PATC

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishContentCodingLib: EDKII Redfish En/Decode library

2021-02-22 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner (HPS SW/FW Technologist) > Sent: Monday, January 18, 2021 11:28 AM > To: devel@edk2.groups.io > Cc: Wang, Nickle (HPS SW) ; Ray Ni > ; Michae

Re: [edk2-devel] [PATCH] RedfishPkg/Include: EDKII Redfish Config Handler Protocol header file

2021-02-22 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner (HPS SW/FW Technologist) > Sent: Monday, January 18, 2021 10:31 AM > To: devel@edk2.groups.io > Cc: Wang, Nickle (HPS SW) > Subject: [edk2-deve

Re: [edk2-devel] [PATCH v2] RedfishPkg/JsonLib: Add JsonLoadString function

2021-02-22 Thread Nickle Wang
Thanks for addressing my comment. The function header looks good to me now. Reviewed-by: Nickle Wang Thanks, Nickle > -Original Message- > From: Chang, Abner (HPS SW/FW Technologist) > Sent: Thursday, February 18, 2021 11:12 AM > To: devel@edk2.groups.io > Cc: Leif

Re: [edk2-devel] [PATCH v2] RedfishPkg/RedfishCrtLib: Add more CRT functions

2021-02-22 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle > -Original Message- > From: devel@edk2.groups.io On Behalf Of Chang, > Abner (HPS SW/FW Technologist) > Sent: Thursday, January 28, 2021 10:58 AM > To: devel@edk2.groups.io > Cc: Wang, Nickle (HPS SW) ; Leif Lindholm &g

Re: [edk2-devel] [patch 18/28] RedfishPkg: Consume RegisterFilterLibNull instance

2021-03-14 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle > -Original Message- > From: Dandan Bi > Sent: Monday, March 15, 2021 11:59 AM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) ; > Wang, Nickle (HPS SW) > Subject: [patch 18/28] RedfishPkg: Consume

Re: [edk2-devel] [patch V2 19/29] RedfishPkg: Consume MdeLibs.dsc.inc for RegisterFilterLib

2021-03-22 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle > -Original Message- > From: Dandan Bi > Sent: Monday, March 22, 2021 4:10 PM > To: devel@edk2.groups.io > Cc: Chang, Abner (HPS SW/FW Technologist) ; > Wang, Nickle (HPS SW) > Subject: [patch V2 19/29] RedfishPkg: Consum

Re: [edk2-devel] [PATCH] EmulatorPkg/RedfishPlatformCredentialLib: Check EFI_SECURE_BOOT_MODE_NAME

2022-03-14 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, March 10, 2022 1:42 PM To: devel@edk2.groups.io Cc: Wang, Nickle (Server BIOS) ; Andrew Fish ; Ray Ni Subject: [PATCH] EmulatorPkg/RedfishPlatformCredentialLib

Re: [edk2-devel] [PATCH] EmulatorPkg/RedfishPlatformCredentialLib: Don't stop Redfish service

2022-03-16 Thread Nickle Wang
Some typos. Platform Redfish credential library shouldn't stop the service at either EndOfDXE or ExitBootService notification. RedfishConfigureHandler UEFI driver is responsible to stop the Redfish service when EndOfDXE or ExitBootService event is triggered. Reviewed-by: Nickle Wang T

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDiscoverDxe: EFI Redfish Discover Protocol

2021-04-11 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Friday, March 26, 2021 12:54 PM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Jiaxin Wu ; Siyuan Fu ; Fan Wang ; Jiewen Yao Subject: [PATCH] RedfishPkg

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishConfigHandler: EDKII RedfishConfigHandler Protocol

2021-04-11 Thread Nickle Wang
ialization. RedfishConfigHandlerCommon.c has the common code for the driver instances used in different EDK2 boot phases or used by different driver models in the future contribution. Signed-off-by: Jiaxin Wu Signed-off-by: Siyuan Fu Signed-off-by: Fan Wang Signed-off-by: Abner Chang Cc: N

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishConfigHandler: EDKII RedfishConfigHandler Protocol

2021-04-11 Thread Nickle Wang
Reviewed-by: Nickle Wang Got it. Thanks Abner. Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Monday, April 12, 2021 12:20 PM To: Wang, Nickle (HPS SW) ; devel@edk2.groups.io Subject: RE: [edk2-devel] [PATCH] RedfishPkg/RedfishConfigHandler: EDKII

Re: [edk2-devel] [PATCH v2] RedfishPkg: Add EDK2 Redfish Foundation diagrams

2021-04-14 Thread Nickle Wang
Reviewed-by: Nickle Wang Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Wednesday, April 14, 2021 10:25 PM To: devel@edk2.groups.io Cc: Jiaxin Wu ; Ting Ye ; Siyuan Fu ; Fan Wang ; Jiewen Yao ; Wang, Nickle (HPS SW) ; Andrew Fish ; Laszlo Ersek ; Leif

Re: [edk2-devel] [PATCH v2] RedfishPkg/RestJsonStructureDxe: Fix typo in function header

2021-04-14 Thread Nickle Wang
Reviewed-by: Nickle Wang Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, April 15, 2021 1:37 PM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) Subject: [PATCH v2] RedfishPkg/RestJsonStructureDxe: Fix typo in function header In v2, BZ

Re: [edk2-devel] [staging/edk2-redfish-client PATCH 2/2] edk2: Update Maintainers.txt

2021-07-19 Thread Nickle Wang
Reviewed-by: Nickle Wang Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Saturday, July 17, 2021 10:02 PM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao ; Andrew Fish ; Leif Lindholm ; Michael D Kinney Subject: [staging/edk2-redfish

Re: [edk2-devel] [staging/edk2-redfish-client PATCH v2 1/2] RedfishClientPkg: Initial commit

2021-07-19 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Tuesday, July 20, 2021 11:54 AM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao ; Andrew Fish ; Leif Lindholm ; Michael D Kinney Subject: [staging/edk2

Re: [edk2-devel] [staging/edk2-redfish-client Tools PATCH 4/6] RedfishClientPkg/Redfish-Profile-Simulator: HTTP methods on Memory Collection

2021-07-22 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, July 22, 2021 14:08 To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao Subject: [staging/edk2-redfish-client Tools PATCH 4/6] RedfishClientPkg

Re: [edk2-devel] [staging/edk2-redfish-client Tools PATCH 5/6] RedfishClientPkg/Redfish-Profile-Simulator: Add ETAG on memory resource

2021-07-22 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, July 22, 2021 14:08 To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao Subject: [staging/edk2-redfish-client Tools PATCH 5/6] RedfishClientPkg

Re: [edk2-devel] [staging/edk2-redfish-client Tools PATCH 6/6] RedfishClientPkg/Redfish-Profile-Simulator: Add requirements

2021-07-22 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, July 22, 2021 14:08 To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao Subject: [staging/edk2-redfish-client Tools PATCH 6/6] RedfishClientPkg

Re: [edk2-devel] [staging/edk2-redfish-client RedfishFeatureCore PATCH 1/3] RedfishClientPkg: Initial commit of meta files

2021-08-08 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Tuesday, July 27, 2021 10:55 PM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao Subject: [staging/edk2-redfish-client RedfishFeatureCore PATCH 1/3

Re: [edk2-devel] [staging/edk2-redfish-client RedfishFeatureCore PATCH 2/3] RedfishClientPkg/RedfishFeatureCoreDxe: Redfish Feature Core DXE driver

2021-08-08 Thread Nickle Wang
: Abner Chang Cc: Nickle Wang Cc: Liming Gao --- RedfishClientPkg/RedfishClientPkg.dec | 13 +- .../RedfishClientComponents.dsc.inc | 2 + RedfishClientPkg/RedfishClient.fdf.inc| 1 + .../RedfishFeatureCoreDxe.inf | 49 +++ .../Include/Protocol

Re: [edk2-devel] [staging/edk2-redfish-client RedfishFeatureCore PATCH 3/3] RedfishClientPkg/Document: Update diagrams

2021-08-08 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Tuesday, July 27, 2021 10:55 PM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao Subject: [staging/edk2-redfish-client RedfishFeatureCore PATCH 3/3

Re: [edk2-devel] [PATCH] RedfishPkg/JsonLib: Add more JsonLib functions

2021-08-08 Thread Nickle Wang
Reviewed-by: Nickle Wang I have question about copyright year format. - (C) Copyright 2020 Hewlett Packard Enterprise Development LP + (C) Copyright 2021 Hewlett Packard Enterprise Development LP This should be "2020-2021", right? Thanks, Nickle -Original Message- F

Re: [edk2-devel] [PATCH] RedfishPkg/RefishCrtLib: Public RefishCrtLib

2021-08-08 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Wednesday, July 28, 2021 1:04 PM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) Subject: [PATCH] RedfishPkg/RefishCrtLib: Public RefishCrtLib Move RefishCrtLib from

Re: [edk2-devel] [staging/edk2-redfish-client PATCH v2 2/2] edk2: Update Maintainers.txt

2021-08-08 Thread Nickle Wang
Reviewed-by: Nickle Wang Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Tuesday, July 20, 2021 11:54 AM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao ; Andrew Fish ; Leif Lindholm ; Michael D Kinney Subject: [staging/edk2-redfish

Re: [edk2-devel] [staging/edk2-redfish-client Tools PATCH 2/6] RedfishClientPkg/Tools: Add more Redfish resource

2021-08-08 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, July 22, 2021 2:08 PM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao Subject: [staging/edk2-redfish-client Tools PATCH 2/6] RedfishClientPkg/Tools

Re: [edk2-devel] [staging/edk2-redfish-client Tools PATCH 3/6] RedfishClientPkg/Redfish-Profile-Simulator: Add more features

2021-08-08 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Thursday, July 22, 2021 2:08 PM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao Subject: [staging/edk2-redfish-client Tools PATCH 3/6] RedfishClientPkg

Re: [edk2-devel] [staging/edk2-redfish-client RedfishFeatureCore PATCH 0/3] RedfishFeatureCoreDxe

2021-08-08 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: devel@edk2.groups.io On Behalf Of Chang, Abner (HPS SW/FW Technologist) Sent: Tuesday, July 27, 2021 10:55 PM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao Subject: [edk2-devel] [staging/edk2-redfish

Re: [edk2-devel] [PATCH V2] RedfishPkg/RefishCrtLib: Public RefishCrtLib

2021-08-10 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Wednesday, August 11, 2021 11:01 AM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) Subject: [PATCH V2] RedfishPkg/RefishCrtLib: Public RefishCrtLib Public the header file

Re: [edk2-devel] [PATCH 0/3] Use RedfishPkg libraries

2021-08-11 Thread Nickle Wang
I reviewed entire series of patch. Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Wednesday, August 11, 2021 2:03 PM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao Subject: [PATCH 0/3] Use RedfishPkg

Re: [edk2-devel] [PATCH] RedfishClientPkg/ConvertLib: Common code and header files

2021-08-12 Thread Nickle Wang
and header files ConverterLib/ is the folder of script-generated JSON to C library for the each Redfish schema. The common code and header files in this patch are used by those libraries. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Liming Gao --- .../ConverterLib/include/RedfishCsCommon.h

Re: [edk2-devel] [PATCH V2] RedfishClientPkg/ConvertLib: Common code and header files

2021-08-13 Thread Nickle Wang
Reviewed-by: Nickle Wang Thanks, Nickle -Original Message- From: Chang, Abner (HPS SW/FW Technologist) Sent: Friday, August 13, 2021 6:22 PM To: devel@edk2.groups.io Cc: Wang, Nickle (HPS SW) ; Liming Gao Subject: [PATCH V2] RedfishClientPkg/ConvertLib: Common code and header files

[edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix memory assert in FreePool()

2021-06-09 Thread Nickle Wang
is not touched when using calloc(). Signed-off-by: Nickle Wang --- .../RegularExpressionDxe/OnigurumaUefiPort.c | 19 ++- .../RegularExpressionDxe/OnigurumaUefiPort.h | 14 ++ 2 files changed, 20 insertions(+), 13 deletions(-) diff --git a/MdeModulePkg/Universal

Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix memory assert in FreePool()

2021-06-29 Thread Nickle Wang
@byosoft.com.cn; jian.j.w...@intel.com; > hao.a...@intel.com > 主题: Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix > memory assert in FreePool() > > On 06/10/21 06:56, Nickle Wang wrote: > > Memory buffer that is allocated by malloc() and realloc() will be > > s

Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix memory assert in FreePool()

2021-06-29 Thread Nickle Wang
edk2.groups.io; nickle.w...@hpe.com > > 抄送: gaolim...@byosoft.com.cn; jian.j.w...@intel.com; > > hao.a...@intel.com > > 主题: Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix > > memory assert in FreePool() > > > > On 06/10/21 06:56, Nickle Wang wrote:

Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix memory assert in FreePool()

2021-06-30 Thread Nickle Wang
Hi Liming, I got my patch ready. Should I test it by creating PR on Github like https://github.com/tianocore/edk2/pull/1735? Or I just send out new patch for review? Thanks, Nickle -Original Message- From: devel@edk2.groups.io On Behalf Of Nickle Wang Sent: Wednesday, June 30, 2021 9

Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix memory assert in FreePool()

2021-07-04 Thread Nickle Wang
g > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Nickle Wang > 发送时间: 2021年6月30日 21:11 > 收件人: devel@edk2.groups.io; Wang, Nickle (HPS SW) > ; gaoliming ; > ler...@redhat.com > 抄送: jian.j.w...@intel.com; hao.a...@intel.com; Wang, Nickle (HPS SW) > > 主题:

[edk2-devel] [PATCH v2 1/2] MdeModulePkg/RegularExpressionDxe: Fix memory assert in FreePool()

2021-07-04 Thread Nickle Wang
is not touched when using calloc(). Signed-off-by: Nickle Wang --- .../RegularExpressionDxe/OnigurumaUefiPort.c | 19 ++- .../RegularExpressionDxe/OnigurumaUefiPort.h | 14 ++ 2 files changed, 20 insertions(+), 13 deletions(-) diff --git a/MdeModulePkg/Universal

[edk2-devel] [PATCH v2 2/2] MdeModulePkg: Update YAML file to fix CI error

2021-07-04 Thread Nickle Wang
Add OnigurumaUefiPort.h and OnigurumaUefiPort.c into ECC exception in MdeModulePkg.ci.yaml in order to fix CI error. Signed-off-by: Nickle Wang --- MdeModulePkg/MdeModulePkg.ci.yaml | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/MdeModulePkg/MdeModulePkg.ci.yaml b

Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix memory assert in FreePool()

2021-07-04 Thread Nickle Wang
...@redhat.com Cc: jian.j.w...@intel.com; hao.a...@intel.com Subject: 回复: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressionDxe: Fix memory assert in FreePool() Please also add this file into the ignored file list. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Nickle Wang

[edk2-devel] [edk2-staging][PATCH] edk2-staging/RedfishClientPkg: Update Bios schema version

2022-07-12 Thread Nickle Wang
Update mock-up file and use Bios schema version 1.0.9 in order to support BIOS configuration driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../redfish/v1/Systems/2M220100SL/Bios/index.json | 2 +- .../redfish/v1/Systems/2M220101SL/Bios

[edk2-devel] [edk2-staging][PATCH 1/2] edk2-staging/EmulatorPkg: Introduce Hii2RedfishBootDxe driver

2022-07-12 Thread Nickle Wang
Add Hii2RedfishBootDxe driver with configure language defined in UNI file in order to demonstrate the use of Redfish Platform Config Protocol. Feature drivers under RedfishClientPkg will work with this driver and provide the REST data to Redfish service. Signed-off-by: Nickle Wang Cc: Andrew

[edk2-devel] [edk2-staging][PATCH 2/2] edk2-staging/EmulatorPkg: Introduce Hii2RedfishBiosDxe driver

2022-07-12 Thread Nickle Wang
Add Hii2RedfishBiosDxe driver with configure language defined in UNI file in order to demonstrate the use of Redfish Platform Config Protocol. Feature drivers under RedfishClientPkg will work with this driver and provide the REST data to Redfish service. Signed-off-by: Nickle Wang Cc: Andrew

[edk2-devel] [edk2-staging][PATCH 00/15] Update RedfishClientpkg

2022-07-12 Thread Nickle Wang
In this series of patch files, additional three feature drivers are enabled. Corresponding libraries and protocols are introduced to help performing Redfish operation like provisioning, consuming and updating Redfish resource between UEFI HII driver and Redfish service hosted at BMC side. Nickle

[edk2-devel] [edk2-staging][PATCH 03/15] edk2-staging/RedfishClientPkg: Update Redfish Resource Config Protocol

2022-07-12 Thread Nickle Wang
Update Redfish resource config protocol to support Identify action in order to identify remote resource and see if this is resource belongs to current owner or not. Use unicode string instead of ASCII string for all interfaces to align with HTTP interface. Signed-off-by: Nickle Wang Cc: Abner

[edk2-devel] [edk2-staging][PATCH 02/15] edk2-staging/RedfishClientPkg: Introduce Redfish version library

2022-07-12 Thread Nickle Wang
Add RedfishVersionLib in order to get Redfish version hosted at BMC. When there is trouble to get Redfish support version, the default version is retrieved from pre-defined PCD value. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Include/Library

[edk2-devel] [edk2-staging][PATCH 01/15] edk2-staging/RedfishClientPkg: Introduce Redfish event library

2022-07-12 Thread Nickle Wang
Add RedfishEventLib to handle Redfish event. There are two events defined in this library. One is the event before feature driver provisioning and the other one is the event after all provisioning is finished. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez

[edk2-devel] [edk2-staging][PATCH 05/15] edk2-staging/RedfishClientPkg: Introduce resource identify library

2022-07-12 Thread Nickle Wang
accepts all Redfish resource and another implementation to computer system resource uses UUID to identify Redfish resource. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Library/RedfishResourceIdentifyLib.h | 29

[edk2-devel] [edk2-staging][PATCH 04/15] edk2-staging/RedfishClientPkg: Introduce Redfish resource config library

2022-07-12 Thread Nickle Wang
Add EdkIIRedfishResourceConfigLib in order to work with Redfish Config Protocol and do the communication between each feature drivers. Also introduce Redfish interchange data protocol to exchange data efficiently. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez

[edk2-devel] [edk2-staging][PATCH 08/15] edk2-staging/RedfishClientPkg: Update Redfish feature core driver

2022-07-12 Thread Nickle Wang
feature drivers directly. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Include/Protocol/EdkIIRedfishFeature.h| 20 +- .../RedfishFeatureCoreDxe.c | 290 -- .../RedfishFeatureCoreDxe.h | 20

[edk2-devel] [edk2-staging][PATCH 06/15] edk2-staging/RedfishClientPkg: Introduce RedfishConfigLangMap driver

2022-07-12 Thread Nickle Wang
provisioning, consuming and updating efficiently. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../EdkIIRedfishConfigLangMapProtocol.h | 88 ++ RedfishClientPkg/RedfishClient.fdf.inc| 3 +- .../RedfishClientComponents.dsc.inc | 1

[edk2-devel] [edk2-staging][PATCH 07/15] edk2-staging/RedfishClientPkg: Update ETag driver

2022-07-12 Thread Nickle Wang
Update ETag driver and use specific variable GUID. Also fix the typo in comment. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- RedfishClientPkg/RedfishClientPkg.dec| 2 +- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 10

[edk2-devel] [edk2-staging][PATCH 09/15] edk2-staging/RedfishClientPkg: Update RedfishLib

2022-07-12 Thread Nickle Wang
RedfishLib has no capability to return HTTP header in response. However, feature driver needs to know the information like "ETag" or "Location" in HTTP response header per Redfish specification. Add corresponding function to return HTTP header in response data. Signed-off

[edk2-devel] [edk2-staging][PATCH 11/15] edk2-staging/RedfishClientPkg: Rename RedfishMemoryCollection driver

2022-07-12 Thread Nickle Wang
Rename RedfishMemoryCollectionDxe by removing Redfish prefix. Update memory collection driver to support "Identify" action and also have code refactoring to support Redfish operation. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../MemoryColle

[edk2-devel] [edk2-staging][PATCH 13/15] edk2-staging/RedfishClientPkg: Introduce Computer System collection driver

2022-07-12 Thread Nickle Wang
Introduce new feature driver to support Computer System Collection schema. Update corresponding FDF and DSC file to enable this feature driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../ComputerSystemCollectionDxe.c | 667

[edk2-devel] [edk2-staging][PATCH 12/15] edk2-staging/RedfishClientPkg: Rename Memory feature driver

2022-07-12 Thread Nickle Wang
Rename Memory driver by removing Redfish prefix. Update memory feature driver and support all properties under Memory schema. Also support "Identify" action in this driver. Corresponding changes are made to honor newly introduced library and protocol. Signed-off-by: Nickle Wang Cc: A

[edk2-devel] [edk2-staging][PATCH 14/15] edk2-staging/RedfishClientPkg: Introduce Computer System feature driver

2022-07-12 Thread Nickle Wang
Introduce new feature driver to support Computer System version 1.5.0 schema. Update corresponding FDF and DSC file to enable this feature driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../v1_5_0/Common/ComputerSystemCommon.c | 1614

[edk2-devel] [edk2-staging][PATCH 15/15] edk2-staging/RedfishClientPkg: Introduce Bios feature driver

2022-07-12 Thread Nickle Wang
Introduce new feature driver to support Bios version 1.0.9 schema. Update corresponding FDF and DSC file to enable this feature driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Features/Bios/v1_0_9/Common/BiosCommon.c | 741

[edk2-devel] [edk2-staging][PATCH v2 2/2] edk2-staging/EmulatorPkg: Introduce Hii2RedfishBiosDxe driver

2022-07-24 Thread Nickle Wang
Add Hii2RedfishBiosDxe driver with configure language defined in UNI file in order to demonstrate the use of Redfish Platform Config Protocol. Feature drivers under RedfishClientPkg will work with this driver and provide the REST data to Redfish service. Signed-off-by: Nickle Wang Cc: Andrew

[edk2-devel] [edk2-staging][PATCH v2 1/2] edk2-staging/EmulatorPkg: Introduce Hii2RedfishBootDxe driver

2022-07-24 Thread Nickle Wang
Add Hii2RedfishBootDxe driver with configure language defined in UNI file in order to demonstrate the use of Redfish Platform Config Protocol. Feature drivers under RedfishClientPkg will work with this driver and provide the REST data to Redfish service. Signed-off-by: Nickle Wang Cc: Andrew

[edk2-devel] [edk2-staging][PATCH v2 00/15] Update RedfishClientpkg

2022-07-24 Thread Nickle Wang
In this series of patch files, additional three feature drivers are enabled. Corresponding libraries and protocols are introduced to help performing Redfish operation like provisioning, consuming and updating Redfish resource between UEFI HII driver and Redfish service hosted at BMC side. Nickle

[edk2-devel] [edk2-staging][PATCH v2 01/15] edk2-staging/RedfishClientPkg: Introduce Redfish event library

2022-07-24 Thread Nickle Wang
Add RedfishEventLib to handle Redfish event. There are two events defined in this library. One is the event before feature driver provisioning and the other one is the event after all provisioning is finished. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez

[edk2-devel] [edk2-staging][PATCH v2 03/15] edk2-staging/RedfishClientPkg: Update Redfish Resource Config Protocol

2022-07-24 Thread Nickle Wang
Update Redfish resource config protocol to support Identify action in order to identify remote resource and see if this is resource belongs to current owner or not. Use unicode string instead of ASCII string for all interfaces to align with HTTP interface. Signed-off-by: Nickle Wang Cc: Abner

[edk2-devel] [edk2-staging][PATCH v2 02/15] edk2-staging/RedfishClientPkg: Introduce Redfish version library

2022-07-24 Thread Nickle Wang
Add RedfishVersionLib in order to get Redfish version hosted at BMC. When there is trouble to get Redfish support version, the default version is retrieved from pre-defined PCD value. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Include/Library

[edk2-devel] [edk2-staging][PATCH v2 04/15] edk2-staging/RedfishClientPkg: Introduce Redfish resource config library

2022-07-24 Thread Nickle Wang
Add EdkIIRedfishResourceConfigLib in order to work with Redfish Config Protocol and do the communication between each feature drivers. Also introduce Redfish interchange data protocol to exchange data efficiently. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez

[edk2-devel] [edk2-staging][PATCH v2 05/15] edk2-staging/RedfishClientPkg: Introduce resource identify library

2022-07-24 Thread Nickle Wang
accepts all Redfish resource and another implementation to computer system resource uses UUID to identify Redfish resource. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Library/RedfishResourceIdentifyLib.h | 29

[edk2-devel] [edk2-staging][PATCH v2 06/15] edk2-staging/RedfishClientPkg: Introduce RedfishConfigLangMap driver

2022-07-24 Thread Nickle Wang
provisioning, consuming and updating efficiently. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../EdkIIRedfishConfigLangMapProtocol.h | 88 ++ RedfishClientPkg/RedfishClient.fdf.inc| 3 +- .../RedfishClientComponents.dsc.inc | 1

[edk2-devel] [edk2-staging][PATCH v2 07/15] edk2-staging/RedfishClientPkg: Update ETag driver

2022-07-24 Thread Nickle Wang
Update ETag driver and use specific variable GUID. Also fix the typo in comment. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- RedfishClientPkg/RedfishClientPkg.dec| 2 +- RedfishClientPkg/RedfishETagDxe/RedfishETagDxe.c | 10

[edk2-devel] [edk2-staging][PATCH v2 09/15] edk2-staging/RedfishClientPkg: Update RedfishLib

2022-07-24 Thread Nickle Wang
RedfishLib has no capability to return HTTP header in response. However, feature driver needs to know the information like "ETag" or "Location" in HTTP response header per Redfish specification. Add corresponding function to return HTTP header in response data. Signed-off

[edk2-devel] [edk2-staging][PATCH v2 08/15] edk2-staging/RedfishClientPkg: Update Redfish feature core driver

2022-07-24 Thread Nickle Wang
feature drivers directly. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Include/Protocol/EdkIIRedfishFeature.h| 20 +- .../RedfishFeatureCoreDxe.c | 290 -- .../RedfishFeatureCoreDxe.h | 20

[edk2-devel] [edk2-staging][PATCH v2 11/15] edk2-staging/RedfishClientPkg: Rename RedfishMemoryCollection driver

2022-07-24 Thread Nickle Wang
Rename RedfishMemoryCollectionDxe by removing Redfish prefix. Update memory collection driver to support "Identify" action and also have code refactoring to support Redfish operation. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../MemoryColle

[edk2-devel] [edk2-staging][PATCH v2 13/15] edk2-staging/RedfishClientPkg: Introduce Computer System collection driver

2022-07-24 Thread Nickle Wang
Introduce new feature driver to support Computer System Collection schema. Update corresponding FDF and DSC file to enable this feature driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../ComputerSystemCollectionDxe.c | 667

[edk2-devel] [edk2-staging][PATCH v2 14/15] edk2-staging/RedfishClientPkg: Introduce Computer System feature driver

2022-07-24 Thread Nickle Wang
Introduce new feature driver to support Computer System version 1.5.0 schema. Update corresponding FDF and DSC file to enable this feature driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../v1_5_0/Common/ComputerSystemCommon.c | 1614

[edk2-devel] [edk2-staging][PATCH v2 15/15] edk2-staging/RedfishClientPkg: Introduce Bios feature driver

2022-07-24 Thread Nickle Wang
Introduce new feature driver to support Bios version 1.0.9 schema. Update corresponding FDF and DSC file to enable this feature driver. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Features/Bios/v1_0_9/Common/BiosCommon.c | 741

[edk2-devel] [edk2-staging][PATCH v2 12/15] edk2-staging/RedfishClientPkg: Rename Memory feature driver

2022-07-24 Thread Nickle Wang
Rename Memory driver by removing Redfish prefix. Update memory feature driver and support all properties under Memory schema. Also support "Identify" action in this driver. Corresponding changes are made to honor newly introduced library and protocol. Signed-off-by: Nickle Wang Cc: A

[edk2-devel] [edk2-staging][PATCH v3 00/15] Update RedfishClientpkg

2022-07-26 Thread Nickle Wang
In this series of patch files, additional three feature drivers are enabled. Corresponding libraries and protocols are introduced to help performing Redfish operation like provisioning, consuming and updating Redfish resource between UEFI HII driver and Redfish service hosted at BMC side. Nickle

[edk2-devel] [edk2-staging][PATCH v3 01/15] edk2-staging/RedfishClientPkg: Introduce Redfish event library

2022-07-26 Thread Nickle Wang
Add RedfishEventLib to handle Redfish event. There are two events defined in this library. One is the event before feature driver provisioning and the other one is the event after all provisioning is finished. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez

[edk2-devel] [edk2-staging][PATCH v3 02/15] edk2-staging/RedfishClientPkg: Introduce Redfish version library

2022-07-26 Thread Nickle Wang
Add RedfishVersionLib in order to get Redfish version hosted at BMC. When there is trouble to get Redfish support version, the default version is retrieved from pre-defined PCD value. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez --- .../Include/Library

[edk2-devel] [edk2-staging][PATCH v3 03/15] edk2-staging/RedfishClientPkg: Update Redfish Resource Config Protocol

2022-07-26 Thread Nickle Wang
Update Redfish resource config protocol to support Identify action in order to identify remote resource and see if this is resource belongs to current owner or not. Use unicode string instead of ASCII string for all interfaces to align with HTTP interface. Signed-off-by: Nickle Wang Cc: Abner

[edk2-devel] [edk2-staging][PATCH v3 04/15] edk2-staging/RedfishClientPkg: Introduce Redfish resource config library

2022-07-26 Thread Nickle Wang
Add EdkIIRedfishResourceConfigLib in order to work with Redfish Config Protocol and do the communication between each feature drivers. Also introduce Redfish interchange data protocol to exchange data efficiently. Signed-off-by: Nickle Wang Cc: Abner Chang Cc: Yang Atom Cc: Nick Ramirez

  1   2   3   4   5   6   7   >