Some typos.

Platform Redfish credential library shouldn't stop the service at either 
EndOfDXE or ExitBootService notification. RedfishConfigureHandler UEFI driver 
is responsible to stop the Redfish service when EndOfDXE or ExitBootService 
event is triggered.

Reviewed-by: Nickle Wang <nickle.w...@hpe.com>

Thanks,
Nickle

________________________________
From: Chang, Abner (HPS SW/FW Technologist) <abner.ch...@hpe.com>
Sent: Wednesday, March 16, 2022 16:04
To: devel@edk2.groups.io <devel@edk2.groups.io>
Cc: Wang, Nickle (Server BIOS) <nickle.w...@hpe.com>; Andrew Fish 
<af...@apple.com>; Ray Ni <ray...@intel.com>
Subject: [PATCH] EmulatorPkg/RedfishPlatformCredentialLib: Don't stop Redfish 
service

https://bugzilla.tianocore.org/show_bug.cgi?id=3859

Platform Redfish credential library shouldn't top the service at either 
EndOfDXE or ExitBootService notification. RedfishConfiguHandler UEFI driver is 
responsible to stop the Redfish service when EndOfDXE or ExitBootService event 
is triggered.

Signed-off-by: Abner Chang <abner.ch...@hpe.com>
Cc: Nickle Wang <nickle.w...@hpe.com>
Cc: Andrew Fish <af...@apple.com>
Cc: Ray Ni <ray...@intel.com>
---
 .../RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.c | 2 --
 1 file changed, 2 deletions(-)

diff --git 
a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.c
 
b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.c
index a0233a984d..614eaebb0d 100644
--- 
a/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.c
+++ 
b/EmulatorPkg/Library/RedfishPlatformCredentialLib/RedfishPlatformCredentialLib.c
@@ -223,7 +223,6 @@ LibCredentialExitBootServicesNotify (
   IN  EDKII_REDFISH_CREDENTIAL_PROTOCOL  *This
   )
 {
-  LibStopRedfishService (This, ServiceStopTypeExitBootService);
 }

 /**
@@ -237,5 +236,4 @@ LibCredentialEndOfDxeNotify (
   IN  EDKII_REDFISH_CREDENTIAL_PROTOCOL  *This
   )
 {
-  LibStopRedfishService (This, ServiceStopTypeSecureBootDisabled);
 }
--
2.17.1



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#87630): https://edk2.groups.io/g/devel/message/87630
Mute This Topic: https://groups.io/mt/89817622/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to