Hi Gerd,
On Tue, Dec 5, 2023 at 4:51 PM Gerd Hoffmann wrote:
>
> Extend the ValidateFvHeader function, additionally to the header checks
> walk over the list of variables and sanity check them.
>
> In case we find inconsistencies indicating variable store corruption
> return EFI_NOT_FOUND so the
es, the IP address must be specified
in brackets, i.e. the resulting string should look like:
"http{,s}://[X::X:X:X:X]/".
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 20 ---
ubnet
> information so they can know the network domain the NIC is
> connected. There may have multiple subnets in the corporation
> network environment. So the subnet information provides client
> an idea when they choose the network interface, so does VLAN ID.
>
> Signed-off-b
coverDxe.c
| 8 +-
RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
| 4 +-
14 files changed, 265 insertions(+), 65 deletions(-)
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike
PlatformHostInterfaceBmcUsbNicLib is the library instance name not the class
name.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../PlatformHostInterfaceBmcUsbNicLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion
RedfishPlatformCredentialIpmiLib is the library instance name not the class
name.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishPlatformCredentialIpmiLib.inf| 2 +-
1 file changed, 1 insertion(+), 1 deletion
hat also seems based on a header mentioned above.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishPkg/Include/Library/RedfishCrtLib.h | 45 ++
1 file changed, 11 insertions(+), 34 deletions(-)
diff --git a/RedfishPkg/Include/L
ff-by: Mike Maslenkin
---
.../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
index cbc65ba
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
b/RedfishPkg
Currently there is no description for RedfishConfigHandler driver.
This leads to in the "DRIVER NAME" column of a `drivers`
command for example.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishConfigHandler/ComponentName.c
All fields of IPMI_CHANNEL_INFO_CHANNEL_NUMBER union must be
initialized to avoid error condition on BMC side.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../PlatformHostInterfaceBmcUsbNicLib.c | 8 +---
1 file changed, 5
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
EmulatorPkg/EmulatorPkg.dec | 8
.../RedfishPlatformCredentialLib.c | 12 ++--
.../RedfishPlatformCredentialLib.inf | 8
3 files changed, 14
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
.../RedfishPlatformHostInterfaceLib.c | 2 --
1 file changed, 2 deletions(-)
diff --git
a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostInterfaceLib.c
b/EmulatorPkg/Library
now the network domain the NIC is
> connected. There may have multiple subnets in the corporation
> network environment. So the subnet information provides client
> an idea when they choose the network interface, so does VLAN ID.
>
> Change-Id: Ibb38ddcd17459ad4b23fcb4fcd
Fair.
I'll try to make some cleanups before applying this patch after
committing Abner's remedy patch
https://github.com/tianocore/edk2/pull/5139.
Regards,
Mike..
On Wed, Dec 13, 2023 at 4:15 PM Pedro Falcato wrote:
>
> On Thu, Dec 7, 2023 at 1:24 PM Mike Maslenkin
> wr
"that that"
removed variable declaration in block scope
added patches 10-13
removed unnecessary casts
added checks for memory allocation result
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You r
PlatformHostInterfaceBmcUsbNicLib is the library instance name not
the class name.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../PlatformHostInterfaceBmcUsbNicLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion
RedfishPlatformCredentialIpmiLib is the library instance name not the
class name.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishPlatformCredentialIpmiLib.inf| 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
hat also seems based on a header mentioned above.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishPkg/Include/Library/RedfishCrtLib.h | 45 ++
1 file changed, 11 insertions(+), 34 deletions(-)
diff --git a/RedfishPkg/Include/L
ff-by: Mike Maslenkin
---
.../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c
index cbc65ba
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
b/RedfishPkg
Currently there is no description for RedfishConfigHandler driver.
This leads to in the "DRIVER NAME" column of a `drivers`
command for example.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishConfigHandler/ComponentName.c
All fields of IPMI_CHANNEL_INFO_CHANNEL_NUMBER union must be
initialized to avoid error condition on BMC side.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../PlatformHostInterfaceBmcUsbNicLib.c | 8 +---
1 file changed, 5
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
EmulatorPkg/EmulatorPkg.dec | 8
.../RedfishPlatformCredentialLib.c | 12 ++--
.../RedfishPlatformCredentialLib.inf | 8
3 files changed, 14
Cc: Abner Chang
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
.../RedfishPlatformHostInterfaceLib.c | 2 --
1 file changed, 2 deletions(-)
diff --git
a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostInterfaceLib.c
b/EmulatorPkg/Library
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 108 --
1 file changed, 74 insertions(+), 34 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
b/RedfishPkg
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Pedro Falcato
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 36 +--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
Cache size of ASCII string in local variable.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 34 ---
1 file changed, 21 insertions(+), 13 deletions(-)
diff --git a/RedfishPkg
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 85 ---
1 file changed, 75 insertions(+), 10 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
b/RedfishPkg
es, the IP address must be specified
in brackets, i.e. the resulting string should look like:
"http{,s}://[X::X:X:X:X]/".
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 21 ---
This patch set contains minor fixes and the one major change related
to BIOS resources provisioning.
PR: https://github.com/tianocore/edk2-redfish-client/pull/64
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links
Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
b/RedfishClientPkg/Features
n [-Werror=maybe-uninitialized]
*Location = StrAsciiToUnicode (AsciiLocation);
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c| 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
dif
: Nickle Wang
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
ethod is not used anywhere in RedfishClientPkg/Features/Bios
and "PUT back to instance" actually performs the PATCH.
I will drop this patch from the current PR until it becomes clear how this can
be improved.
Regards,
Mike.
>
>> -Original Message-
>> From: Mike Masl
> On 18. 12. 2023., at 03:33, Mike Maslenkin via groups.io
> wrote:
>
>
> Hi Nickle,
>
>> On 15. 12. 2023., at 04:53, Nickle Wang > <mailto:nick...@nvidia.com>> wrote:
>>
>> Hi Mike,
>>
>> Per Redfish specification 7.9 POST(c
This patch set contains minor fixes.
diff from v1:
original patch 4/4 with change related to BIOS resources provisioning removed.
PR: https://github.com/tianocore/edk2-redfish-client/pull/64
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
Abner Chang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Nickle Wang
---
.../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility
Cc: Abner Chang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Nickle Wang
---
RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
b/RedfishClientPkg
n [-Werror=maybe-uninitialized]
*Location = StrAsciiToUnicode (AsciiLocation);
Cc: Abner Chang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Nickle Wang
---
.../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c| 3 ++-
1 file changed, 2 insertions(+), 1 deletio
Hi Abner,
On Mon, Dec 18, 2023 at 7:47 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> > -Original Message-
> > From: Mike Maslenkin
> > Sent: Friday, December 15, 2023 7:25 AM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner
copyright
> that follow below format on the later patches you send; as you use the
> individual contributor copyright.
>
> Copyright (c) FIRST - LAST, Contributor
>
> Thanks
> Abner
>
> > -Original Message-
> > From: Mike Maslenkin
> > Sent
Hi Abner,
On Mon, Dec 18, 2023 at 7:58 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> > -Original Message-
> > From: Mike Maslenkin
> > Sent: Friday, December 15, 2023 7:25 AM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner
/pull/64
Cc: Abner Chang
Cc: Igor Kulchytskyy
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#112848): https://edk2.groups.io/g/devel/message/112848
Mute This Topic: https://groups.
Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Nickle Wang
Reviewed-by: Abner Chang
---
.../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
a/RedfishClientPkg/Library/RedfishFeatureUtili
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Nickle Wang
Reviewed-by: Abner Chang
---
RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
b
n [-Werror=maybe-uninitialized]
*Location = StrAsciiToUnicode (AsciiLocation);
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Nickle Wang
Reviewed-by: Abner Chang
---
.../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c| 3 ++-
1 file changed, 2 insertions(+),
le in the last patch
diff from v1:
fixed typo double "that that"
removed variable declaration in block scope
added patches 10-13
removed unnecessary casts
added checks for memory allocation result
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by:
PlatformHostInterfaceBmcUsbNicLib is the library instance name not
the class name.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../PlatformHostInterfaceBmcUsbNicLib.inf | 2 +-
1 file changed, 1 insertion(+), 1
RedfishPlatformCredentialIpmiLib is the library instance name not the
class name.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../RedfishPlatformCredentialIpmiLib.inf| 2 +-
1 file changed, 1 insertion(+), 1 deletion
hat also seems based on a header mentioned above.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
RedfishPkg/Include/Library/RedfishCrtLib.h | 45 ++
1 file changed, 11 insertions(+), 34 deletions(-)
diff --git a/R
It's unclear why the new string is allocated as copy of the original
string if its pointer is stored in an array and the original string
is released immediately after the copy is created. All data allocated
in the same pool.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Masl
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
b/RedfishPkg
Currently there is no description for RedfishConfigHandler driver.
This leads to in the "DRIVER NAME" column of a `drivers`
command for example.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishConfigHandler/ComponentName.c
All fields of IPMI_CHANNEL_INFO_CHANNEL_NUMBER union must be
initialized to avoid error condition on BMC side.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../PlatformHostInterfaceBmcUsbNicLib.c | 8 +---
1 file
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
EmulatorPkg/EmulatorPkg.dec | 8
.../RedfishPlatformCredentialLib.c | 12 ++--
.../RedfishPlatformCredentialLib.inf | 8
3 files
Cc: Nickle Wang
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../RedfishPlatformHostInterfaceLib.c | 2 --
1 file changed, 2 deletions(-)
diff --git
a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostInterfaceLib.c
b/EmulatorPkg
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 108 --
1 file changed, 74 insertions(+), 34 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
b/RedfishPkg
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Cc: Pedro Falcato
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 36 +--
1 file changed, 18 insertions(+), 18 deletions(-)
diff --git a/RedfishPkg/RedfishDiscoverDxe
It is required to free previously allocated strings stored in
DiscoveredInstance->Information structure.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 2 ++
1 file changed, 2 insertions(+)
d
This patch adds a handy helper function deallocating resources from the
EFI_REDFISH_DISCOVERED_INFORMATION structure instance.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 68 ---
1 file
es, the IP address must be specified
in brackets, i.e. the resulting string should look like:
"http{,s}://[X::X:X:X:X]/".
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 17 +++--
Cache size of ASCII string in local variable.
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Reviewed-by: Abner Chang
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 34 ---
1 file changed, 21 insertions(+), 13 deletions(-)
diff --git a/RedfishPkg
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4625
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
.../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 89 ---
1 file changed, 78 insertions(+), 11 deletions(-)
diff --git a/RedfishPkg
set it.
>
> Thanks
> Abner
>
> > -Original Message-
> > From: Mike Maslenkin
> > Sent: Monday, December 25, 2023 6:59 AM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner ; nick...@nvidia.com;
> > ig...@ami.com; Mike Maslenkin
&
Variable 'Status' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
Signed-off-by: Mike Maslenkin
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
---
RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 1 +
1 file changed, 1 insertion(+)
di
r Chang
>
> Add PCD to disable ETag capability for the case Redfish
> service doesn't support ETag.
>
> Signed-off-by: Abner Chang
> Cc: Nickle Wang
> Cc: Igor Kulchytskyy
> Cc: Mike Maslenkin
> ---
> RedfishClientPkg/RedfishClientPkg.dec | 2 +
y the question?
>
> Thanks
> Abner
>
> > -Original Message-
> > From: Mike Maslenkin
> > Sent: Friday, January 5, 2024 8:20 AM
> > To: devel@edk2.groups.io; Chang, Abner
> > Cc: Nickle Wang ; Igor Kulchytskyy
> > Subject: Re: [edk2-devel] [edk2-redfis
emset(), memcpy() and memchr().
>
> Signed-off-by: Nickle Wang
> Cc: Abner Chang
> Cc: Igor Kulchytskyy
> Cc: Nick Ramirez
> Cc: Mike Maslenkin
> ---
> RedfishPkg/Include/Library/RedfishCrtLib.h | 81 +-
> 1 file changed, 1 insertion(+), 80 deleti
On Mon, Oct 2, 2023 at 5:56 AM Chang, Abner wrote:
>
> [AMD Official Use Only - General]
>
> > -Original Message-
> > From: Mike Maslenkin
> > Sent: Saturday, September 30, 2023 5:59 AM
> > To: devel@edk2.groups.io
> > Cc: Chang, Abner ; nick
This patchset contains fixes of wrong format and number of arguments
passed to DEBUG macro.
Also a number of memory leaks were fixed.
Here is a link to PR:
https://github.com/tianocore/edk2-redfish-client/pull/52
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c
index
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureUtilityLib.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git
a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
b/RedfishClientPkg/Library
Memory allocated by calloc() is filled with bytes of value zero.
Signed-off-by: Mike Maslenkin
---
.../PrivateLibrary/RedfishLib/edk2libredfish/src/service.c | 1 -
1 file changed, 1 deletion(-)
diff --git
a/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c
b
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureUtilityLib.c| 30 +++
1 file changed, 30 insertions(+)
diff --git
a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
b/RedfishClientPkg/Library/RedfishFeatureUtilityLib
This functions contain memory leaks.
Less identation helps to solve this issues.
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureUtilityLib.c| 289 +-
1 file changed, 146 insertions(+), 143 deletions(-)
diff --git
a/RedfishClientPkg/Library
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureUtilityLib.c| 11 +++
1 file changed, 11 insertions(+)
diff --git
a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c
b/RedfishClientPkg/Library/RedfishFeatureUtilityLib
This patch fixes leak in RedfishExternalResourceResourceFeatureCallback
function.
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c
b/RedfishClientPkg
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h
b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h
index
StrnCpyS accepts string length in characters, not in bytes.
Signed-off-by: Mike Maslenkin
---
RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
b
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
Signed-off-by: Mike Maslenkin
---
.../RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c
index
On Wed, Oct 25, 2023 at 3:40 PM Nickle Wang wrote:
>
> > double declaration of 'strcpy' is still there.
>
> Thanks for catching this, Mike. Version 2 patch file was sent.
>
> Regards,
> Nickle
Hello, Nickle
v2 is good enough, but it can be improved a bit.
Since the definitions in this header fi
r(), strcasecmp(), strstr(), memcmp(), memset(),
> memcpy(), memchr(), memcmp() and memmove().
>
> Signed-off-by: Nickle Wang
> Cc: Abner Chang
> Cc: Igor Kulchytskyy
> Cc: Nick Ramirez
> Cc: Mike Maslenkin
> Reviewed-by: Abner Chang
> ---
> Red
Hi Igor
please find my comments below.
On Tue, Oct 31, 2023 at 8:56 PM Igor Kulchytskyy via groups.io
wrote:
>
> Supported function of the driver changed to wait for all newtwork
> interface to be installed.
> Filer out the network interfaces which are not supported by
> Redfish Host Interface.
On Tue, Oct 31, 2023 at 7:52 PM Henz, Patrick wrote:
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4578
>
> The implementation of XhcGetElapsedTicks did not account for
> non-zero start and stop values for the performance counter
> timer, potentially resulting in an incorrect elapsed tick
On Wed, Nov 1, 2023 at 6:24 AM Igor Kulchytskyy wrote:
>
> Hi Mike,
> Thank you for review.
> Please see my answers below the text.
>
> -Original Message-
> From: Mike Maslenkin
> Sent: Tuesday, October 31, 2023 9:00 PM
> To: devel@edk2.groups.io; Igor Kul
On Wed, Nov 1, 2023 at 11:17 PM Igor Kulchytskyy wrote:
>
> Supported function of the driver changed to wait for all newtwork
> interface to be installed.
> Filer out the network interfaces which are not supported by
> Redfish Host Interface.
>
> Cc: Abner Chang
> Cc:
Hi Igor
I want to return to my initial comments regarding this patch.
Please, find my comments below.
> On 1. 11. 2023., at 06:24, Igor Kulchytskyy wrote:
>
> Hi Mike,
> Thank you for review.
> Please see my answers below the text.
>
> -Original Message-
&
> On 7. 11. 2023., at 15:06, Igor Kulchytskyy via groups.io
> wrote:
>
> Supported function of the driver changed to wait for all newtwork
> interface to be installed.
> Filer out the network interfaces which are not supported by
> Redfish Host Interface.
>
> Cc: Abner Chang
> Cc: Nickle Wa
On Tue, Nov 14, 2023 at 9:57 PM Igor Kulchytskyy via groups.io
wrote:
>
> Hi Leif,
> Please see my comments below.
> Thank you,
> Igor
>
>
> -Original Message-
> From: Leif Lindholm
> Sent: Tuesday, November 14, 2023 12:26 PM
> To: devel@edk2.groups.io; Igor Kulchytskyy
> Cc: Abner Chang
On Wed, Nov 15, 2023 at 4:52 PM Igor Kulchytskyy wrote:
>
> Hello Leif and Mike,
> Let me try to explain the idea of the filtering IP.
> That filtering should work only if we know exactly that IP is IPv4 or IPv6 in
> SMBIOS Type 42.
Hm. I've already composed a reply below, but then a returned to
sTcpTypeMatch() gives TRUE and we skip this iteration.
Effectively this means
if (IpType == REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_UNKNOWN ) {
return EFI_DEVICE_ERROR
}
Just because there is nothing after this loop.
And this is not what we wanted, and recognized as my mistake previously.
This patch series involves the following changes:
1. fix memory leak and add explicit variable initialization in HiiUtilityLib
2. fix MAC address comparison during USB NIC discovering.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c
b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c
'ConfigAccess' may be used uninitialized in this function
[-Werror=maybe-uninitialized]
if (ConfigAccess != NULL) {
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c | 1 +
1 file chan
According to RedfishPkg/Readme.md document:
"The last byte of host-end USB NIC MAC address is the last byte of
BMC-end USB NIC MAC address minus 1."
It is necessary to subtract 1 from IpmiLanChannelMacAddress.
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike
v2:
removed --transfer-encoding=base64 from `git send-email` command line
as it has broken patch format as I can see from the mailing list.
v1:
This patch series involves the following changes:
1. fix memory leak and add explicit variable initialization in HiiUtilityLib
2. fix MAC addres
Cc: Abner Chang
Cc: Nickle Wang
Cc: Igor Kulchytskyy
Signed-off-by: Mike Maslenkin
---
RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c
b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c
1 - 100 of 236 matches
Mail list logo