Re: [edk2-devel] [PATCH 1/1] OvmfPkg/VirtNorFlashDxe: sanity-check variables

2023-12-06 Thread Mike Maslenkin
Hi Gerd, On Tue, Dec 5, 2023 at 4:51 PM Gerd Hoffmann wrote: > > Extend the ValidateFvHeader function, additionally to the header checks > walk over the list of variables and sanity check them. > > In case we find inconsistencies indicating variable store corruption > return EFI_NOT_FOUND so the

[edk2-devel] [RFC PATCH] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses

2023-12-07 Thread Mike Maslenkin
es, the IP address must be specified in brackets, i.e. the resulting string should look like: "http{,s}://[X::X:X:X:X]/". Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 20 ---

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishDicovery: Remedy Redfish service discovery flow

2023-12-07 Thread Mike Maslenkin
ubnet > information so they can know the network domain the NIC is > connected. There may have multiple subnets in the corporation > network environment. So the subnet information provides client > an idea when they choose the network interface, so does VLAN ID. > > Signed-off-b

[edk2-devel] [PATCH 0/9] Redfish related fixes and improvements

2023-12-12 Thread Mike Maslenkin
coverDxe.c | 8 +- RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 4 +- 14 files changed, 265 insertions(+), 65 deletions(-) Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike

[edk2-devel] [PATCH 1/9] RedfishPkg: fix RedfishPlatformHostInterfaceLib library class name typo.

2023-12-12 Thread Mike Maslenkin
PlatformHostInterfaceBmcUsbNicLib is the library instance name not the class name. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../PlatformHostInterfaceBmcUsbNicLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[edk2-devel] [PATCH 2/9] RedfishPkg: fix RedfishPlatformCredentialLib library class name typo.

2023-12-12 Thread Mike Maslenkin
RedfishPlatformCredentialIpmiLib is the library instance name not the class name. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishPlatformCredentialIpmiLib.inf| 2 +- 1 file changed, 1 insertion(+), 1 deletion

[edk2-devel] [PATCH 3/9] RedfishPkg: get rid of unused definitions from RedfishCrtLib.h

2023-12-12 Thread Mike Maslenkin
hat also seems based on a header mentioned above. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishPkg/Include/Library/RedfishCrtLib.h | 45 ++ 1 file changed, 11 insertions(+), 34 deletions(-) diff --git a/RedfishPkg/Include/L

[edk2-devel] [PATCH 4/9] RedfishPkg: RedfishPlatformConfigDxe: reduce memory allocations

2023-12-12 Thread Mike Maslenkin
ff-by: Mike Maslenkin --- .../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c index cbc65ba

[edk2-devel] [PATCH 5/9] RedfishPkg: RedfishDiscoverDxe: fix memory leak on error path.

2023-12-12 Thread Mike Maslenkin
Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPkg

[edk2-devel] [PATCH 6/9] RedfishPkg: add Component Name protocols to RedfishConfigHandler driver

2023-12-12 Thread Mike Maslenkin
Currently there is no description for RedfishConfigHandler driver. This leads to in the "DRIVER NAME" column of a `drivers` command for example. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishConfigHandler/ComponentName.c

[edk2-devel] [PATCH 7/9] RedfishPkg: add proper initialization of IPMI request

2023-12-12 Thread Mike Maslenkin
All fields of IPMI_CHANNEL_INFO_CHANNEL_NUMBER union must be initialized to avoid error condition on BMC side. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../PlatformHostInterfaceBmcUsbNicLib.c | 8 +--- 1 file changed, 5

[edk2-devel] [PATCH 8/9] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService

2023-12-12 Thread Mike Maslenkin
Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Mike Maslenkin --- EmulatorPkg/EmulatorPkg.dec | 8 .../RedfishPlatformCredentialLib.c | 12 ++-- .../RedfishPlatformCredentialLib.inf | 8 3 files changed, 14

[edk2-devel] [PATCH 9/9] EmulatorPkg: RedfishPlatformHostInterfaceLib: get rid of unused variable

2023-12-12 Thread Mike Maslenkin
Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Mike Maslenkin --- .../RedfishPlatformHostInterfaceLib.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostInterfaceLib.c b/EmulatorPkg/Library

Re: [edk2-devel] [PATCH V2] RedfishPkg/RedfishDicovery: Remedy Redfish service discovery flow

2023-12-12 Thread Mike Maslenkin
now the network domain the NIC is > connected. There may have multiple subnets in the corporation > network environment. So the subnet information provides client > an idea when they choose the network interface, so does VLAN ID. > > Change-Id: Ibb38ddcd17459ad4b23fcb4fcd

Re: [edk2-devel] [RFC PATCH] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses

2023-12-13 Thread Mike Maslenkin
Fair. I'll try to make some cleanups before applying this patch after committing Abner's remedy patch https://github.com/tianocore/edk2/pull/5139. Regards, Mike.. On Wed, Dec 13, 2023 at 4:15 PM Pedro Falcato wrote: > > On Thu, Dec 7, 2023 at 1:24 PM Mike Maslenkin > wr

[edk2-devel] [PATCH v2 0/14] Redfish related fixes and improvements

2023-12-14 Thread Mike Maslenkin
"that that" removed variable declaration in block scope added patches 10-13 removed unnecessary casts added checks for memory allocation result Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You r

[edk2-devel] [PATCH v2 01/14] RedfishPkg: fix RedfishPlatformHostInterfaceLib library class name typo.

2023-12-14 Thread Mike Maslenkin
PlatformHostInterfaceBmcUsbNicLib is the library instance name not the class name. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../PlatformHostInterfaceBmcUsbNicLib.inf | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[edk2-devel] [PATCH v2 02/14] RedfishPkg: fix RedfishPlatformCredentialLib library class name typo.

2023-12-14 Thread Mike Maslenkin
RedfishPlatformCredentialIpmiLib is the library instance name not the class name. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishPlatformCredentialIpmiLib.inf| 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[edk2-devel] [PATCH v2 03/14] RedfishPkg: get rid of unused definitions from RedfishCrtLib.h

2023-12-14 Thread Mike Maslenkin
hat also seems based on a header mentioned above. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishPkg/Include/Library/RedfishCrtLib.h | 45 ++ 1 file changed, 11 insertions(+), 34 deletions(-) diff --git a/RedfishPkg/Include/L

[edk2-devel] [PATCH v2 04/14] RedfishPkg: RedfishPlatformConfigDxe: reduce memory allocations

2023-12-14 Thread Mike Maslenkin
ff-by: Mike Maslenkin --- .../RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c b/RedfishPkg/RedfishPlatformConfigDxe/RedfishPlatformConfigDxe.c index cbc65ba

[edk2-devel] [PATCH v2 05/14] RedfishPkg: RedfishDiscoverDxe: fix memory leak on error path.

2023-12-14 Thread Mike Maslenkin
Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPkg

[edk2-devel] [PATCH v2 06/14] RedfishPkg: add Component Name protocols to RedfishConfigHandler driver

2023-12-14 Thread Mike Maslenkin
Currently there is no description for RedfishConfigHandler driver. This leads to in the "DRIVER NAME" column of a `drivers` command for example. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishConfigHandler/ComponentName.c

[edk2-devel] [PATCH v2 07/14] RedfishPkg: add proper initialization of IPMI request

2023-12-14 Thread Mike Maslenkin
All fields of IPMI_CHANNEL_INFO_CHANNEL_NUMBER union must be initialized to avoid error condition on BMC side. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../PlatformHostInterfaceBmcUsbNicLib.c | 8 +--- 1 file changed, 5

[edk2-devel] [PATCH v2 08/14] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService

2023-12-14 Thread Mike Maslenkin
Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Mike Maslenkin --- EmulatorPkg/EmulatorPkg.dec | 8 .../RedfishPlatformCredentialLib.c | 12 ++-- .../RedfishPlatformCredentialLib.inf | 8 3 files changed, 14

[edk2-devel] [PATCH v2 09/14] EmulatorPkg: RedfishPlatformHostInterfaceLib: get rid of unused variable

2023-12-14 Thread Mike Maslenkin
Cc: Abner Chang Cc: Nickle Wang Signed-off-by: Mike Maslenkin --- .../RedfishPlatformHostInterfaceLib.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostInterfaceLib.c b/EmulatorPkg/Library

[edk2-devel] [PATCH v2 10/14] RedfishDiscoverDxe: introduce InitInformationData helper function

2023-12-14 Thread Mike Maslenkin
Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 108 -- 1 file changed, 74 insertions(+), 34 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPkg

[edk2-devel] [PATCH v2 11/14] RedfishDiscoverDxe: refine InitInformationData(), remove unnecessary casts

2023-12-14 Thread Mike Maslenkin
Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Pedro Falcato Signed-off-by: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 36 +-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c

[edk2-devel] [PATCH v2 12/14] RedfishDiscoverDxe: refine InitInformationData() function

2023-12-14 Thread Mike Maslenkin
Cache size of ASCII string in local variable. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 34 --- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/RedfishPkg

[edk2-devel] [PATCH v2 13/14] RedfishDiscoverDxe: handle memory allocation error conditions.

2023-12-14 Thread Mike Maslenkin
Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 85 --- 1 file changed, 75 insertions(+), 10 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPkg

[edk2-devel] [PATCH v2 14/14] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses

2023-12-14 Thread Mike Maslenkin
es, the IP address must be specified in brackets, i.e. the resulting string should look like: "http{,s}://[X::X:X:X:X]/". Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 21 ---

[edk2-devel] [edk2-redfish-client][PATCH 0/4] change method for provisioning + minor fixes

2023-12-14 Thread Mike Maslenkin
This patch set contains minor fixes and the one major change related to BIOS resources provisioning. PR: https://github.com/tianocore/edk2-redfish-client/pull/64 Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links

[edk2-devel] [edk2-redfish-client][PATCH 1/4] RedfishClientPkg: add check for NULL pointer to avoid ASSERT

2023-12-14 Thread Mike Maslenkin
Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib

[edk2-devel] [edk2-redfish-client][PATCH 2/4] RedfishClientPkg: fix typo in EfiRestJsonStructureProtocolIsReady

2023-12-14 Thread Mike Maslenkin
Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b/RedfishClientPkg/Features

[edk2-devel] [edk2-redfish-client][PATCH 3/4] RedfishClientPkg: fix access to unitialized variable.

2023-12-14 Thread Mike Maslenkin
n [-Werror=maybe-uninitialized] *Location = StrAsciiToUnicode (AsciiLocation); Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c| 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) dif

[edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg: use POST method while provisioning new property.

2023-12-14 Thread Mike Maslenkin
: Nickle Wang Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c

Re: [edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg: use POST method while provisioning new property.

2023-12-17 Thread Mike Maslenkin
ethod is not used anywhere in RedfishClientPkg/Features/Bios and "PUT back to instance" actually performs the PATCH. I will drop this patch from the current PR until it becomes clear how this can be improved. Regards, Mike. > >> -Original Message- >> From: Mike Masl

Re: [edk2-devel] [edk2-redfish-client][PATCH 4/4] RedfishClientPkg: use POST method while provisioning new property.

2023-12-17 Thread Mike Maslenkin
> On 18. 12. 2023., at 03:33, Mike Maslenkin via groups.io > wrote: > > > Hi Nickle, > >> On 15. 12. 2023., at 04:53, Nickle Wang > <mailto:nick...@nvidia.com>> wrote: >> >> Hi Mike, >> >> Per Redfish specification 7.9 POST(c

[edk2-devel] [edk2-redfish-client][PATCH v2 0/3] change method for provisioning + minor fixes

2023-12-18 Thread Mike Maslenkin
This patch set contains minor fixes. diff from v1: original patch 4/4 with change related to BIOS resources provisioning removed. PR: https://github.com/tianocore/edk2-redfish-client/pull/64 Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin

[edk2-devel] [edk2-redfish-client][PATCH v2 1/3] RedfishClientPkg: add check for NULL pointer to avoid ASSERT

2023-12-18 Thread Mike Maslenkin
Abner Chang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang --- .../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtility

[edk2-devel] [edk2-redfish-client][PATCH v2 2/3] RedfishClientPkg: fix typo in EfiRestJsonStructureProtocolIsReady

2023-12-18 Thread Mike Maslenkin
Cc: Abner Chang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b/RedfishClientPkg

[edk2-devel] [edk2-redfish-client][PATCH v2 3/3] RedfishClientPkg: fix access to unitialized variable.

2023-12-18 Thread Mike Maslenkin
n [-Werror=maybe-uninitialized] *Location = StrAsciiToUnicode (AsciiLocation); Cc: Abner Chang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang --- .../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c| 3 ++- 1 file changed, 2 insertions(+), 1 deletio

Re: [edk2-devel] [PATCH v2 13/14] RedfishDiscoverDxe: handle memory allocation error conditions.

2023-12-18 Thread Mike Maslenkin
Hi Abner, On Mon, Dec 18, 2023 at 7:47 AM Chang, Abner wrote: > > [AMD Official Use Only - General] > > > -Original Message- > > From: Mike Maslenkin > > Sent: Friday, December 15, 2023 7:25 AM > > To: devel@edk2.groups.io > > Cc: Chang, Abner

Re: [edk2-devel] [edk2-redfish-client][PATCH v2 0/3] change method for provisioning + minor fixes

2023-12-18 Thread Mike Maslenkin
copyright > that follow below format on the later patches you send; as you use the > individual contributor copyright. > > Copyright (c) FIRST - LAST, Contributor > > Thanks > Abner > > > -Original Message- > > From: Mike Maslenkin > > Sent

Re: [edk2-devel] [PATCH v2 14/14] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses

2023-12-18 Thread Mike Maslenkin
Hi Abner, On Mon, Dec 18, 2023 at 7:58 AM Chang, Abner wrote: > > [AMD Official Use Only - General] > > > -Original Message- > > From: Mike Maslenkin > > Sent: Friday, December 15, 2023 7:25 AM > > To: devel@edk2.groups.io > > Cc: Chang, Abner

[edk2-devel] [edk2-redfish-client][PATCH v3 0/3] change method for provisioning + minor fixes

2023-12-22 Thread Mike Maslenkin
/pull/64 Cc: Abner Chang Cc: Igor Kulchytskyy Cc: Nickle Wang Signed-off-by: Mike Maslenkin -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#112848): https://edk2.groups.io/g/devel/message/112848 Mute This Topic: https://groups.

[edk2-devel] [edk2-redfish-client][PATCH v3 1/3] RedfishClientPkg: add check for NULL pointer to avoid ASSERT

2023-12-22 Thread Mike Maslenkin
Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang Reviewed-by: Abner Chang --- .../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtili

[edk2-devel] [edk2-redfish-client][PATCH v3 2/3] RedfishClientPkg: fix typo in EfiRestJsonStructureProtocolIsReady

2023-12-22 Thread Mike Maslenkin
Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang Reviewed-by: Abner Chang --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b

[edk2-devel] [edk2-redfish-client][PATCH v3 3/3] RedfishClientPkg: fix access to unitialized variable.

2023-12-22 Thread Mike Maslenkin
n [-Werror=maybe-uninitialized] *Location = StrAsciiToUnicode (AsciiLocation); Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Nickle Wang Reviewed-by: Abner Chang --- .../RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c| 3 ++- 1 file changed, 2 insertions(+),

[edk2-devel] [PATCH v3 0/16] Redfish related fixes and improvements

2023-12-24 Thread Mike Maslenkin
le in the last patch diff from v1: fixed typo double "that that" removed variable declaration in block scope added patches 10-13 removed unnecessary casts added checks for memory allocation result Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by:

[edk2-devel] [PATCH v3 01/16] RedfishPkg: fix RedfishPlatformHostInterfaceLib library class name typo.

2023-12-24 Thread Mike Maslenkin
PlatformHostInterfaceBmcUsbNicLib is the library instance name not the class name. Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- .../PlatformHostInterfaceBmcUsbNicLib.inf | 2 +- 1 file changed, 1 insertion(+), 1

[edk2-devel] [PATCH v3 02/16] RedfishPkg: fix RedfishPlatformCredentialLib library class name typo.

2023-12-24 Thread Mike Maslenkin
RedfishPlatformCredentialIpmiLib is the library instance name not the class name. Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- .../RedfishPlatformCredentialIpmiLib.inf| 2 +- 1 file changed, 1 insertion(+), 1 deletion

[edk2-devel] [PATCH v3 03/16] RedfishPkg: get rid of unused definitions from RedfishCrtLib.h

2023-12-24 Thread Mike Maslenkin
hat also seems based on a header mentioned above. Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- RedfishPkg/Include/Library/RedfishCrtLib.h | 45 ++ 1 file changed, 11 insertions(+), 34 deletions(-) diff --git a/R

[edk2-devel] [PATCH v3 04/16] RedfishPkg: RedfishPlatformConfigDxe: reduce memory allocations

2023-12-24 Thread Mike Maslenkin
It's unclear why the new string is allocated as copy of the original string if its pointer is stored in an array and the original string is released immediately after the copy is created. All data allocated in the same pool. Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Masl

[edk2-devel] [PATCH v3 05/16] RedfishPkg: RedfishDiscoverDxe: fix memory leak on error path.

2023-12-24 Thread Mike Maslenkin
Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPkg

[edk2-devel] [PATCH v3 06/16] RedfishPkg: add Component Name protocols to RedfishConfigHandler driver

2023-12-24 Thread Mike Maslenkin
Currently there is no description for RedfishConfigHandler driver. This leads to in the "DRIVER NAME" column of a `drivers` command for example. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishConfigHandler/ComponentName.c

[edk2-devel] [PATCH v3 07/16] RedfishPkg: add proper initialization of IPMI request

2023-12-24 Thread Mike Maslenkin
All fields of IPMI_CHANNEL_INFO_CHANNEL_NUMBER union must be initialized to avoid error condition on BMC side. Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- .../PlatformHostInterfaceBmcUsbNicLib.c | 8 +--- 1 file

[edk2-devel] [PATCH v3 08/16] EmulatorPkg: fix typo. PcdRedfishServie -> PcdRedfishService

2023-12-24 Thread Mike Maslenkin
Cc: Nickle Wang Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- EmulatorPkg/EmulatorPkg.dec | 8 .../RedfishPlatformCredentialLib.c | 12 ++-- .../RedfishPlatformCredentialLib.inf | 8 3 files

[edk2-devel] [PATCH v3 09/16] EmulatorPkg: RedfishPlatformHostInterfaceLib: get rid of unused variable

2023-12-24 Thread Mike Maslenkin
Cc: Nickle Wang Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- .../RedfishPlatformHostInterfaceLib.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/EmulatorPkg/Library/RedfishPlatformHostInterfaceLib/RedfishPlatformHostInterfaceLib.c b/EmulatorPkg

[edk2-devel] [PATCH v3 10/16] RedfishDiscoverDxe: introduce InitInformationData helper function

2023-12-24 Thread Mike Maslenkin
Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 108 -- 1 file changed, 74 insertions(+), 34 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c b/RedfishPkg

[edk2-devel] [PATCH v3 11/16] RedfishDiscoverDxe: refine InitInformationData(), remove unnecessary casts

2023-12-24 Thread Mike Maslenkin
Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Pedro Falcato Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 36 +-- 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/RedfishPkg/RedfishDiscoverDxe

[edk2-devel] [PATCH v3 14/16] RedfishDiscoverDxe: release resources when refreshing information data

2023-12-24 Thread Mike Maslenkin
It is required to free previously allocated strings stored in DiscoveredInstance->Information structure. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c | 2 ++ 1 file changed, 2 insertions(+) d

[edk2-devel] [PATCH v3 13/16] RedfishDiscoverDxe: add a helper function deallocating string resources.

2023-12-24 Thread Mike Maslenkin
This patch adds a handy helper function deallocating resources from the EFI_REDFISH_DISCOVERED_INFORMATION structure instance. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 68 --- 1 file

[edk2-devel] [PATCH v3 16/16] RedfishPkg: RedfishDiscoverDxe: add [] brackets to URI for IPv6 addresses

2023-12-24 Thread Mike Maslenkin
es, the IP address must be specified in brackets, i.e. the resulting string should look like: "http{,s}://[X::X:X:X:X]/". Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 17 +++--

[edk2-devel] [PATCH v3 12/16] RedfishDiscoverDxe: refine InitInformationData() function

2023-12-24 Thread Mike Maslenkin
Cache size of ASCII string in local variable. Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin Reviewed-by: Abner Chang --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 34 --- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/RedfishPkg

[edk2-devel] [PATCH v3 15/16] RedfishDiscoverDxe: handle memory allocation error conditions.

2023-12-24 Thread Mike Maslenkin
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4625 Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- .../RedfishDiscoverDxe/RedfishDiscoverDxe.c | 89 --- 1 file changed, 78 insertions(+), 11 deletions(-) diff --git a/RedfishPkg

Re: [edk2-devel] [PATCH v3 0/16] Redfish related fixes and improvements

2023-12-26 Thread Mike Maslenkin
set it. > > Thanks > Abner > > > -Original Message- > > From: Mike Maslenkin > > Sent: Monday, December 25, 2023 6:59 AM > > To: devel@edk2.groups.io > > Cc: Chang, Abner ; nick...@nvidia.com; > > ig...@ami.com; Mike Maslenkin &

[edk2-devel] [PATCH] RedfishClientPkg: fix uninitialized variable build error

2024-01-04 Thread Mike Maslenkin
Variable 'Status' may be used uninitialized in this function [-Werror=maybe-uninitialized] Signed-off-by: Mike Maslenkin Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy --- RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 1 + 1 file changed, 1 insertion(+) di

Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg: Add ETag PCD and revise Redfish ETag functions

2024-01-04 Thread Mike Maslenkin
r Chang > > Add PCD to disable ETag capability for the case Redfish > service doesn't support ETag. > > Signed-off-by: Abner Chang > Cc: Nickle Wang > Cc: Igor Kulchytskyy > Cc: Mike Maslenkin > --- > RedfishClientPkg/RedfishClientPkg.dec | 2 +

Re: [edk2-devel] [edk2-redfish-client][PATCH V2] RedfishClientPkg: Add ETag PCD and revise Redfish ETag functions

2024-01-05 Thread Mike Maslenkin
y the question? > > Thanks > Abner > > > -Original Message- > > From: Mike Maslenkin > > Sent: Friday, January 5, 2024 8:20 AM > > To: devel@edk2.groups.io; Chang, Abner > > Cc: Nickle Wang ; Igor Kulchytskyy > > Subject: Re: [edk2-devel] [edk2-redfis

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: remove multiple definitions.

2023-10-23 Thread Mike Maslenkin
emset(), memcpy() and memchr(). > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > Cc: Mike Maslenkin > --- > RedfishPkg/Include/Library/RedfishCrtLib.h | 81 +- > 1 file changed, 1 insertion(+), 80 deleti

Re: [edk2-devel] [PATCH 9/9] RedfishClientPkg: fix StrnCpyS arguments

2023-10-26 Thread Mike Maslenkin
On Mon, Oct 2, 2023 at 5:56 AM Chang, Abner wrote: > > [AMD Official Use Only - General] > > > -Original Message- > > From: Mike Maslenkin > > Sent: Saturday, September 30, 2023 5:59 AM > > To: devel@edk2.groups.io > > Cc: Chang, Abner ; nick

[edk2-devel] [edk2-redfish-client][PATCH v2 0/11] RedfishClientPkg: various minor fixes

2023-10-26 Thread Mike Maslenkin
This patchset contains fixes of wrong format and number of arguments passed to DEBUG macro. Also a number of memory leaks were fixed. Here is a link to PR: https://github.com/tianocore/edk2-redfish-client/pull/52 Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike

[edk2-devel] [edk2-redfish-client][PATCH v2 01/11] RedfishClientPkg: fix format used for output __func__

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c index

[edk2-devel] [edk2-redfish-client][PATCH v2 02/11] RedfishClientPkg: fix DEBUG macro arguments

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c b/RedfishClientPkg/Library

[edk2-devel] [edk2-redfish-client][PATCH v2 03/11] RedfishLib: remove redudant zeroing

2023-10-26 Thread Mike Maslenkin
Memory allocated by calloc() is filled with bytes of value zero. Signed-off-by: Mike Maslenkin --- .../PrivateLibrary/RedfishLib/edk2libredfish/src/service.c | 1 - 1 file changed, 1 deletion(-) diff --git a/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c b

[edk2-devel] [edk2-redfish-client][PATCH v2 04/11] RedfishClientPkg: RedfishFeatureUtilityLib: fix memory leaks

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib.c| 30 +++ 1 file changed, 30 insertions(+) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c b/RedfishClientPkg/Library/RedfishFeatureUtilityLib

[edk2-devel] [edk2-redfish-client][PATCH v2 05/11] RedfishClientPkg: reduce identation level by adding early return

2023-10-26 Thread Mike Maslenkin
This functions contain memory leaks. Less identation helps to solve this issues. Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib.c| 289 +- 1 file changed, 146 insertions(+), 143 deletions(-) diff --git a/RedfishClientPkg/Library

[edk2-devel] [edk2-redfish-client][PATCH v2 06/11] RedfishClientPkg: fix memory leaks while applying feature settings

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib.c| 11 +++ 1 file changed, 11 insertions(+) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c b/RedfishClientPkg/Library/RedfishFeatureUtilityLib

[edk2-devel] [edk2-redfish-client][PATCH v2 07/11] RedfishClientPkg: fix memory leak

2023-10-26 Thread Mike Maslenkin
This patch fixes leak in RedfishExternalResourceResourceFeatureCallback function. Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b/RedfishClientPkg

[edk2-devel] [edk2-redfish-client][PATCH v2 08/11] RedfishClientPkg: fix pragma pack usage

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h index

[edk2-devel] [edk2-redfish-client][PATCH v2 09/11] RedfishClientPkg: fix StrnCpyS arguments

2023-10-26 Thread Mike Maslenkin
StrnCpyS accepts string length in characters, not in bytes. Signed-off-by: Mike Maslenkin --- RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c b

[edk2-devel] [edk2-redfish-client][PATCH v2 10/11] RedfishFeatureCoreDxe: replace __FUNCTION__ with __func__

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- .../RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c

[edk2-devel] [edk2-redfish-client][PATCH v2 11/11] RedfishFeatureCoreDxe: add check for memory allocation failure

2023-10-26 Thread Mike Maslenkin
Signed-off-by: Mike Maslenkin --- .../RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c b/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c index

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishCrtLib: remove multiple definitions.

2023-10-29 Thread Mike Maslenkin
On Wed, Oct 25, 2023 at 3:40 PM Nickle Wang wrote: > > > double declaration of 'strcpy' is still there. > > Thanks for catching this, Mike. Version 2 patch file was sent. > > Regards, > Nickle Hello, Nickle v2 is good enough, but it can be improved a bit. Since the definitions in this header fi

Re: [edk2-devel] [PATCH v3] RedfishPkg/RedfishCrtLib: remove multiple definitions.

2023-10-31 Thread Mike Maslenkin
r(), strcasecmp(), strstr(), memcmp(), memset(), > memcpy(), memchr(), memcmp() and memmove(). > > Signed-off-by: Nickle Wang > Cc: Abner Chang > Cc: Igor Kulchytskyy > Cc: Nick Ramirez > Cc: Mike Maslenkin > Reviewed-by: Abner Chang > --- > Red

Re: [edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

2023-10-31 Thread Mike Maslenkin
Hi Igor please find my comments below. On Tue, Oct 31, 2023 at 8:56 PM Igor Kulchytskyy via groups.io wrote: > > Supported function of the driver changed to wait for all newtwork > interface to be installed. > Filer out the network interfaces which are not supported by > Redfish Host Interface.

Re: [edk2-devel] [PATCH] MdeModulePkg/XhciDxe: Non-zero start/stop values in XhcGetElapsedTicks

2023-10-31 Thread Mike Maslenkin
On Tue, Oct 31, 2023 at 7:52 PM Henz, Patrick wrote: > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4578 > > The implementation of XhcGetElapsedTicks did not account for > non-zero start and stop values for the performance counter > timer, potentially resulting in an incorrect elapsed tick

Re: [edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

2023-11-01 Thread Mike Maslenkin
On Wed, Nov 1, 2023 at 6:24 AM Igor Kulchytskyy wrote: > > Hi Mike, > Thank you for review. > Please see my answers below the text. > > -Original Message- > From: Mike Maslenkin > Sent: Tuesday, October 31, 2023 9:00 PM > To: devel@edk2.groups.io; Igor Kul

Re: [edk2-devel] [PATCH v2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

2023-11-03 Thread Mike Maslenkin
On Wed, Nov 1, 2023 at 11:17 PM Igor Kulchytskyy wrote: > > Supported function of the driver changed to wait for all newtwork > interface to be installed. > Filer out the network interfaces which are not supported by > Redfish Host Interface. > > Cc: Abner Chang > Cc:

Re: [edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

2023-11-05 Thread Mike Maslenkin
Hi Igor I want to return to my initial comments regarding this patch. Please, find my comments below. > On 1. 11. 2023., at 06:24, Igor Kulchytskyy wrote: > > Hi Mike, > Thank you for review. > Please see my answers below the text. > > -Original Message- &

Re: [edk2-devel] [PATCH v3] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

2023-11-07 Thread Mike Maslenkin
> On 7. 11. 2023., at 15:06, Igor Kulchytskyy via groups.io > wrote: > > Supported function of the driver changed to wait for all newtwork > interface to be installed. > Filer out the network interfaces which are not supported by > Redfish Host Interface. > > Cc: Abner Chang > Cc: Nickle Wa

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

2023-11-14 Thread Mike Maslenkin
On Tue, Nov 14, 2023 at 9:57 PM Igor Kulchytskyy via groups.io wrote: > > Hi Leif, > Please see my comments below. > Thank you, > Igor > > > -Original Message- > From: Leif Lindholm > Sent: Tuesday, November 14, 2023 12:26 PM > To: devel@edk2.groups.io; Igor Kulchytskyy > Cc: Abner Chang

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

2023-11-15 Thread Mike Maslenkin
On Wed, Nov 15, 2023 at 4:52 PM Igor Kulchytskyy wrote: > > Hello Leif and Mike, > Let me try to explain the idea of the filtering IP. > That filtering should work only if we know exactly that IP is IPv4 or IPv6 in > SMBIOS Type 42. Hm. I've already composed a reply below, but then a returned to

Re: [edk2-devel] [PATCH v5 2/2] RedfishPkg: RedfishDiscoverDxe: Optimize the Redfish Discover flow

2023-11-15 Thread Mike Maslenkin
sTcpTypeMatch() gives TRUE and we skip this iteration. Effectively this means if (IpType == REDFISH_HOST_INTERFACE_HOST_IP_ADDRESS_FORMAT_UNKNOWN ) { return EFI_DEVICE_ERROR } Just because there is nothing after this loop. And this is not what we wanted, and recognized as my mistake previously.

[edk2-devel] [PATCH 0/3] RedfishPkg: refine HiiUtilityLib and fix USB NIC discovering

2023-11-22 Thread Mike Maslenkin
This patch series involves the following changes: 1. fix memory leak and add explicit variable initialization in HiiUtilityLib 2. fix MAC address comparison during USB NIC discovering. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin

[edk2-devel] [PATCH 1/3] RedfishPkg: fix memory leak in HiiUtilityLib

2023-11-22 Thread Mike Maslenkin
Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c

[edk2-devel] [PATCH 2/3] RedfishPkg: add explicit variable initialization

2023-11-22 Thread Mike Maslenkin
'ConfigAccess' may be used uninitialized in this function [-Werror=maybe-uninitialized] if (ConfigAccess != NULL) { Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishPkg/Library/HiiUtilityLib/HiiUtilityInternal.c | 1 + 1 file chan

[edk2-devel] [PATCH 3/3] RedfishPkg: fix searching for the BMC-exposed USB NIC

2023-11-22 Thread Mike Maslenkin
According to RedfishPkg/Readme.md document: "The last byte of host-end USB NIC MAC address is the last byte of BMC-end USB NIC MAC address minus 1." It is necessary to subtract 1 from IpmiLanChannelMacAddress. Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike

[edk2-devel] [PATCH v2 0/3] RedfishPkg: refine HiiUtilityLib and fix USB NIC discovering

2023-11-22 Thread Mike Maslenkin
v2: removed --transfer-encoding=base64 from `git send-email` command line as it has broken patch format as I can see from the mailing list. v1: This patch series involves the following changes: 1. fix memory leak and add explicit variable initialization in HiiUtilityLib 2. fix MAC addres

[edk2-devel] [PATCH v2 1/3] RedfishPkg: fix memory leak in HiiUtilityLib

2023-11-22 Thread Mike Maslenkin
Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenkin --- RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c b/RedfishPkg/Library/HiiUtilityLib/HiiUtilityLib.c

  1   2   3   >