Re: [edk2-devel] [PATCH] Ext4Pkg: Fix CRC16 checksumming on block groups

2023-12-03 Thread Marvin Häuser
Reviewed-by: Marvin Häuser > On Dec 3, 2023, at 23:41, Pedro Falcato wrote: > > Old filesystems (around 2008 and older) do not use CRC32c > but rather CRC16-ANSI. Previously, the CalculateCrc16Ansi function was > broken and gave us wrong checksums. Adapt to the new interface.

Re: [edk2-devel][PATCH v1 1/3] MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize

2024-03-14 Thread Marvin Häuser
Good day everyone, Sorry for interjecting, but I’d like to avoid premature changes to PE code that would only make the current mess even worse. > On 4. Mar 2024, at 20:24, Oliver Smith-Denny wrote: > > I relooked at the spec, you are correct, SizeOfRawData is aligned to > the FileAlignment. So

Re: [edk2-devel][PATCH v1 1/3] MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize

2024-03-14 Thread Marvin Häuser
> On 14. Mar 2024, at 15:45, Oliver Smith-Denny > wrote: > > This does not appear to be the case with MSVC built binaries. I am > seeing that VirtualSize is the size of the data-initialized part of the > section. What? :( So you are saying modern MSVC generates PEs that either have non-contig

Re: [edk2-devel][PATCH v1 1/3] MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize

2024-03-15 Thread Marvin Häuser
> On 15. Mar 2024, at 23:57, Oliver Smith-Denny > wrote: > > I don't think this is what I'm saying. What I am trying to say is that > on MSVC, I see PE images getting created that have VirtualSize set to > the actual number of initialized bytes in that section (not padded to > the section align

Re: [edk2-devel] [PATCH v2 1/3] MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize

2024-03-16 Thread Marvin Häuser
Reviewed-by: Marvin Häuser On Mon, Mar 11, 2024 at 02:29 PM, Oliver Smith-Denny wrote: > > When an ImageRecord is stored by ImagePropertiesRecordLib, it reports the > CodeSegmentSize as the SizeOfRawData from the image. However, the image > as loaded into memory is al

Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests

2024-07-02 Thread Marvin Häuser
Hi Rebecca, Sounds good to me! Best regards, Marvin > On 1. Jul 2024, at 21:16, Rebecca Cran wrote: > > Now that edk2 has been using PRs for a few weeks, I'd like to propose > enabling the same workflow for edk2-platfoms. > > As maintainers or reviewers of platforms in the edk2-platforms re

Re: [edk2-devel] [PATCH 00/35] edk2: clean up the usage of standardized (VOID*) typedefs

2019-09-23 Thread Marvin Häuser
Good day, Thank you, Laszlo, for your ambition to introduce stricter code style enforcements. Sorry to "hijack" the actual topic (I did not CC anyone on purpose, as this is mostly a separate topic and I'd like a quick comment first), but this seems like a good occasion to mention another few ba

[edk2-devel] [PATCH] MdeModulePkg/FrameBufferBltLib: Correctly consider SourceX

2019-09-24 Thread Marvin Häuser
From: Marvin Haeuser Currently, SourceX is not considered in the BufferToVideo operation when the 8-bit pixel format is used. Correctly add the resulting offset to prevent image corruption. Cc: Jian J Wang Cc: Hao A Wu Signed-off-by: Marvin Haeuser --- MdeModulePkg/Library/FrameBufferBltLib/

[edk2-devel] [PATCH] WinHost: Add SimplePointer support

2019-09-24 Thread Marvin Häuser
From: Marvin Haeuser Catch WM mouse events and expose them via the SimplePointer protocol. Cc: Jordan Justen Cc: Andrew Fish Cc: Ray Ni Signed-off-by: Marvin Haeuser --- EmulatorPkg/Win/Host/WinGopInput.c | 25 ++-- EmulatorPkg/Win/Host/WinGopScreen.c | 41 Emu

Re: [edk2-devel] [PATCH 00/35] edk2: clean up the usage of standardized (VOID*) typedefs

2019-09-25 Thread Marvin Häuser
gards, Marvin Am 24.09.2019 um 22:26 schrieb Laszlo Ersek: > On 09/23/19 18:27, Marvin Häuser wrote: >> Good day, >> >> Thank you, Laszlo, for your ambition to introduce stricter code style >> enforcements. Sorry to "hijack" the actual topic (I did not CC anyone o

Re: [edk2-devel] [PATCH] WinHost: Add SimplePointer support

2019-09-26 Thread Marvin Häuser
schrieb Ni, Ray: > Marvin, > Can you kindly share what unit test you've done? > >> -Original Message----- >> From: Marvin Häuser >> Sent: Tuesday, September 24, 2019 5:46 AM >> To: devel@edk2.groups.io >> Cc: Justen, Jordan L ; Andrew Fish &g

Re: [edk2-devel] Saving data structure at Pre EFI Initialization phase in memory to use it at DXE phase by some UEFI application?

2020-01-30 Thread Marvin Häuser
Hey, Are HOBs ("Hand-Off Blocks") what you are looking for? They are passed from PEI to DXE (see PI 1.6, 9.3 "Passing the Hand-Off Block (HOB) List"). Regards, Marvin Am 30.01.2020 um 10:51 schrieb serges...@yandex.ru: > Is it possible to save SYSHOST data structure at PEI phase in memory at >

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

2020-02-17 Thread Marvin Häuser
es makes sense to >> find incorrect input to these functions from modules that can >> guarantee the inputs would never return an error and catch these as >> part of dev/debug/validation builds. >> I would not expect disabling on a module by module basis to be common. >> I

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

2020-02-17 Thread Marvin Häuser
, Marvin Von: Marvin Häuser Gesendet: Montag, 17. Februar 2020 09:26 An: devel@edk2.groups.io; af...@apple.com; Mike Kinney Cc: vit9696; Gao, Liming; Gao, Zhichao; Marvin Häuser; Laszlo Ersek Betreff: Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions Good day

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

2020-02-20 Thread Marvin Häuser
Hey Andrew, Thanks once again for your comments, mine are inline. Best regards, Marvin Am 20.02.2020 um 00:55 schrieb Andrew Fish: > > >> On Feb 17, 2020, at 12:26 AM, Marvin Häuser > <mailto:mhaeu...@outlook.de>> wrote: >> >> Good day Andrew, >>

Re: [edk2-devel] [PATCH v3 0/1] Add PCD to disable safe string constraint assertions

2020-03-03 Thread Marvin Häuser
next stable tag? Thanks! Best regards, Marvin Am 20.02.2020 um 11:18 schrieb Marvin Häuser: > Hey Andrew, > > Thanks once again for your comments, mine are inline. > > Best regards, > Marvin > > Am 20.02.2020 um 00:55 schrieb Andrew Fish: >> >> >&g

Re: [edk2-devel] CdePkg - added unit test for ASSERT.H and LOCALE.H functions

2019-12-02 Thread Marvin Häuser
Good day, I have seen e-mails about this package several times now and got a bit curious about its purpose and future. As far as I understood it, it aims to provide an actual full C standard library implementation. Is this planned to land in edk2 and if so, in what ways will one be encouraged

Re: [edk2-devel] [PATCH v2 055/105] .mailmap: Add an entry for Marvin Häuser

2019-12-06 Thread Marvin Häuser
Good day, Please excuse me, I didn't see the patch the first time. Reviewed-by: Marvin Häuser Best regards, Marvin We use .mailmap to display contributors email addresses in an uniform format. Add an entry for Marvin Häuser to have his name and email address displayed properly in th

Re: [edk2-devel] [staging/branch]: CdePkg - some more details

2019-12-10 Thread Marvin Häuser
Good day Kilian, Comments are inline. Thank you very much for your very comprehensive explainations! Please do not understand my sceptical tone as if I didn't want this project to succeed, my concerns are a lot more organisation-centered than on the work on the library itself. I wish you the

Re: [edk2-devel] [PATCH] MdePkg: PE loader should zero out dest buffer on allocation

2020-01-13 Thread Marvin Häuser
Good day, Please see my comment in the related BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1999#c5 Best regards, Marvin Am 13.01.2020 um 09:18 schrieb Zhiguang Liu: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1999 When PE loader loads image to memory, the first section of ima

Re: [edk2-devel] [PATCH] WinHost: Add SimplePointer support

2019-10-20 Thread Marvin Häuser
Good day, Thank you for your review. I have not seen this patch pushed yet, could you please update me with the status? Thanks, Marvin > Reviewed-by: Ray Ni > >> -Original Message----- >> From: Marvin Häuser >> Sent: Thursday, September 26, 2019 9:38 AM >&g

[edk2-devel] [PATCH] UefiShellCommandLib: Default to first found UC for unsupported PlatformLang

2019-10-20 Thread Marvin Häuser
From: Marvin Haeuser REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2300 On some firmwares PlatformLang is set to the local language (e.g. ru-RU), however there is no Unicode Collation protocol instance that supports it. As for missing PlatformLang, fall back to the first found instance. C

[edk2-devel] [PATCH] MdePkg/UefiFileHandleLib: Fix potential NULL dereference

2019-10-20 Thread Marvin Häuser
From: Marvin Haeuser REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2293 Move the NULL check in FileHandleGetInfo() to directly after the allocation to prevent potential NULL dereferences. Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Marvin Haeuser --- MdePkg/Library/UefiFileHand

[edk2-devel] [PATCH] MdePkg/UefiFileHandleLib: Tolerate more Root handle FileNames

2019-10-20 Thread Marvin Häuser
From: Marvin Haeuser REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2295 The current implementation of the FileHandleGetFileName() function assumes that the Root directory always has the FileName '\0'. However, the only requirement the UEFI specification defines is that a prepended '\\' mus

[edk2-devel] [PATCH] ShellPkg/Ls: Return empty content for all empty folders

2019-10-20 Thread Marvin Häuser
From: Marvin Haeuser REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2296 Currently, when 'ls' is run on an entirely empty directory (this includes not having '.' and '..'), the output is always 'File not found'. For when not filtering its children, this patch rather displays the usual heade

[edk2-devel] [PATCH] MdePkg/UefiDebugLibConOut: Pass the correct buffer size

2019-10-20 Thread Marvin Häuser
From: Marvin Haeuser REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2302 The second argument of "UnicodeVSPrintAsciiFormat" is "BufferSize", which takes the size of the buffer in bytes. Replace the currently used MAX_DEBUG_MESSAGE_LENGTH usage, which is the buffer's length, with the actual

[edk2-devel] [PATCH] ShellPkg/Ls: Consider UEFI timezone may not be set

2019-10-20 Thread Marvin Häuser
From: Marvin Haeuser REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2294 EFI_RUNTIME_SERVICES.GetTime() might return an unspecified Timezone, such as when SetTime() has not been called after the RTC was cut off power. Consider this case by not attempting Timezone translations for when it is

[edk2-devel] [PATCH] MdePkg/UefiDebugLibStdErr: Pass the correct buffer size

2019-10-21 Thread Marvin Häuser
From: Marvin Haeuser REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2302 The second argument of "UnicodeVSPrintAsciiFormat" is "BufferSize", which takes the size of the buffer in bytes. Replace the currently used MAX_DEBUG_MESSAGE_LENGTH usage, which is the buffer's length, with the actual

[edk2-devel] [PATCH] ShellPkg/CommandLib: Use first found UC for unsupported PlatformLang

2019-11-05 Thread Marvin Häuser
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2300 On some firmwares PlatformLang is set to the local language (e.g. ru-RU), however there is no Unicode Collation protocol instance that supports it. As for missing PlatformLang, fall back to the first found instance. Cc: Ray Ni Cc: Zhichao

Re: [edk2-devel] [PATCH 2/3] MdePkg/BaseLib: rewrite Base64Decode()

2019-07-15 Thread Marvin Häuser
d appropriate return statuses. Is there any kind of policy I am unaware of? Regards, Marvin > -Original Message- > From: devel@edk2.groups.io On Behalf Of Laszlo > Ersek > Sent: Tuesday, July 2, 2019 12:29 PM > To: edk2-devel-groups-io > Cc: Liming Gao ; Marvin Häuser >

Re: [edk2-devel] [PATCH 1/1] Ext4Pkg: Fix broken stack protector-enabled builds

2022-09-16 Thread Marvin Häuser
Reviewed-by: Marvin Häuser > On 16. Sep 2022, at 01:06, Pedro Falcato wrote: > > As reported by Rebecca Cran, there was some build breakage when > compiling with stack-protector-on-by-default toolchains. Adding the > proper library to the DSC should fix it. > > Cc: Rebec

Re: [edk2-devel] [PATCH EDK2 v2 1/1] SecurityPkg/DxeImageVerificationLib:Enhanced verification of Offset

2020-08-18 Thread Marvin Häuser
Good day everyone, First off, for your information, I'm sending from my new e-mail address from now on. Please excuse me, I cannot read your entire thread right now, I will definitely make sure to catch up as soon as time permits, but I just wanted to confirm we are indeed working on a reimp

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support CLANGPDB build

2021-10-14 Thread Marvin Häuser
n '-fpie' for target 'x86_64-unknown-windows-gnu'". So we add the CLANGPDB option "-fno-pie" later to overwrite it. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Vitaly Cheptsov Cc: Marvin Häuser Cc: Steven Shi

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support CLANGPDB build

2021-10-14 Thread Marvin Häuser
NGPDB:*_*_ *IA32*_CC_FLAGS= -fno-pie +  CLANGPDB:*_*_ *X64*_CC_FLAGS= -fno-pie Thanks Steven Shi > -Original Message- > From: devel@edk2.groups.io On Behalf Of Marvin > Häuser > Sent: Thursday, October 14, 2021 4:05 PM > To: Yang, JiyangX ; devel@edk2.groups.io > Cc

Re: [edk2-devel] [PATCH v1 1/1] StandaloneMmPkg: To support CLANGPDB build

2021-10-14 Thread Marvin Häuser
Hey Ard, Thanks for commenting! On 14.10.21 11:09, Ard Biesheuvel wrote: On Thu, 14 Oct 2021 at 11:08, Marvin Häuser wrote: Hey Steven, As I said, I prefer my patch, but this would work too of course. I talked about the PIE stuff with Ard before, so maybe he has an opinion on this

[edk2-devel] [PATCH v2 0/1] StandaloneMmPkg: Support CLANGPDB builds

2021-10-14 Thread Marvin Häuser
relocation, drop it for other architectures and document the limitation to enable e.g. X64 CLANGPDB builds of StandaloneMmCore. Marvin Häuser (1): StandaloneMmPkg: Support CLANGPDB builds StandaloneMmPkg/Core/StandaloneMmCore.inf | 12 ++-- Stand

[edk2-devel] [PATCH v2 1/1] StandaloneMmPkg: Support CLANGPDB builds

2021-10-14 Thread Marvin Häuser
d document the limitation to enable e.g. X64 CLANGPDB builds of StandaloneMmCore. Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Jiewen Yao Cc: Supreeth Venkatesh Cc: Vitaly Cheptsov Cc: Steven Shi Cc: Jiyang Yang Signed-off-by: Marvin Häuser --- StandaloneMmPkg/Core/Standalone

Re: [edk2-devel] [PATCH v1 1/3] MdeModulePkg/SortLib: Add QuickSort function on BaseLib

2021-10-15 Thread Marvin Häuser
Good day Ianx, On 15.10.21 16:33, IanX Kuo wrote: From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Use QuickSort instead of QuickSortWorker Cc: Ray Ni Cc: Jian J Wang Cc: Liming Gao Signed-off-by: IanX Kuo --- .../Library/BaseSortLib/BaseSortLib.c | 117 +

Re: [edk2-devel] [PATCH v1 3/3] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort function on BaseLib

2021-10-15 Thread Marvin Häuser
Good day Ianx, On 15.10.21 16:33, IanX Kuo wrote: From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Remove MdeModulePkg dependency Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: IanX Kuo --- UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c | 5

Re: [edk2-devel] [PATCH v2 3/3] UefiCpuPkg/CpuCacheInfoLib: Add QuickSort function on BaseLib

2021-10-16 Thread Marvin Häuser
Hey IanX, On 16.10.21 01:25, IanX Kuo wrote: From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Remove MdeModulePkg dependency Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Signed-off-by: IanX Kuo --- UefiCpuPkg/Library/CpuCacheInfoLib/CpuCacheInfoLib.c | 9

Re: [edk2-devel] [PATCH v2 2/3] CryptoPkg/CryptLib: Add QuickSort function on BaseLib

2021-10-16 Thread Marvin Häuser
Hey IanX, On 16.10.21 01:25, IanX Kuo wrote: From: IanX Kuo REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3675 Use QuickSort instead of QuickSortWorker Cc: Ray Ni Cc: Jiewen Yao Cc: Jian J Wang Cc: Xiaoyu Lu Cc: Guomin Jiang Signed-off-by: IanX Kuo --- .../Library/BaseCryptLib/

Re: [edk2-devel] [edk2-rfc] Inclusive Language RFC

2021-10-27 Thread Marvin Häuser
Hey, On 25.10.21 20:47, Teng, Lynn L wrote: Hello all, Please provide your feedback and comments to the Inclusive Language Plan below over the next two weeks (10/25-11/05). Thank you in advance for your contributions. *** ## Overview To promote a more inclusive and open ecosystem, TianoC

Re: [edk2-devel] RFC: Replace FMMT Tool from C to Python Version

2021-10-29 Thread Marvin Häuser
Good day, Is there any information available on PyGenFv? It also handles ELF to PE conversion (who knows why...), is that planned to be ported to Python as well? For Project Amaranth, we are currently implementing a tool to replace the ELF to PE conversion (among other things) and decided to

Re: [edk2-devel] [PATCH v2 16/16] ArmPlatformPkg: Resolve build errors resulting from package moves

2021-11-06 Thread Marvin Häuser
Hey Bret, If I understood this correctly, this fixes build issues introduced with the move patch of the same series? In that case, is there no edk2 rule that every commit must compile for the whole tree? We have such a rule downstream that overrides any colliding rules (e.g. "mod only one pac

Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?

2021-11-08 Thread Marvin Häuser
e.org/uncrustify/ >   > Adding the installation information to the EDK II Getting Started page would > be a good place to capture the developer install. >   > Mike >   > *From:* Andrew Fish > *Sent:* Monday, November 8, 2021 6:47 PM > *To:* Kinney, Michael D > *Cc:* devel@

Re: [edk2-devel] Progress on getting Uncrustify working for EDK2?

2021-11-09 Thread Marvin Häuser
Hey Mike, On 09.11.21 16:43, Kinney, Michael D wrote: Hi Marvin, Comments below. Mike -Original Message- From: devel@edk2.groups.io On Behalf Of Marvin Häuser Sent: Monday, November 8, 2021 11:33 PM To: Kinney, Michael D Cc: Andrew Fish ; devel@edk2.groups.io; Michael Kubacki

Re: [edk2-devel] [PATCH] MdePkg: DebugLib: Compilation fix for clang-13.

2021-11-22 Thread Marvin Häuser
23.11.2021 00:17:30 Michael Brown : > On 22/11/2021 16:42, Michael D Kinney wrote: >> You are also modifying the DebugLib in the paths where ASSERT() macros >> are disabled.  When they are disabled, we want all code/data associated >> with ASSERT() to be removed by the optimizing compiler/linker

Re: [edk2-devel] [PATCH V2 2/3] MdePkg/Base.h: Introduce various alignment-related macros

2021-11-23 Thread Marvin Häuser
Ping? :) On 16.08.21 15:10, Marvin Häuser wrote: Hey Ray, On 16/08/2021 11:42, Ni, Ray wrote: Marvin, So lucky to have you in the edk2 project looking into these fundamentals! Thank you. :) +  #define ALIGNOF(TYPE) OFFSET_OF (struct { CHAR8 C; TYPE A; }, A) 1. Does struct{} inside a

Re: [EXTERNAL] Re: [edk2-devel] [PATCH V6 1/1] MdePkg: Fix SafeString performing assertions on runtime checks

2020-05-15 Thread Marvin Häuser
15 PM *To:* devel@edk2.groups.io; Kinney, Michael D ; chept...@ispras.ru *Cc:* Andrew Fish ; Ard Biesheuvel ; Brian J . Johnson ; Chiu, Chasel ; Justen, Jordan L ; Laszlo Ersek ; Leif Lindholm ; Gao, Liming ; Marvin Häuser ; Zimmer, Vincent ; Gao, Zhichao *Subject:* Re: [EXTERNAL] Re:

Re: [edk2-devel] [PATCH V2 2/3] MdePkg/Base.h: Introduce various alignment-related macros

2021-12-08 Thread Marvin Häuser
Hey Mike, Thanks! I agree using "offset" may make it more readable, but I haven't seen it being used much outside of memory terminology (the macro also applies to plain integers). Any feedback from the maintainers for preferences? Thanks! Best regards, Marvin On 08.12.21 10:10, mjsbea...@gm

[edk2-devel] [PATCH edk2 v1 3/3] StandaloneMmPkg: Fix check buffer address failed issue from TF-A

2021-12-16 Thread Marvin Häuser
Hey all, > On 15. Dec 2021, at 16:02, Ming Huang wrote: > >  > >> On 12/9/21 1:46 AM, Omkar Anand Kulkarni wrote: >> Hi Ming, >> Thanks for this patch. This patch helps to resolve Standalone MM issue while >> exercising RAS use case. >> Few comments mentioned inline. >> - Omkar >>> On 10/15/

Re: [edk2-devel] [PATCH edk2 v2 3/3] StandaloneMmPkg: Fix check buffer address failed issue from TF-A

2021-12-22 Thread Marvin Häuser
Hey Ming, Please check https://edk2.groups.io/g/devel/message/84973?p=%2C%2C%2C20%2C0%2C0%2C0%3A%3Arecentpostdate%2Fsticky%2C%2CMarvin%2C20%2C2%2C0%2C86334815 While a few comments were cosmetical, there is an invalid memory access outlined too, which persists in this patch. For the future, th

Re: [edk2-devel] [PATCH edk2 v1 3/3] StandaloneMmPkg: Fix check buffer address failed issue from TF-A

2021-12-23 Thread Marvin Häuser
On 23.12.21 11:46, Ming Huang wrote: 在 12/16/21 5:15 PM, Marvin Häuser 写道: Hey all, On 15. Dec 2021, at 16:02, Ming Huang wrote:  On 12/9/21 1:46 AM, Omkar Anand Kulkarni wrote: Hi Ming, Thanks for this patch. This patch helps to resolve Standalone MM issue while exercising RAS use

Re: [edk2-devel] [PATCH edk2 v1 3/3] StandaloneMmPkg: Fix check buffer address failed issue from TF-A

2021-12-24 Thread Marvin Häuser
On 24.12.21 02:18, Ming Huang wrote: 在 12/23/21 7:05 PM, Marvin Häuser 写道: On 23.12.21 11:46, Ming Huang wrote: 在 12/16/21 5:15 PM, Marvin Häuser 写道: Hey all, On 15. Dec 2021, at 16:02, Ming Huang wrote:  On 12/9/21 1:46 AM, Omkar Anand Kulkarni wrote: Hi Ming, Thanks for this patch

Re: [edk2-devel] [PATCH edk2 v1 3/3] StandaloneMmPkg: Fix check buffer address failed issue from TF-A

2021-12-30 Thread Marvin Häuser
On 25.12.21 03:09, Ming Huang wrote: 在 12/24/21 9:52 PM, Marvin Häuser 写道: On 24.12.21 02:18, Ming Huang wrote: 在 12/23/21 7:05 PM, Marvin Häuser 写道: On 23.12.21 11:46, Ming Huang wrote: 在 12/16/21 5:15 PM, Marvin Häuser 写道: Hey all, On 15. Dec 2021, at 16:02, Ming Huang wrote

Re: [edk2-devel] [PATCH v1 1/2] UefiCpuPkg: Extend SMM CPU Service with rendezvous support.

2022-02-11 Thread Marvin Häuser
Hey all, On 10.02.22 09:18, Siyuan, Fu wrote: Hi, Mike -Original Message- From: devel@edk2.groups.io On Behalf Of Michael D Kinney Sent: 2022年2月9日 0:31 To: devel@edk2.groups.io; Li, Zhihao ; Kinney, Michael D Cc: Dong, Eric ; Ni, Ray ; Kumar, Rahul1 Subject: Re: [edk2-devel] [PATCH

Re: [edk2-devel] [PATCH v1 1/2] UefiCpuPkg: Extend SMM CPU Service with rendezvous support.

2022-02-11 Thread Marvin Häuser
Good day, On 08.02.22 06:35, Li, Zhihao wrote: From: Zhihao Li REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3815 This patch extends the SMM CPU Service protocol with new interface SmmWaitForAllProcessor(), which can be used by SMI handler to optionally wait for other APs to complete SM

Re: [edk2-devel] Unit Test and sanitizers

2022-02-26 Thread Marvin Häuser
Hey Andrew, +1 Linux Clang sanitizers not only work but actually have more advanced techniques here and there over macOS and Windows. GCC definitely has some level of support, but if I recall correctly it was not as nice for some reason. I think MSVC only has ASan and it's not very nice. I'm

Re: [edk2-devel][PATCH] MdeModulePkg: Make RSP 16-byte boundary aligned for PEI 64bit

2022-03-17 Thread Marvin Häuser
Good day, On 17. Mar 2022, at 02:05, Kuo, Ted wrote: Hi Liming and Mike, Can you please review the change? Thanks, Ted -Original Message- From: devel@edk2.groups.io On Behalf Of Kuo, Ted Sent: Thursday, March 10, 2022 2:21 PM To: devel@edk2.groups.io Cc: Bi, Dandan ; Gao, Liming

Re: [edk2-devel] [GSoC 2022] Introducing Myself

2022-03-17 Thread Marvin Häuser
Hey Ayush, I heard Bret likes Rust. :) The Rust staging branch is owned by Jiewen. Nate handles GSoC. All CC’d (better get used to it fast :) ). Best regards, Marvin > On 16. Mar 2022, at 23:16, ayushdevel1...@gmail.com wrote: > Hello everyone, > > I am Ayush Singh, a 2nd-year student from In

Re: [edk2-devel] [Patch] Fix edkii-rust brach in edk2-staging

2022-03-17 Thread Marvin Häuser
CC Jiewen (needs whitespace changes cleaned and the bench needs to be rebased beyond 2019 too) Also see: https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers Best regards, Marvin > On 17. Mar 2022, at 15:54, ayushdevel1...@gmai

Re: [edk2-devel] [PATCH v1 0/3]: Fix RustPkg/Tests in edkii-rust branch edk2-staging

2022-03-19 Thread Marvin Häuser
> On 19. Mar 2022, at 08:06, Ayush Singh wrote: > > CC Jiewen Yao You didn’t actually CC, done. Best regards, Marvin > > This is my 2nd email about this patch to fix edkii-rust branch in > edk2-staging repo, this time hopefully following contributing procedure > better. > > I have tried

Re: [edk2-devel][PATCH 1/2] MdeModulePkg: StackOffset must be aligned to a 16-byte boundary in X64

2022-03-21 Thread Marvin Häuser
from old stack to new stack. Cc: Michael D Kinney Cc: Dandan Bi Cc: Liming Gao Cc: Debkumar De Cc: Harry Han Cc: Catharine West Cc: Jian J Wang Cc: Marvin Häuser Signed-off-by: Ted Kuo --- MdeModulePkg/Core/Pei/Dispatcher/Dispatcher.c | 18 +- 1 file changed, 17 inser

Re: [edk2-devel][PATCH 1/2] MdeModulePkg: StackOffset must be aligned to a 16-byte boundary in X64

2022-03-22 Thread Marvin Häuser
be specific to X64 in IntelFspPkg. You still can find my > inline comments with [Ted] for your questions. > > Thanks, > Ted > > -----Original Message- > From: Marvin Häuser > Sent: Tuesday, March 22, 2022 3:46 AM > To: devel@edk2.groups.io; Kuo, Ted > Cc: K

Re: [edk2-devel] [PATCH V2 2/3] MdePkg/Base.h: Introduce various alignment-related macros

2022-03-22 Thread Marvin Häuser
reflect the roadmap. Best regards, Marvin On 23.11.21 11:12, Marvin Häuser wrote: Ping? :) On 16.08.21 15:10, Marvin Häuser wrote: Hey Ray, On 16/08/2021 11:42, Ni, Ray wrote: Marvin, So lucky to have you in the edk2 project looking into these fundamentals! Thank you. :) +  #define

Re: [edk2-devel] Question about UEFI, AddressSanitizer and MMU mappings

2022-03-25 Thread Marvin Häuser
Hey Pedro, ASan is somewhat listed for „LLVM Optimizations“. A quick and dirty reference for UEFI UBSan can be found here: https://github.com/acidanthera/OpenCorePkg/tree/master/Library/OcGuardLib I don’t think you need to strictly adhere to the UEFI spec for debug tooling. I cannot check the c

Re: [edk2-devel] [GSoC 2022] How to begin contributing?

2022-03-30 Thread Marvin Häuser
Hey Tejesh, Sorry your mail doesn't get much activity. I think parsing-related things are most important: - String functions in BaseLib: https://github.com/tianocore/edk2/blob/55637a2894babca97945eeca1da0d431f74f8627/MdePkg/Library/BaseLib/String.c - DevicePathLib: https://github.com/tiano

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

2021-04-04 Thread Marvin Häuser
Good day Ethin and all, I'd recommend you taking a look at our audio implementation at Acidanthera: https://github.com/acidanthera/OpenCorePkg/tree/master/Staging/AudioDxe It was tested on at least a few hundred, possibly a few thousand machines to work adequately. This includes preboot access

[edk2-devel] [GSoC proposal] Secure Image Loader

2021-04-04 Thread Marvin Häuser
Good day everyone, I'll keep the introduction brief because I've been around for a while now. :) I'm Marvin Häuser, a third-year Computer Science student from TU Kaiserslautern, Germany. Late last year, my colleague Vitaly from ISP RAS and me introduced a formally verified I

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

2021-04-06 Thread Marvin Häuser
ing unclear. Just try to not give Laszlo too many flashbacks. :) With Best Regards, Nate -Original Message----- From: devel@edk2.groups.io On Behalf Of Marvin Häuser Sent: Sunday, April 4, 2021 4:02 PM To: devel@edk2.groups.io; Laszlo Ersek ; Andrew Fish ; Kinney, Michael D Subject: [ed

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

2021-04-07 Thread Marvin Häuser
of API I would not expect to be accessed outside of platform code. Am I missing or overlooking something? Best regards, Marvin On 07.04.21 23:05, Michael Brown wrote: On 05/04/2021 00:01, Marvin Häuser wrote: 3. During my initial exploration, I discovered defective PPIs and protocols (e.g.

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

2021-04-08 Thread Marvin Häuser
On 07.04.21 23:50, Michael Brown wrote: On 07/04/2021 22:31, Marvin Häuser wrote: Sorry, but I do not see why this would be the case. In fact the solution is (temporary) co-existence, as already is the case with InstallProtocolInterface() and InstallMultipleProtocolInterfaces

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

2021-04-08 Thread Marvin Häuser
g>> wrote: On 07/04/2021 22:31, Marvin Häuser wrote: Sorry, but I do not see why this would be the case. In fact the solution is (temporary) co-existence, as already is the case with InstallProtocolInterface() and InstallMultipleProtocolInterfaces() InstallMultipleProtocolInterfaces()

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

2021-04-08 Thread Marvin Häuser
tform drivers and OS loaders from the real world. "Mostly" can be clarified further once we have a detailed plan on the changes (and responses to e.g. malformed binary issues with iPXE and GNU-EFI). Best regards, Marvin On 08.04.21 11:26, Michael Brown wrote: On 08/04/2021 09:53, Mar

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

2021-04-08 Thread Marvin Häuser
Sorry, I accidentally removed an inline comment when sending. Best regards, Marvin On 08.04.21 11:41, Marvin Häuser wrote: Well, I assume this is a misunderstanding. I understood your usage of "workaround" to be supporting both *_PROTOCOL and *2_PROTOCOL instances. Yes,

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

2021-04-08 Thread Marvin Häuser
On 08.04.21 11:55, Michael Brown wrote: On 08/04/2021 10:41, Marvin Häuser wrote: No, backwards-compatibility will not be broken in the sense that the old API is absent or malfunctioning. Perfect. :) As I *have* said, I imagine there to be an option (default true) to expose both variants

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

2021-04-08 Thread Marvin Häuser
e had a tool that would point out the security faults with a given PE/COFF file layout. Sent from my iPhone On Apr 8, 2021, at 4:16 AM, Laszlo Ersek wrote: On 04/06/21 12:06, Marvin Häuser wrote: Good day Nate, Comments are inline. Best regards, Marvin On 06.04.21 11:41, Nate DeSimone

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

2021-04-08 Thread Marvin Häuser
On 08.04.21 18:44, Andrew Fish via groups.io wrote: On Apr 8, 2021, at 9:06 AM, Marvin Häuser <mailto:mhaeu...@posteo.de>> wrote: We use the loader code in userspace anyway for fuzzing and such. I also want to build a database of all sorts of UEFI binaries some time before the

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

2021-04-08 Thread Marvin Häuser
08.04.2021 19:39:16 Andrew Fish : > > >> On Apr 8, 2021, at 10:02 AM, Marvin Häuser wrote: >> >> On 08.04.21 18:44, Andrew Fish via groups.io wrote: >>> >>> >>>> On Apr 8, 2021, at 9:06 AM, Marvin Häuser >>> <mailto:mhaeu..

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

2021-04-12 Thread Marvin Häuser
ec changes that you believe are needed. Thank you for sending the application and alerting us to the great work you and Vitaly have done! I'll read your paper more closely and come back with any questions I still have. With Best Regards, Nate -Original Message- From: devel@edk2.grou

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

2021-04-13 Thread Marvin Häuser
system > time to test the new loader and correct any issues that arise from its > introduction. > > Best Regards, > Nate > > -Original Message- > From: Kinney, Michael D > Sent: Monday, April 12, 2021 5:20 PM > To: Marvin Häuser ; devel@edk2.groups.io

Re: [edk2-devel] [GSoC proposal] Secure Image Loader

2021-04-16 Thread Marvin Häuser
anks, Nate -----Original Message- From: Marvin Häuser Sent: Tuesday, April 13, 2021 12:32 AM To: Desimone, Nathaniel L Cc: Kinney, Michael D ; devel@edk2.groups.io; Laszlo Ersek ; Andrew Fish Subject: Re: [edk2-devel] [GSoC proposal] Secure Image Loader Hey Mike, Hey Nate, I'm not 1

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

2021-04-16 Thread Marvin Häuser
Good day, Sorry for the nitpicking. - Protocols always need a "Revision" field as first member. This is used to be able to expand its capabilities in later revisions without introducing a new, distinct protocol. - Consider the name EFI_SIMPLE_AUDIO_OUTPUT(!)_PROTOCOL, to not cause confusion i

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

2021-04-16 Thread Marvin Häuser
On 16.04.21 16:34, Andrew Fish via groups.io wrote: On Apr 16, 2021, at 6:22 AM, Marvin Häuser <mailto:mhaeu...@posteo.de>> wrote: Good day, Sorry for the nitpicking. - Protocols always need a "Revision" field as first member. This is used to be able to expand its ca

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

2021-04-17 Thread Marvin Häuser
On 16.04.21 19:45, Ethin Probst wrote: Yes, three APIs (maybe like this) would work well: - Start, Stop: begin playback of a stream - SetVolume, GetVolume, Mute, Unmute: control volume of output and enable muting - CreateStream, ReleaseStream, SetStreamSampleRate: Control sample rate of stream (b

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

2021-04-17 Thread Marvin Häuser
On 17.04.21 19:31, Andrew Fish via groups.io wrote: On Apr 17, 2021, at 9:51 AM, Marvin Häuser <mailto:mhaeu...@posteo.de>> wrote: On 16.04.21 19:45, Ethin Probst wrote: Yes, three APIs (maybe like this) would work well: - Start, Stop: begin playback of a stream - SetVolume, GetVol

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

2021-04-18 Thread Marvin Häuser
cations believe that unlimited streams are possible. I apologize for this really long-winded email, and I hope no one minds. :-) On 4/17/21, Marvin Häuser <mailto:mhaeu...@posteo.de>> wrote: On 17.04.21 19:31, Andrew Fish via groups.io <http://groups.io> wrote: On Apr 17, 20

Re: [edk2-devel] VirtIO Sound Driver (GSoC 2021)

2021-04-18 Thread Marvin Häuser
On 18.04.21 21:11, Marvin Häuser wrote: On 18.04.21 17:22, Andrew Fish via groups.io wrote: On Apr 18, 2021, at 1:55 AM, Ethin Probst <mailto:harlydavid...@gmail.com>> wrote: I think it would be best to sketch use-cases for audio and design the solutions closely to the requirement

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Allocate a separate SEV-ES AP reset stack area

2021-05-14 Thread Marvin Häuser
Good day Thomas, Thank you very much for the quick patch. Comments inline. Best regards, Marvin On 11.05.21 22:50, Lendacky, Thomas wrote: BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3324 The SEV-ES stacks currently share a page with the reset code and data. Separate the SEV-ES stacks

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Allocate a separate SEV-ES AP reset stack area

2021-05-14 Thread Marvin Häuser
On 14.05.21 17:23, Lendacky, Thomas wrote: On 5/14/21 10:04 AM, Marvin Häuser wrote: Good day Thomas, Hi Marvin, Thank you very much for the quick patch. Comments inline. Best regards, Marvin On 11.05.21 22:50, Lendacky, Thomas wrote: BZ: https://nam11.safelinks.protection.outlook.com

Re: [edk2-devel] [PATCH] UefiCpuPkg/MpInitLib: Allocate a separate SEV-ES AP reset stack area

2021-05-16 Thread Marvin Häuser
Am 16.05.2021 um 03:17 schrieb Laszlo Ersek: On 05/14/21 17:44, Marvin Häuser wrote: On 14.05.21 17:23, Lendacky, Thomas wrote: On 5/14/21 10:04 AM, Marvin Häuser wrote: +  // Check to be sure that the "allocate below" behavior hasn't changed. +  // This will also

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/MpInitLib: Allocate a separate SEV-ES AP reset stack area

2021-05-18 Thread Marvin Häuser
ing the SFF, even if we call it a feature. But I'd like Marvin to take a look as well, plus I'd like at least one of Eric and Ray to check. ... I'm tempted not to call it a bugfix, because the lack of this patch does not break SEV-ES usage, as far as I understand. Cc: Eric Dong Cc: Ra

Re: [edk2-devel] [PATCH v1 6/6] UefiPayloadPkg: LinuxBoot: use a text format for the configuration block.

2021-07-21 Thread Marvin Häuser
On 21.07.21 15:23, Cheng-Chieh Huang via groups.io wrote: From: Trammell Hudson This adds a text command line for the UefiPayloadPkg that uses a textual magic number 'LnxBoot1' and a series of white-space separated key=value[,value...] pairs for the parameters. The v1 binary configuration s

Re: [edk2-devel] RFC: EXT4 filesystem driver

2021-07-22 Thread Marvin Häuser
On 22.07.21 01:12, Pedro Falcato wrote: EXT4 (fourth extended filesystem) is a filesystem developed for Linux that has been in wide use (desktops, servers, smartphones) since 2008. The Ext4Pkg implements the Simple File System Protocol for a partition that is formatted with the EXT4 file system.

Re: [edk2-devel] RFC: EXT4 filesystem driver

2021-07-22 Thread Marvin Häuser
On 22.07.21 17:58, Andrew Fish wrote: On Jul 22, 2021, at 3:24 AM, Marvin Häuser <mailto:mhaeu...@posteo.de>> wrote: On 22.07.21 01:12, Pedro Falcato wrote: EXT4 (fourth extended filesystem) is a filesystem developed for Linux that has been in wide use (desktops, servers, smartphon

Re: [edk2-devel] ArmVirt and Self-Updating Code

2021-07-23 Thread Marvin Häuser
; Marvin Häuser; Sami Mujawar Cc: nd Subject: [EXTERNAL] RE: ArmVirt and Self-Updating Code + Sami From: Bret Barkelew Sent: Thursday, July 8, 2021 11:05 AM To: Thomas Abraham; Ard Biesheuvel (TianoCore); Lindholm, Leif; Laszlo Ersek; Marvin Häuser Subject: ArmVirt and Self-Updating Code

Re: [edk2-devel] ArmVirt and Self-Updating Code

2021-07-23 Thread Marvin Häuser
On 23.07.21 12:13, Ard Biesheuvel wrote: On Fri, 23 Jul 2021 at 11:55, Marvin Häuser wrote: On 22.07.21 17:14, Ard Biesheuvel wrote: On Thu, 22 Jul 2021 at 16:54, Bret Barkelew wrote: Expanding audience to the full dev list… See below… - Bret From: Thomas Abraham Sent: Wednesday

Re: [edk2-devel] ArmVirt and Self-Updating Code

2021-07-23 Thread Marvin Häuser
On 23.07.21 16:09, Ard Biesheuvel wrote: On Fri, 23 Jul 2021 at 12:47, Marvin Häuser wrote: On 23.07.21 12:13, Ard Biesheuvel wrote: On Fri, 23 Jul 2021 at 11:55, Marvin Häuser wrote: On 22.07.21 17:14, Ard Biesheuvel wrote: On Thu, 22 Jul 2021 at 16:54, Bret Barkelew wrote: Expanding

[edk2-devel] EmulatorPkg and the state of DlLoadImage()

2021-07-30 Thread Marvin Häuser
Good day everyone, I'm currently refining the port of EmulatorPkg to my new PE/COFF loader library instance. In the process, I found the function DlOpenImage() [1], which loads UEFI Images via the OS loader to utilise its symbol loading capability. Theoretically, this should e.g. allow arbitra

Re: [edk2-devel] EmulatorPkg and the state of DlLoadImage()

2021-07-30 Thread Marvin Häuser
30.07.2021 17:58:05 Andrew Fish via groups.io : On Jul 30, 2021, at 3:37 AM, Marvin Häuser wrote: Good day everyone, I'm currently refining the port of EmulatorPkg to my new PE/COFF loader library instance. In the process, I found the function DlOpenImage() [1], which loads UEFI I

  1   2   3   4   5   >