Re: [edk2-devel] [PATCH v1 1/6] uefi-sct/SctPkg: TCG2 Protocol: add header with TCG2 protocol definitions

On 12/15/23 00:39, Stuart Yoder wrote: From: Joseph Hemann Please, provide commit messages. Signed-off-by: Joseph Hemann Signed-off-by: Stuart Yoder --- uefi-sct/SctPkg/UEFI/Protocol/TCG2.h | 179 1 file changed, 179 insertions(+) diff --git a/uefi-sct/SctPkg/UEFI

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=- --- Begin Message --- Update Gigadevice norflash list: gd25q16, gd25q32, gd25q64, gd25lq64c, gd25q128, gd25lq128, gd25q256 Add Silicon Kaiser norflash list: sk25lp128 Cc: Sunil V L Cc: Li Yong Cc: Heinrich Schuchar

Re: [edk2-devel] [PATCH v1] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

On 26.02.24 11:17, Chao Li wrote: DevicePathFromTextBBTextCoverage.c function CreateDNSDeviceNode has a bug, code: SctStrToIPv4Addr (&IpStr1, (EFI_IPv4_ADDRESS *)(DNS + sizeof (DNS_DEVICE_PATH))); DNS is a pointer, which is increased by a structure size and converted to EFI_IPv4_ADDRESS*, whic

Re: [edk2-devel] [edk2-test v2] SctPkg: Fixed a pinter error in DevicePathFromTextBBTestCoverage.c

: Eric Jin Cc: Arvin Chen Cc: Supreeth Venkatesh Cc: Heinrich Schuchardt Signed-off-by: Chao Li --- .../BlackBoxTest/DevicePathFromTextBBTestCoverage.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathFromTex

Re: [edk2-devel] [PATCH] OvmfPkg: OVMF supports USB mouses

=1&t=31572. I worked around this by including the below patch in my local builds, and was encouraged by Heinrich Schuchardt to submit a patch. I have not contributed to this project before, so please accept my apologies if I've formatted anything incorrect. All the best. Signed-off

Re: [edk2-devel] [PATCH] OvmfPkg: OVMF supports USB mouses

=1&t=31572. I worked around this by including the below patch in my local builds, and was encouraged by Heinrich Schuchardt to submit a patch. I have not contributed to this project before, so please accept my apologies if I've formatted anything incorrect. All the best. Signed-off

[edk2-devel] [PATCH v2 1/1] OvmfPkg: OVMF supports USB mouses

his: https://forum.osdev.org/viewtopic.php?f=1&t=31572. Signed-off-by: Phillip Tennen Reviewed-by: Heinrich Schuchardt --- v2: fix formatting problems leading to the patch not being applicable move both insertions below UsbKbDxe update commit message --- OvmfPkg/Ovmf

Re: [edk2-devel] [PATCH v1 1/3] uefi-sct/SctPkg: TCG2 Protocol: correct definition of TPMT_HA struct

On 4/16/24 00:23, Stuart Yoder wrote: The TPMT_HA struct defining event log hash algorithms was cut/pasted from the TCG EFI Protocol specification which used a C struct with a flexible array member as the last element. This is incorrect because TPMT_HA itself is used as an array element, and thu

Re: [edk2-devel] [PATCH v1 3/3] uefi-sct/SctPkg: TCG2 Protocol: #pragma pack cleanup

On 4/16/24 00:23, Stuart Yoder wrote: Fix compiler warning by adding #pragma pack() to close a pragma section. Also delete extraneous #pragma pack(1). Signed-off-by: Stuart Yoder Reviewed-by: Heinrich Schuchardt --- uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/TCG2/BlackBoxTest

Re: [edk2-devel] [PATCH v2 0/4] TCG2 protocol clean up

On 4/16/24 16:53, Stuart Yoder wrote: This patch series cleans up some issues found when building edk2-test with a non-GCC compiler: -TPMT_HA struct had an error due to incorrect use of C flexible array member -compute struct member offsets using OFFSET_OF, which is not GCC specific -cle

Re: [edk2-devel] edk2-test Release candidate 2: edk2-test-rc2_202405

On 5/4/24 01:47, G Edhaya Chandran wrote: Hi All,    A new release candidate is published after upstreaming Stuart's commits on build cleanup. _https://github.com/tianocore/edk2-test/tree/edk2-test-rc2_202405_ The updates since

[edk2-devel] [PATCH 1/1] ShellPkg: add missing linefeed in reset message

sing linefeed. Signed-off-by: Heinrich Schuchardt --- ShellPkg/Library/UefiShellLevel2CommandsLib/Reset.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ShellPkg/Library/UefiShellLevel2CommandsLib/Reset.c b/ShellPkg/Library/UefiShellLevel2CommandsLib/Reset.c index 361c47e43059.

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: setting key toggle state may be unsupported

It is allowable that a system does not support EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.SetState(). For instance a serial console would not allow to set toggle keys. In this case do not expect the function to check its arguments. It will typically directly return EFI_UNSUPPORTED. Signed-off-by: Heinrich

[edk2-devel] [edk2-core] [PATCH 1/1] MdeModulePkg: errors in UninstallMultipleProtocolInterfaces

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1869 The UEFI spec requires that if any error occurs in UninstallMultipleProtocolInterfaces(), EFI_INVALID_PARAMETER is returned and not the return code of UninstallProtocolInterface(). Signed-off-by: Heinrich Schuchardt --- MdeModulePkg/Core

[edk2-devel] [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: SNP Statistics may be unsupported

ate assertion messages always directly after each individual check. Fix some typos in comments and messages. Signed-off-by: Heinrich Schuchardt --- v2: Create assertion messages always directly after each individual check. Fix typos in comments and messa

[edk2-devel] [edk2-core] [PATCH v2 1/1] MdeModulePkg: Make retval in UninstallMultipleProtocol follow Spec

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1869 The UEFI spec requires that if any error occurs in UninstallMultipleProtocolInterfaces(), EFI_INVALID_PARAMETER is returned and not the return code of UninstallProtocolInterface(). Signed-off-by: Heinrich Schuchardt --- v2 Adjust

[edk2-devel] [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: setting key toggle state may be unsupported

: Heinrich Schuchardt --- v2: Issue warning if EFI_UNSUPPORTED is returned when called with invalid parameters. --- .../BlackBoxTest/SimpleTextInputExBBTestConformance.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI

[edk2-devel] [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: buffer overflow in NotifyFunctionTplEx()

CloseEvent() ensures that we only measure the events we are interested in. In function NotifyFunctionTplEx() check the index against the buffer limits. Stop recording after MAX_TEST_EVENT_NUM events. Fixes: c093702f98ad (""uefi-sct/SctPkg:Fix flaw in BBTestCreateEventEx_Func_Sub3) Sig

Re: [edk2-devel] [edk2-test] [PATCH v2 1/1] uefi-sct/SctPkg: setting key toggle state may be unsupported

add my name. Best regards Heinrich Schuchardt I could help to add it when I push the patch. With that - Reviewed by: Eric Jin Best Regards Eric -Original Message- From: Heinrich Schuchardt Sent: Thursday, September 12, 2019 2:45 AM To: EDK II Development Cc: Jin, Eric ; Supreeth

[edk2-devel] Copyright EDK II C Coding Standards Specification

Hello Stephano, the EDK II C Coding Standards Specification is available at: https://raw.githubusercontent.com/tianocore-docs/Docs/master/Specifications/CCS_2_1_Draft.pdf It is copyright restricted, allowing only copying for internal use. As EDK II has moved to be open source wouldn't it make

Re: [edk2-devel] [edk2-core] [PATCH v2 1/1] MdeModulePkg: Make retval in UninstallMultipleProtocol follow Spec

to last. Thanks for reviewing. Best regards Heinrich Since these are the comments update and with these addressed, Reviewed-by: Dandan Bi Thanks, Dandan -Original Message- From: Heinrich Schuchardt [mailto:xypron.g...@gmx.de] Sent: Tuesday, September 10, 2019 4:12 PM To: EDK II Deve

[edk2-devel] [edk2-core] [PATCH v3 1/1] MdeModulePkg: Make retval in UninstallMultipleProtocol follow Spec

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1869 The UEFI spec requires that if any error occurs in UninstallMultipleProtocolInterfaces(), EFI_INVALID_PARAMETER is returned and not the return code of UninstallProtocolInterface(). Signed-off-by: Heinrich Schuchardt Reviewed-by: Dandan Bi

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: UninstallMultipleProtocols, checkpoint 7-9

assertions. InterfaceCheckpoint6 has already been corrected with commit 30c4031acbdb ("uefi-sct/SctPkg: assertion for UninstallMultipleProtocols") Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/ProtocolHandlerBBTestFunction_2.c | 6 +++--- 1 file changed, 3 insert

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo DuplicateDevicePath

%s/DupilicateDevicePath/DuplicateDevicePath/g Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/DevicePathUtilitiesBBTestFunction.c | 2 +- .../BlackBoxTest/DevicePathUtilitiesBBTestMain.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/uefi

[edk2-devel] [PATCH 1/1] uefi-sct/SctPkg: SNP ReceiveFilters may be unsupported

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2197 If EFI_SIMPLE_NETWORK.ReceiveFilters() is not supported, it will return EFI_UNSUPPORTED. In this case do not expect input parameters to be checked for conformance. Signed-off-by: Heinrich Schuchardt

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: use EFI_UNICODE_COLLATION_PROTOCOL2_GUID

-off-by: Heinrich Schuchardt --- uefi-sct/SctPkg/Library/SctGuidLib/SctGuidLib.c | 2 +- uefi-sct/SctPkg/Library/SctLib/Guid.c | 2 +- uefi-sct/SctPkg/Library/SctLib/Init.c | 6 +++--- uefi-sct/SctPkg/Library/SctLib/SctLib.inf

Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Add MediaPresentSupported check

On 9/24/19 10:50 AM, xianhui liu wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2061 check MediaPresent while MediaPresentSupported is TRUE sync change from EFI to IHV SimpleNetworkBBTestFunction Thanks for addressing this issue. Cc: Heinrich Schuchardt %s/Cc:/Reported-by

[edk2-devel] [PATCH 1/1] uefi-sct/SctPkg: network: missing EFIAPI

/RELEASE_GCC5/X64/SctPkg/TestCase/RIVL/Protocol/ Http/Http/HttpENTSTest/DEBUG/AutoGen.h:77:1: note: previous declaration of ‘HttpENTSTestMain’ was here 77 | HttpENTSTestMain ( | ^~~~ Signed-off-by: Heinrich Schuchardt --- This is only a partial fix to the problem reported in #2126

Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Add MediaPresentSupported check

@gmx.de Cc: Supreeth Venkatesh ; Jin, Eric Subject: Re: [edk2-devel] [edk2-test][Patch] uefi-sct/SctPkg: Add MediaPresentSupported check Please refer to below comments. -Original Message- From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Heinrich Schuchardt Sent:

Re: [edk2-devel] [edk2-core] [PATCH v3 1/1] MdeModulePkg: Make retval in UninstallMultipleProtocol follow Spec

On 2/19/20 6:58 AM, Bi, Dandan wrote: This patch seems be reviewed but not submitted. Hope it can be covered in Q1 stable tag. I have reopened https://bugzilla.tianocore.org/show_bug.cgi?id=1869 Thanks, Dandan -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this

[edk2-devel] [edk] [PATCH] ShellPkg/edit: allow non-ASCII characters in edit

characters as input in ASCII mode. When saving a file in ASCII mode replace non-ASCII characters by a question mark ('?'). Signed-off-by: Heinrich Schuchardt --- .../Edit/FileBuffer.c | 21 +++ 1 file changed, 17 insertions(+), 4 deletions(-) diff --git

[edk2-devel] [edk2] [PATCH] ShellPkg/edit: typo "%d Lines Wrote"

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2379 When a file is saved in the edit command a status message L"%d Lines Wrote" is displayed. The hexedit command suffers from the same typo. Change the message to L"%d Lines Written". Signed-off-by: Heinrich Schuchardt -

[edk2-devel] [edk] [PATCH] ShellPkg/edit: allow non-ASCII characters in edit

characters as input in ASCII mode. When saving a file in ASCII mode replace non-ASCII characters by a question mark ('?'). Signed-off-by: Heinrich Schuchardt --- Resent due to a typo in Limings email-address. --- .../Edit/FileBuffer.c | 21 +++ 1 file c

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: typo Verity in TimeServicesBBTestFunction

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2407 %s/Verity/Verify/g Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/TimeServicesBBTestFunction.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: EFI_RNG_PROTOCOL.GetInfo check size != 0

size is non-zero too. Signed-off-by: Heinrich Schuchardt --- .../RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/RandomNumber/BlackBoxTest/RandomNumberBBTestConformance.c

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: assertion for UninstallMultipleProtocols

assertion. Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/ProtocolHandlerBBTestFunction_2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/BootServices/ProtocolHandlerServices/BlackBoxTest/ProtocolHandlerBBTestFunction_2.

[edk2-devel] [edk2-test] [PATCH] uefi-sct/SctPkg: StrUpr() test for cyrillic letters

unchanged. This leads to rejecting the output of UEFI implementations fully supporting cyrillic letters. Replace cyrillic 0x50f by 0x50 ('P') to avoid false positives. Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/UnicodeCollation2BBTestFunction.c | 2 +- 1 file

Re: [edk2-devel] [PATCH v3 1/1] ShellPkg/CommandLib: avoid NULL derefence and memory leak

On 5/10/19 4:32 PM, Carsey, Jaben wrote: Reviewed-by: Jaben Carsey Code change looks good visually. Somehow this patch https://edk2.groups.io/g/devel/message/40395 was never merged. Who is the maintainer for the ShellPkg? Best regards Heinrich -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: Yo

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo 'Remained test cases'

%s/Remained/Remaining/g Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heinrich Schuchardt --- .../SctPkg/TestInfrastructure/SCT/Framework/Execute/Execute.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/uefi-sct/SctPkg/TestInfrastructure/SCT

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: buffer overflow in NotifyFunctionTplEx()

gainst the buffer limits. Stop recording after MAX_TEST_EVENT_NUM events. Fixes: c093702f98ad (""uefi-sct/SctPkg:Fix flaw in BBTestCreateEventEx_Func_Sub3) Contributed-under: TianoCore Contribution Agreement 1.1 Signed-off-by: Heinrich Schuchardt --- ...rTaskPriorityServicesBBTest

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo 'Remained test cases'

On 9/4/19 4:27 AM, Jin, Eric wrote: Hi Heinrich Schuchardt, According to https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format The statement "Contributed-under:..." need be removed. With that: Reviewed-by: Eric Jin If no object, I will help to push with this

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix typo 'supproted'

%s/supproted/supported/g Signed-off-by: Heinrich Schuchardt --- .../Protocol/PciIo/BlackBoxTest/PciIoBBTestStress.c | 2 +- .../BlackBoxTest/SimpleNetworkBBTestConformance.c| 12 ++-- .../BlackBoxTest/SimpleNetworkBBTestFunction.c | 12 ++-- .../BlackBoxTest

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: SNP Statistics may be unsupported

If EFI_SIMPLE_NETWORK.Statistics() is not supported, it will return EFI_UNSUPPORTED. In this case do not expect input parameters to be checked for conformance. Signed-off-by: Heinrich Schuchardt --- .../SimpleNetworkBBTestConformance.c | 112 +++--- 1 file changed, 72

[edk2-devel] [PATCH 1/1] ShellPkg/CommandLib: avoid NULL derefence and memory leak

anoCore Contribution Agreement 1.1 Signed-off-by: Heinrich Schuchardt --- .../UefiShellCommandLib/UefiShellCommandLib.c | 20 +-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c b/ShellPkg/Library

Re: [edk2-devel] [PATCH 1/1] ShellPkg/CommandLib: avoid NULL derefence and memory leak

h on a Windows system and resend it. Best regards Heinrich > >> -Original Message- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Heinrich Schuchardt >> Sent: Friday, April 5, 2019 9:29 AM >> To: Carsey, Jaben ; Ni, Ray ; >

Re: [edk2-devel] [PATCH 1/1] ShellPkg/CommandLib: avoid NULL derefence and memory leak

ub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=- From 9478bbcd1d8a03762924a0b4533c1b84cbfcaa57 Mon Sep 17 00:00:00 2001 From: Heinrich Schuchardt Date: Fri, 5 Apr 2019 03:06:18 +0200 Subject: [PATCH 1/1] ShellPkg/CommandLib: avoid NULL derefence and memory leak Since TianoCore EDK2 commit d65f2cea36d1 ("ShellPkg/Comma

[edk2-devel] [PATCH v2 1/1] ShellPkg/CommandLib: avoid NULL derefence and memory leak

anoCore Contribution Agreement 1.1 Signed-off-by: Heinrich Schuchardt --- v2 resend with transfer encoding base64 --- .../UefiShellCommandLib/UefiShellCommandLib.c | 20 +-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/ShellPkg/Library/UefiShellCommandLib/Uefi

[edk2-devel] [PATCH v3 1/1] ShellPkg/CommandLib: avoid NULL derefence and memory leak

anoCore Contribution Agreement 1.1 Signed-off-by: Heinrich Schuchardt Reviewed-by: Zhichao Gao --- v3 resend as quoted-printable --- .../UefiShellCommandLib/UefiShellCommandLib.c | 20 +-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/ShellPkg/Library

Re: [edk2-devel] [RFC PATCH 2/2] Maintainers.txt: Add entry for new RiscVVirt

On 9/6/22 19:10, Sunil V L wrote: Signed-off-by: Sunil V L --- Maintainers.txt | 5 + 1 file changed, 5 insertions(+) Acked-by: Heinrich Schuchardt diff --git a/Maintainers.txt b/Maintainers.txt index a4a0e4b907..6fac3369dd 100644 --- a/Maintainers.txt +++ b/Maintainers.txt

Re: [edk2-devel] [RFC PATCH 1/2] RISC-V: Add Qemu Virt platform support

On 9/6/22 19:10, Sunil V L wrote: Add build infrastructure files to boot qemu virt machine. EDK2 will boot as S-mode payload of opensbi. There is no integrated opensbi (M-mode firmware) within EDK2 for virt machine. It relies on the RISC-V calling convention that M-mode firmware like opensbi

Re: [edk2-devel] [RFC PATCH 1/2] RISC-V: Add Qemu Virt platform support

On 9/6/22 19:10, Sunil V L wrote: Add build infrastructure files to boot qemu virt machine. EDK2 will boot as S-mode payload of opensbi. There is no integrated opensbi (M-mode firmware) within EDK2 for virt machine. It relies on the RISC-V calling convention that M-mode firmware like opensbi wi

[edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable services conformance test

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2865 QueryVariableInfo() returning EFI_SUCCESS for a legal combination of attributes is not an error. Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/AuthVariableServicesBBTestConformance.c| 2 +- 1 file changed, 1 insertion

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: EFI_RNG_PROTOCOL.GetInfo check size != 0

Hello Eric, hello Edhaya, probably due to a maintainer change the patch below was missed out. Could you, please, review and merge it. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2438 Best regards Heinrich On 12/28/19 4:37 PM, Heinrich Schuchardt wrote: > REF: ht

Re: [edk2-devel] [PATCH] Check return status on calls to GetTime()

) return code. If it doesn't return > EFI_SUCCESS, then use the traditional 1/1/1970 epoch so that the test > report at least looks sane, but it is obvious that we don't have a valid > timestamp. > > Fixes: https://bugzilla.tianocore.org/show_bug.cgi?id=2870 > > Cc: G Edha

Re: [edk2-devel] [PATCH] Check return status on calls to GetTime()

On 06.08.20 15:31, Samer El-Haj-Mahmoud wrote: > One issue here is that UEFI 2.8 spec language around allowing runtime > services (like GetTime() ) to return EFI_UNSUPPORTED is a bit vague: > > "" > EFI_UNSUPPORTED > This call is not supported by this platform at the time the call is made. The >

Re: [edk2-devel] [edk2-test] [PATCH 1/1] uefi-sct/SctPkg: fix variable services conformance test

On 8/4/20 1:13 PM, Samer El-Haj-Mahmoud wrote: > Reviewed-by: Samer El-Haj-Mahmoud Dear Edhaya, could you, please, consider these patches https://edk2.groups.io/g/devel/message/63354 https://edk2.groups.io/g/devel/message/52599 for review and merging. Best regards Heinrich -=-=-=-=-=-=-=-=-

[edk2-devel] EDK II bug 3066: please merge [PATCH 1/1] BaseTools: add edk2-test repo to SetupGit.py

Dear Bob, dear Liming, The patch appended to https://bugzilla.tianocore.org/show_bug.cgi?id=3066 was reviewed by Yuwei Chen last year but has not been merged since. Please, consider adding the patch to EDK II. Cf. https://edk2.groups.io/g/devel/message/67192 Best regards Heinrich -=-=-=-=-=

Re: [edk2-devel] Return EFI_INVALID_PARAMETER if attribute only has EFI_VARIABLE_NON_VOLATILE set

On 10/21/21 12:18, Sunny Wang wrote: Hi Liming, Hao, and all Now we’re checking the SCT runtime variable service test case. https://github.com/tianocore/edk2-test/blob/92a0343c1553342c53fae9d9d646b763add232c0/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/Vari

Re: [edk2-devel] [edk2-test] [PATCH v1 1/1] SctPkg: Fix X64 build errors for GCC toolchain

On 10/26/21 13:42, Abdul Lateef Attar via groups.io wrote: Corrects the function declaration/definition by adding EFIAPI. Removes duplicate functions. Unfortunately this mail is not a valid patch: $ wget https://patchew.org/EDK2/20211026114226.30761-1-abdat...@amd.com/mbox $ git am mbox --kee

[edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: invalid values for SetWakeupTime()

the years 1997 and 2100. Values 1899 and 1 must lead to this error code. Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/TimeServicesBBTestConformance.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI

Re: [edk2-devel] [edk2-test PATCH v1 0/2] Add RISCV64 support to SctPkg

On 08.02.21 15:30, Daniel Schaefer wrote: > On 12/2/20 1:37 AM, Heinrich Schuchardt wrote: >> On 12/1/20 6:11 PM, Daniel Schaefer wrote: >>> On 12/2/20 12:59 AM, Heinrich Schuchardt wrote: >>>> On 12/1/20 5:17 PM, Daniel Schaefer wrote: >>>>> REF:https:

Re: [edk2-devel] [edk2-test PATCH v1 2/2] SctPkg: Enable RISCV64 support using AARCH64 sources

ndholm wrote: >> On Wed, Dec 02, 2020 at 00:17:52 +0800, Daniel Schaefer wrote: >>> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3042 >>> >>> TODO: Need to check whether we can avoid copying Aarch64 sources. >>> >>> Cc: Leif Lindholm >&

Re: [edk2-devel] [edk2-test PATCH v1 2/2] SctPkg: Enable RISCV64 support using AARCH64 sources

On 09.02.21 13:42, Leif Lindholm wrote: > On Mon, Feb 08, 2021 at 18:04:45 +0100, Heinrich Schuchardt wrote: >>>>> diff --git a/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S >>>>> b/uefi-sct/SctPkg/SCRT/SCRTApp/Riscv64/GoVirtual.S >>>>> new

[edk2-devel] [PATCH edk2-test 1/1] SctPkg: remove CR in uefi-sct/SctPkg/build.sh

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3239 A superfluous carriage return leads to an error: uefi-sct/SctPkg/build.sh: line 61: syntax error near unexpected token `fi' uefi-sct/SctPkg/build.sh: line 61: `fi' Signed-off-by: Heinrich Schuchardt --- uefi-sct/SctPkg/bu

[edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: typo Positoin

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3244 %s/Positoin/Position/g %s/positoin/position/g Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/SimpleTextOutBBTestConformance_efi.c | 4 ++-- .../BlackBoxTest/SimpleTextOutBBTestConformance_uefi.c| 4

[edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: type mismatch in SimpleTextOut test

t output like: MaxMode=-549755813885, -549755813885 is 0x0xFF83. So MaxMode actually is an INT32 with value 3 in this example. Convert the parameters to UINTN. Signed-off-by: Heinrich Schuchardt --- .../SimpleTextOutBBTestFunction_uefi.c| 624 +- 1 file

[edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: IHV: type mismatch in Simple Network test

- Unsupported, Filter - Mode->ReceiveFilterSetting has only 32 bit. The true value is 0. Convert the parameters to UINTN. Signed-off-by: Heinrich Schuchardt --- .../SimpleNetworkBBTestFunction.c | 50 +-- 1 file changed, 25 insertions(+), 25 deleti

[edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: type mismatch in Simple Network test

- Unsupported, Filter - Mode->ReceiveFilterSetting has only 32 bit. The true value is 0. Convert the parameters to UINTN. Signed-off-by: Heinrich Schuchardt --- .../SimpleNetworkBBTestFunction.c | 52 +-- 1 file changed, 26 insertions(+), 26 deleti

[edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: IHV: type mismatch in SimpleTextOut test

t output like: MaxMode=-549755813885, -549755813885 is 0x0xFF83. So MaxMode actually is an INT32 with value 3 in this example. Convert the parameters to UINTN. Signed-off-by: Heinrich Schuchardt Reviewed-by: G Edhaya Chandran --- .../SimpleTextOutBBTestFunction_uefi.c

[edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: fix BuildAtaDeviceNode()

ta(Primary,Master,0) Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/DevicePathToTextBBTestMain.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/BlackBoxTest/DevicePathToTextBBTestMain.

[edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: correct print code for EFI_MEMORY_TYPE

REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2284 EFI_MEMORY_TYPE is an enum. SctPrint expects an UINTN when printing with %d. Add missing conversions in MemoryAllocationServicesBBTestFunction. Signed-off-by: Heinrich Schuchardt --- .../MemoryAllocationServicesBBTestFunction.c | 98

Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: IHV: type mismatch in SimpleTextOut test

hange. Best regards Heinrich Best Regards, Sunny Wang -Original Message- From: devel@edk2.groups.io On Behalf Of Heinrich Schuchardt via groups.io Sent: Tuesday, March 30, 2021 11:09 PM To: EDK II Development Cc: Eric Jin ; G Edhaya Chandran ; Barton Gao ; Arvin Chen ; Samer El-Haj-Ma

Re: [edk2-devel] [PATCH] Add support for RISCV GOT/PLT relocations

;& !__STDC_HOSTED__ #pragma GCC visibility push (hidden) #endif Maybe this is something we should additionally explore. Best regards Heinrich >Signed-off-by: Sunil V L >Cc: Abner Chang >Cc: Daniel Schaefer >Cc: Heinrich Schuchardt >--- > BaseTools/Source/C/GenFw/Elf64Con

Re: [edk2-devel] Commit a9d1fb58 - uefi-sct/SctPkg: allowable NotifyTpl in CreateEvent

age- From: Sunny Wang Sent: Thursday, June 10, 2021 4:26 AM To: Heinrich Schuchardt ; Samer El-Haj-Mahmoud ; Barton Gao ; G Edhaya Chandran Cc: Sunny Wang Subject: RE: Commit a9d1fb58 Thanks for the information, Heinrich. I think we need to further work on this for Mike's comment with

Re: [edk2-devel] [edk2-test][PATCH v1 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

, have a look at commit ae7e5477b555 ("uefi-sct/SctPkg: allowable NotifyTpl in CreateEventEx") too. Acked-by: Heinrich Schuchardt > > Cc: Samer El-Haj-Mahmoud > Cc: G Edhaya Chandran > Cc: Barton Gao > Cc: Heinrich Sc

Re: [edk2-devel] [edk2-test][PATCH v2 1/1] uefi-sct/SctPkg: Not create event with TPL_HIGH_LEVEL

/g/devel/message/76338 > > Cc: Samer El-Haj-Mahmoud > Cc: G Edhaya Chandran > Cc: Barton Gao > Cc: Heinrich Schuchardt > Cc: Michael D Kinney > Signed-off-by: Sunny Wang Acked-by: Heinrich Schuchardt > --- > .

[edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: uefi-sct: QueryVariableInfo(EFI_VARIABLE_NON_VOLATILE)

QueryVariableInfoConfTestSub5(). Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/VariableServicesBBTestConformance.c | 1 + 1 file changed, 1 insertion(+) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/RuntimeServices/VariableServices/BlackBoxTest/VariableServicesBBTestConformance.c

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

On 9/29/23 04:02, John Chew wrote: Update Gigadevice norflash list: gd25q16, gd25q32, gd25q64, gd25lq64c, gd25q128, gd25lq128, gd25q256 Add Silicon Kaiser norflash list: sk25lp128 Cc: Sunil V L Cc: Li Yong Cc: Heinrich Schuchardt Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

On 29.09.23 15:35, YuinYee Chew wrote: Hi Heinrich, Both gd25lq128d and gd25lq128e share the same ID "{ 0xc8, 0x60, 0x18}" gd25lq128d : https://www.gigadevice.com/product/flash/product-series/spi-nor-flash/gd25lq128d.html gd25lq128e : https://www.gigadevice.com/product/flash/product-series/spi

Re: [edk2-devel] [RFC PATCH V2 03/19] MdePkg/Protocol: Add RiscVBootProtocol.h

On 9/7/22 13:36, Sunil V L wrote: RISC-V UEFI platforms need to implement RISCV_EFI_BOOT_PROTOCOL. Add header file with the definitions of this protocol. Signed-off-by: Sunil V L Reviewed-by: Heinrich Schuchardt --- MdePkg/Include/Protocol/RiscVBootProtocol.h | 35

Re: [edk2-devel] [RFC PATCH V2 08/19] MdePkg: Add RiscVSbiLib Library for RISC-V

On 9/7/22 13:36, Sunil V L wrote: This library is required to make SBI ecalls from the S-mode EDK2. Signed-off-by: Sunil V L --- MdePkg/Library/RiscVSbiLib/RiscVSbiLib.inf | 27 +++ MdePkg/Include/Library/RiscVSbiLib.h | 129 +++ MdePkg/Library/RiscVSbiLib/RiscVSbiLib.c

Re: [edk2-devel] [RFC PATCH V2 06/19] MdePkg/BaseLib: RISC-V: Add generic CPU related functions

On 9/7/22 13:36, Sunil V L wrote: EDK2 in S-mode needs to use SSCRATCH register. Implement functions to set/get the SSCRATCH register. Signed-off-by: Sunil V L --- MdePkg/Library/BaseLib/BaseLib.inf | 1 + MdePkg/Include/Library/BaseLib.h| 10 ++ MdePkg/Library/BaseLib/

Re: [edk2-devel] [RFC PATCH V2 02/19] MdePkg/MdePkg.dec: Add RISCV_EFI_BOOT_PROTOCOL GUID

On 9/7/22 13:36, Sunil V L wrote: RISC-V UEFI based platforms need to support RISCV_EFI_BOOT_PROTOCOL. Add this protocol GUID definition. Signed-off-by: Sunil V L Reviewed-by: Heinrich Schuchardt --- MdePkg/MdePkg.dec | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MdePkg

Re: [edk2-devel] [RFC PATCH V2 07/19] MdePkg: Add ArchTimerLib library

On 9/7/22 13:36, Sunil V L wrote: This library implements the TimerLib.h functionality. This library is similar to CpuTimerLib but needs the library constructor. Signed-off-by: Sunil V L --- MdePkg/Library/ArchTimerLib/ArchTimerLib.inf | 40 +++ MdePkg/Library/ArchTimerLib/RiscV64/C

Re: [edk2-devel] [RFC PATCH V2 18/19] RISC-V: Add Qemu Virt platform support

On 9/7/22 13:36, Sunil V L wrote: Add build infrastructure files to boot qemu virt machine. EDK2 will boot as S-mode payload of opensbi. There is no integrated opensbi (M-mode firmware) within EDK2 for virt machine. It relies on the RISC-V calling convention that M-mode firmware like opensbi wi

Re: [edk2-devel] [PATCH 0/4] OvmfPkg/RiscVVirt: Separate code and variable storage

e branch : > https://github.com/vlsunil/edk2/tree/separate_code_vars > > CI tests passed (#4553). > > Cc: Ard Biesheuvel > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Gerd Hoffmann > Cc: Andrei Warkentin > Cc: Heinrich Schuchardt > Cc: Dann Frazier > &

Re: [edk2-devel] [PATCH 0/4] OvmfPkg/RiscVVirt: Separate code and variable storage

On 6/15/23 13:50, Sunil V L wrote: On Wed, Jun 14, 2023 at 07:11:18PM +0200, Heinrich Schuchardt wrote: Sunil V L schrieb am Mi., 14. Juni 2023, 19:01: Recent updates to RISC-V qemu virt platform merged today (07/14), have enabled both pflash devices for the S-mode payload like EDK2. These

Re: [edk2-devel] [PATCH v2 4/4] OvmfPkg/RiscVVirt: Add a readme for build and test

On 6/16/23 12:16, Sunil V L wrote: Add a readme file which provides information regarding how to build and test EDK2 on RISC-V qemu virt platform. Signed-off-by: Sunil V L Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Cc: Andrei Warkentin Unfortunately you only se

Re: [edk2-devel] [edk2-staging/RiscV64QemuVirt PATCH V8 00/19] Add support for RISC-V virt machine

On 2/17/23 10:16, Michael Brown wrote: On 17/02/2023 04:27, Sunil V L wrote: On Thu, Feb 16, 2023 at 03:45:49PM -0700, dann frazier wrote:    Thanks for your work getting this merged! In the above wiki, it notes that GCC 12+ is not supported. Is that still accurate? If so, can you clarify wh

Re: [edk2-devel] [PATCH V2 1/1] BaseTools/tools_def.template: Update -march parameter for RISC-V

ao Cc: Yuwei Chen Cc: Andrei Warkentin Cc: Heinrich Schuchardt Signed-off-by: Sunil V L Tested-by: Gerd Hoffmann Tested-by: Heinrich Schuchardt --- Changes since V1: 1) Updated commit message 2) Added Tested-by tag from Gerd BaseTools/Conf/tools_def.template | 2 +- 1 fil

[edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: unsupported TEXT_INPUT_EX.SetState

) must not report an error in this case. Fixes: e9c21711c17 ("uefi-sct/SctPkg:Add checkpoint of ReadKeyStrokeEx Toggle state") Signed-off-by: Heinrich Schuchardt --- .../BlackBoxTest/SimpleTextInputExBBTestFunction.c | 3 +++ .../BlackBoxTest/SimpleTextInputExBBTestFuncti

[edk2-devel] [PATCH edk2-test v2 1/1] uefi-sct/SctPkg: fix BuildAtaDeviceNode()

ta(Primary,Master,0) Signed-off-by: Heinrich Schuchardt --- v2: correct parentheses --- .../BlackBoxTest/DevicePathToTextBBTestMain.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/uefi-sct/SctPkg/TestCase/UEFI/EFI/Protocol/DevicePathToText/Bl