g care of this.
>
> Reviewed-by: Ard Biesheuvel
Acked-by: Corvin Köhne
>
> > > -Original Message-
> > > From: Laszlo Ersek
> > > Sent: Saturday, November 11, 2023 7:58 AM
> > > To: devel@edk2.groups.io
> > > Cc: Anatol Belski ; Wa
d38e593355d9/OvmfPkg/Bhyve/PlatformPei/Platform.c#L156-L157
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Rebecca Cran
---
OvmfPkg/Bhyve/PlatformPei/Platform.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/OvmfPkg/Bhyve/PlatformPei/P
On Fri, 2023-11-17 at 17:09 +0100, Laszlo Ersek wrote:
> On 11/17/23 13:43, Corvin Köhne wrote:
> > Bhyve uses an io port range of [ 0x2000, 0x1 ] [1]. At the
> > moment,
> > EDKII is using a subset of this range [ 0xC000, 0x1 ] [2]. Even
> > though the EDKII ra
bfe2701fd38e593355d9/OvmfPkg/Bhyve/PlatformPei/Platform.c#L156-L157
[3] https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=274389
Signed-off-by: Corvin Köhne
Reviewed-by: Laszlo Ersek
Reviewed-by: Rebecca Cran
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Liming Gao
Cc: Jiewen Yao
---
OvmfPkg/Bhyve/Pl
On Tue, 2024-02-20 at 09:15 +0100, Gerd Hoffmann wrote:
> On Tue, Feb 20, 2024 at 06:27:21AM +, Min Xu wrote:
> > On Monday, February 12, 2024 11:22 PM, Gerd Hoffmann wrote:
> > > On Thu, Feb 01, 2024 at 10:38:43AM +0100, Gerd Hoffmann wrote:
> > > > Hi,
> > > >
> > > > > > Can you confirm (
.)
>
> Cc: Anatol Belski
> Cc: Andrei Warkentin
> Cc: Anthony Perard
> Cc: Ard Biesheuvel
> Cc: Corvin Köhne
> Cc: Erdem Aktas
> Cc: Gerd Hoffmann
> Cc: Jianyong Wu
> Cc: Jiewen Yao
> Cc: Michael Roth
> Cc: Min Xu
> Cc: Rebecca Cran
> Cc: Sunil V
On Tue, 2024-01-30 at 14:04 +0100, Gerd Hoffmann wrote:
> Specifically before running lzma uncompress of the main firmware
> volume.
> This is needed to make sure caching is enabled, otherwise the
> uncompress
> can be extremely slow.
>
> Adapt the ASSERTs and MTRR setup in PlatformInitLib to the
On Thu, 2024-05-30 at 11:03 +0200, Gerd Hoffmann wrote:
> Hi,
>
> > > - SetMem (&MtrrSettings.Fixed, sizeof MtrrSettings.Fixed,
> > > 0x06);
> > > + SetMem (&MtrrSettings.Fixed, sizeof MtrrSettings.Fixed,
> > > MTRR_CACHE_WRITE_BACK);
> > > ZeroMem (&MtrrSettings.Variables, sizeof
> >
hose, fall back to OVMF tables.
Implementation is similar to .
Signed-off-by: Corvin Köhne
CC: Ard Biesheuvel
CC: Jiewen Yao
CC: Jordan Justen
CC: Gerd Hoffmann
CC: Rebecca Cran
CC: Peter Grehan
CC: devel@edk2.groups.io
CC: Michael D Kinney
CC: Liming Gao
CC: Zhiguang Liu
---
MdePkg/In
From: Corvin Köhne
QemuFwCfg is more powerful and has more use cases than BhyveFwCtl. Try
to use QemuFwCfg in first place. If that fails, fall back to
BhyveFwCtl.
Signed-off-by: Corvin Köhne
CC: Ard Biesheuvel
CC: Jiewen Yao
CC: Jordan Justen
CC: Gerd Hoffmann
CC: Rebecca Cran
CC: Peter
in
CC: Ard Biesheuvel
CC: Jiewen Yao
CC: Jordan Justen
CC: Gerd Hoffmann
CC: Rebecca Cran
CC: Peter Grehan
CC: devel@edk2.groups.io
CC: FreeBSD Virtualization
Corvin Köhne (1):
OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg
OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf |
From: Corvin Köhne
QemuFwCfg is much more powerful than BhyveFwCtl. Sadly, BhyveFwCtl
decided to use the same IO ports as QemuFwCfg. It's not possible to use
both interfaces simultaneously. So, prefer QemuFwCfg over BhyveFwCtl.
Signed-off-by: Corvin Köhne
CC: Ard Biesheuvel
CC: Jiewe
Hi Gerd,
> There is FW_CFG_NB_CPUS + FW_CFG_MAX_CPUS. ovmf uses different names,
> see OvmfPkg/Include/IndustryStandard/QemuFwCfg.h
>
> PlatformPei for qemu uses QemuFwCfgItemSmpCpuCount aka FW_CFG_NB_CPUS,
> which is the number of cpus which are online.
>
> I think FW_CFG_MAX_CPUS is basically u
Hi Gerd,
> Hmm, so QemuFwCfg and BhyveFwCtl are incompatible but use the same
> ports? I guess the signature used is different then so the guest
> has a chance to figure which one is active?
Yes, BhyveFwCtl uses another signature.
Best regards
Corvin
Beckhoff Automation GmbH & Co. KG | Manag
From: Corvin Köhne
QemuFwCfg is much more powerful than BhyveFwCtl. Sadly, BhyveFwCtl
decided to use the same IO ports as QemuFwCfg. It's not possible to use
both interfaces simultaneously. So, prefer QemuFwCfg over BhyveFwCtl.
Signed-off-by: Corvin Köhne
Acked-by: Gerd Hoffmann
CC
Hi Gerd,
> But I think I'd tend to keep the bhyve-specific behavior nevertheless,
> so you don't have to worry about qemu quirks.
Ok. I will leave it as is.
> Or go the qemu route and generate the acpi tables on the host instead.
> When you generate the acpi tables in the guest firmware you alwa
An USB driver is required to use a keyboard or mouse while installing
an OS or while in a bootloader menu like grub when using GPU + USB
Passthrough.
Signed-off-by: Corvin Köhne
---
OvmfPkg/Bhyve/BhyveX64.dsc | 11 +++
OvmfPkg/Bhyve/BhyveX64.fdf | 10 ++
2 files changed, 21
ayout:
[..., lowmemlimit] RAM
[lowmemlimit, gsmbase] Memory hole (may be absent)
[gsmbase, 0xC000 ] GSM (may be absent)
[0xC000 , 0xE000 ] PCI Space
Signed-off-by: Corvin Köhne
---
OvmfPkg/Bhyve/BhyveX64.dsc | 4 ++--
OvmfPkg/Bhyve/Platfo
Hi,
GPU-Passthrough for bhyve requires a few patches to work properly.
These patches will allow GPU-Passthrough for bhyve.
It will work for dedicated AMD GPUs and integrated Intel GPUs.
Best Regards,
Corvin
Corvin Köhne (4):
OvmfPkg/Bhyve: enable bus enumeration
Revert "OvmfPkg/
Neccessary for GPU Passthrough of dedicated AMD GPUs. For Linux
guests, AMD GPUs require that their PCI ROM is processed by UEFI.
Enable bus enumeration to process the PCI ROM of all devices.
Signed-off-by: Corvin Köhne
---
OvmfPkg/Bhyve/BhyveX64.dsc | 2 +-
1 file changed, 1 insertion(+), 1
This reverts commit c2f24ba3218ae91a8d5a1a31c31dad3417850d0c.
Revert this commit to enable bus enumeration properly.
Signed-off-by: Corvin Köhne
---
OvmfPkg/Bhyve/BhyveX64.dsc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve
Hi,
these patches could be merged to improve GPU-Passthrough support.
If I get an agreement with Peter about BusEnumeration, I'll create a new patch
series
Best Regards
Corvin
Corvin Köhne (2):
OvmfPkg/Bhyve: add USB support
OvmfPkg/Bhyve: use static PCI32Base address
OvmfPkg/
It's neccessary to allocate a Graphics Stolen Memory area to enable
GPU-Passthrough for integrated Intel GPUs. Therefore, use a new
memory layout with a static Pci32Baseaddress.
Old layout:
[..., lowmemlimit] RAM
[lowmemlimit, 0xE000 ] PCI Space
New layout:
[
An USB driver is required to use a keyboard or mouse while installing
an OS or while in a bootloader menu like grub when using GPU + USB
Passthrough.
---
OvmfPkg/Bhyve/BhyveX64.dsc | 11 +++
OvmfPkg/Bhyve/BhyveX64.fdf | 10 ++
2 files changed, 21 insertions(+)
diff --git a/Ovmf
Hi Peter,
> bhyve doesn't (and will likely never) support Uhci/Ehci controllers so those
> lines can be removed.
Is it possible to pass such a controller by PCI-Passthrough to a VM?
If it's possible, I would keep these lines.
Best regards
Corvin
Beckhoff Automation GmbH & Co. KG | Managing D
An USB driver is required to use a keyboard or mouse while installing
an OS or while in a bootloader menu like grub when using GPU + USB
Passthrough.
---
OvmfPkg/Bhyve/BhyveX64.dsc | 9 +
OvmfPkg/Bhyve/BhyveX64.fdf | 8
2 files changed, 17 insertions(+)
diff --git a/OvmfPkg/Bh
It's neccessary to allocate a Graphics Stolen Memory area to enable
GPU-Passthrough for integrated Intel GPUs. Therefore, use a new
memory layout with a static Pci32Baseaddress.
Old layout:
[..., lowmemlimit] RAM
[lowmemlimit, 0xE000 ] PCI Space
New layout:
[
An USB driver is required to use a keyboard or mouse while installing
an OS or while in a bootloader menu like grub when using GPU + USB
Passthrough.
Reviewed-by: Peter Grehan
Acked-by: Rebecca Cran
Signed-off-by: Corvin Köhne
---
OvmfPkg/Bhyve/BhyveX64.dsc | 9 +
OvmfPkg/Bhyve
ayout:
[..., lowmemlimit] RAM
[lowmemlimit, gsmbase] Memory hole (may be absent)
[gsmbase, 0xC000 ] GSM (may be absent)
[0xC000 , 0xE000 ] PCI Space
Reviewed-by: Peter Grehan
Acked-by: Rebecca Cran
Signed-off-by: Corvin Köhne
---
OvmfPkg/Bhyve/Bhy
On Tue, 2023-08-08 at 18:25 +0200, Ard Biesheuvel wrote:
> On Tue, 8 Aug 2023 at 15:33, Rebecca Cran wrote:
> >
> > Nit: "sizeof" is normally used like a function. And this patch
> > mixes the
> > two styles.
> >
>
> Actually, this is not unidiomatic for OVMF - sizeof takes either a
> type name
On Thu, 2023-08-10 at 14:55 +0200, Ard Biesheuvel wrote:
> On Thu, 10 Aug 2023 at 14:53, Corvin Köhne
> wrote:
> >
> > On Tue, 2023-08-08 at 18:25 +0200, Ard Biesheuvel wrote:
> > > On Tue, 8 Aug 2023 at 15:33, Rebecca Cran
> > > wrote:
> > > >
On Thu, 2023-08-10 at 15:54 -0400, Michael Kubacki wrote:
> I'm not sure why test results are not being reported that may be a
> larger issue.
>
> I pulled the branch locally, run uncrustify, and it automatically
> fixed
> the code to pass.
>
> The issue is the following function call:
>
>
CI: https://github.com/tianocore/edk2/pull/4799
Corvin Köhne (1):
OvmfPkg/Bhyve: don't exit early if RSDP is not found in memory
OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 19 ---
1 file changed, 8 insertions(+), 11 deletions(-)
--
2
If OVMF fails to find the RSDP in memory, it should fall back installing
the statically provided ACPI tables.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Rebecca Cran
Cc: Peter Grehan
---
OvmfPkg/Bhyve/AcpiPlatformDxe
Signed-off-by: Corvin Köhne
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: devel@edk2.groups.io
---
Maintainers.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 7e98083685..3ea9a4cca6 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
Signed-off-by: Corvin Köhne
Reviewed-by: Rebecca Cran
Reviewed-by: Peter Grehan
Cc: Andrew Fish
Cc: Leif Lindholm
Cc: Michael D Kinney
Cc: devel@edk2.groups.io
---
Maintainers.txt | 1 +
1 file changed, 1 insertion(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 7e98083685
Hi,
can we merge this?
https://edk2.groups.io/g/devel/message/97026
I've created a pull request if it's easier to merge for you:
https://github.com/tianocore/edk2/pull/3718
--
Best regards,
Corvin
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
Vie
Xen and bhyve are placing ACPI tables into system memory. So, they can
share the same code. Therefore, create a new library which searches and
installs ACPI tables from system memory.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc
emory. For that reason,
pick up the ACPI tables from main memory.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Rebecca Cran
Cc: Peter Grehan
---
OvmfPkg/Bhyve/BhyveX64.dsc| 1 +
.../Bhyve/AcpiPlatformDxe/AcpiPlatf
This makes the function reuseable by bhyve.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Anthony Perard
Cc: Julien Grall
Cc: Leif Lindholm
Cc: Sami Mujawar
---
.../XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf | 1 -
OvmfPkg/Include
On Tue, 2023-05-02 at 20:25 -0600, Rebecca Cran wrote:
> I applied the patch and tested it. The UEFI Shell command "acpiview"
> reports an error. I enabled the "acpiview" command with the patch:
>
>
> diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc
> index d0d2712c5662..0c04
On Fri, 2023-05-05 at 08:43 -0600, Rebecca Cran wrote:
> On 5/3/23 01:32, Corvin Köhne wrote:
>
> > diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc
> > b/OvmfPkg/Bhyve/BhyveX64.dsc
> > index d0d2712c5662..465b81ffcd51 100644
> > --- a/OvmfPkg/Bhyve/BhyveX64.dsc
> &
Xen and bhyve are placing ACPI tables into system memory. So, they can
share the same code. Therefore, create a new library which searches and
installs ACPI tables from system memory.
Signed-off-by: Corvin Köhne
Acked-by: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc
emory. For that reason,
pick up the ACPI tables from main memory.
Signed-off-by: Corvin Köhne
Acked-by: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Rebecca Cran
Cc: Peter Grehan
---
OvmfPkg/Bhyve/BhyveX64.dsc| 1 +
.../Bhyve/AcpiPlatformDxe/Acpi
This makes the function reuseable by bhyve.
Signed-off-by: Corvin Köhne
Acked-by: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Anthony Perard
Cc: Julien Grall
---
.../XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf | 1 -
OvmfPkg/Include/Library/AcpiPlatformLib.h
gt; > Cc: Gerd Hoffmann
> > Cc: Rebecca Cran
> > Cc: Peter Grehan
> > Cc: Corvin Köhne
> > Signed-off-by: Pedro Falcato
> > ---
> > OvmfPkg/Bhyve/BhyveX64.dsc | 2 +-
> > OvmfPkg/Bhyve/BhyveX64.fdf | 2 +-
> > 2 files changed, 2 insertions(+),
This makes the function reuseable by bhyve.
Signed-off-by: Corvin Köhne
Acked-by: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Anthony Perard
Cc: Julien Grall
---
.../XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf | 1 -
OvmfPkg/Include/Library/AcpiPlatformLib.h
emory. For that reason,
pick up the ACPI tables from main memory.
Signed-off-by: Corvin Köhne
Reviewed-by: Rebecca Cran
Acked-by: Peter Grehan
Acked-by: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
---
OvmfPkg/Bhyve/BhyveX64.dsc| 1 +
.../Bhyve/
Xen and bhyve are placing ACPI tables into system memory. So, they can
share the same code. Therefore, create a new library which searches and
installs ACPI tables from system memory.
Signed-off-by: Corvin Köhne
Acked-by: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc
-
Kind regards,
Corvin
On 5/11/23 06:02, Corvin Köhne wrote:
> This makes the function reuseable by bhyve.
>
> Signed-off-by: Corvin Köhne
> Acked-by: Gerd Hoffmann
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
> Cc: Jordan Justen
> Cc: Anthony Perard
> Cc: Julien Grall
There's no bhyve specific PlatformSecureLib any more. Use the default
one of OvmfPkg which works too.
Signed-off-by: Corvin Köhne
CC: Ard Biesheuvel
CC: Jiewen Yao
CC: Jordan Justen
CC: Gerd Hoffmann
CC: Rebecca Cran
CC: Peter Grehan
CC: devel@edk2.groups.io
---
OvmfPkg/Bhyve/Bhy
Beckhoff
Registered office: Verl, Germany | Register court: Guetersloh HRA 7075
-Original Message-
From: Ard Biesheuvel
Sent: Monday, September 5, 2022 2:24 PM
To: Corvin Köhne
Cc: Ard Biesheuvel ; Jiewen Yao
; Jordan Justen ; Gerd
Hoffmann ; Rebecca Cran ; Peter Grehan
; devel@edk2.groups.i
emory. For that reason,
pick up the ACPI tables from main memory.
Implementation is similar to OvmfPkg/XenAcpiPlatformDxe/Xen.c.
Signed-off-by: Corvin Köhne
Cc: Michael D Kinney
Cc: Liming Gao
Cc: Zhiguang Liu
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Rebecca
On Mon, 2023-04-17 at 14:14 +0200, Gerd Hoffmann wrote:
> On Mon, Apr 17, 2023 at 01:46:01PM +0200, Corvin Köhne wrote:
> > It's much easier to create configuration dependend ACPI tables for
> > bhyve
> > than for OVMF. For this reason, don't use the statically creat
CI: https://github.com/tianocore/edk2/pull/4379/checks
Corvin Köhne (3):
OvmfPkg/Xen: export search of RSDP into a library function
OvmfPkg/Xen: export AcpiTable installation into AcpiPlatformLib
OvmfPkg/Bhyve: install ACPI tables from memory
OvmfPkg/OvmfPkg.dec
Xen and bhyve are placing ACPI tables into system memory. So, they can
share the same code. Therefore, create a new library which searches and
installs ACPI tables from system memory.
Signed-off-by: Corvin Köhne
Reviewed-by: Anthony PERARD
Acked-by: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen
This makes the function reuseable by bhyve.
Signed-off-by: Corvin Köhne
Reviewed-by: Anthony PERARD
Acked-by: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Julien Grall
Cc: Rebecca Cran
Cc: Peter Grehan
---
.../XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf | 1
emory. For that reason,
pick up the ACPI tables from main memory.
Signed-off-by: Corvin Köhne
Reviewed-by: Rebecca Cran
Acked-by: Peter Grehan
Acked-by: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
---
OvmfPkg/Bhyve/BhyveX64.dsc| 1 +
.../Bhyve/
Hi,
I'm currently working on TPM emulation for bhyve. Therefore, the guest
firmware has to set up the TPM device properly for the guest OS. I'd
like to send the attached patch to the EDKII project.
Any comments are appreciated.
Thanks,
Corvin
Corvin Köhne (1):
OvmfPkg/Bhyve: i
From: Corvin Köhne
Bhyve will gain support for TPM emulation in the near future. Therefore,
prepare OVMF by copying all TPM driver used by qemu's OVMF DSC into the
bhyve OVMF DSC.
Signed-off-by: Corvin Köhne
---
OvmfPkg/Bhyve/BhyveX64.dsc | 17 +++--
OvmfPkg/Bhyve/BhyveX6
On Tue, 2023-06-06 at 15:20 +0200, Corvin Köhne wrote:
> Hi,
>
> I'm currently working on TPM emulation for bhyve. Therefore, the
> guest
> firmware has to set up the TPM device properly for the guest OS. I'd
> like to send the attached patch to the EDKII pr
Hi,
I'm working on TPM emulation for bhyve and would like to merge this
patchset to edk2.
As already send this patch to edk2 by mistake, I'm now resending this
patch as v2.
I've already created a PR to run all CI checks at:
https://github.com/tianocore/edk2/pull/4531
Thanks,
From: Corvin Köhne
Bhyve will gain support for TPM emulation in the near future. Therefore,
prepare OVMF by copying all TPM driver used by qemu's OVMF DSC into the
bhyve OVMF DSC.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Re
Bhyve will gain support for TPM emulation in the near future. Therefore,
prepare OVMF by copying all TPM driver used by qemu's OVMF DSC into the
bhyve OVMF DSC.
Signed-off-by: Corvin Köhne
Reviewed-by: Rebecca Cran
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffman
CI: https://github.com/tianocore/edk2/pull/4543
Corvin Köhne (3):
Revert "OvmfPkg/Bhyve: consume PciHostBridgeLibScan"
Revert "OvmfPkg/Bhyve: remove IncompatiblePciDeviceSupport DXE driver"
OvmfPkg/BhyvePkg: enable bus enumeration
OvmfPkg/Bhyve/BhyveX64.dsc | 4
We like to enable bus enumeration for bhyve. Therefore, this patch needs
to be reverted.
This reverts commit 8c8f886f27556f2fb6e8b502d32aa9ccee930acc.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Rebecca Cran
Cc: Peter Grehan
We like to enable bus enumartion for bhyve. Therefore, this patch needs
to be reverted.
This reverts commit c2f24ba3218ae91a8d5a1a31c31dad3417850d0c.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Gerd Hoffmann
Cc: Rebecca Cran
Cc: Peter Grehan
bhyve supports adding a ROM to PCI devices. It was added to support GPU
passthrough of dedicated AMD GPUs. At the moment, this ROM file is
mostly useless as it's not shadowed and executed by firmware. Change
that by enabling bus enumeration.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuve
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/Include/Library/AcpiPlatformLib.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/OvmfPkg/Include
Hi,
latest Bhyve exposes it's Acpi tables by FwCfg. This patch series reuses
the Acpi Install method of Qemu for Bhyve.
CI: https://github.com/tianocore/edk2/pull/4545
Kind regards,
Corvin
Corvin Köhne (5):
OvmfPkg: avoid including AcpiPlatformLib twice
OvmfPkg: move PciEncoding
Bhyve supports providing ACPI tables by FwCfg. Therefore,
InstallQemuFwCfgTables should be moved to AcpiPlatformLib to reuse the
code. As first step, move PciEncoding into AcpiPlatformLib.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc
This is required to move InstallQemuFwCfgTables into AcpiPlatformLib.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
This makes the InstallQemuFwcfgTables function reusable by bhyve.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/OvmfPkg/Bhyve
On Mon, 2023-06-19 at 12:41 +0200, Gerd Hoffmann wrote:
> On Wed, Jun 14, 2023 at 09:55:43AM +0200, Corvin Köhne wrote:
> > Signed-off-by: Corvin Köhne
> > Cc: Ard Biesheuvel
> > Cc: Gerd Hoffmann
> > Cc: Jiewen Yao
> > Cc: Jordan Justen
> > Cc: Leif
Bhyve will gain support for TPM emulation in the near future. Therefore,
prepare OVMF by copying all TPM driver used by qemu's OVMF DSC into the
bhyve OVMF DSC.
Signed-off-by: Corvin Köhne
Reviewed-by: Rebecca Cran
Acked-by: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan J
CI: https://github.com/tianocore/edk2/pull/4531
Corvin Köhne (1):
OvmfPkg/Bhyve: include TPM driver
OvmfPkg/Bhyve/BhyveX64.dsc | 17 +++--
OvmfPkg/Bhyve/BhyveX64.fdf | 7 +++
2 files changed, 22 insertions(+), 2 deletions(-)
--
2.41.0
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io
On Mon, 2023-06-19 at 15:04 +0200, Gerd Hoffmann wrote:
> On Mon, Jun 19, 2023 at 01:52:19PM +0200, Corvin Köhne wrote:
> > On Mon, 2023-06-19 at 12:41 +0200, Gerd Hoffmann wrote:
> > > On Wed, Jun 14, 2023 at 09:55:43AM +0200, Corvin Köhne wrote:
> > > > Signed-of
CI: https://github.com/tianocore/edk2/pull/4545
Corvin Köhne (6):
OvmfPkg/Library: fix definition of GetAcpiRsdpFromMemory
OvmfPkg: avoid including AcpiPlatformLib twice
OvmfPkg: move PciEncoding into AcpiPlatformLib
OvmfPkg: move BootScript into AcpiPlatformLib
OvmfPkg: move
The definition and declaration of GetAcpiRsdpFromMemory doesn't match.
We don't get a compile error yet because UINTN is the same as UINT64 on
64bit machines. As the function works on memory addresses, UINTN is the
correct type of the input parameters.
Signed-off-by: Corvin Köhn
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/Include/Library/AcpiPlatformLib.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/OvmfPkg/Include
Bhyve supports providing ACPI tables by FwCfg. Therefore,
InstallQemuFwCfgTables should be moved to AcpiPlatformLib to reuse the
code. As first step, move PciEncoding into AcpiPlatformLib.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc
This is required to move InstallQemuFwCfgTables into AcpiPlatformLib.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
This makes the InstallQemuFwcfgTables function reusable by bhyve.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/OvmfPkg/Bhyve
CI: https://github.com/tianocore/edk2/pull/4545
Corvin Köhne (6):
OvmfPkg/Library: fix definition of GetAcpiRsdpFromMemory
OvmfPkg: avoid including AcpiPlatformLib twice
OvmfPkg: move PciEncoding into AcpiPlatformLib
OvmfPkg: move BootScript into AcpiPlatformLib
OvmfPkg: move
The definition and declaration of GetAcpiRsdpFromMemory doesn't match.
We don't get a compile error yet because UINTN is the same as UINT64 on
64bit machines. As the function works on memory addresses, UINTN is the
correct type of the input parameters.
Signed-off-by: Corvin Köhne
Teste
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/Include/Library/AcpiPlatformLib.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/OvmfPkg/Include
Bhyve supports providing ACPI tables by FwCfg. Therefore,
InstallQemuFwCfgTables should be moved to AcpiPlatformLib to reuse the
code. As first step, move PciEncoding into AcpiPlatformLib.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc
This is required to move InstallQemuFwCfgTables into AcpiPlatformLib.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
This makes the InstallQemuFwcfgTables function reusable by bhyve.
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
Signed-off-by: Corvin Köhne
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Peter Grehan
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/OvmfPkg/Bhyve
CI: https://github.com/tianocore/edk2/pull/4545
Corvin Köhne (6):
OvmfPkg/Library: fix definition of GetAcpiRsdpFromMemory
OvmfPkg: avoid including AcpiPlatformLib twice
OvmfPkg: move PciEncoding into AcpiPlatformLib
OvmfPkg: move BootScript into AcpiPlatformLib
OvmfPkg: move
Signed-off-by: Corvin Köhne
Acked-by: Peter Grehan
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/Include/Library/AcpiPlatformLib.h | 5 +
1 file changed, 5 insertions(+)
diff --git a/OvmfPkg
The definition and declaration of GetAcpiRsdpFromMemory doesn't match.
We don't get a compile error yet because UINTN is the same as UINT64 on
64bit machines. As the function works on memory addresses, UINTN is the
correct type of the input parameters.
Signed-off-by: Corvin Köhne
Teste
Bhyve supports providing ACPI tables by FwCfg. Therefore,
InstallQemuFwCfgTables should be moved to AcpiPlatformLib to reuse the
code. As first step, move PciEncoding into AcpiPlatformLib.
Signed-off-by: Corvin Köhne
Acked-by: Peter Grehan
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
This is required to move InstallQemuFwCfgTables into AcpiPlatformLib.
Signed-off-by: Corvin Köhne
Acked-by: Peter Grehan
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/AcpiPlatformDxe
This makes the InstallQemuFwcfgTables function reusable by bhyve.
Signed-off-by: Corvin Köhne
Acked-by: Peter Grehan
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/AcpiPlatformDxe/AcpiPlatformDxe.inf
Signed-off-by: Corvin Köhne
Acked-by: Peter Grehan
Cc: Ard Biesheuvel
Cc: Gerd Hoffmann
Cc: Jiewen Yao
Cc: Jordan Justen
Cc: Leif Lindholm
Cc: Rebecca Cran
Cc: Sami Mujawar
---
OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatform.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/OvmfPkg
On Mon, 2023-06-12 at 11:20 +0200, Corvin Köhne wrote:
> bhyve supports adding a ROM to PCI devices. It was added to support
> GPU
> passthrough of dedicated AMD GPUs. At the moment, this ROM file is
> mostly useless as it's not shadowed and executed by firmware. Change
>
1 - 100 of 128 matches
Mail list logo
