Hi, I'm going to add QemuFwCfg support to bhyve. See https://reviews.freebsd.org/D31578. Therefore, this patch for OVMF is neccessary to work properly.
There's one open point on that patch and hopefully one of you has more insights. Qemu has an item called FW_CFG_MAX_CPUS. It looks very similar to what we need here, but I'm not sure if we can use it safely as Qemu has a comment about it: https://github.com/qemu/qemu/blob/0021c4765a6b83e5b09409b75d50c6caaa6971b9/hw/i386/fw_cfg.c#L110-L121 /* FW_CFG_MAX_CPUS is a bit confusing/problematic on x86: * * For machine types prior to 1.8, SeaBIOS needs FW_CFG_MAX_CPUS for * building MPTable, ACPI MADT, ACPI CPU hotplug and ACPI SRAT table, * that tables are based on xAPIC ID and QEMU<->SeaBIOS interface * for CPU hotplug also uses APIC ID and not "CPU index". * This means that FW_CFG_MAX_CPUS is not the "maximum number of CPUs", * but the "limit to the APIC ID values SeaBIOS may see". * * So for compatibility reasons with old BIOSes we are stuck with * "etc/max-cpus" actually being apic_id_limit */ Thanks Corvin CC: Ard Biesheuvel <ardb+tianoc...@kernel.org> CC: Jiewen Yao <jiewen....@intel.com> CC: Jordan Justen <jordan.l.jus...@intel.com> CC: Gerd Hoffmann <kra...@redhat.com> CC: Rebecca Cran <rebe...@bsdio.com> CC: Peter Grehan <gre...@freebsd.org> CC: devel@edk2.groups.io CC: FreeBSD Virtualization <freebsd-virtualizat...@freebsd.org> Corvin Köhne (1): OvmfPkg/BhyveBhfPkg: add support for QemuFwCfg OvmfPkg/Bhyve/AcpiPlatformDxe/AcpiPlatformDxe.inf | 1 + OvmfPkg/Bhyve/AcpiPlatformDxe/Bhyve.c | 41 ++++++++++++++++++++--- OvmfPkg/Bhyve/BhyveX64.dsc | 4 +-- 3 files changed, 40 insertions(+), 6 deletions(-) -- 2.11.0 Beckhoff Automation GmbH & Co. KG | Managing Director: Dipl. Phys. Hans Beckhoff Registered office: Verl, Germany | Register court: Guetersloh HRA 7075 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88159): https://edk2.groups.io/g/devel/message/88159 Mute This Topic: https://groups.io/mt/90103180/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
