Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2024-10-21 Thread Rebecca Cran
Thanks, I'll fix it. Could you confirm whether the change from STATIC to static is something we want to go ahead with, or do we want to keep STATIC to allow GoogleTest to work? -- Rebecca On 10/15/24 3:12 PM, Kinney, Michael D wrote: The draft status is never disabled in the master branch

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2024-10-21 Thread Pedro Falcato
On Mon, Oct 21, 2024 at 3:49 PM Rebecca Cran via groups.io wrote: > > Thanks, I'll fix it. > > Could you confirm whether the change from STATIC to static is something > we want to go ahead with, or do we want to keep STATIC to allow > GoogleTest to work? You don't need STATIC, doing stuff like -D

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2024-10-21 Thread Oliver Smith-Denny
On 10/21/2024 12:42 PM, Pedro Falcato wrote: On Mon, Oct 21, 2024 at 3:49 PM Rebecca Cran via groups.io wrote: Thanks, I'll fix it. Could you confirm whether the change from STATIC to static is something we want to go ahead with, or do we want to keep STATIC to allow GoogleTest to work? You

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2024-10-21 Thread Pedro Falcato
On Mon, Oct 21, 2024 at 9:05 PM Oliver Smith-Denny wrote: > > On 10/21/2024 12:42 PM, Pedro Falcato wrote: > > On Mon, Oct 21, 2024 at 3:49 PM Rebecca Cran via groups.io > > wrote: > >> > >> Thanks, I'll fix it. > >> > >> Could you confirm whether the change from STATIC to static is something > >

[edk2-devel] Updated Event: Tools and CI meeting - W- US / ASIA TZ friendly - Monday, October 21, 2024 #cal-invite

2024-10-21 Thread Group Notification
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20240422T053451Z TZURL:https://www.tzurl.org/zoneinfo-outlook/America/Los_An

[edk2-devel] Updated Event: Tools and CI meeting - W- US / ASIA TZ friendly - Monday, October 21, 2024 #cal-invite

2024-10-21 Thread Group Notification
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20240422T053451Z TZURL:https://www.tzurl.org/zoneinfo-outlook/America/Los_An

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2024-10-21 Thread Michael D Kinney
This needs further discussion. Before GoogleTest was added, there was a clear direction to move from STATIC->static. The issue at hand is really a C++/C compatibility issue. We need to enumerate the full set of issues and see if there are reasonable ways to address. Mike > -Original Mes

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2024-10-21 Thread Oliver Smith-Denny
On 10/21/2024 1:21 PM, Pedro Falcato wrote: On Mon, Oct 21, 2024 at 9:05 PM Oliver Smith-Denny wrote: On 10/21/2024 12:42 PM, Pedro Falcato wrote: On Mon, Oct 21, 2024 at 3:49 PM Rebecca Cran via groups.io wrote: Thanks, I'll fix it. Could you confirm whether the change from STATIC to sta

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2024-10-21 Thread Michael D Kinney
Would it help if code was modified to completely remove the use of static in local variables and enforce that going forward and limit use of static to functions and global variables? Mike > -Original Message- > From: Oliver Smith-Denny > Sent: Monday, October 21, 2024 1:26 PM > To: deve

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2024-10-21 Thread Oliver Smith-Denny
On 10/21/2024 1:35 PM, Kinney, Michael D wrote: Would it help if code was modified to completely remove the use of static in local variables and enforce that going forward and limit use of static to functions and global variables? We'd have to test further, but I believe that would allow Pedro

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2024-10-21 Thread Pedro Falcato
On Mon, Oct 21, 2024 at 10:04 PM Kinney, Michael D wrote: > > I recall clang having more restrictions on redefining keywords. Clang has restrictions on redefining macros and builtin functions. It appears to not have any issues doing horrible unspeakable things with the C keywords and the C prepro

[edk2-devel] Event: Tools and CI meeting - W- US / ASIA TZ friendly - Monday, October 21, 2024 #cal-invite

2024-10-21 Thread Group Notification
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20240422T053451Z TZURL:https://www.tzurl.org/zoneinfo-outlook/America/Los_An

[edk2-devel] Event: Tools and CI meeting - Euro TZ - Monday, October 28, 2024 #cal-invite

2024-10-21 Thread Group Notification
BEGIN:VCALENDAR VERSION:2.0 PRODID:-//Groups.io Inc//Groups.io Calendar//EN METHOD:PUBLISH REFRESH-INTERVAL;VALUE=DURATION:PT1H X-PUBLISHED-TTL:PT1H CALSCALE:GREGORIAN BEGIN:VTIMEZONE TZID:America/Los_Angeles LAST-MODIFIED:20240422T053451Z TZURL:https://www.tzurl.org/zoneinfo-outlook/America/Los_An

Re: [edk2-devel] [edk2-CCodingStandardsSpecification PATCH 1/1] Prefer use of `static` C keyword over EDK2 type `STATIC`

2024-10-21 Thread Michael D Kinney
I recall clang having more restrictions on redefining keywords. Mike > -Original Message- > From: Oliver Smith-Denny > Sent: Monday, October 21, 2024 1:38 PM > To: Kinney, Michael D ; > devel@edk2.groups.io; pedro.falc...@gmail.com > Cc: rebe...@bsdio.com > Subject: Re: [edk2-devel] [edk