[edk2-devel] [PATCH v1 v1 1/1] MdePkg: Add error output for IoLib.c

2024-08-13 Thread Ming Huang
It is better to output error address information When Address is invalid before ASSERT. Signed-off-by: Ming Huang --- MdePkg/Library/BaseIoLibIntrinsic/IoLib.c | 24 1 file changed, 24 insertions(+) diff --git a/MdePkg/Library/BaseIoLibIntrinsic/IoLib.c b/MdePkg/Library/Ba

Re: [edk2-devel] [PATCH v1 v1 1/1] MdePkg: Add error output for IoLib.c

2024-08-13 Thread Michael D Kinney
Hi, We have moved to a PR based review process. Can you change this to a PR? https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process Also, this change may impact the code size and performance of these APIs. When ASSERTS() are disabled, an optimizing compiler can inline

[edk2-devel] help needed - FAILED [build -p EmulatorPkg\EmulatorPkg.dsc -t VS2019 -a X64]

2024-08-13 Thread michael yang
Hi, build failed, could you please? D:\work\dev\efiWorkspace\edk2>build -p EmulatorPkg\EmulatorPkg.dsc -t VS2019 -a X64 Build environment: Windows-10-10.0.19045-SP0 Build start time: 10:24:16, Aug.13 2024 WORKSPACE= d:\work\dev\efiworkspace EDK_TOOLS_PATH = d:\work\dev\efiworkspace\edk2\

Re: [edk2-devel] help needed - FAILED [build -p EmulatorPkg\EmulatorPkg.dsc -t VS2019 -a X64]

2024-08-13 Thread Andrew Fish via groups.io
> On Aug 12, 2024, at 7:25 PM, michael yang wrote: > > Hi, > build failed, could you please? > D:\work\dev\efiWorkspace\edk2>build -p EmulatorPkg\EmulatorPkg.dsc -t VS2019 > -a X64 Your build command is implying D:\work\dev\efiWorkspace\edk2\EmulatorPkg\EmulatorPkg.dsc but your WORKSPACE is

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Wednesday, August 14, 2024 #cal-reminder

2024-08-13 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Wednesday, August 14, 2024 5:30pm to 6:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344

Re: [edk2-devel] [PATCH v1 v1 1/1] MdePkg: Add error output for IoLib.c

2024-08-13 Thread Ming Huang
On 8/13/24 11:29 PM, Kinney, Michael D wrote: > Hi, > > We have moved to a PR based review process. Can you change this to a PR? OK, I will change this to a PR. > > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process > > Also, this change may impact the code si

[edk2-devel] [PATCH 0/2] Ampere: Add BMC Configuration Screen

2024-08-13 Thread Nhi Pham via groups.io
This implements BMC Configuration Screen and supports on Ampere Mt. Jade platform. Nhi Pham (2): AmpereSiliconPkg: Implement BMC Configuration screen JadePkg: Add BmcConfigDxe Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 8 +- Platform/Ampere/JadePkg/Jade.dsc

[edk2-devel] [PATCH 1/2] AmpereSiliconPkg: Implement BMC Configuration screen

2024-08-13 Thread Nhi Pham via groups.io
This implements the BMC configuration screen to provide basic information such as IPMI version, BMC version, and BMC IPv4. Signed-off-by: Nhi Pham --- Silicon/Ampere/AmpereSiliconPkg/AmpereSiliconPkg.dec | 8 +- Silicon/Ampere/AmpereSiliconPkg/Drivers/BmcConfigDxe/BmcConfigDxe

[edk2-devel] [PATCH 2/2] JadePkg: Add BmcConfigDxe

2024-08-13 Thread Nhi Pham via groups.io
Signed-off-by: Nhi Pham --- Platform/Ampere/JadePkg/Jade.dsc | 1 + Platform/Ampere/JadePkg/Jade.fdf | 1 + 2 files changed, 2 insertions(+) diff --git a/Platform/Ampere/JadePkg/Jade.dsc b/Platform/Ampere/JadePkg/Jade.dsc index 1bd9f2ec1583..db3733cf5b08 100644 --- a/Platform/Ampere/JadePkg/Jade

[edk2-devel] [PATCH 1/1] AmpereAltraPkg/FlashLib: Fix kernel crash if not call SetVirtualAddressMap()

2024-08-13 Thread Nhi Pham via groups.io
From: Chuong Tran OS kernel with greater than or equal to 48-bit VA space avoids EFI's SetVirtualAddressMap() runtime service on Arm64 and simply uses the 1:1 address mapping that UEFI used at booting. However, AmpereAltraPkg's RuntimeFlashLib replies on function call SetVirtualAddressMap() to de

[edk2-devel] [edk2-platforms][PATCH 1/1] JadePkg: Add ACPI SPMI table

2024-08-13 Thread Nhi Pham via groups.io
This implements ACPI SPMI table as defined in the IPMI specification. Signed-off-by: Nhi Pham --- Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatformDxe.inf | 4 + Platform/Ampere/JadePkg/Drivers/AcpiPlatformDxe/AcpiPlatform.h | 13 +++ Platform/Ampere/JadePkg/Drivers/AcpiPlatfo

Re: [edk2-devel] [PATCH v1 v1 1/1] MdePkg: Add error output for IoLib.c

2024-08-13 Thread Michael D Kinney
> -Original Message- > From: Ming Huang > Sent: Tuesday, August 13, 2024 7:05 PM > To: Kinney, Michael D ; devel@edk2.groups.io; > gaolim...@byosoft.com.cn; Liu, Zhiguang > Cc: ming.hua...@outlook.com > Subject: Re: [PATCH v1 v1 1/1] MdePkg: Add error output for IoLib.c > > > > On 8/