Re: [edk2-devel] [PATCH V6 0/6] MPAM ACPI definitions and parser

2024-07-09 Thread Sami Mujawar
Hi Rohit, Edk2 has moved to a pull request model for code review and merge. See the latest guidelines at https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process I replied to your previous patch series on the mailing list as it was sent before the new process was introduc

Re: [edk2-devel] [PATCH V6 0/6] MPAM ACPI definitions and parser

2024-07-09 Thread Rohit Mathew
Thank you, Sami, for letting me know. I had created a PR as well for making sure the CI goes through here - https://github.com/tianocore/edk2/pull/5888 Could you please let me know if this would be sufficient? Regards, Rohit > -Original Message- > From: Sami Mujawar > Sent: Tuesday, Ju

Re: [edk2-devel] [PATCH V6 0/6] MPAM ACPI definitions and parser

2024-07-09 Thread Sami Mujawar
Hi Rohit, I think the pull request template must be used. In addition to the patch series description you have added, it has questions like if the change is a breaking change, how was the patch tested etc. It would be good if you can update the pull request to use the PR template. Regards, Sam

[edk2-devel] [PATCH edk2-platforms v3 0/5] SbsaQemu: Align the PPTT tables with QEMU

2024-07-09 Thread Marcin Juszkiewicz
We want to make sure that CPU topology information given to QEMU would be provided to the operating system. So we use SMC call to ask TF-A for amount of sockets, clusters, cores and threads set in QEMU config. The TF-A part is already merged: https://review.trustedfirmware.org/c/TF-A/trusted-firmw

[edk2-devel] [PATCH edk2-platforms v3 3/5] SbsaQemu: update PPTT to ACPI 6.5

2024-07-09 Thread Marcin Juszkiewicz
ACPI 6.5 is the newest version of specification so far. The only change to make is handling of CacheId (has to be unique and higher than zero). Signed-off-by: Marcin Juszkiewicz --- .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.h | 4 +- .../Include/IndustryStandard/SbsaQemuAcpi.h

[edk2-devel] [PATCH edk2-platforms v3 4/5] SbsaQemu: provide cache info per core in PPTT

2024-07-09 Thread Marcin Juszkiewicz
During Linaro Connect MAD24 I was asked to move cache information from being 'per cluster' to be 'per core'. This is a move for implementing MPAM support. So topology moves from: Socket -> Clusters -> Cores + Caches -> Threads (if exist) to: Socket -> Clusters -> Cores -> Caches + Threads (if e

[edk2-devel] [PATCH edk2-platforms v3 5/5] SbsaQemu: introduce helper in PPTT generation

2024-07-09 Thread Marcin Juszkiewicz
Function AddPpttTable() adding PPTT got too long. This change moves part of it into helper function AddCoresToPpttTable() which takes care of generating entries for Core and below (Cache, Thread). Signed-off-by: Marcin Juszkiewicz --- .../Drivers/SbsaQemuAcpiDxe/SbsaQemuAcpiDxe.c | 237 +++

[edk2-devel] [PATCH edk2-platforms v3 2/5] SbsaQemu: align the PPTT tables with QEMU

2024-07-09 Thread Marcin Juszkiewicz
From: Xiong Yining To align the CPU topology information recognized by the operating system with the CPU topology information configured by QEMU, we need to make use of the CPU topology information to create complex PPTT tables setups. We can get the CPU topology information via SMC. Signed-off

[edk2-devel] [PATCH edk2-platforms v3 1/5] SbsaQemu: get the information of CPU topology via SMC calls

2024-07-09 Thread Marcin Juszkiewicz
Provide functions to check for CPU topology information: - the number of sockets on sbsa-ref platform. - the number of clusters in one socket. - the number of cores in one cluster. - the number of threads in one core. As SMC calls can return up to 4 return values, the number of sockets, cluste

Re: [edk2-devel] [PATCH edk2-platforms v3 1/5] SbsaQemu: get the information of CPU topology via SMC calls

2024-07-09 Thread Leif Lindholm
On Tue, Jul 09, 2024 at 12:47:06 +0200, Marcin Juszkiewicz wrote: > Provide functions to check for CPU topology information: > - the number of sockets on sbsa-ref platform. > - the number of clusters in one socket. > - the number of cores in one cluster. > - the number of threads in one core. >

Re: [edk2-devel] [PATCH edk2-platforms v3 1/5] SbsaQemu: get the information of CPU topology via SMC calls

2024-07-09 Thread Leif Lindholm
On 2024-07-09 13:40, Leif Lindholm wrote: On Tue, Jul 09, 2024 at 12:47:06 +0200, Marcin Juszkiewicz wrote: Provide functions to check for CPU topology information: - the number of sockets on sbsa-ref platform. - the number of clusters in one socket. - the number of cores in one cluster.

Re: [edk2-devel] [PATCH edk2-platforms v3 2/5] SbsaQemu: align the PPTT tables with QEMU

2024-07-09 Thread Leif Lindholm
On Tue, Jul 09, 2024 at 12:47:07 +0200, Marcin Juszkiewicz wrote: > From: Xiong Yining > > To align the CPU topology information recognized by the operating system > with the CPU topology information configured by QEMU, we need to make > use of the CPU topology information to create complex PPTT

Re: [edk2-devel] [PATCH edk2-platforms v3 3/5] SbsaQemu: update PPTT to ACPI 6.5

2024-07-09 Thread Leif Lindholm
On Tue, Jul 09, 2024 at 12:47:08 +0200, Marcin Juszkiewicz wrote: > ACPI 6.5 is the newest version of specification so far. The only change "The only functional change..." With that: Reviewed-by: Leif Lindholm / Leif > to make is handling of CacheId (has to be unique and higher than zero).

Re: [edk2-devel] [PATCH edk2-platforms v3 5/5] SbsaQemu: introduce helper in PPTT generation

2024-07-09 Thread Leif Lindholm
On Tue, Jul 09, 2024 at 12:47:10 +0200, Marcin Juszkiewicz wrote: > Function AddPpttTable() adding PPTT got too long. This change moves part > of it into helper function AddCoresToPpttTable() which takes care of > generating entries for Core and below (Cache, Thread). > > Signed-off-by: Marcin Jus

Re: [edk2-devel] [PATCH edk2-platforms v3 4/5] SbsaQemu: provide cache info per core in PPTT

2024-07-09 Thread Leif Lindholm
On Tue, Jul 09, 2024 at 12:47:09 +0200, Marcin Juszkiewicz wrote: > During Linaro Connect MAD24 I was asked to move cache information from > being 'per cluster' to be 'per core'. This is a move for implementing > MPAM support. > > So topology moves from: > > Socket -> Clusters -> Cores + Caches -

Re: [edk2-devel] [PATCH edk2-platforms v3 5/5] SbsaQemu: introduce helper in PPTT generation

2024-07-09 Thread Marcin Juszkiewicz
Dnia wtorek, 9 lipca 2024 15:00:12 CEST Leif Lindholm via groups.io pisze: > On Tue, Jul 09, 2024 at 12:47:10 +0200, Marcin Juszkiewicz wrote: > > Function AddPpttTable() adding PPTT got too long. This change moves part > > of it into helper function AddCoresToPpttTable() which takes care of > > ge

Re: [edk2-devel] [PATCH edk2-platforms v3 5/5] SbsaQemu: introduce helper in PPTT generation

2024-07-09 Thread Leif Lindholm
On Tue, Jul 09, 2024 at 15:12:37 +0200, Marcin Juszkiewicz wrote: > Dnia wtorek, 9 lipca 2024 15:00:12 CEST Leif Lindholm via groups.io pisze: > > On Tue, Jul 09, 2024 at 12:47:10 +0200, Marcin Juszkiewicz wrote: > > > Function AddPpttTable() adding PPTT got too long. This change moves part > > > o

[edk2-devel] Questions regarding NVDIMM and OVMF

2024-07-09 Thread Thomas Preisner
Hello, I'm currently working on a research project with the goal to (mostly) replace DRAM with NVRAM on the OS-side. In order to speed things up, I'm currenlty trying to switch over to QEMU+OVMF instead of developing directly on hardware (server boot times are a massive pain). However, I've no

[edk2-devel] [PATCH V2 0/2] Initial commit for RISC-V Qemu-based Server

2024-07-09 Thread Evan Chai
This is a foundational patch to move the 'RISC-V QEMU Server Reference Platform' forward. Evan Chai (2): RiscVQemuServerPlatform: Initial commit for RISC-V Qemu-based Server platform RiscVQemuServerPlatform: Unified .dsc files into a single file Platform/Qemu/RiscVQemuServerPlatform/Do

[edk2-devel] [PATCH V2 2/2] RiscVQemuServerPlatform: Unified .dsc files into a single file

2024-07-09 Thread Evan Chai
>From past experience, fragmented .dsc files lead to repeated definitions for users due to multiple related .dsc files containing the same [section] fields. As a result, only one .dsc file is now maintained. Cc: Andrei Warkentin Cc: Sunil V L Cc: Yong Li Signed-off-by: Evan Chai --- Platform/

Re: [edk2-devel] github impact:breaking-change

2024-07-09 Thread Michael Kubacki
Hi Leif, Thanks for raising this. The label was intended to be set from the PR template which has an explanation: https://github.com/tianocore/edk2/blob/master/.github/pull_request_template.md If the breaking change box is checked, it will be added automatically. I added a description in Git

Re: [edk2-devel] Questions regarding NVDIMM and OVMF

2024-07-09 Thread Gerd Hoffmann
Hi, > Do you have any pointers for implementing the support of nvdimm in > edk2/OVMF? Or is it not feasible and I need to also look at adding it > directly into QEMU qemu. Add e820_add_entry() calls. Possibly edk2 too. Not sure how linux is supposed to figure the memory in question is nvdim

Re: [edk2-devel] github impact:breaking-change

2024-07-09 Thread Leif Lindholm
Hi Michael, On Tue, Jul 09, 2024 at 10:44:46 -0400, Michael Kubacki wrote: > Hi Leif, > > Thanks for raising this. The label was intended to be set from the PR > template which has an explanation: > > https://github.com/tianocore/edk2/blob/master/.github/pull_request_template.md > > If the brea

Re: [edk2-devel] github impact:breaking-change

2024-07-09 Thread Michael Kubacki
The tweaks look good to me. Thanks, Michael On 7/9/2024 11:03 AM, Leif Lindholm wrote: Hi Michael, On Tue, Jul 09, 2024 at 10:44:46 -0400, Michael Kubacki wrote: Hi Leif, Thanks for raising this. The label was intended to be set from the PR template which has an explanation: https://github.

[edk2-devel] Enable Wikis and Discussions in all Tianocore repos

2024-07-09 Thread Michael D Kinney
Hello, There was a request to enable use of GitHub discussions in edk2-libc repo. This is a feature that has been enabled on a few Tianocore repo such as the edk2 repo. I have enabled Wikis and Discussions on all the active Tianocore repos. Thanks, Mike -=-=-=-=-=-=-=-=-=-=-=- Groups.io Lin

Re: [edk2-devel] RedfishPlatformConfigDxe needs Depex on gEfiRegularExpressionProtocolGuid?

2024-07-09 Thread Rebecca Cran
I'm ok keeping the current behavior as long as the DEBUG_ERROR message is removed or downgraded to DEBUG_INFO. As it is, it makes it look as though the driver has failed when error messages are highlighted during the boot. -- Rebecca Cran On 7/8/24 21:53, Nickle Wang wrote: Should the follow

[edk2-devel] Drop VS2015 Support

2024-07-09 Thread Oliver Smith-Denny
Hi Rebecca, Per Liming's request I am moving this discussion to the mailing list. Now that VS2022 support has been added to edk2, can we drop VS2015 support (honestly VS2017 could be dropped, too). This is an almost 10 year old toolchain that is unsupported, has many quirks, and will continue to

Re: [edk2-devel] Drop VS2015 Support

2024-07-09 Thread Michael D Kinney
What do you mean by drop? Remove from CI or remove from both CI and tools_def.txt? Mike > -Original Message- > From: devel@edk2.groups.io On Behalf Of Oliver Smith- > Denny > Sent: Tuesday, July 9, 2024 12:48 PM > To: devel@edk2.groups.io; Rebecca Cran > Subject: [edk2-devel] Drop VS20

Re: [edk2-devel] Drop VS2015 Support

2024-07-09 Thread Rebecca Cran
On 7/9/24 14:01, Michael D Kinney wrote: What do you mean by drop? Remove from CI or remove from both CI and tools_def.txt? I'm thinking remove it from both. -- Rebecca Cran Mike -Original Message- From: devel@edk2.groups.io On Behalf Of Oliver Smith- Denny Sent: Tuesday, July 9

[edk2-devel] Event: TianoCore Bug Triage - APAC / NAMO - Wednesday, July 10, 2024 #cal-reminder

2024-07-09 Thread Group Notification
*Reminder: TianoCore Bug Triage - APAC / NAMO* *When:* Wednesday, July 10, 2024 5:30pm to 6:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4

Re: 转发:[edk2-devel] [PATCH V2 0/2] Initial commit for RISC-V Qemu-based Server

2024-07-09 Thread Sunil V L
Hi Evan, Did you look at all the comments I gave? Since I replied inline in the patch which had images, I am not sure mail whether the mail client truncated them. Thanks, Sunil On Tue, Jul 09, 2024 at 08:51:07PM +0800, EvanChai via groups.io wrote: > Hi Sunil, > Thanks for your comments, it's th