[edk2-devel] [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the etc/boot-menu-wait

2024-03-12 Thread sunceping
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4415 Refer to the section 8.3.4 of tdx-virtual-firmware-design-guide spec, OVMF would uses FW_CFG_IO_SELECTOR(0x510) and FW_CFG_IO_DATA(0x511) to get configuration data from QEMU. From the security perspective, if TDVF uses this method, configura

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the etc/boot-menu-wait

2024-03-12 Thread Yao, Jiewen
Thanks for the patch. Is this the only missing configuration data? Or do you have more on the way? > -Original Message- > From: Sun, CepingX > Sent: Wednesday, March 13, 2024 7:52 AM > To: devel@edk2.groups.io > Cc: Sun, CepingX ; Aktas, Erdem > ; Yao, Jiewen ; Xu, Min M > ; Gerd Hoffm

Re: [edk2-devel][PATCH v1 1/3] MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize

2024-03-12 Thread Ard Biesheuvel
On Mon, 11 Mar 2024 at 20:34, Oliver Smith-Denny wrote: > > On 3/4/2024 2:38 PM, Oliver Smith-Denny wrote: > > On 3/4/2024 11:24 AM, Oliver Smith-Denny wrote: > >> On 3/4/2024 10:54 AM, Ard Biesheuvel wrote: > >>> On Mon, 4 Mar 2024 at 18:49, Oliver Smith-Denny > >>> wrote: > > Hi Ard,

Re: [edk2-devel] [PATCH v2 1/3] MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize

2024-03-12 Thread Ard Biesheuvel
On Mon, 11 Mar 2024 at 22:29, Oliver Smith-Denny wrote: > > When an ImageRecord is stored by ImagePropertiesRecordLib, it reports the > CodeSegmentSize as the SizeOfRawData from the image. However, the image > as loaded into memory is aligned to the SectionAlignment, so > SizeOfRawData is under th

[edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

2024-03-12 Thread PierreGondois
This patch relies on [1]. Following the RFC v1: ArmPkg,MdePkg: move ArmLib.h to MdePkg [1], move the Chipset/* files to the MdePkg as the Armlib.h relies on them. These patches span over multiple packages as these Chipset/* files are relocated to a new directory and include paths must be updated.

[edk2-devel] [PATCH 1/2] ArmPkg,MdePkg: Move ArmPkg/Chipset/ArmV7[|Mmu].h to MdePkg

2024-03-12 Thread PierreGondois
Following the discussion at [1] and as the ArmLib relies on them, move ArmPkg/Chipset/ArmV7[|Mmu].h files to the MdePkg. Update the path to correctly include the moved files. [1] https://edk2.groups.io/g/devel/message/111566 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffm

[edk2-devel] [PATCH 2/2] ArmPkg,MdePkg: Move ArmPkg/Chipset/Aarch64[|Mmu].h to MdePkg

2024-03-12 Thread PierreGondois
Following the discussion at [1] and as the ArmLib relies on them, move ArmPkg/Chipset/Aarch64[|Mmu].h files to the MdePkg. Update the path to correctly include the moved files. [1] https://edk2.groups.io/g/devel/message/111566 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Sami Mujawar Cc: Michael

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/RPI4: Grow FV size to accommodate DEBUG build

2024-03-12 Thread Ard Biesheuvel
On Tue, 12 Mar 2024 at 11:29, Ard Biesheuvel wrote: > > From: Ard Biesheuvel > > The DEBUG build no longer fits when all build options used by the > release script on github.com/pftf are used, presumably due to the > OpenSSL upgrade. > > So bump the size for all builds. > > Signed-off-by: Ard Bie

Re: [edk2-devel] [PATCH V1 1/1] OvmfPkg/QemuBootOrderLib: Measure the etc/boot-menu-wait

2024-03-12 Thread Gerd Hoffmann
On Wed, Mar 13, 2024 at 07:51:46AM +0800, Ceping Sun wrote: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4415 > > Refer to the section 8.3.4 of tdx-virtual-firmware-design-guide spec, > OVMF would uses FW_CFG_IO_SELECTOR(0x510) and FW_CFG_IO_DATA(0x511) > to get configuration data from QE

Re: [edk2-devel][PATCH v1 1/3] MdeModulePkg: ImagePropertiesRecordLib: Use SectionAlignment for CodeSize

2024-03-12 Thread Oliver Smith-Denny
On 3/12/2024 1:32 AM, Ard Biesheuvel wrote: On Mon, 11 Mar 2024 at 20:34, Oliver Smith-Denny wrote: On 3/4/2024 2:38 PM, Oliver Smith-Denny wrote: On 3/4/2024 11:24 AM, Oliver Smith-Denny wrote: On 3/4/2024 10:54 AM, Ard Biesheuvel wrote: On Mon, 4 Mar 2024 at 18:49, Oliver Smith-Denny wro

[edk2-devel] [PATCH 0/4] Update the comments of ReadKeyStroke and ReadKeyStrokeEx

2024-03-12 Thread Qingyu
Refer to Uefi spec 2.10 section 13.3.3, Add a new retval EFI_UNSUPPORTED to EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.ReadKeyStrokeEx and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.ReadKeyStroke(). This patch series update ReadKeyStroke and ReadKeyStrokeEx implementation in Edk2. Qingyu (4): MdeModulePkg: Update t

[edk2-devel] [PATCH 4/4] EmulatorPkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx

2024-03-12 Thread Qingyu
Refer to Uefi spec 2.10 section 13.3.3, Add a new retval EFI_UNSUPPORTED to EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.ReadKeyStrokeEx and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.ReadKeyStroke(). Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Signed-off-by: Qingyu --- EmulatorPkg/EmuGopDxe/GopInput.c | 2 ++

Re: [edk2-devel] [Patch V3] BaseTools: VfrCompiler Adds DefaultValueError

2024-03-12 Thread Zhang, Zifeng
Thanks for sharing. Best Regards, Zifeng -Original Message- From: gaoliming Sent: Friday, March 8, 2024 10:47 PM To: Zhang, Zifeng ; Yang, Yuting2 ; devel@edk2.groups.io Cc: 'Rebecca Cran' ; Feng, Bob C ; Chen, Christine ; Chen, Arthur G Subject: 回复: [Patch V3] BaseTools: VfrCompiler

[edk2-devel] [PATCH 3/4] EmbeddedPkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx

2024-03-12 Thread Qingyu
Refer to Uefi spec 2.10 section 13.3.3, Add a new retval EFI_UNSUPPORTED to EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.ReadKeyStrokeEx and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.ReadKeyStroke(). Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Liming Gao Signed-off-by: Qingyu --- .../Drivers/VirtualK

[edk2-devel] [PATCH 1/4] MdeModulePkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx

2024-03-12 Thread Qingyu
Refer to Uefi spec 2.10 section 13.3.3, Add a new retval EFI_UNSUPPORTED to EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.ReadKeyStrokeEx and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.ReadKeyStroke(). Cc: Liming Gao Cc: Michael D Kinney Signed-off-by: Qingyu --- MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KbdTextIn.c

[edk2-devel] [PATCH 2/4] ShellPkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx

2024-03-12 Thread Qingyu
Refer to Uefi spec 2.10 section 13.3.3, Add a new retval EFI_UNSUPPORTED to EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL.ReadKeyStrokeEx and EFI_SIMPLE_TEXT_INPUT_PROTOCOL.ReadKeyStroke(). Cc: Liming Gao Cc: Zhichao Gao Cc: Chao Li Signed-off-by: Qingyu --- ShellPkg/Application/Shell/ConsoleWrappers.c |

[edk2-devel] [PATCH edk2-platforms 1/1] Platform/RPI4: Grow FV size to accommodate DEBUG build

2024-03-12 Thread Ard Biesheuvel via groups.io
From: Ard Biesheuvel The DEBUG build no longer fits when all build options used by the release script on github.com/pftf are used, presumably due to the OpenSSL upgrade. So bump the size for all builds. Signed-off-by: Ard Biesheuvel --- Platform/RaspberryPi/RPi4/RPi4.fdf | 14 +++---

[edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of TpmMeasureAndLogDataWithFlags()

2024-03-12 Thread Du Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4700 TpmMeasureAndLogDataWithFlags() computes the measure the code and log it into PCR 0. TpmMeasureAndLogData() computes the hash for the configuration. The same "Status" variable is used to store the return values for both of the functions. The

[edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed

2024-03-12 Thread Ard Biesheuvel via groups.io
From: Ard Biesheuvel NonCoherentIoMmuSetAttribute() does nothing except return EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI bus driver will fail a PCI I/O Map() operation if the SetAttributes fails. So return EFI_SUCCESS instead. Signed-off-by: Ard Biesheuvel --- Thi

[edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit()

2024-03-12 Thread Du Lin
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4701 The error handling of FspmWrapperInit() is limited to ASSERT statements only, which only works in debug builds, but not in release builds. Fix the issue by enhancing the error handling of FspmWrapperInit() to cover both debug builds and rele

Re: [edk2-devel] [PATCH v2] DynamicTablesPkg/SSDT: Require Package node in hierarchy

2024-03-12 Thread Jeshua Smith via groups.io
Can we get this reviewed/merged? > -Original Message- > From: Jeshua Smith > Sent: Monday, February 5, 2024 12:01 PM > To: devel@edk2.groups.io > Cc: ardb+tianoc...@kernel.org; quic_llind...@quicinc.com; > pierre.gond...@arm.com; sami.muja...@arm.com; Jeshua Smith > > Subject: [PATCH v2]

Re: [edk2-devel] [PATCH v2] DynamicTablesPkg/SSDT: Require Package node in hierarchy

2024-03-12 Thread Sami Mujawar
Hi Jeshua, Apologies, I somehow missed getting this merged. I will get this in before end of this week. Regards, Sami Mujawar On 12/03/2024, 16:12, "Jeshua Smith" mailto:jesh...@nvidia.com>> wrote: Can we get this reviewed/merged? > -Original Message- > From: Jeshua Smith mailto:je

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed

2024-03-12 Thread Leif Lindholm
On 2024-03-12 08:17, Ard Biesheuvel wrote: From: Ard Biesheuvel NonCoherentIoMmuSetAttribute() does nothing except return EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI bus driver will fail a PCI I/O Map() operation if the SetAttributes fails. So return EFI_SUCCESS ins

Re: [edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

2024-03-12 Thread Leif Lindholm
On 2024-03-12 02:18, Pierre Gondois wrote: This patch relies on [1]. Following the RFC v1: ArmPkg,MdePkg: move ArmLib.h to MdePkg [1], move the Chipset/* files to the MdePkg as the Armlib.h relies on them. These patches span over multiple packages as these Chipset/* files are relocated to a new

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed

2024-03-12 Thread Ard Biesheuvel
On Tue, 12 Mar 2024 at 17:38, Leif Lindholm wrote: > > On 2024-03-12 08:17, Ard Biesheuvel wrote: > > From: Ard Biesheuvel > > > > NonCoherentIoMmuSetAttribute() does nothing except return > > EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI > > bus driver will fail a PCI I

Re: [edk2-devel] [PATCH 0/2] ArmPkg/MdePkg: Move Chipset/* files to MdePkg

2024-03-12 Thread Michael D Kinney
The MdePkg does have a standard location for CPU specific register related includes. Did you consider moving some of the content into * MdePkg/Include/Register/Arm * MdePkg/Include/Register/AArch64 Thanks, Mike > -Original Message- > From: Leif Lindholm > Sent: Tuesday, March 12, 2024

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed

2024-03-12 Thread Leif Lindholm
On 2024-03-12 09:50, Ard Biesheuvel wrote: On Tue, 12 Mar 2024 at 17:38, Leif Lindholm wrote: On 2024-03-12 08:17, Ard Biesheuvel wrote: From: Ard Biesheuvel NonCoherentIoMmuSetAttribute() does nothing except return EFI_UNSUPPORTED. This was fine when it was introduced, but now, the PCI bus

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed

2024-03-12 Thread Ard Biesheuvel
On Tue, 12 Mar 2024 at 17:56, Leif Lindholm wrote: > > On 2024-03-12 09:50, Ard Biesheuvel wrote: > > On Tue, 12 Mar 2024 at 17:38, Leif Lindholm > > wrote: > >> > >> On 2024-03-12 08:17, Ard Biesheuvel wrote: > >>> From: Ard Biesheuvel > >>> > >>> NonCoherentIoMmuSetAttribute() does nothing ex

Re: [edk2-devel] [PATCH 1/1] EmbeddedPkg/NonCoherentIoMmuDxe: Make SetAttributes always succeed

2024-03-12 Thread Leif Lindholm
On 2024-03-12 09:58, Ard Biesheuvel wrote: On Tue, 12 Mar 2024 at 17:56, Leif Lindholm wrote: On 2024-03-12 09:50, Ard Biesheuvel wrote: On Tue, 12 Mar 2024 at 17:38, Leif Lindholm wrote: On 2024-03-12 08:17, Ard Biesheuvel wrote: From: Ard Biesheuvel NonCoherentIoMmuSetAttribute() does

Re: [edk2-devel] [PATCH 0/4][edk2-redfish-client] RedfishClientPkg: fix deallocation of C-structures

2024-03-12 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] For the patch set, Reviewed-by: Abner Chang Please update each patch with reviewed-by and update the PR. Thanks Mike. Abner > -Original Message- > From: Mike Maslenkin > Sent: Sunday, March 10, 2024 6:42 PM > To: devel@edk2.groups.io > Cc: Chang, Abner

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit()

2024-03-12 Thread Chen, Gang C
Reviewed-by: Chen Gang C BR Gang -Original Message- From: Lin, Du Sent: Tuesday, March 12, 2024 5:28 PM To: devel@edk2.groups.io Cc: Lin, Du ; S, Ashraf Ali ; Chiu, Chasel ; Chen, Gang C ; Duggapu, Chinni B ; Desimone, Nathaniel L ; Zeng, Star ; Mohapatra, Susovan ; Kuo, Ted Subje

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of TpmMeasureAndLogDataWithFlags()

2024-03-12 Thread Chen, Gang C
Reviewed-by: Chen Gang C BR Gang -Original Message- From: Lin, Du Sent: Tuesday, March 12, 2024 5:20 PM To: devel@edk2.groups.io Cc: Lin, Du ; S, Ashraf Ali ; Chiu, Chasel ; Chen, Gang C ; Duggapu, Chinni B ; Desimone, Nathaniel L ; Zeng, Star ; Mohapatra, Susovan ; Kuo, Ted Subje

Re: [edk2-devel] [PATCH edk2-platforms 1/1] Platform/RPI4: Grow FV size to accommodate DEBUG build

2024-03-12 Thread Jeremy Linton
Hi, On 3/12/24 05:43, Ard Biesheuvel wrote: On Tue, 12 Mar 2024 at 11:29, Ard Biesheuvel wrote: From: Ard Biesheuvel The DEBUG build no longer fits when all build options used by the release script on github.com/pftf are used, presumably due to the OpenSSL upgrade. So bump the size for all

Re: [edk2-devel] [PATCH v2 1/5] Platform/RaspberryPi/DualSerialPortLib: Always configure the pl011

2024-03-12 Thread Jeremy Linton
Hi, On 3/11/24 09:13, Ard Biesheuvel via groups.io wrote: On Wed, 17 Jan 2024 at 22:36, Jeremy Linton wrote: The rpi's config.txt controls which uart (pl011, or miniuart) is selected as the console. TFA and edk2 follow its lead, but if the miniuart is selected as the primary and the machine

Re: [edk2-devel] [PATCH 2/4] ShellPkg: Update the comments of ReadKeyStroke and ReadKeyStrokeEx

2024-03-12 Thread Chao Li
Hi Qingyu, It may not be my domain, I think what you are trying to say is "Refer to UEFI spec 2.10 section 12.3.3",  not 13.3.3, because the 13.3.3 is "Number and Location of System Partitions", see me comment below. I recommend fixing all of the patch commit messages in this series. The cha

Re: [edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData function description

2024-03-12 Thread Michael D Kinney
Merged: https://github.com/tianocore/edk2/pull/5463 > -Original Message- > From: devel@edk2.groups.io On Behalf Of Qingyu > Sent: Sunday, February 25, 2024 7:06 PM > To: devel@edk2.groups.io > Subject: [edk2-devel] [PATCH v4 0/3] Update ReceiveData and SendData > function description > >

回复: [edk2-devel] [PATCH 0/4] Update the comments of ReadKeyStroke and ReadKeyStrokeEx

2024-03-12 Thread gaoliming via groups.io
For this patch set, Reviewed-by: Liming Gao Besides, please also update Edk2Platforms\Features\Intel\UserInterface\VirtualKeyboardFeaturePkg\Virtual KeyboardDxe Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Qingyu > 发送时间: 2024年3月11日 16:41 > 收件人: devel@edk2.groups.io > 抄送: Ming T

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of TpmMeasureAndLogDataWithFlags()

2024-03-12 Thread Ashraf Ali S
Reviewed-by: S, Ashraf Ali Thanks., S, Ashraf Ali -Original Message- From: Lin, Du Sent: Tuesday, March 12, 2024 2:50 PM To: devel@edk2.groups.io Cc: Lin, Du ; S, Ashraf Ali ; Chiu, Chasel ; Chen, Gang C ; Duggapu, Chinni B ; Desimone, Nathaniel L ; Zeng, Star ; Mohapatra, Susovan

Re: [edk2-devel] [PATCH] IntelFsp2WrapperPkg: Error handling of FspmWrapperInit()

2024-03-12 Thread Ashraf Ali S
Reviewed-by: S, Ashraf Ali Thanks., S, Ashraf Ali -Original Message- From: Lin, Du Sent: Tuesday, March 12, 2024 2:58 PM To: devel@edk2.groups.io Cc: Lin, Du ; S, Ashraf Ali ; Chiu, Chasel ; Chen, Gang C ; Duggapu, Chinni B ; Desimone, Nathaniel L ; Zeng, Star ; Mohapatra, Susovan