[edk2-devel] [PATCH v4 1/2] MdePkg/SmBios.h: Add New ProcessorFamily definitions for SMBIOS Type4

2024-02-25 Thread Jason Lou
From: Jason Lou The patch adds new ProcessorFamily definitions for SMBIOS Type4 based on SMBIOS 3.8.0. Signed-off-by: Jason Lou Cc: Zhiguang Liu Cc: Dandan Bi Cc: Star Zeng Cc: Zhichao Gao Cc: Benny Lin Cc: Gua Guo Cc: Michael D Kinney Cc: Liming Gao --- MdePkg/Include/IndustryStandard

[edk2-devel] [PATCH v4 2/2] ShellPkg/SmbiosView: Support New ProcessorFamily for SMBIOS Type4

2024-02-25 Thread Jason Lou
From: Jason Lou The patch updates SmbiosView to support new ProcessorFamily for SMBIOS Type4 based on SMBIOS 3.8.0. Signed-off-by: Jason Lou Cc: Liming Gao Cc: Zhichao Gao --- ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/PrintInfo.c | 34 +++- 1 file changed, 33 in

Re: [edk2-devel] [PATCH v2 4/5] UefiCpuPkg/MpInitLib: Add support for multiple HOBs to MpInitLibInitialize

2024-02-25 Thread Laszlo Ersek
On 2/23/24 01:23, Ni, Ray wrote: > I prefer HOB instead of dynamic PCD. > And let's keep the new singleton HOB structure as an internal interface > between > PEI MpInitLib and DXE MpInitLib. Sounds good to me, thanks Laszlo >> -Original Message- >> From: Gerd Hoffmann >> Sent: Thursday,

Re: [edk2-devel] [PATCH] UefiCpuPkg: add volatile qualifier to page table related variable

2024-02-25 Thread Laszlo Ersek
On 2/22/24 11:23, Ni, Ray wrote: >>> I agree with the idea (I think it's a necessary change, or put >>> differently, an improvement, even though I may not be convinced that it >>> is a *sufficient* improvement; but let's not rehash all that here >>> again); however, I think the implementation is no

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuPageTableLib: qualify page table accesses as volatile

2024-02-25 Thread Laszlo Ersek
On 2/23/24 16:51, Michael Brown wrote: > On 23/02/2024 15:12, Zhou, Jianfeng wrote: >>> While it may well cause the compiler to generate less optimised code, >>> there is absolutely no way that this volatile declaration on a local >>> stack variable can possibly change the outcome of the code. >>>

Re: [edk2-devel] [PATCH v2] MdeModulePkg/PciBusDxe: plug device hierarchy leak upon bridge hot-unplug

2024-02-25 Thread Laszlo Ersek
On 2/22/24 17:28, Neo Hsueh wrote: > A USB4 or TBT bridge can be plugged or unplugged on USB4 port. The actions > require PciHotPlugRequestNotify to add a root bridge or remove a root bridge > completely. > In the plug-unplug-plug scenerio, PciHotPlugRequestNotify will return with > no-action on

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/CpuPageTableLib: Fix IN OUT parameters marked as IN

2024-02-25 Thread Laszlo Ersek
On 2/22/24 03:39, Zhou Jianfeng wrote: > Some IN OUT parameters in CpuPageTableMap.c were mistakenly marked as IN. > "IN" replaced with "IN OUT" in the following interfaces: > > PageTableLibSetPte4K(): Pte4K > PageTableLibSetPleB(): PleB > PageTableLibSetPle(): Ple > PageTableLibSetPnle(): Pnl

[edk2-devel] [PATCH v1 0/1] UefiPayloadPkg: Make Dsc accomodative of other archs

2024-02-25 Thread Dhaval Sharma
Current DSC files contains a lot of files which are specific to X86 arch. Need to move around files under arch specific sections. Cc: Guo Dong Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Dhaval Sharma Dhaval (1): UefiPayloadPkg: Make Dsc accomodative of other archs UefiPayloa

[edk2-devel] [PATCH v1 1/1] UefiPayloadPkg: Make Dsc accomodative of other archs

2024-02-25 Thread Dhaval Sharma
Current DSC files contains a lot of files which are specific to X86 arch. Need to move around files under arch specific sections. Cc: Guo Dong Cc: Sean Rhodes Cc: James Lu Cc: Gua Guo Signed-off-by: Dhaval Sharma --- UefiPayloadPkg/UefiPayloadPkg.dsc | 48 +++- 1 file changed

Re: [edk2-devel] edk2-test: bug in DevicePathFromTextBBTestCoverage.c

2024-02-25 Thread Laszlo Ersek
Hello Charles, On 2/24/24 17:01, Charles Hyde wrote: > There is a bug in the following source file: > > uefi-sct\ > SctPkg\ > TestCase\ > UEFI\ >EFI\ > Protocol\ > DevicePathFromText\ > BlackBoxTest\ >

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

2024-02-25 Thread Laszlo Ersek
On 2/23/24 16:50, Albecki, Mateusz wrote: > Hi, > > I was originally responsible for suggesting this change > internally(more specifically - to switch from Intel specific LPSS UART > driver to EDK2 driver which on inspection seemed to cover all relevant > modes of operations of LPSS UART). > > Firs

Re: [edk2-devel] [PATCH 1/1] MdeModulePkg: Load Serial driver earlier in DXE

2024-02-25 Thread Laszlo Ersek
On 2/25/24 17:18, Laszlo Ersek wrote: > ... Ah, okay! This is the point where I re-read your steps, and now I > see the actual breakage. > > It is your step #2. > > Placing the PciSioSerialDxe driver -- which is a UEFI driver that > follows the UEFI driver model, and has a long list of dependenc

Re: [edk2-devel] [PATCH] UefiCpuPkg/CpuPageTableLib: qualify page table accesses as volatile

2024-02-25 Thread Zhou, Jianfeng
> While it may well cause the compiler to generate less optimised code, there > is absolutely no way that this volatile declaration on a local stack variable > can possibly change the outcome of the code. > There can never be any meaningful side-effects from reading or writing a > stack variable

Re: [edk2-devel] [PATCH v3 00/12] OvmfPkg: tweak shell builds

2024-02-25 Thread Laszlo Ersek
On 2/22/24 11:13, Gerd Hoffmann wrote: > - Create include files to reduce duplication. > - Fix varpolicy command. > - Little CI tweak. > > v3: > - pick up review and ack tags. > - no functional changes. > v2: > - do not move ShellCEntryLib to include file. > - refine network config conditional

Re: [edk2-devel] [PATCH] ArmVirtPkg/XenAcpiPlatformDxe: Install FACS table from DT

2024-02-25 Thread Laszlo Ersek
On 2/13/24 11:50, David Woodhouse wrote: > From: David Woodhouse > > The FACS may still exist when the reduced hardware flag is set in FADT; > it is optional. Since it contains the hardware signature field which > indicates that a hibernated system should boot cleanly instead of > attempting to r

Re: [edk2-devel] [PATCH v1 0/1] UefiPayloadPkg: Make Dsc accomodative of other archs

2024-02-25 Thread Guo, Gua
Series Reviewed-by: Gua Guo From: Dhaval Sent: Sunday, February 25, 2024 10:50:50 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Rhodes, Sean ; Lu, James ; Guo, Gua Subject: [PATCH v1 0/1] UefiPayloadPkg: Make Dsc accomodative of other archs Current DSC files con

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, February 26, 2024 #cal-reminder

2024-02-25 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, February 26, 2024 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%22

[edk2-devel] [PATCH] RedfishPkg/RestJsonStructureDxe: Refine REST JSON C Structure DXE driver

2024-02-25 Thread Chang, Abner via groups.io
From: Abner Chang BZ #: 4711 - Add mode debug messages. - This driver shouldn't have a dependency on Redfish package and the references of "Redfish" terminology. Remove the references of "Redfish" from this driver. - Fix the missing parameter of DEBUG macros used in this driver. Signed-off

[edk2-devel] [edk2-redfish-client][PATCH] edk2-Redfish-client: Clarify HTTP method used for provisioning

2024-02-25 Thread Chang, Abner via groups.io
From: Abner Chang Clarify the HTTP method that is used to provision BIOS managed Redfish resource. Signed-off-by: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Cc: Mike Maslenkin --- RedfishClientPkg/Readme.md| 35 --- .../Media/redfish-call-flow-provi

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fsp 2.x Changes

2024-02-25 Thread cbduggap
Thanks, Nate, for taking some time to review the patch. I agree that GlobalDatapointer usage to pass Top of CAR from FSP-T to FSP-M is an ugly hack where I only convinced 90% (with my approach 😊) but ended up in adding that logic as we covered all corner cases. Here is the background why: 1.

[edk2-devel] [PATCH V1 0/3] OvmfPkg: Update TDVMCALL to avoid leaking secrets to the VMM

2024-02-25 Thread sunceping
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4696 According to section 2.4.1 of [GHCI] spec, RBP register is usually used as a frame pointer according to the C language calling convention. The software should not use RBP as an input/output parameter and should clear BIT5 (RBP) in the GPR

[edk2-devel] [PATCH V1 1/3] MdePkg/BaseLib: Update TDVMCALL_EXPOSE_REGS_MASK

2024-02-25 Thread sunceping
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4696 Refer to the [GHCI] spec, TDVF should clear the BIT5 for RBP in the mask. Reference: [GHCI]: TDX Guest-Host-Communication Interface v1.5 https://cdrdv2.intel.com/v1/dl/getContent/726792 Cc: Liming Gao Cc: Michael D Kinney Cc: Erdem Aktas

[edk2-devel] [PATCH V1 2/3] OvmfPkg/CcExitLib: Update TDVMCALL_EXPOSE_REGS_MASK

2024-02-25 Thread sunceping
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4696 Refer to the [GHCI] spec, TDVF should clear the BIT5 for RBP in the mask. Reference: [GHCI]: TDX Guest-Host-Communication Interface v1.5 https://cdrdv2.intel.com/v1/dl/getContent/726792 Cc: Erdem Aktas Cc: James Bottomley Cc: Jiewen Yao

[edk2-devel] [PATCH V1 3/3] OvmfPkg/TdxDxe: Clear the registers before tdcall

2024-02-25 Thread sunceping
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4696 Refer to the [GHCI] spec, TDVF should clear the BIT5 for RBP in the mask. And TDVF should clear the regitsers to avoid leaking secrets to VMM. Reference: [GHCI]: TDX Guest-Host-Communication Interface v1.5 https://cdrdv2.intel.com/v1/dl/get

Re: [edk2-devel] [PATCH v2] IntelFsp2Pkg: Fsp 2.x Changes

2024-02-25 Thread cbduggap
Corrected #3 in background. Thanks, Chinni. -Original Message- From: devel@edk2.groups.io On Behalf Of cbduggap Sent: Monday, February 26, 2024 10:45 AM To: Desimone, Nathaniel L ; devel@edk2.groups.io Cc: Chaganty, Rangasai V ; Chiu, Chasel Subject: Re: [edk2-devel] [PATCH v2] IntelFs