Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix clang error

Hi Liming, Could you please help review and get this patch merged within the next edk2-stable tag? Thanks, Nhi On 10/23/2023 11:27 AM, Nhi Pham via groups.io wrote: > This looks good to me. I also build-tested this patch. > > Reviewed-by: Nhi Pham > Tested-by: Nhi Pham > > On 10/3/2023 10:04

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Remove Orphan status option

Hi Mike, On 11/5/23 02:11, Michael D Kinney wrote: > Cc: Andrew Fish > Cc: Leif Lindholm > Cc: Laszlo Ersek > Signed-off-by: Michael D Kinney > --- > Maintainers.txt | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/Maintainers.txt b/Maintainers.txt > index 2b03ccbe54aa..cfbde42f2e04

Re: [edk2-devel] [Patch 1/1] Maintainers.txt: Update based on active community members

On 11/5/23 02:22, Kinney, Michael D wrote: > Hi Laszlo, > > I have sent patch review to remove Orphan status option from Maintainers.txt. > > I have also opened the following 3 BZs > > OvmfPkg/CSM: https://bugzilla.tianocore.org/show_bug.cgi?id=4588 > SignedCapsulePkg: https://bugzilla.tianocore

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP Exception when CET enable

Hi Jiaxin, looks great; now I'm only asking for a few light touch-ups: On 11/3/23 19:37, Jiaxin Wu wrote: > Shadow stack will stop update after CET disable (DisableCet in > DisableReadOnlyPageWriteProtect), but normal smi stack will be > continue updated with the function return and enter > (Disa

Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix clang error

On 10/3/23 17:04, Jake Garver via groups.io wrote: > Ignore old style declaration warnings in oniguruma/src/st.c. This was > already ignored for MSFT, but newer versions of clang complain as well. > > Signed-off-by: Jake Garver > --- > .../Universal/RegularExpressionDxe/RegularExpressionDxe.inf

[edk2-devel] [PATCH v2 edk2-platforms 0/1] Add Standalone MM support for SmmIpmiBaseLib

V1: This patch is to add Standalone MM support for SmmIpmiBaseLib. PR: https://github.com/tianocore/edk2-platforms/pull/107 V2: - Update the copyright year - Remove the duplicate old-style function comment on IpmiSubmitCommand() - Add MM_CORE_STANDALONE type into the inf PR: https://github.com/tia

[edk2-devel] [PATCH v2 edk2-platforms 1/1] IpmiFeaturePkg/SmmIpmiBaseLib: Support Standalone MM.

Add MM_STANDALONE type support for SmmIpmiBaseLib instance. Replace Smst with Mmst. Remove unused UefiBootServicesTableLib reference. Cc: Abner Chang Cc: Nate DeSimone Cc: Liming Gao Signed-off-by: Wei6 Xu --- .../Library/SmmIpmiBaseLib/SmmIpmiBaseLib.c | 39 +-- .../Library

[edk2-devel] [Patch v2 1/1] Maintainers.txt: Remove Orphan status option

We would like any proposed change in the edk2 codebase to be assignable to a human maintainer/reviewer. If there is a feature for which there is no longer any support, we should find a way to remove it from the head of the repository. For critical features, we must find community members that are w

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, November 6, 2023 #cal-reminder

*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, November 6, 2023 4:30pm to 5:30pm (UTC-08:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%227

Re: [edk2-devel] [edk2-redfish-client][PATCH 1/2] RedfishClientPkg: introduce Redfish override protocol

[AMD Official Use Only - General] Reviewed-by: Abner Chang > -Original Message- > From: Nickle Wang > Sent: Thursday, November 2, 2023 6:18 PM > To: devel@edk2.groups.io > Cc: Chang, Abner ; Igor Kulchytskyy > ; Nick Ramirez > Subject: [edk2-redfish-client][PATCH 1/2] RedfishClientPkg:

Re: [edk2-devel] [edk2-redfish-client][PATCH 2/2] RedfishClientPkg/RedfishFeatureCoreDxe: notify platform before reboot.

[AMD Official Use Only - General] Looks good, you can move EDKII_REDFISH_OVERRIDE_PROTOCOL *RedfishOverride from local variable to global variable and locate this protocol only once if there are more than one use cases of Redfish override protocol in RedfishFeatureCore in the future. Reviewe

回复: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix clang error

Laszlo： I agree your suggestion. We can submit a new request to update oniguruma to the latest version. This patch avoids the warning on the current version. I think this change is OK. I would like to merge this fix first. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Las

回复: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix clang error

Reviewed-by: Liming Gao > -邮件原件- > 发件人: Nhi Pham > 发送时间: 2023年11月5日 15:09 > 收件人: devel@edk2.groups.io; j...@nvidia.com > 抄送: jian.j.w...@intel.com; gaolim...@byosoft.com.cn > 主题: Re: [edk2-devel] [PATCH] MdeModulePkg/RegularExpressinoDxe: Fix > clang error > > Hi Liming, > > Could you

[edk2-devel] 回复: [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-regs-only for AArch64 CLANGDWARF

Reviewed-by: Liming Gao > -邮件原件- > 发件人: Yeping Song > 发送时间: 2023年11月4日 0:38 > 收件人: devel@edk2.groups.io > 抄送: Yeping Song ; Rebecca Cran > ; Liming Gao ; Bob Feng > ; Yuwei Chen ; Ard > Biesheuvel ; Leif Lindholm > ; Sami Mujawar > 主题: [PATCH 1/1] BaseTools/tools_def: drop -mgeneral-reg

回复: [edk2-devel] [PATCH 1/1] BaseTools: Update PatchCheck.py to allow whitespace issues in .rtf files

Reviewed-by: Liming Gao > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Rebecca Cran > 发送时间: 2023年11月3日 22:42 > 收件人: Liming Gao > 抄送: devel@edk2.groups.io; Bob Feng ; Yuwei Chen > > 主题: Re: [edk2-devel] [PATCH 1/1] BaseTools: Update PatchCheck.py to > allow whitespace issues in .rtf files > >

Re: [edk2-devel] [PATCH v1 6/7] UefiPayloadPkg: Specifies SmmCpuSyncLib instance

Reviewed-by: Gua Guo -Original Message- From: Wu, Jiaxin Sent: Friday, November 3, 2023 11:30 PM To: devel@edk2.groups.io Cc: Dong, Guo ; Rhodes, Sean ; Lu, James ; Guo, Gua ; Ni, Ray ; Zeng, Star Subject: [PATCH v1 6/7] UefiPayloadPkg: Specifies SmmCpuSyncLib instance The SmmCpuSyn

[edk2-devel] 回复: [PATCH v2 0/2] dp command without ACPI

Create PR https://github.com/tianocore/edk2/pull/5003 for this patch set. > -邮件原件- > 发件人: Gao, Zhichao > 发送时间: 2023年10月17日 10:39 > 收件人: Jeff Brasen ; Gao, Liming > ; devel@edk2.groups.io > 抄送: Wang, Jian J ; Bi, Dandan > > 主题: RE: [PATCH v2 0/2] dp command without ACPI > > Hi Liming, >

Re: [edk2-devel] [PATCH] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Hi Igor I want to return to my initial comments regarding this patch. Please, find my comments below. > On 1. 11. 2023., at 06:24, Igor Kulchytskyy wrote: > > Hi Mike, > Thank you for review. > Please see my answers below the text. > > -Original Message- > From: Mike Maslenkin > Sent

[edk2-devel] [PATCH v3] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP Exception when CET enable

Shadow stack will stop update after CET disable (DisableCet in DisableReadOnlyPageWriteProtect), but normal smi stack will be continue updated with the function return and enter (DisableReadOnlyPageWriteProtect & EnableReadOnlyPageWriteProtect), thus leading stack mismatch after CET re-enabled (Ena

Re: [edk2-devel] [PATCH v2] UefiCpuPkg/PiSmmCpuDxeSmm: Fix CP Exception when CET enable

Thanks Laszlo, all fixed in version 3. > -Original Message- > From: Laszlo Ersek > Sent: Sunday, November 5, 2023 7:01 PM > To: Wu, Jiaxin ; devel@edk2.groups.io > Cc: Dong, Eric ; Ni, Ray ; Zeng, Star > ; Gerd Hoffmann ; Kumar, Rahul R > > Subject: Re: [PATCH v2] UefiCpuPkg/PiSmmCpuDxeS

[edk2-devel] [PATCH v8 0/5] Cache Management Operations Support For RISC-V

Implementing code to support Cache Management Operations (CMO) defined by RISC-V CMO instructions.https://github.com/riscv/riscv-CMOs This is a re-write of original series v5. The patchset contains 5 patches- created based on V5 feedback. 1. Restructuring of existing code and move instruction decla

[edk2-devel] [PATCH v8 2/5] MdePkg: Rename Cache Management Function To Clarify Fence Based Op

There are different ways to manage cache on RISC-V Processors. One way is to use fence instruction. Another way is to use CPU specific cache management operation instructions ratified as per RISC-V ISA specifications to be introduced in future patches. Current method is fence instruction based, ren

[edk2-devel] [PATCH v8 1/5] MdePkg: Move RISC-V Cache Management Declarations Into BaseLib

The declarations for cache Management functions belong to BaseLib instead of instance source file. This helps with further restructuring of cache management code for RISC-V. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Laszlo Ersek Signed-off-by: Dhaval Sharma Reviewed-by: Laszlo

[edk2-devel] [PATCH v8 3/5] MdePkg: Implement RISC-V Cache Management Operations

Implement Cache Management Operations (CMO) defined by RISC-V spec https://github.com/riscv/riscv-CMOs. Notes: 1. CMO only supports block based Operations. Meaning cache flush/invd/clean Operations are not available for the entire range. In that case we fallback on fence.i instructions. 2. O

[edk2-devel] [PATCH v8 4/5] MdePkg: Utilize Cache Management Operations Implementation For RISC-V

Use newly defined cache management operations for RISC-V where possible It builds up on the support added for RISC-V cache management instructions in BaseLib. Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Cc: Laszlo Ersek Signed-off-by: Dhaval Sharma Acked-by: Laszlo Ersek --- Notes:

[edk2-devel] [PATCH v8 5/5] OvmfPkg/RiscVVirt: Override for RV CPU Features

This PCD provides a way for platform to override any HW features that are default enabled by previous stages of FW (like OpenSBI). For the case where previous/prev stage has disabled the feature, this override is not useful and its usage should be avoided. Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: J

Re: [edk2-devel] [PATCH v2] RedfishPkg: RedfishDiscoverDxe: Fix issue if IPv4 installed after RestEx

Fixed and resubmitted. Get Outlook for Android From: devel@edk2.groups.io on behalf of Igor Kulchytskyy via groups.io Sent: Friday, November 3, 2023 2:01:36 PM To: Mike Maslenkin Cc: devel@edk2.groups.io ; Abner Chang ; Nickle Wang Sub

[edk2-devel] [PATCH v2 00/30] Enable LoongArch virtual machine in edk2

This patch set will enable LoongArch virtual machine in edk2, the new LoongArch virtual machine is located in OvmfPkg/LoongArchVirt/, it is a generic platform that dose not require any actual hardware. Patch1-Patch14: Submit the common library and driver for LoongArch virtual machine and real hard

[edk2-devel] [PATCH v2 01/30] MdePkg: Add the header file named Csr.h for LoongArch64

Adding Csr.h for LoongArch64, it is use for accessing the CSR registers. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Chao Li --- MdePkg/Include/Register/LoongArch64/Csr.h | 221 ++ 1 file chan

[edk2-devel] [PATCH v2 02/30] MdePkg: Add LoongArch64 FPU function set into BaseCpuLib

Adding InitializeFloatingPointUnits, EnableFloatingPointUnits and DisableFloatingPointUnits functions for LoongArch64. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Chao Li --- MdePkg/Include/Library/CpuLib.h

[edk2-devel] [PATCH v2 03/30] MdePkg: Add LoongArch64 exception function set into BaseLib

Adding SetExceptionBaseAddress and SetTlbRebaseAddress functions for LoongArch64. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Chao Li --- MdePkg/Include/Library/BaseLib.h | 20 + MdePkg/Libra

[edk2-devel] [PATCH v2 04/30] MdePkg: Add LoongArch64 local interrupt function set into BaseLib

Adding LoongArch local interrupt function set, which is used to control the opening or closing of the local interrupt when the global interrupt is enabled. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Chao Li ---

[edk2-devel] [PATCH v2 05/30] MdePkg: Add LoongArch Cpucfg function

Add LoongArch AsmCpucfg function and Cpucfg definitions. Also added Include/Register/LoongArch64/Cpucfg.h to IgnoreFiles of EccCheck. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Chao Li --- MdePkg/Include/Librar

[edk2-devel] [PATCH v2 06/30] MdePkg: Add read stable counter operation for LoongArch

Add LoongArch gets stable counter ASM function. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Chao Li --- MdePkg/Include/Library/BaseLib.h | 12 ++ MdePkg/Library/BaseLib/BaseLib.inf

[edk2-devel] [PATCH v2 07/30] MdePkg: Add CSR operation for LoongArch

Add CsrRead, CsrWrite and CsrXChg functions for LoongArch, and use them to operate the CSR register of LoongArch architecture. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Chao Li Co-authored-by: Bibo Mao --- Mde

[edk2-devel] [PATCH v2 08/30] MdePkg: Add IOCSR operation for LoongArch

Add IoCsrRead8, IoCsrRead16, IoCsrRead32, IoCsrRead64, IoCsrWrite8, IoCsrWrite16, IoCsrWrite32, IoCsrWrite64 to operate the IOCSR registers of LoongArch architecture. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Michael D Kinney Cc: Liming Gao Cc: Zhiguang Liu Signed-off-by: Cha

[edk2-devel] [PATCH v2 09/30] UefiCpuPkg: Add LoongArch64 CPU Timer library

Add the LoongArch64 CPU Timer library, using CPUCFG 0x4 and 0x5 for Stable Counter frequency. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Chao Li --- .../BaseLoongArch64CpuTimerLib.inf| 30 +++

[edk2-devel] [PATCH v2 10/30] UefiCpuPkg: Add CPU exception library for LoongArch

Added a new library named LoongArch64CpuExceptionHandlerLib, and modified the way LoongArch exceptions are expressed. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Chao Li Co-authored-by: Baoqi Zhang --- Md

[edk2-devel] [PATCH v2 11/30] UefiCpuPkg: Add CpuMmuLib.h to UefiCpuPkg

Add a new header file CpuMmuLib.h, whitch is referenced from ArmPkg/Include/Library/ArmMmuLib.h. Currently, only support for LoongArch64 is added, and more architectures can be accommodated in the future. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Eric Dong Cc: Ray Ni Cc: Rahul

[edk2-devel] [PATCH v2 12/30] UefiCpuPkg: Add LoongArch64CpuMmuLib to UefiCpuPkg

Add a new library LoongArch64CpuMmuLib. It provides two-stage MMU library instances, PEI and DXE. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Chao Li Co-authored-by: Baoqi Zhang Co-authored-by: Dongyan Qia

[edk2-devel] [PATCH v2 13/30] UefiCpuPkg: Add multiprocessor library for LoongArch64

Added a new library named LoongArch64MpInitLib. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Acked-by: Ray Ni Signed-off-by: Chao Li --- .../LoongArch64MpInitLib/DxeMpInitLib.inf | 45 + .../LoongArch64MpInitLib/Dx

[edk2-devel] [PATCH v2 14/30] UefiCpuPkg: Add CpuDxe driver for LoongArch64

Added a new DXE driver named CpuDxeLoongArch64. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Eric Dong Cc: Ray Ni Cc: Rahul Kumar Cc: Gerd Hoffmann Signed-off-by: Chao Li Co-authored-by: Baoqi Zhang Co-authored-by: Dongyan Qian --- UefiCpuPkg/CpuDxeLoongArch64/CpuDxe.c|

[edk2-devel] [PATCH v2 15/30] EmbeddedPkg: Add PcdPrePiCpuIoSize width for LOONGARCH64

Added LoongArch64 architecture CPU IO width. https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Daniel Schaefer Signed-off-by: Chao Li --- EmbeddedPkg/EmbeddedPkg.dec | 3 +++ 1 file changed, 3 insertions(+) diff --git a/EmbeddedPkg

[edk2-devel] [PATCH v2 16/30] ArmVirtPkg: Move PCD of FDT base address and FDT padding to OvmfPkg

Moved PcdDeviceTreeInitialBaseAddress and PcdDeviceTreeAllocationPadding to OvmfPkg for easier use by other architectures. Build-tested only (with "ArmVirtQemu.dsc"). BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Leif Lindholm Cc: Sami Mujawar Cc: Gerd Hoffman

[edk2-devel] [PATCH v2 17/30] OvmfPkg/LoongArchVirt: Add PciCpuIo2Dxe module

Add PciCpuIo2Dxe for LoongArch, this module is similar to ArmPciCpuIo2Dxe drvier. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Chao Li Co-authored-by: Xianglai Li Co-authored-by: Bibo Mao --- .

[edk2-devel] [PATCH v2 18/30] OvmfPkg/LoongArchVirt: Add stable timer driver

Add a CPU timer driver named StableTimerDxe, which proviedes EFI_TIMER_ARCH_PROTOCOL for LoongArch. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Chao Li Co-authored-by: Baoqi Zhang --- .../Drive

[edk2-devel] [PATCH v2 19/30] OvmfPkg/LoongArchVirt: Add a NULL library named CollectApResouceLibNull

This Library is used to collect APs resources, but is currently NULL for OvmfPkg, because it is not used by the LoongArch virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Chao Li ---

[edk2-devel] [PATCH v2 20/30] OvmfPkg/LoongArchVirt: Add serial port library

Add two libraries named Fdt16550SerialPortHookLib and EarlyFdtSerialPortLib16550, requested by LoongArch virtual machine. The Fdt16550SerialProtHookLib is referenced from ArmVirtPkg. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc

[edk2-devel] [PATCH v2 21/30] OvmfPkg/LoongArchVirt: Add real time clock library

This library is provides real time clock for LoongArch virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Chao Li Co-authored-by: Baoqi Zhang Co-authored-by: Xianglai Li --- .../DxeL

[edk2-devel] [PATCH v2 22/30] OvmfPkg/LoongArchVirt: Add NorFlashQemuLib

Add NorFlashQemuLib for LoongArch, it is referenced from ArmVirtPkg. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Chao Li Co-authored-by: Xianglai Li Co-authored-by: Bibo Mao --- .../Library/No

[edk2-devel] [PATCH v2 23/30] OvmfPkg/LoongArchVirt: Add PeiServiceTablePointerLib

Use a register to save PeiServiceTable pointer. This Library provides PeiServiceTable pointer saveing and retrieval serivces. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Chao Li Co-authored-by: X

[edk2-devel] [PATCH v2 24/30] OvmfPkg/LoongArchVirt: Add platform boot manager library

This library is provides boot mananger interfaces, and it is referenced from ArmVirtPkg. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Chao Li Co-authored-by: Xianglai Li Co-authored-by: Bibo Mao

[edk2-devel] [PATCH v2 25/30] OvmfPkg/LoongArchVirt: Add FdtQemuFwCfgLib

This library for PEI phase, and obtains the QemuFwCfg base address by directly parsing the FDT, reads and writes the data in QemuFwCfg by operating on the QemuFwCfg base address. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Ger

[edk2-devel] [PATCH v2 26/30] OvmfPkg/LoongArchVirt: Add reset system library

This library provides interface related to restart and shudown the LoongArch64 virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Chao Li Co-authored-by: Xianglai Li Co-authored-by: Bi

[edk2-devel] [PATCH v2 27/30] OvmfPkg/LoongArchVirt: Support SEC phase

Add SEC code for LoongArch virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Chao Li Co-authored-by: Xianglai Li Co-authored-by: Bibo Mao --- OvmfPkg/LoongArchVirt/Sec/LoongArch64/S

[edk2-devel] [PATCH v2 28/30] OvmfPkg/LoongArchVirt: Support PEI phase

Platfrom PEI module for LoongArch platfrom initialization. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Chao Li Co-authored-by: Xianglai Li Co-authored-by: Bibo Mao --- OvmfPkg/LoongArchVirt/Pl

[edk2-devel] [PATCH v2 29/30] OvmfPkg/LoongArchVirt: Add build file

Add infrastructure files to build edk2 for LoongArch QEMU virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Chao Li Co-authored-by: Xianglai Li Co-authored-by: Bibo Mao --- OvmfPkg/

[edk2-devel] [PATCH v2 30/30] OvmfPkg/LoongArchVirt: Add self introduction file

Add self introduction file for LoongArch virtual machine. BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=4584 Cc: Ard Biesheuvel Cc: Jiewen Yao Cc: Jordan Justen Cc: Gerd Hoffmann Signed-off-by: Chao Li --- OvmfPkg/LoongArchVirt/Readme.md | 67 + 1 file c

Re: [edk2-devel] [PATCH] MdeModulePkg/PciHostBridgeDxe: Add readback after final Cfg-Write

> > (1) I'd like (a) the problem report, and the full reasoning by Ard and > Michael to be captured in the commit message, and (b) *minimally* a hint > at the possible reordering, and at the PCI spec-based workaround, to be > placed in the code comment as well. > Laszlo, please forgive me if thi

[edk2-devel] [PATCH v4 0/4] StandaloneMmCore finds drivers in uncompressed inner fv.

V1: This patch is to fix the issue that StandaloneMmCore fails to detect uncompressed inner FV. PR: https://github.com/tianocore/edk2/pull/4943 V2: Based on V1, fix some other issues 1. Add Missing object size checks before casting pointers to header types a. InnerFvHeader = (EFI_FIRMWARE_VOLUM

[edk2-devel] [PATCH v4 1/4] StandaloneMmPkg/Core: Limit FwVol encapsulation section recursion

MmCoreFfsFindMmDriver() is called recursively for encapsulation sections. Currently this recursion is not limited. Introduce a new PCD (fixed-at-build, or patchable-in-module), and make MmCoreFfsFindMmDriver() track the section nesting depth against that PCD. Cc: Laszlo Ersek Cc: Ard Biesheuvel

[edk2-devel] [PATCH v4 2/4] StandaloneMmPkg/Core: Fix potential memory leak issue

In MmCoreFfsFindMmDriver(), - ScratchBuffer is not freed in the error return path that DstBuffer page allocation fails. Free ScratchBuffer before return with error. - If the decoded buffer is identical to the data in InputSection, ExtractGuidedSectionDecode() will change the value of DstBuffer rath

[edk2-devel] [PATCH v4 3/4] StandaloneMmPkg/Core: Fix issue that offset calculation might be wrong

MmCoreFfsFindMmDriver() assumes FileHeader is EFI_FFS_FILE_HEADER. If FileHeader is an EFI_FFS_FILE_HEADER2, 'FileHeader + 1' will get a wrong section address. Use FfsFindSection to get the section directly, instead of 'FileHeader + 1' to avoid this issue. MmCoreFfsFindMmDriver() also assumes secti

[edk2-devel] [PATCH v4 4/4] StandaloneMmPkg/Core: Fix the failure to find uncompressed inner FV

The MmCoreFfsFindMmDriver only checks for encapsulated compressed FVs. When an inner FV is uncompressed, StandaloneMmCore will miss the FV and all the MM drivers in the FV will not be dispatched. Add checks for uncompressed inner FV to fix this issue. Cc: Laszlo Ersek Cc: Ard Biesheuvel Cc: Sami

Re: [edk2-devel] [PATCH v3 2/4] StandaloneMmPkg/Core: Fix potential memory leak issue

Sorry for the late response. Thanks a lot for the review. Comment below. BR, Wei >-Original Message- >From: Laszlo Ersek >Sent: Tuesday, October 31, 2023 7:43 PM >To: Xu, Wei6 ; devel@edk2.groups.io >Cc: Ard Biesheuvel ; Sami Mujawar >; Ni, Ray >Subject: Re: [PATCH v3 2/4] StandaloneMmP