[edk2-devel] [PATCH 0/2] DynamicTablesPkg/TableHelperLib updates

2023-10-06 Thread Jeshua Smith via groups.io
While using the ConfigurationManagerObjectParser to dump objects and debug adding new objects, I noticed some bugs and deficiencies. This series is intended to address those. Jeshua Smith (2): DynamicTablesPkg/TableHelperLib: Fix and improve text handling DynamicTablesPkg/TableHelperLib: Enhan

[edk2-devel] [PATCH 2/2] DynamicTablesPkg/TableHelperLib: Enhance error handling

2023-10-06 Thread Jeshua Smith via groups.io
This patch enhances error handling and reporting in the CM ObjectParser. Specifically: 1. ObjectIDs used as array indexes are checked for being out of bounds, and if so an error message is printed before the assert. 2. An error message is printed for unsupported NameSpaceIDs. 3. Adds support for

[edk2-devel] [PATCH 1/2] DynamicTablesPkg/TableHelperLib: Fix and improve text handling

2023-10-06 Thread Jeshua Smith via groups.io
This fixes two bugs and adds some enhancements to the handling of characters and strings in objects being printed by the CM ObjectParser. Bug fixes: 1. PrintOemID() currently attempts to print characters with "%C", but the correct syntax is (lowercase) "%c". This bug results in "CC" bein

Re: [edk2-devel] [PATCH 1/1] ArmVirtPkg/FdtPL011SerialPortLib: initialize implicitly

2023-10-06 Thread Ard Biesheuvel
On Mon, 2 Oct 2023 at 16:47, Laszlo Ersek wrote: > > On 9/30/23 23:23, Laszlo Ersek wrote: > > FdtPL011SerialPortLib claims that it's usable from the DXE_CORE. That's > > not correct: the DXE_CORE calls DEBUG() and ASSERT() before it calls > > ProcessLibraryConstructorList(). Via the BaseDebugLibS

[edk2-devel] another broken PR

2023-10-06 Thread Ard Biesheuvel
Could someone please explain what went wrong this time? Many of the tests are failing, and i don't see a 're-run failed tests' button. https://github.com/tianocore/edk2/pull/4893 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109367): ht

Re: [edk2-devel] another broken PR

2023-10-06 Thread Michael Kubacki
I think this is related to the fact that the latest VM images switched over to Python 3.12 and the minor version is not fixed to 11. C:\hostedtoolcache\windows\Python\3.12.0 I can send a patch to fix the minor version to 3.11 and then the transition to 3.12 can take place with more time to e

Re: [edk2-devel] another broken PR

2023-10-06 Thread Taylor Beebe
Did you not create a circle of salt before starting the CI pipelines? That's probably it... or something else :) -Taylor On 10/6/2023 3:50 PM, Ard Biesheuvel wrote: Could someone please explain what went wrong this time? Many of the tests are failing, and i don't see a 're-run failed tests' bu

[edk2-devel] [PATCH v1 0/2] Fix Python minor version

2023-10-06 Thread Michael Kubacki
From: Michael Kubacki Python 3.12 released recently. The Python version is currently specified to allow updates to newer minor versions. Time is needed to adjust scripts for Python 3.12 so this series fixes the Python version to 3.11. Some places that were already fixed but need the version upda

[edk2-devel] [PATCH v1 1/2] .azurepipelines: Fix Python version (to 3.11)

2023-10-06 Thread Michael Kubacki
From: Michael Kubacki Build was previously using 3.11. Using 3.12 now that is is released. To allow scripts to take time to update, fix to 3.11. Cc: Sean Brogan Cc: Michael D Kinney Cc: Liming Gao Signed-off-by: Michael Kubacki --- .azurepipelines/Ubuntu-PatchCheck.yml | 2 +- .azurepipeli

[edk2-devel] [PATCH v1 2/2] .github: Fix Python version (to 3.11)

2023-10-06 Thread Michael Kubacki
From: Michael Kubacki Build was previously using 3.11. Using 3.12 now that is is released. To allow scripts to take time to update, fix to 3.11. Cc: Sean Brogan Cc: Michael D Kinney Signed-off-by: Michael Kubacki --- .github/workflows/codeql-analysis.yml | 2 +- 1 file changed, 1 insertion(+

Re: [edk2-devel] another broken PR

2023-10-06 Thread Michael Kubacki
https://edk2.groups.io/g/devel/message/109370 On 10/6/2023 6:54 PM, Michael Kubacki wrote: I think this is related to the fact that the latest VM images switched over to Python 3.12 and the minor version is not fixed to 11.   C:\hostedtoolcache\windows\Python\3.12.0 I can send a patch to fix

Re: [edk2-devel] [PATCH v1 0/2] Fix Python minor version

2023-10-06 Thread Sean
for the series Reviewed-by: Sean Brogan On 10/6/2023 4:10 PM, Michael Kubacki wrote: From: Michael Kubacki Python 3.12 released recently. The Python version is currently specified to allow updates to newer minor versions. Time is needed to adjust scripts for Python 3.12 so this series fixes

Re: [edk2-devel] another broken PR

2023-10-06 Thread Michael Kubacki
On 10/6/2023 7:17 PM, Michael Kubacki wrote: https://edk2.groups.io/g/devel/message/109370 I am planning to quickly merge that series (with its R-b) when PR checks are completed to unblock CI. On 10/6/2023 6:54 PM, Michael Kubacki wrote: I think this is related to the fact that the latest VM

Re: [edk2-devel] another broken PR

2023-10-06 Thread Michael Kubacki
On 10/6/2023 8:18 PM, Michael Kubacki wrote: On 10/6/2023 7:17 PM, Michael Kubacki wrote: https://edk2.groups.io/g/devel/message/109370 I am planning to quickly merge that series (with its R-b) when PR checks are completed to unblock CI. Merged to master in commits 6439c73 and 82191f8. On

Re: [edk2-devel] [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry

2023-10-06 Thread Li, Yi
Joey: I already give feedback for CryptoPkg part. Seems there are two Crypto patch 07/24 and 13/24, but actually 13 is StandaloneMmPkg changes. Please check. [PATCH v1 13/24] CryptoPkg: CI: Add PrEval entry -Original Message- From: devel@edk2.groups.io On Behalf Of Li, Yi Sent: Wednes

[edk2-devel] 回复: [PATCH v2] BaseStackCheckLib: Fix STACK FAULT message

2023-10-06 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Jake Garver > 发送时间: 2023年10月6日 0:19 > 收件人: devel@edk2.groups.io > 抄送: michael.d.kin...@intel.com; gaolim...@byosoft.com.cn; > zhiguang@intel.com; Jake Garver > 主题: [PATCH v2] BaseStackCheckLib: Fix STACK FAULT message > > __builtin_return_add

回复: 回复: [edk2-devel] 回复: [PATCH v1 3/4] MdeModulePkg: PeiMain: Introduce implementation of delayed dispatch

2023-10-06 Thread gaoliming via groups.io
Kun: For this usage, this PCD is not required. We can update the code logic to avoid new PCD. You can set the default PPI number for current usage. If so, PPI number will not be increased. Thanks Liming 发件人: devel@edk2.groups.io 代表 Kun Qin 发送时间: 2023年10月4日 22:54 收件人: devel@edk2.groups.i

[edk2-devel] 回复: [PATCH] MdeModulePkg/DxeCore: Allow relocation of images with large address

2023-10-06 Thread gaoliming via groups.io
Jeff: I have no better solution than your proposal for this problem. So, this patch is good to me. Reviewed-by: Liming Gao Thanks Liming > -邮件原件- > 发件人: Jeff Brasen > 发送时间: 2023年9月12日 4:14 > 收件人: devel@edk2.groups.io > 抄送: jian.j.w...@intel.com; gaolim...@byosoft.com.cn; > dandan...@in

回复: [edk2-devel] [PATCH v4 00/14] Add ImagePropertiesRecordLib and Fix MAT Bugs

2023-10-06 Thread gaoliming via groups.io
Taylor: I agree to add new ImagePropertiesRecordLib library for DxeCore and SmmCore. The impact is that platform needs to update their DSC with new library. Frankly, I have not understood MAT code in detail. So, I have no comments on this part. Last, what test have been done to verify t

[edk2-devel] [PATCH] UefiCpuPkg: Correct file description for MpHandOff header file

2023-10-06 Thread Yuanhao Xie
Cc: Eric Dong Cc: Rahul Kumar Cc: Tom Lendacky Signed-off-by: Yuanhao Xie --- UefiCpuPkg/Library/MpInitLib/MpHandOff.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/UefiCpuPkg/Library/MpInitLib/MpHandOff.h b/UefiCpuPkg/Library/MpInitLib/MpHandOff.h index 83e4055ec9..