Joey:
I already give feedback for CryptoPkg part.
Seems there are two Crypto patch 07/24 and 13/24, but actually 13 is
StandaloneMmPkg changes. Please check.
[PATCH v1 13/24] CryptoPkg: CI: Add PrEval entry
-----Original Message-----
From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Li, Yi
Sent: Wednesday, August 2, 2023 12:42 PM
To: Joey Vagedes <joey.vage...@gmail.com>; devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen....@intel.com>; Lu, Xiaoyu1 <xiaoyu1...@intel.com>;
Jiang, Guomin <guomin.ji...@intel.com>
Subject: Re: [edk2-devel] [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry
Looks good to me.
Reviewed-by: Yi Li <yi1...@intel.com>
-----Original Message-----
From: Joey Vagedes <joey.vage...@gmail.com>
Sent: Tuesday, June 27, 2023 5:34 AM
To: devel@edk2.groups.io
Cc: Yao, Jiewen <jiewen....@intel.com>; Li, Yi1 <yi1...@intel.com>; Lu, Xiaoyu1
<xiaoyu1...@intel.com>; Jiang, Guomin <guomin.ji...@intel.com>
Subject: [PATCH v1 07/24] CryptoPkg: CI: Add PrEval entry
Adds a PrEval entry to the package's ci.yaml file which is used to verify if
the package uses a particular library instance when that library instance file
(INF) is updated.
When a library instance file (INF) is updated, PrEval will review each
package's DSC as described in the ci.yaml file to determine if the package uses
said library instance. If the package does use the library instance, it will be
built and tested to ensure the package is not broken from the change.
Cc: Jiewen Yao <jiewen....@intel.com>
Cc: Yi Li <yi1...@intel.com>
Cc: Xiaoyu Lu <xiaoyu1...@intel.com>
Cc: Guomin Jiang <guomin.ji...@intel.com>
Signed-off-by: Joey Vagedes <joeyvage...@gmail.com>
---
CryptoPkg/CryptoPkg.ci.yaml | 3 +++
1 file changed, 3 insertions(+)
diff --git a/CryptoPkg/CryptoPkg.ci.yaml b/CryptoPkg/CryptoPkg.ci.yaml index
47f29759676d..4cec206477bc 100644
--- a/CryptoPkg/CryptoPkg.ci.yaml
+++ b/CryptoPkg/CryptoPkg.ci.yaml
@@ -6,6 +6,9 @@
# SPDX-License-Identifier: BSD-2-Clause-Patent ## {+ "PrEval": {+
"DscPath": "CryptoPkg.dsc",+ }, "LicenseCheck": { "IgnoreFiles":
[ # These directories contain auto-generated OpenSSL content--
2.41.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109377): https://edk2.groups.io/g/devel/message/109377
Mute This Topic: https://groups.io/mt/99798040/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
