Re: [edk2-devel] [PATCH 8/9] RedfishClientPkg: fix pragma pack usage

2023-10-02 Thread Mike Maslenkin
On Mon, Oct 2, 2023 at 5:45 AM Chang, Abner wrote: > > [AMD Official Use Only - General] > > > -Original Message- > > From: Mike Maslenkin > > Sent: Saturday, September 30, 2023 5:59 AM > > To: devel@edk2.groups.io > > Cc: Chang, Abner ; nick...@nvidia.com; > > ig...@ami.com; Mike Maslenk

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: add Sami as maintainer of arm-architectural subdirs

2023-10-02 Thread Leif Lindholm
Thanks all, merged as f6a314e5b5dc. On Wed, Sep 27, 2023 at 16:02:37 +, Kinney, Michael D wrote: > Reviewed-by: Michael D Kinney > > > -Original Message- > > From: Leif Lindholm > > Sent: Wednesday, September 27, 2023 4:07 AM > > To: devel@edk2.groups.io > > Cc: Ard Biesheuvel ; Sam

Re: [edk2-devel] [PATCH 1/1] ArmVirtPkg/FdtPL011SerialPortLib: initialize implicitly

2023-10-02 Thread Laszlo Ersek
On 9/30/23 23:23, Laszlo Ersek wrote: > FdtPL011SerialPortLib claims that it's usable from the DXE_CORE. That's > not correct: the DXE_CORE calls DEBUG() and ASSERT() before it calls > ProcessLibraryConstructorList(). Via the BaseDebugLibSerialPort instance, > those DEBUG() and ASSERT() calls resul

Re: [edk2-devel] [PATCH v2 2/5] MdePkg/BaseLib: add ASSERT in ARM* SetJump implementations

2023-10-02 Thread Leif Lindholm
On Fri, Sep 29, 2023 at 16:06:54 +0100, Sami Mujawar wrote: > Hi Leif, > > Thank you for this patch. > > This patch looks good to me. > > Just a question, should we also do the same for the AArch32 builds? Hmm, fair point. But I just managed to get rid of this set after nearly 4 years :):) > I

[edk2-devel] [PATCH v5 0/6] MPAM ACPI definitions and parser

2023-10-02 Thread Rohit Mathew
This series adds the following - definitions corresponding to MPAM ACPI 2.0 specification. - MPAM parser An MPAM ACPI table formulated using the newly added MPAM ACPI definitions were validated on the linux kernel tree at [1]. The same table was parsed via acpiview using the newly added parser

[edk2-devel] [PATCH v5 1/6] MdePkg/IndustryStandard: Add definitions for MPAM ACPI specification

2023-10-02 Thread Rohit Mathew
From: Rohit Mathew Add definitions, macros and types for elements associated with MPAM ACPI 2.0 specification. Signed-off-by: Rohit Mathew Cc: James Morse Cc: Liming Gao Cc: Michael D Kinney Cc: Sami Mujawar Cc: Thomas Abraham Cc: Zhiguang Liu Acked-by: Liming Gao Reviewed-by: Pierre Gon

[edk2-devel] [PATCH v5 2/6] ShellPkg/AcpiView: Update field-validator prototype

2023-10-02 Thread Rohit Mathew
As of now, the field-validator implemented by FNPTR_FIELD_VALIDATOR function pointer takes two parameters, the pointer to the field and a context pointer. For cases where the validator has to have access to the length of the field, there is no clean way to currently do it. In order to resolve this,

[edk2-devel] [PATCH v5 3/6] ShellPkg/AcpiView: Update print-formatter prototype

2023-10-02 Thread Rohit Mathew
As of now, the print-formatter implemented by the FNPTR_PRINT_FORMATTER function pointer takes two parameters, the format string and the pointer to the field. For cases where the print-formatter has to have access to the length of the field, there is no clean way to currently do it. In order to res

[edk2-devel] [PATCH v5 4/6] ShellPkg: acpiview: Add routine to print 16 chars

2023-10-02 Thread Rohit Mathew
Certain ACPI tables like MPAM has fields which are 16 bytes long. Routines similar to Dump12Chars but for 16 characters are required to print such fields. Add Dump16Chars routine to satisfy this requirement. Signed-off-by: Rohit Mathew Cc: James Morse Cc: Sami Mujawar Cc: Thomas Abraham Cc: Zh

[edk2-devel] [PATCH v5 5/6] ShellPkg: acpiview: Add routines to print reserved fields

2023-10-02 Thread Rohit Mathew
Most of the ACPI tables have fields that are marked reserved. Implement functions "DumpReserved" and "DumpReservedBits" aligning with the print-formatter prototype to print out reserved fields. Signed-off-by: Rohit Mathew Cc: James Morse Cc: Sami Mujawar Cc: Thomas Abraham Cc: Zhichao Gao ---

[edk2-devel] [PATCH v5 6/6] ShellPkg/AcpiView: Add MPAM Parser

2023-10-02 Thread Rohit Mathew
Add a parser for the MPAM (Memory system resource partitioning and monitoring) ACPI table. This parser would parse all MPAM related structures embedded as part of the ACPI table. Necessary validations are also performed where and when required. Signed-off-by: Rohit Mathew Cc: James Morse Cc: Sam

[edk2-devel] [PATCH] DynamicTablesPkg/AmlLib: Enumerate memory cacheability and type

2023-10-02 Thread Jeshua Smith via groups.io
AmlCodeGenRdQWordMemory's and AmlCodeGenRdDWordMemory's Cacheable and MemoryRangeType parameters treat specific values as having specific meanings. This change adds enums to map those meanings to their corresponding values. Signed-off-by: Jeshua Smith --- .../Include/Library/AmlLib/AmlLib.h

[edk2-devel] Event: Tools, CI, Code base construction meeting series - Monday, October 2, 2023 #cal-reminder

2023-10-02 Thread Group Notification
*Reminder: Tools, CI, Code base construction meeting series* *When:* Monday, October 2, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272

Re: [edk2-devel] EDK2 ArmVirtQemu behaviour with multiple UARTs

2023-10-02 Thread Laszlo Ersek
On 10/2/23 03:51, Laszlo Ersek wrote: > On 9/21/23 12:50, peter.maydell at linaro.org (Peter Maydell) wrote: > >> If you want to play around with this, I have some WIP patches at >> https://git.linaro.org/people/pmaydell/qemu-arm.git uart-edk-investigation >> (content wise they should be fine, but

Re: [edk2-devel] EDK2 ArmVirtQemu behaviour with multiple UARTs

2023-10-02 Thread Laszlo Ersek
On 10/3/23 01:05, Laszlo Ersek wrote: > On 10/2/23 03:51, Laszlo Ersek wrote: >> On 9/21/23 12:50, peter.maydell at linaro.org (Peter Maydell) wrote: >> >>> If you want to play around with this, I have some WIP patches at >>> https://git.linaro.org/people/pmaydell/qemu-arm.git uart-edk-investigatio

[edk2-devel] Now: Tools, CI, Code base construction meeting series - Monday, October 2, 2023 #cal-notice

2023-10-02 Thread Group Notification
*Tools, CI, Code base construction meeting series* *When:* Monday, October 2, 2023 4:30pm to 5:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f

Re: [edk2-devel] [PATCH 8/9] RedfishClientPkg: fix pragma pack usage

2023-10-02 Thread Chang, Abner via groups.io
[AMD Official Use Only - General] That makes sense. Reviewed-by: Abner Chang > -Original Message- > From: Mike Maslenkin > Sent: Saturday, September 30, 2023 5:59 AM > To: devel@edk2.groups.io > Cc: Chang, Abner ; nick...@nvidia.com; > ig...@ami.com; Mike Maslenkin > Subject: [PATCH 8

[edk2-devel] [PATCH v1 0/2] BZ 4221: Fix MdeModulePkg/Bus/Pci/XhciDxe issues pointed by Coverity

2023-10-02 Thread Ranbir Singh
Ranbir Singh (2): MdeModulePkg/Bus/Pci/XhciDxe: Fix FORWARD_NULL Coverity issues MdeModulePkg/Bus/Pci/XhciDxe: Fix MISSING_BREAK Coverity issues MdeModulePkg/Bus/Pci/XhciDxe/UsbHcMem.c | 14 ++ MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 6 ++ 2 files changed, 20 insertions(+

[edk2-devel] [PATCH v1 1/2] MdeModulePkg/Bus/Pci/XhciDxe: Fix FORWARD_NULL Coverity issues

2023-10-02 Thread Ranbir Singh
From: Ranbir Singh The functions UsbHcGetHostAddrForPciAddr, UsbHcGetPciAddrForHostAddr and UsbHcFreeMem do have ASSERT ((Block != NULL)); statements after for loop, but these are applicable only in DEBUG mode. In RELEASE mode, if for whatever reasons there is no match inside for loop and t

[edk2-devel] [PATCH v1 2/2] MdeModulePkg/Bus/Pci/XhciDxe: Fix MISSING_BREAK Coverity issues

2023-10-02 Thread Ranbir Singh
From: Ranbir Singh The functions XhcInitializeEndpointContext and XhcInitializeEndpointContext64 has a switch-case code in which the case USB_ENDPOINT_CONTROL: falls through to default: While this may be intentional, it is not evident to any general code reader as well as any static analyzer too