From: Ranbir Singh <ranbir.sin...@dell.com>
The functions
XhcInitializeEndpointContext and XhcInitializeEndpointContext64 has
a switch-case code in which the case USB_ENDPOINT_CONTROL: falls
through to default:
While this may be intentional, it is not evident to any general code
reader as well as any static analyzer tool. Just adding
// No break; here as this is an intentional fallthrough.
as comment in between makes any reader as well as Coverity happy.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4221
Cc: Hao A Wu <hao.a...@intel.com>
Cc: Ray Ni <ray...@intel.com>
Co-authored-by: Veeresh Sangolli <veeresh.sango...@dellteam.com>
Signed-off-by: Ranbir Singh <ranbir.sin...@dell.com>
Signed-off-by: Ranbir Singh <rsi...@ventanamicro.com>
---
MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
index 05528a478baf..2afecd40cab0 100644
--- a/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
+++ b/MdeModulePkg/Bus/Pci/XhciDxe/XhciSched.c
@@ -2979,6 +2979,9 @@ XhcInitializeEndpointContext (
// Do not support control transfer now.
//
DEBUG ((DEBUG_INFO, "XhcInitializeEndpointContext: Unsupport Control
EP found, Transfer ring is not allocated.\n"));
+ //
+ // No break; here as this is an intentional fall through.
+ //
default:
DEBUG ((DEBUG_INFO, "XhcInitializeEndpointContext: Unknown EP found,
Transfer ring is not allocated.\n"));
EpDesc = (USB_ENDPOINT_DESCRIPTOR *)((UINTN)EpDesc + EpDesc->Length);
@@ -3182,6 +3185,9 @@ XhcInitializeEndpointContext64 (
// Do not support control transfer now.
//
DEBUG ((DEBUG_INFO, "XhcInitializeEndpointContext64: Unsupport Control
EP found, Transfer ring is not allocated.\n"));
+ //
+ // No break; here as this is an intentional fall through.
+ //
default:
DEBUG ((DEBUG_INFO, "XhcInitializeEndpointContext64: Unknown EP found,
Transfer ring is not allocated.\n"));
EpDesc = (USB_ENDPOINT_DESCRIPTOR *)((UINTN)EpDesc + EpDesc->Length);
--
2.34.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#109274): https://edk2.groups.io/g/devel/message/109274
Mute This Topic: https://groups.io/mt/101729058/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
