Re: [edk2-devel] setting TLS ciphers is broken (openssl 3?)

On 9/28/23 16:25, Gerd Hoffmann wrote: >> The OpenSSL3 update may have restricted set (3), causing the grand >> intersection to be empty. > > That seems to be the case. Maybe (2) needs an update to enable newer > ciphers, when logging the mappings I see there are quite a few IDs which > don't get

Re: [edk2-devel] setting TLS ciphers is broken (openssl 3?)

Hi, > > According to the mailing list discussion linked in > > , > > "TlsCipherMappingTable" should never offer *more* cipher suites than > > actually supported by OpensslLib (because then the TLS client might > > negotiate a cipher suite wi

Re: [edk2-devel] setting TLS ciphers is broken (openssl 3?)

On Fri, Sep 29, 2023 at 10:42:19AM +0200, Gerd Hoffmann wrote: > Hi, > > > > According to the mailing list discussion linked in > > > , > > > "TlsCipherMappingTable" should never offer *more* cipher suites than > > > actually supported by Op

Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh

[AMD Official Use Only - General] Hi Leif, We have done the review on these patches. Are you the steward of this repo and able to grant AMD folks the merge privilege? To Eric, Abdul and me. Btw, do we have to create a PR against non OSI repo for merging or we can just push it? Thanks Abner

Re: [edk2-devel] efi and ext4 and case sensitive file names

> On Sep 28, 2023, at 19:57, Pedro Falcato wrote: > > On Wed, Sep 27, 2023 at 1:09 PM Gerd Hoffmann wrote: >> >> Hi, >> >> I've noticed that the edk2 ext4 driver does case-insensitive filename >> matching. I know the fat filesystem is case-insensitive, and the uefi >> spec describing the f

Re: [edk2-devel] setting TLS ciphers is broken (openssl 3?)

Hi, > > (2) TlsCipherMappingTable [CryptoPkg/Library/TlsLib/TlsConfig.c] > That seems to be the case. Maybe (2) needs an update to enable newer > ciphers, when logging the mappings I see there are quite a few IDs which > don't get mapped: Turns out we don't need TlsCipherMappingTable at all,

Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh

Hi Abner, On Fri, Sep 29, 2023 at 09:09:25 +, Chang, Abner wrote: > We have done the review on these patches. Still waiting for an R-b from Duke. Hmm, who doesn't seem to have been cc:d. > Are you the steward of this repo and able to grant AMD folks the > merge privilege? To Eric, Abdul and

Re: [edk2-devel] efi and ext4 and case sensitive file names

On Fri, Sep 29, 2023 at 10:47 AM Marvin Häuser wrote: > > > > On Sep 28, 2023, at 19:57, Pedro Falcato wrote: > > > > On Wed, Sep 27, 2023 at 1:09 PM Gerd Hoffmann wrote: > >> > >> Hi, > >> > >> I've noticed that the edk2 ext4 driver does case-insensitive filename > >> matching. I know the fat

Re: [edk2-devel] efi and ext4 and case sensitive file names

On 29/09/2023 10:47, Marvin Häuser wrote: Maybe when Linux starts adhering the spec for file names (the spec clearly defines e.g. BOOTx64.EFI, while at least some distros/images use bootx64.efi), this can be discussed. :) Let's not break various GRUB setups... Seems slightly unfair to blame L

Re: [edk2-devel] efi and ext4 and case sensitive file names

> On Sep 29, 2023, at 12:58, Michael Brown wrote: > > On 29/09/2023 10:47, Marvin Häuser wrote: >> Maybe when Linux starts adhering the spec for file names (the spec clearly >> defines e.g. BOOTx64.EFI, while at least some distros/images use >> bootx64.efi), this can be discussed. :) Let's n

[edk2-devel] [PATCH 1/1] MdePkg/DxeRngLib: Add missing GUID declaration in inf

From: Pierre Gondois Add missing GUID declaration in DxeRngLib.inf. Fixes: bd1f0eecc1df ("MdePkg/DxeRngLib: Request raw algorithm instead of default") Signed-off-by: Pierre Gondois --- MdePkg/Library/DxeRngLib/DxeRngLib.inf | 1 + 1 file changed, 1 insertion(+) diff --git a/MdePkg/Library/Dx

Re: [edk2-devel] [PATCH 1/1] MdePkg/DxeRngLib: Add missing GUID declaration in inf

Hi Pierre, Thank you for this fix. Unfortunately, this did not get trapped by the edk2 CI as well. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 29/09/2023, 13:30, "pierre.gond...@arm.com " mailto:pierre.gond...@arm.com>> wrote: From: Pierre Gondois m

[edk2-devel] [PATCH 1/1] CryptoPkg/TlsLib: fix tls cipher configuration

Trying to configure the TLS ciphers can lead to TLS handshake failures because TlsCipherMappingTable is not in line with the ciphers actually supported by OpensslLib. Fix that by removing TlsCipherMappingTable altogether. Use SSL_get_ciphers() instead to get the stack of ciphers supported by open

Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh

[AMD Official Use Only - General] Hi Leif, > -Original Message- > From: Leif Lindholm > Sent: Friday, September 29, 2023 6:49 PM > To: Chang, Abner > Cc: Xing, Eric ; devel@edk2.groups.io; Michael D Kinney > ; Attar, AbdulLateef (Abdul Lateef) > > Subject: Re: [[edk2-non-osi][Silicon/A

Re: [edk2-devel] [PATCH v2 1/5] MdePkg/BaseLib: fix comments in ARM* SetJump/LongJump implementations

Hi Leif, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 26/09/2023 06:15 pm, Leif Lindholm wrote: Drop redundant comment about IPF (clearly copied across from now deleted code). Also change "Instead is resumes execution" -> "Ins

Re: [edk2-devel] [PATCH v2 2/5] MdePkg/BaseLib: add ASSERT in ARM* SetJump implementations

Hi Leif, Thank you for this patch. This patch looks good to me. Just a question, should we also do the same for the AArch32 builds? In either case, Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 26/09/2023 06:15 pm, Leif Lindholm wrote: The SetJump comment header states that: If J

Re: [edk2-devel] [PATCH v2 3/5] MdePkg/BaseLib: use normal register init in ARM SetJump implementations

Hi Leif, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 26/09/2023 06:15 pm, Leif Lindholm wrote: There may be architectures on which there are benefits to eor r0, r0(, r0) but ARM was never one of them. Change to more readabl

Re: [edk2-devel] [PATCH v2 4/5] MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump

Hi Leif, Thank you for this patch. These changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 26/09/2023 06:15 pm, Leif Lindholm wrote: Both in SetJump and in InternalLongJump, 32-bit w register views were used for the UINTN return value. In SetJump, this did not cau

Re: [edk2-devel] [PATCH v2 5/5] MdePkg/BaseLib: ensure ARM LongJump never returns 0

Hi Leif, Thank you for this patch. There is a minor typo in the commit message, other than that these changes look good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 26/09/2023 06:15 pm, Leif Lindholm wrote: The ARM implementation of of InternalLongJump always returned the va

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: add Sami as maintainer of arm-architectural subdirs

Reviewed-by: Sami Mujawar Thanks. Regards, Sami Mujawar On 27/09/2023 12:06 pm, Leif Lindholm wrote: We added Sami as a reviewer to ArmPkg early last year, and I think it was always our intention to have him as a reviewer of Arm architectural stuff in general, but we seem to have missed out

Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh

On Fri, Sep 29, 2023 at 14:52:23 +, Chang, Abner via groups.io wrote: > > -Original Message- > > From: Leif Lindholm > > Sent: Friday, September 29, 2023 6:49 PM > > To: Chang, Abner > > Cc: Xing, Eric ; devel@edk2.groups.io; Michael D Kinney > > ; Attar, AbdulLateef (Abdul Lateef) >

Re: [edk2-devel] UDK2022 stable202211 - GCC compiler for Windows for building X64 EFI

Thank you Pedro. -Original Message- From: Pedro Falcato Sent: Thursday, September 28, 2023 3:39 PM To: devel@edk2.groups.io; daniel.samuel...@broadcom.com Cc: Kinney, Michael D ; quic_llind...@quicinc.com; Felix Polyudov ; af...@apple.com; Jianning Wang Subject: Re: [edk2-devel] UDK2022

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

On 9/29/23 04:02, John Chew wrote: Update Gigadevice norflash list: gd25q16, gd25q32, gd25q64, gd25lq64c, gd25q128, gd25lq128, gd25q256 Add Silicon Kaiser norflash list: sk25lp128 Cc: Sunil V L Cc: Li Yong Cc: Heinrich Schuchardt Cc: Leif Lindholm Cc: Ard Biesheuvel Cc: Abner Chang Cc: Da

Re: [edk2-devel] [PATCH v1] EmbeddedPkg/NorFlashInfoLib: Update norflash device list

On 29.09.23 15:35, YuinYee Chew wrote: Hi Heinrich, Both gd25lq128d and gd25lq128e share the same ID "{ 0xc8, 0x60, 0x18}" gd25lq128d : https://www.gigadevice.com/product/flash/product-series/spi-nor-flash/gd25lq128d.html gd25lq128e : https://www.gigadevice.com/product/flash/product-series/spi

Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH v2] 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh

[Public] Reviewed-by: Abdul Lateef Attar -Original Message- From: Xing, Eric Sent: Thursday, September 28, 2023 10:37 PM To: devel@edk2.groups.io Cc: Michael D Kinney ; Chang, Abner ; Leif Lindholm ; Attar, AbdulLateef (Abdul Lateef) Subject: [[edk2-non-osi][Silicon/AMD][PATCH v2] 1

Re: [edk2-devel] [[edk2-non-osi][Silicon/AMD][PATCH] VanGogh Silicon initialization firmware binaries 1/2] Maintainers.txt: Add maintainer for Silicon/AMD and Silicon/AMD/Vangogh

[AMD Official Use Only - General] > -Original Message- > From: Leif Lindholm > Sent: Friday, September 29, 2023 11:31 PM > To: devel@edk2.groups.io; Chang, Abner > Cc: Xing, Eric ; Michael D Kinney > ; Attar, AbdulLateef (Abdul Lateef) > ; Zhai, MingXin (Duke) > Subject: Re: [edk2-devel

Re: [edk2-devel] Problems mocking UEFI Protocol in gMock

Greetings, A week long collaboration between me and GDB, figuring out how to reproduce my CounterProtocol with function arguments, made me reach the conclusion that mocking a UEFI protocol is indeed documented and the solution had to do with copying the style of a global table Mock. This is the

Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: add Sami as maintainer of arm-architectural subdirs

On Fri, 29 Sept 2023 at 15:11, Sami Mujawar wrote: > > Reviewed-by: Sami Mujawar > Reviewed-by: Ard Biesheuvel > > On 27/09/2023 12:06 pm, Leif Lindholm wrote: > > We added Sami as a reviewer to ArmPkg early last year, and I think it was > > always our intention to have him as a reviewer of Ar

Re: [edk2-devel] [PATCH v4 20/28] MdeModulePkg: Add Additional Profiles to SetMemoryProtectionsLib

Sorry for the slow reply :) Additional profiles which fit general use cases can be added to SetMemoryProtectionsLib, but because this is a profile for grub compatibility I'd say it's better suited for platform code making MemoryProtectionConfigLib in OvmfPkg the best spot. I'll add an additi

[edk2-devel] [PATCH 0/9] RedfishClientPkg: various minor fixes

This patchset contains fixes of wrong format and number of arguments passed to DEBUG macro. Also a number of memory leaks were fixed. Here is a link to PR: https://github.com/tianocore/edk2-redfish-client/pull/52 Cc: Abner Chang Cc: Nickle Wang Cc: Igor Kulchytskyy Signed-off-by: Mike Maslenk

[edk2-devel] [PATCH 1/9] RedfishClientPkg: fix format used for output __func__

Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c b/RedfishClientPkg/Features/Bios/v1_0_9/Common/BiosCommon.c index a969557ddfdb

[edk2-devel] [PATCH 2/9] RedfishClientPkg: fix DEBUG macro arguments

Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c b/RedfishClientPkg/Library/RedfishFeatureUtilityLi

[edk2-devel] [PATCH 3/9] RedfishLib: remove redudant zeroing

Memory allocated by calloc() is filled with bytes of value zero. Signed-off-by: Mike Maslenkin --- .../PrivateLibrary/RedfishLib/edk2libredfish/src/service.c | 1 - 1 file changed, 1 deletion(-) diff --git a/RedfishClientPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c b/Redfi

[edk2-devel] [PATCH 4/9] RedfishClientPkg: RedfishFeatureUtilityLib: fix memory leaks

Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib.c| 30 +++ 1 file changed, 30 insertions(+) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatur

[edk2-devel] [PATCH 6/9] RedfishClientPkg: fix memory leaks while applying feature settings

Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib.c| 11 +++ 1 file changed, 11 insertions(+) diff --git a/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatureUtilityLib.c b/RedfishClientPkg/Library/RedfishFeatureUtilityLib/RedfishFeatur

[edk2-devel] [PATCH 7/9] RedfishClientPkg: fix memory leak

This patch fixes leak in RedfishExternalResourceResourceFeatureCallback function. Signed-off-by: Mike Maslenkin --- RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/RedfishClientPkg/Features/Bios/v1_0_9/Dxe/BiosDxe.c b/RedfishClientPkg/Fe

[edk2-devel] [PATCH 8/9] RedfishClientPkg: fix pragma pack usage

Signed-off-by: Mike Maslenkin --- RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h b/RedfishClientPkg/HiiToRedfishBiosDxe/HiiToRedfishBiosData.h index 7e1b

[edk2-devel] [PATCH 5/9] RedfishClientPkg: reduce identation level by adding early return

This functions contain memory leaks. Less identation helps to solve this issues. Signed-off-by: Mike Maslenkin --- .../RedfishFeatureUtilityLib.c| 289 +- 1 file changed, 146 insertions(+), 143 deletions(-) diff --git a/RedfishClientPkg/Library/RedfishFeatureUti

[edk2-devel] [PATCH 9/9] RedfishClientPkg: fix StrnCpyS arguments

StrnCpyS accepts string length in characters, not in bytes. Signed-off-by: Mike Maslenkin --- RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/RedfishClientPkg/RedfishFeatureCoreDxe/RedfishFeatureCoreDxe.c b/Redfi

Re: [edk2-devel] [PATCH v2 4/5] MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump

Reviewed-by: Andrei Warkentin От: Leif Lindholm Отправлено: вторник, сентября 26, 2023 12:16 PM Кому: devel@edk2.groups.io Копия: Philippe Mathieu-Daudé ; Warkentin, Andrei ; Ard Biesheuvel ; Sami Mujawar Тема: [PATCH v2 4/5] MdePkg/BaseLib: correct register s

[edk2-devel] [PATCH v1] Add EFI_STATUS return to EMU_THUNK_PROTOCOL.SetTime()

There is an inconsistency between the UNIX and Windows implementations of EMU_THUNK_PROTOCOL.SetTime(). The Windows version returns an EFI_STATUS value whereas the the UNIX implementation is VOID. However, the UNIX implementation is an unimplemented stub whereas the Windows version is implementated

[edk2-devel] [PATCH v2] EmulatorPkg: Add EFI_STATUS return to EMU_THUNK_PROTOCOL.SetTime()

There is an inconsistency between the UNIX and Windows implementations of EMU_THUNK_PROTOCOL.SetTime(). The Windows version returns an EFI_STATUS value whereas the the UNIX implementation is VOID. However, the UNIX implementation is an unimplemented stub whereas the Windows version is implementated

[edk2-devel] [PATCH v1] EmulatorPkg: Improve comments in WinThunk.c

File description has not been updated since Nt32Pkg was merged with EmulatorPkg, and several details were no longer technically accurate. Cc: Andrew Fish Cc: Ray Ni Cc: Michael D Kinney Cc: Chasel Chiu Signed-off-by: Nate DeSimone --- EmulatorPkg/Win/Host/WinThunk.c | 19 ++-

[edk2-devel] [RFC][PATCH 0/2][edk2-redfish-client]: tune uncrustify script

Please, look at these changes. I've had some troubles when tried to run uncrustify checks locally on macOS and those fixes helped me. Also I tried this set on Linux and it worked. Here is a link to PR: https://github.com/tianocore/edk2-redfish-client/pull/53 Cc: Abner Chang Cc: Nickle Wang Cc:

[edk2-devel] [PATCH 1/2] RedfishClientPkg/.github: tune file list for uncrustify check

Original "HEAD~$NO_COMMITS" returns a diff agains current repo state including not stashed changes. As the purpose of uncrustify is to check commits, let's get changes against HEAD itself and ignore local modifications. Signed-off-by: Mike Maslenkin --- .github/workflows/uncrustify-check.sh | 2

[edk2-devel] [PATCH 2/2] RedfishClientPkg/.github: fix file list for uncrustify check

Current `grep` command doesn't work in macOS with GNU bash, version 3.2.57(1)-release-(arm64-apple-darwin21) Signed-off-by: Mike Maslenkin --- .github/workflows/uncrustify-check.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/uncrustify-check.sh b/.githu

[edk2-devel] [PATCH v1] EmulatorPkg: Update MMTimerThread() signature

In the early 2000s as part of the x64 transition the definition for LPTIMECALLBACK changed from (UINT, UINT, DWORD, DWORD, DWORD) to (UINT, UINT, DWORD_PTR, DWORD_PTR, DWORD_PTR). However, the MMTimerThread() function was never updated to the new signature. Since the implementation does not use the