I feel sick each time I have to edit EDK2 code.
All those INF, DEC, DSC, FDF, XYZ files are something I do not even try
to understand, just got minimal knowledge what goes where by asking Leif
(thanks a lot!) and observing build error messages.
I got used to UINTN and other weird variable types.
Hi Swatisri,
Thank you for this patch.
I believe this was reviewed intially at
https://edk2.groups.io/g/devel/topic/96534672#99048 and I see you have
addressed the feedback in this patch.
I also see that patch 2/2 from your previous series was already merged.
Can you increment the revision for
On Fri, Sep 22, 2023 at 15:40:38 -0600, Swatisri Kantamsetti via groups.io
wrote:
> The IO Remapping Table, Platform Design Document, Revision E.e,
> Sept 2022 (https://developer.arm.com/documentation/den0049/ee)
> added flags in SMMUv3 node for validity of ID mappings for MSIs
> related to contro
Hi Leif,
Please find my response inline marked [SAMI].
Regards,
Sami Mujawar
On 25/09/2023 10:40 am, Leif Lindholm wrote:
On Fri, Sep 22, 2023 at 15:40:38 -0600, Swatisri Kantamsetti via groups.io
wrote:
The IO Remapping Table, Platform Design Document, Revision E.e,
Sept 2022 (https://deve
I think you may be using the wrong version of the uncrustify tool.
Is that log from a local run or EDK II CI?
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatting
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatting#installing-uncrustify
Mike
> -
To fix the assert due to ASSERT(TrsRing !=NULL) in XhcSyncTrsRing.
There is a recovery in usb mass stroage driver to do port reset after
fail in transfer. And port reset operation makes that all memory
resources(descriptors, endpoint memory) belonging to this device are
reclaimed in underlying Xhc
From: "Brucex.Wang"
Provide Fit format for UniversalPayload, developer can use argument
"--Fit" to build UniversalPayload.fit
Cc: Guo Dong
Cc: Sean Rhodes
Cc: James Lu
Cc: Gua Guo
Signed-off-by: BruceX Wang
---
MdePkg/Include/Library/FdtLib.h | 6 +-
MdePkg/Library/BaseFdt
From: "Brucex.Wang"
Add FdtGetName() and FdtNodeDepth() function.
Cc: Benny Lin
Cc: Gua Guo
Cc: Chasel Chiu
Cc: James Lu
Signed-off-by: BruceX Wang
---
MdePkg/Include/Library/FdtLib.h| 34 +
MdePkg/Library/BaseFdtLib/FdtLib.c | 40 ++
From: "Brucex.Wang"
V5: Fix Gcc build failure.
V4: Fix Benny comment in patch mail.
V3: Fix Lean Sheng comment in patch mail
V2: Fix Gua and Chasel comment in PR
V1: Initialize Version
Brucex.Wang (2):
MdePkg/BaseFdtLib: Add Fdt function.
UefiPayloadPkg: Add FIT support
MdePkg/Include/Lib
It took me 2-3 weeks to flip my brain over to the 2 space indent. It was not so
bad when I was just working on EFI stuff but if switch around between projects
my editor having the wrong settings gets a lit old sometimes.
The history of this was some of the old Intel legacy BIOS devs really push
On 9/25/2023 3:03 AM, Marcin Juszkiewicz via groups.io wrote:
I feel sick each time I have to edit EDK2 code.
All those INF, DEC, DSC, FDF, XYZ files are something I do not even try
to understand, just got minimal knowledge what goes where by asking Leif
(thanks a lot!) and observing build error
On Mon, Sep 25, 2023 at 10:03 AM Marcin Juszkiewicz
wrote:
>
> I feel sick each time I have to edit EDK2 code.
>
> All those INF, DEC, DSC, FDF, XYZ files are something I do not even try
> to understand, just got minimal knowledge what goes where by asking Leif
> (thanks a lot!) and observing buil
W dniu 25.09.2023 o 20:03, Pedro Falcato pisze:
On Mon, Sep 25, 2023 at 10:03 AM Marcin Juszkiewicz
And can someone take a look at config of code obfuscator used for linting?
It spits out amount of information showing that noone looked at updating it
to current version:
You're supposed to us
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, September 25, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2
Series Reviewed-by: Gua Guo
-Original Message-
From: devel@edk2.groups.io On Behalf Of
brucex.w...@intel.com
Sent: Monday, September 25, 2023 10:15 AM
To: devel@edk2.groups.io
Cc: Wang, BruceX
Subject: [edk2-devel] [PATCH v5 0/2] Add FIT support
From: "Brucex.Wang"
V5: Fix Gcc build
*Tools, CI, Code base construction meeting series*
*When:*
Monday, September 25, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-
Removing Isaac Oram from Maintainers.txt as it is likely that
he no longer wishes to work on EDK II.
Isaac - You are welcome to continue being a maintainer if desired.
If yes, please provide an alternative patch that updates your email
address.
Cc: Isaac Oram
Cc: Chasel Chiu
Cc: Michael D Kinne
Removing Isaac Oram from Maintainers.txt as he is no longer working on
EDK II.
Cc: Isaac Oram
Cc: Chasel Chiu
Cc: Michael D Kinney
Signed-off-by: Nate DeSimone
---
Maintainers.txt | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/Maintainers.txt
Cc: Chasel Chiu
Cc: Isaac Oram
Cc: Liming Gao
Cc: Eric Dong
Signed-off-by: Nate DeSimone
---
Platform/Intel/build_bios.py | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/Platform/Intel/build_bios.py b/Platform/Intel/build_bios.py
index 9c95cfff76..b396017
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, September 26, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e34
REF:https://bugzilla.tianocore.org/show_bug.cgi?id=4560
TRB Template is 16 bytes. When boundary checking is 64 bytes for xHCI
device/host memory address, it may exceed xHCI host memory pool and
cause unwanted DXE_ASSERT. Introduce a new input parameter to indicate
whether to enforce 64byte size al
The proposed patch failed some CI tests.
Details can be referred at: https://github.com/tianocore/edk2/pull/4866. Could
you help to resolve them?
Please help to follow the step 11 in page:
https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Development-Process
and check the CI test res
Ranbir Singh (5):
MdeModulePkg/Core/Dxe: Fix FORWARD_NULL Coverity issues
MdeModulePkg/Core/Dxe: Fix MISSING_BREAK Coverity issue
MdeModulePkg/Core/Dxe: Fix DEADCODE Coverity issue
MdeModulePkg/Core/Dxe: Fix OVERFLOW_BEFORE_WIDEN Coverity issues
MdeModulePkg/Core/Dxe: Fix UNUSED_VALUE Cov
From: Ranbir Singh
The functions CoreConvertSpace and CoreAllocateSpace in
MdeModulePkg/Core/Dxe/Gcd/Gcd.c has
ASSERT (FALSE); at lines 755 and 1155 which gets hit when
Operation neither include GCD_MEMORY_SPACE_OPERATION nor include
GCD_IO_SPACE_OPERATION but this comes into play only
From: Ranbir Singh
The function CoreIsSchedulable has switch-case code in which
case EFI_DEP_BEFORE:
case EFI_DEP_AFTER:
has a comment that
// For a well-formed Dependency Expression, the code should never get here.
It also has an ASSERT (FALSE); but this is applicable only in D
From: Ranbir Singh
In the function PromoteGuardedFreePages(), the value of AvailablePages
cannot be ZERO at the condition check point
if (AvailablePages != 0) {
as the code can come out of the while loop above only when AvailablePages
is non-ZERO.
Hence, remove the redundant condition check
From: Ranbir Singh
"1 << Priority" / "1 << Event->NotifyTpl" are potentially overflowing
expressions with type "int" (32 bits, signed) evaluated using 32-bit
arithmetic, and then used in a context that expects an expression of
type "UINTN" (64 bits, unsigned).
To avoid overflow, cast "1" to type
The return value after calls to functions CoreProcessFvImageFile,
CoreStartImage, CoreGetDepexSectionAndPreProccess,
CoreInternalAddMemorySpace, CoreAddIoSpace, CoreAllocateMemorySpace
and CoreCloseProtocol is stored in Status, but it is not made of any
use and later Status gets overridden.
One o
28 matches
Mail list logo