On Mon, Sep 25, 2023 at 10:03 AM Marcin Juszkiewicz <marcin.juszkiew...@linaro.org> wrote: > > I feel sick each time I have to edit EDK2 code. > > All those INF, DEC, DSC, FDF, XYZ files are something I do not even try > to understand, just got minimal knowledge what goes where by asking Leif > (thanks a lot!) and observing build error messages.
I feel you. We've discussed this before (in the ML and on the UEFI talkbox discord) and there's a large unwillingness to change the build system, because it's "super extensible" and all that. I don't like it, but it is what it is. > > I got used to UINTN and other weird variable types. No idea where from > they came from (MS Windows?) Yes. > > But what sucks more is those 2 spaces used for indenting code. Took me > a while to reming myself when I used such. It was in 90s, when I was > Amiga programmer and all I had was 720x480px screen. > > Last time I looked at calendar it was 2023 year. Maybe it is time to move > to 4 spaces? > > And can someone take a look at config of code obfuscator used for linting? > It spits out amount of information showing that noone looked at updating it > to current version: You're supposed to use the edk2 uncrustify fork that you get *somehow* (no, I don't remember how, I do remember it was a pain though). But seriously, speaking as someone with a completely different personal coding style, the coding style really isn't all that bad (at the very least, it's tolerable), it's just a bastardized NT-kernel style, and with uncrustify you can auto-format all your code. What really pains me is CRLF vs LF, which breaks *every git tool*. Seriously, applying patches tends to be a pain, at least on Linux. -- Pedro -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#109048): https://edk2.groups.io/g/devel/message/109048 Mute This Topic: https://groups.io/mt/101570674/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-