2 comments as follows, starting with "[ray"
@@ -73,6 +73,7 @@ UINT8*mPerformancePointer = NULL;
UINT8*mBootRecordBuffer= NULL;
BOOLEAN mLockInsertRecord = FALSE;
CHAR8*mDevicePathString= NULL;
+UINTNmBootRecordOffset = 0;
[ray.1] How about mSmmBootRecordOffset
Liming,
Need your help to review and merge this patch series after the code freeze.
Thanks,
Star
-Original Message-
From: devel@edk2.groups.io On Behalf Of Zeng, Star
Sent: Friday, August 18, 2023 7:34 PM
To: Gao, Liming ; devel@edk2.groups.io; Cuevas
Farfan, Eduardo
Cc: Kinney, Michae
Hi Mike,
> I didn't find any codyng-style issues in uncrustify output.
I fetch your branch and run uncrustify tool to fix error in vs code editor. I
push the fix to your branch at this commit for your reference:
https://github.com/ghbaccount/edk2-redfish-client/commit/f22209f7bd5946168326a31970
Hi,
> I have tried the patch below, and I don't see any slowdowns with or
> without the patch, running both DEBUG and RELEASE builds under
> ordinary KVM/nested-virt. Note that the change in the first hunk will
> cause the ASSERT()s removed in the other hunks to trigger so the code
> is definite
This patch fixes the issue reported in BZ given below:
https://bugzilla.tianocore.org/show_bug.cgi?id=983
Patch extracted from PR https://github.com/tianocore/edk2-libc/pull/7
Jayaprakash N (1):
edk2-libc: Socket completion functions are not called on Linux
Compilation
StdLib/EfiSocketLib/
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=983
>From the bug description:
Analysis and root cause
After some investigation and debugging I have figured out the following:
The following function is implemented in file edk2/StdLib/EfiSocketLib/Tcp4.c
VOID
Es
On Mon, 28 Aug 2023 at 11:16, Gerd Hoffmann wrote:
>
> Hi,
>
> > I have tried the patch below, and I don't see any slowdowns with or
> > without the patch, running both DEBUG and RELEASE builds under
> > ordinary KVM/nested-virt. Note that the change in the first hunk will
> > cause the ASSERT()
Can I please get reviews/feedback on this patch series?
On 8/16/23 11:14 AM, Taylor Beebe via groups.io wrote:
Can I please get reviews/feedback on this patch series?
On 8/4/2023 12:46 PM, Taylor Beebe via groups.io wrote:
From: Taylor Beebe
v4:
- Expose additional functions in the Library A
I was hoping to get around to this before the end of the week (but I
am not a MdeModulePkg maintainer)
On Mon, 28 Aug 2023 at 18:27, Taylor Beebe wrote:
>
> Can I please get reviews/feedback on this patch series?
>
> On 8/16/23 11:14 AM, Taylor Beebe via groups.io wrote:
> > Can I please get rev
Could someone please explain to me how I can figure out why this PR
was rejected by the CI?
https://github.com/tianocore/edk2/pull/4763
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#108060): https://edk2.groups.io/g/devel/message/108060
Hello!
https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=100301&view=ms.vss-test-web.build-test-results-tab&runId=877528&resultId=16&paneView=attachments
Uncrustify found formatting errors in IoMmuDxe/IoMmuBuffer.c
See Standard_Error_Output.log in "attachments"
It doesn't like t
Here's a git-patch so you can easily fix it:
---
OvmfPkg/IoMmuDxe/IoMmuBuffer.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c b/OvmfPkg/IoMmuDxe/IoMmuBuffer.c
index 2764c35044ac..d66763263784 100644
--- a/OvmfPkg/IoMmuDxe/IoMmuBuffer.c
+++ b/Ov
Hi Ard,
I think your main question is how all developers can find the
details of any of these types of test failures. It is not
obvious until you notice there is a "Tests" tab on one of the
Azure Pipelines pages.
The main interface to developers for these types of failures
is "Test" results in
Another option, when the main pipeline page says there is an uncrustify
error is to take the cmdline it ran with and append
UNCRUSTIFY_IN_PLACE=TRUE to it. It will then auto-fixup any uncrustify
errors (which obviously should be audited afterwards). I do this to
avoid having to wade through numero
On Mon, 28 Aug 2023 at 20:37, Kinney, Michael D
wrote:
>
> Hi Ard,
>
> I think your main question is how all developers can find the
> details of any of these types of test failures. It is not
> obvious until you notice there is a "Tests" tab on one of the
> Azure Pipelines pages.
>
> The main in
Merged:
https://github.com/tianocore/edk2/commit/2c7fd32676272e22ed44fdfc8fa7e47f5c7a93b8
Thanks,
Chasel
> -Original Message-
> From: Kuo, Ted
> Sent: Thursday, July 20, 2023 3:20 AM
> To: devel@edk2.groups.io
> Cc: Chiu, Chasel ; Desimone, Nathaniel L
> ; Zeng, Star ; S, Ashraf
> Ali
Hi everyone,
1. Is there an inbuilt way to mount an external FV in uefi 2.0 shell ?
2. I tried the "map" command but wasn't able to mount a fv partition.
3. Please suggest if this is supported in uefi 2.0 shell out of the box?
Thanks & Regards,
Bharavi Peeyush Kandala
-=-=-=-=-=-=-=-=
1. Is there an inbuilt way to mount an external FV in uefi 2.0 shell ?
2. I tried the "map" command but wasn't able to mount a fv partition.
3. Please suggest if this is supported in uefi 2.0 shell out of the box?
Thanks & Regards,
Bharavi Peeyush Kandala
On Mon, Aug 28, 2023 at 1:55
merged:
https://github.com/tianocore/edk2/commit/b1e558f6369fc85ae053e0c16ffcd600880fe78d
Thanks,
Chasel
> -Original Message-
> From: Zhang, Hongbin1
> Sent: Thursday, August 24, 2023 8:15 PM
> To: devel@edk2.groups.io
> Cc: Zhang, Hongbin1 ; Chiu, Chasel
> ; Desimone, Nathaniel L
> ; D
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, August 28, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272
Hi Nickle,
I incorporated changes required for uncrustify check.
Also I added additional patch with trivial spelling fixes. Do I need
to resend v.2 to the list?
Regards,
Mike.
On Mon, Aug 28, 2023 at 12:03 PM Nickle Wang via groups.io
wrote:
>
> Hi Mike,
>
> > I didn't find any codyng-style iss
*Tools, CI, Code base construction meeting series*
*When:*
Monday, August 28, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f
*Reminder: TianoCore Bug Triage - APAC / NAMO*
*When:*
Tuesday, August 29, 2023
6:30pm to 7:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_OTk1YzJhN2UtOGQwNi00NjY4LWEwMTktY2JiODRlYTY1NmY0%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e344-4
Thanks Zhichao, I updated the commit message and also created a PR at
https://github.com/tianocore/edk2/pull/4767
Please help check.
Regards,
-Nhi
On 8/21/2023 2:01 PM, Gao, Zhichao wrote:
Better to update the commit message with specific SMBIOS version.
Others looks good to me.
Thanks,
Zhi
Just a gentle ping!
Hi Ard, can you provide your feedback on this patch?
Thanks,
-Nhi
On 8/16/2023 3:55 PM, Nhi Pham via groups.io wrote:
Hi Ard and Ming,
I have been seeing an issue with StandaloneMM HobLib that can be fixed
by this patch as well.
The function CreateHob() in the HobLib i
Eduardo:
The patch is good to me. Reviewed-by: Liming Gao
Besides, I have one minor comment. Please see the below.
Thanks
Liming
> -邮件原件-
> 发件人: devel@edk2.groups.io 代表 Eduardo
> Cuevas Farfan
> 发送时间: 2023年8月11日 0:32
> 收件人: devel@edk2.groups.io
> 抄送: Eduardo Cuevas Farfan
> 主题: [ed
26 matches
Mail list logo
