Hi Nickle, I incorporated changes required for uncrustify check. Also I added additional patch with trivial spelling fixes. Do I need to resend v.2 to the list?
Regards, Mike. On Mon, Aug 28, 2023 at 12:03 PM Nickle Wang via groups.io <nicklew=nvidia....@groups.io> wrote: > > Hi Mike, > > > I didn't find any codyng-style issues in uncrustify output. > > I fetch your branch and run uncrustify tool to fix error in vs code editor. I > push the fix to your branch at this commit for your reference: > https://github.com/ghbaccount/edk2-redfish-client/commit/f22209f7bd5946168326a3197006d92856247d35 > The uncrustify check on PR is now passed successfully. My commit breaks > patch check as expected, please incorporate my changes with yours and do a > force push to this PR again. > > For the way of fixing uncrustify error, I am using the instructions here: > https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Code-Formatting#recommended-usage-visual-studio-vs-code-plugin > > Thanks, > Nickle > > > -----Original Message----- > > From: Mike Maslenkin <mike.maslen...@gmail.com> > > Sent: Sunday, August 27, 2023 6:57 PM > > To: devel@edk2.groups.io > > Cc: abner.ch...@amd.com; Nickle Wang <nick...@nvidia.com>; > > ig...@ami.com; Mike Maslenkin <mike.maslen...@gmail.com> > > Subject: [PATCH 0/5] RedfishClientPkg: fix issues with local variables. > > > > External email: Use caution opening links or attachments > > > > > > This patchset contains fixes that resolve crashes while working with > > uninitialized > > variables and a number of fixes for of leaked memory. > > Note: looks like uncrustify check is broken at > > tianocore/edk2-redfish-client repo, > > the corresponding PR failed: > > https://github.co/ > > m%2Ftianocore%2Fedk2-redfish- > > client%2Fpull%2F46&data=05%7C01%7Cnicklew%40nvidia.com%7C7cf336153fb > > f4e2e821008dba6ec62e0%7C43083d15727340c1b7db39efd9ccc17a%7C0%7C0 > > %7C638287306436105158%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAw > > MDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C > > &sdata=VUxJA017msZzRYd%2FAxi0KeZvLi2s0QI6uKgHsOuDdws%3D&reserved=0 > > > > I didn't find any codyng-style issues in uncrustify output. > > > > Cc: Abner Chang <abner.ch...@amd.com> > > Cc: Nickle Wang <nick...@nvidia.com> > > Cc: Igor Kulchytskyy <ig...@ami.com> > > Signed-off-by: Mike Maslenkin <mike.maslen...@gmail.com> > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#108071): https://edk2.groups.io/g/devel/message/108071 Mute This Topic: https://groups.io/mt/100988470/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
