Better to update the commit message with specific SMBIOS version.
Others looks good to me.
Thanks,
Zhichao
> -Original Message-
> From: Nhi Pham
> Sent: Friday, August 18, 2023 2:54 PM
> To: devel@edk2.groups.io
> Cc: Nhi Pham ; Gao, Zhichao
>
> Subject: [PATCH 1/1] ShellPkg/SmbiosView:
I successfully resolved the build issue by adding the flag
-Wno-maybe-uninitialized in the BaseTools/Conf/tools_def.template file. I have
also submitted a patch email to the mailing list with the subject:
'[edk2-devel] [PATCH] BaseTools/Conf/tools_def.template: Fix uninitialized
variable error.
Hi Rohit,
Thank you for this pach.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 18/08/2023 12:44 pm, Rohit Mathew wrote:
From: Rohit Mathew
Add definitions, macros and types for elements associated with MPAM
ACPI 2.0 specification.
Signed-off-by: Roh
Hi Rohit,
Thank you for this patch.
These changes look good to me.
Reviewed-by: Sami Mujawar
Regards,
Sami Mujawar
On 18/08/2023 12:47 pm, Rohit Mathew wrote:
Certain ACPI tables like MPAM has fields which are 16 bytes long.
Routines similar to Dump12Chars but for 16 characters are require
Hi Rohit,
Thank you for this patch.
Please find my feedback inline marked [SAMI].
Regards,
Sami Mujawar
On 18/08/2023 12:48 pm, Rohit Mathew wrote:
Add a parser for the MPAM (Memory system resource partitioning and
monitoring) ACPI table. This parser would parse all MPAM related
structures e
On Wed, Aug 16, 2023 at 03:11:45PM -0500, Michael Roth wrote:
> Booting an SEV guest with AmdSev OVMF package currently triggers the
> following assertion with QEMU:
>
> InstallQemuFwCfgTables: installed 7 tables
> PcRtc: Write 0x20 to CMOS location 0x32
> [Variable]END_OF_DXE is signaled
>
Reviewed-by: Jiewen Yao
> -Original Message-
> From: Xu, Min M
> Sent: Monday, August 21, 2023 11:51 AM
> To: devel@edk2.groups.io
> Cc: Xu, Min M ; Aktas, Erdem ;
> James Bottomley ; Yao, Jiewen ;
> Gerd Hoffmann ; Tom Lendacky
> ; Michael Roth
> Subject: [PATCH V1 1/1] OvmfPkg/TdxDxe:
On Wed, Aug 16, 2023 at 03:11:46PM -0500, Michael Roth wrote:
> PcdFirstTimeWakeUpAPsBySipi was recently introduced to indicate when
> the full INIT-SIPI-SIPI sequence can be skipped for AP bringup. It is
> true by default, but needs to be disabled for QEMU/OVMF where early INIT
> is not simulated.
Hi
This fix breaks the compatibility.
Have you tested all features that depends on this data structure?
Thank you
Yao, Jiewen
> -Original Message-
> From: devel@edk2.groups.io On Behalf Of Elyes Haouas
> Sent: Sunday, August 20, 2023 8:07 PM
> To: devel@edk2.groups.io
> Cc: Elyes Haouas
On Sat, Aug 19, 2023 at 11:10:07PM +0100, Pedro Falcato wrote:
> On Sat, Aug 19, 2023 at 8:39 PM Marcin Juszkiewicz
> wrote:
> >
> > W dniu 18.08.2023 o 20:17, Oliver Smith-Denny pisze:
> > > Currently, unlike OVMF, ArmVirtQemu does not display any graphics, only
> > > the QEMU monitor. Graphics a
On Mon, Aug 07, 2023 at 10:58:26PM -0400, Zhenyu Zhang wrote:
> When the variable store is full, edk2 will directly assert.
> Add debug information to help users understand what caused
> the assertion.
>
> Actual results:
> RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929-
> 48BCD
On 2023-08-19 23:10, Pedro Falcato wrote:
W dniu 18.08.2023 o 20:17, Oliver Smith-Denny pisze:
Currently, unlike OVMF, ArmVirtQemu does not display any graphics, only
the QEMU monitor. Graphics are helpful to confirm booting into an OS is
successful, interacting with the EFI shell while getting
Acked-by: Jiewen Yao
> -Original Message-
> From: Gerd Hoffmann
> Sent: Monday, August 21, 2023 11:29 PM
> To: Michael Roth
> Cc: devel@edk2.groups.io; Ni, Ray ; Aktas, Erdem
> ; James Bottomley ; Yao,
> Jiewen ; Xu, Min M ; Tom
> Lendacky
> Subject: Re: [PATCH 1/2] OvmfPkg/AmdSev: fix
SBSA Reference Platform can have GIC ITS present. And when it has then
we can have complex PCI Express setup (and some other things).
First patch adds support for GIC ITS. Address is read from TF-A via SMC
call. IORT is generated, MADT has ITS information. Linux boots and sees
GIC ITS as expected.
From: Shashi Mallela
SBSA Reference Platform has GIC ITS support. Let make use of it.
Base address is read from TF-A via SMC call.
GIC ITS allows us to have complex PCI Express setups.
Co-authored-by: Marcin Juszkiewicz
Signed-off-by: Shashi Mallela
Signed-off-by: Marcin Juszkiewicz
---
Si
If firmware is used with QEMU 8.0 or older then there will be no GIC ITS
support.
In such case we would not add information about it into MCFG and there
will be no IORT table.
Signed-off-by: Marcin Juszkiewicz
---
.../Qemu/SbsaQemu/AcpiTables/AcpiTables.inf | 1 -
.../SbsaQemuAcpiDxe/SbsaQe
Store Smmu base address in variable in case it would be needed
in more than one place.
Signed-off-by: Marcin Juszkiewicz
---
Silicon/Qemu/SbsaQemu/SbsaQemu.dec | 1 +
Platform/Qemu/SbsaQemu/SbsaQemu.dsc | 1 +
2 files changed, 2 insertions(+)
diff --git a/Silicon/Qemu/SbsaQemu/SbsaQemu.dec
b/
Here's a summmary of the v2 changes :)
v2:
- The previous version required the platform manage the HOB creation
during PEI phase. v2 adds a new library, SetMemoryProtectionsLib, which
offers an interface for setting, locking, and checking the memory protections
for the boot. The settings
Hi,
No, I didn't.
De : "Yao, Jiewen"
A : "devel@edk2.groups.io" ,"ehao...@noos.fr" ,"Yao, Jiewen"
Envoyé: lundi 21 Août 2023 16:35
Objet : RE: [edk2-devel] [PATCH] Use C99 flexible arrays
Hi
This fix breaks the compatibility.
Have you tested all features that depends on this data structure?
Hi community, I have I have published a Visual Studio Code extension for EDK2
development:
"The EDK2Code Extension is a Visual Studio Code extension designed to improve
the development experience for engineers working with the EDK2 (UEFI) codebase.
This extension provides support for syntax hig
On Mon, Aug 21, 2023 at 17:07:55 +0200, Marcin Juszkiewicz wrote:
> From: Shashi Mallela
>
> SBSA Reference Platform has GIC ITS support. Let make use of it.
>
> Base address is read from TF-A via SMC call.
>
> GIC ITS allows us to have complex PCI Express setups.
>
> Co-authored-by: Marcin Ju
On Mon, Aug 21, 2023 at 17:07:56 +0200, Marcin Juszkiewicz wrote:
> Store Smmu base address in variable in case it would be needed
A Pcd is not a variable. s/variable/DynamicPcd/.
And we don't change things "in case we might need them", we change
them for some reason.
Overall, I think this chang
On Mon, Aug 21, 2023 at 17:07:57 +0200, Marcin Juszkiewicz wrote:
> If firmware is used with QEMU 8.0 or older then there will be no GIC ITS
> support.
>
> In such case we would not add information about it into MCFG and there
> will be no IORT table.
>
> Signed-off-by: Marcin Juszkiewicz
> ---
Signed-off-by: Elyes Haouas
---
UefiCpuPkg/Library/MpInitLib/X64/AmdSev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/UefiCpuPkg/Library/MpInitLib/X64/AmdSev.c
b/UefiCpuPkg/Library/MpInitLib/X64/AmdSev.c
index c9f0984f41..3b92beea31 100644
--- a/UefiCpuPkg/Library/MpI
Signed-off-by: Elyes Haouas
---
BaseTools/Source/C/DevicePath/DevicePathUtilities.c | 2 +-
BaseTools/Source/C/GenFw/GenFw.c| 2 +-
BaseTools/Source/C/LzmaCompress/Sdk/C/LzmaDec.c | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/BaseTools/Source/C/Dev
W dniu 21.08.2023 o 20:27, Leif Lindholm pisze:
Hmm, wait. Patch 1/3 adds Iort.aslc and patch 3/3 deletes it. I know
1/3 is Shashi's original implementation and 3/3 is heavily based on
that (if rewritten), but there's no point in merging the churn.
I kind of wanted to get review of both parts.
*Reminder: Tools, CI, Code base construction meeting series*
*When:*
Monday, August 21, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272
*Tools, CI, Code base construction meeting series*
*When:*
Monday, August 21, 2023
4:30pm to 5:30pm
(UTC-07:00) America/Los Angeles
*Where:*
https://teams.microsoft.com/l/meetup-join/19%3ameeting_ZDI2ZDg4NmMtMjI1My00MzI5LWFmYjAtMGQyNjUzNTBjZGYw%40thread.v2/0?context=%7b%22Tid%22%3a%2272f988bf-86f
Disable PcdFirstTimeWakeUpAPsBySipi for IntelTdx, Microvm, and Xen to
preserve the original execution of INIT-SIPI-SIPI.
Cc: Eric Dong
Cc: Ray Ni
Cc: Rahul Kumar
Cc: Gerd Hoffmann
Cc: Ard Biesheuvel
Cc: Jiewen Yao
Cc: Jordan Justen
Signed-off-by: Yuanhao Xie
---
OvmfPkg/IntelTdx/IntelTdxX
From: "Zhenyu Zhang"
When the variable store is full, edk2 will directly assert.
Add debug information to help users understand what caused
the assertion.
Actual results:
RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929-
48BCD90AD31A - 0x0003 - 0x7E
CommonVariableSpace = 0x
This patch provides fix for the file descriptor leak issue in
rename function from the LibC library of the StdLib of edk2-libc
Jayaprakash N (1):
edk2-libc/StdLib: file descriptor leak in rename()
StdLib/LibC/Uefi/Devices/UefiShell/daShell.c | 2 ++
1 file changed, 2 insertions(+)
--
2.40.0
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4529
rename() call leads to a function that makes open() for source file
to be renamed. The resulting file descriptor is never closed.
If you have to rename a couple of files this will quickly exhaust
the descriptor table.
The fix is trivial - ju
Hi Jiewen,
I update the patch V6 to V7, drop raw RSA3K and RSA4K. The change is in
SecurityPkg.
And I did all the tests which are listed in the cover letter. I got the
expected results.
Could you help to review/merge this V7 patch for secure boot feature ?
Thank you.
BR
Sheng Wei
> -Original
On Wed, Aug 16, 2023 at 03:11:46PM -0500, Michael Roth wrote:
> PcdFirstTimeWakeUpAPsBySipi was recently introduced to indicate when
> the full INIT-SIPI-SIPI sequence can be skipped for AP bringup. It is
> true by default, but needs to be disabled for QEMU/OVMF where early INIT
> is not simulated.
On Tue, Aug 22, 2023 at 09:57:14AM +0800, YuanhaoXie wrote:
> Disable PcdFirstTimeWakeUpAPsBySipi for IntelTdx, Microvm, and Xen to
> preserve the original execution of INIT-SIPI-SIPI.
>
> Cc: Eric Dong
> Cc: Ray Ni
> Cc: Rahul Kumar
> Cc: Gerd Hoffmann
> Cc: Ard Biesheuvel
> Cc: Jiewen Yao
On Thu, Jul 20, 2023 at 03:45:57PM +0200, Ard Biesheuvel wrote:
> Instead of relying on raising the TPL to protect the critical sections
> that manipulate the global bitmask that keeps track of bounce buffer
> allocations, use compare-and-exchange to manage the global variable, and
> tweak the logi
Hi Liming,
This is a bug fix and can cause data loss if the variable size > 4k.
Can it be included for the edk2-stable202308? Let me know if it requires
a BZ id.
I tried running the CI tests for this patch. But 2 of tests failed and I
don't think it has anything to do with this patch. If you are
37 matches
Mail list logo
