Acked-by: Jiewen Yao <jiewen....@intel.com>
> -----Original Message-----
> From: Gerd Hoffmann <kra...@redhat.com>
> Sent: Monday, August 21, 2023 11:29 PM
> To: Michael Roth <michael.r...@amd.com>
> Cc: devel@edk2.groups.io; Ni, Ray <ray...@intel.com>; Aktas, Erdem
> <erdemak...@google.com>; James Bottomley <j...@linux.ibm.com>; Yao,
> Jiewen <jiewen....@intel.com>; Xu, Min M <min.m...@intel.com>; Tom
> Lendacky <thomas.lenda...@amd.com>
> Subject: Re: [PATCH 1/2] OvmfPkg/AmdSev: fix BdsPlatform.c assertion failure
> during boot
>
> On Wed, Aug 16, 2023 at 03:11:45PM -0500, Michael Roth wrote:
> > Booting an SEV guest with AmdSev OVMF package currently triggers the
> > following assertion with QEMU:
> >
> > InstallQemuFwCfgTables: installed 7 tables
> > PcRtc: Write 0x20 to CMOS location 0x32
> > [Variable]END_OF_DXE is signaled
> > Initialize variable error flag (FF)
> >
> > ASSERT_EFI_ERROR (Status = Not Found)
> > ASSERT [BdsDxe]
> /home/VT_BUILD/ovmf/OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.
> c(1711): !(((INTN)(RETURN_STATUS)(Status)) < 0)
> >
> > This seems to be due to commit 81dc0d8b4c, which switched to using
> > PlatformBootManagerLib instead of PlatformBootManagerLibGrub. That
> > pulls in a dependency on gEfiS3SaveStateProtocolGuid provider being
> > available (which is asserted for in
> > BdsPlatform.c:PlatformBootManagerBeforeConsole()/SaveS3BootScript()),
> > but the libraries that provide it aren't currently included in the
> > build. Add them similarly to what's done for OvmfPkg.
> >
> > Fixes: 81dc0d8b4c ("OvmfPkg/AmdSev: stop using
> PlatformBootManagerLibGrub")
> > Cc: Gerd Hoffmann <kra...@redhat.com>
> > Cc: Ray Ni <ray...@intel.com>
> > Cc: Erdem Aktas <erdemak...@google.com>
> > Cc: James Bottomley <j...@linux.ibm.com>
> > Cc: Jiewen Yao <jiewen....@intel.com>
> > Cc: Min Xu <min.m...@intel.com>
> > Cc: Tom Lendacky <thomas.lenda...@amd.com>
> > Signed-off-by: Michael Roth <michael.r...@amd.com>
>
> Acked-by: Gerd Hoffmann <kra...@redhat.com>
>
> should be added to the stable tag.
>
> take care,
> Gerd
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#107923): https://edk2.groups.io/g/devel/message/107923
Mute This Topic: https://groups.io/mt/100787519/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
