Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB

Nit: "sizeof" is normally used like a function. And this patch mixes the two styles. Other than that: Reviewed-by: Rebecca Cran -- Rebecca Cran On 7/24/23 06:59, Corvin Köhne wrote: Copy the function BuildPlatformInfoHob() from OvmfPkg/PlatformPei. QemuFwCfgLib expect this HOB to be pre

[edk2-devel] [PATCH 1/1] MdeModulePkg:Add variable store exceed maximum debug info

When the variable store is full, edk2 will directly assert. Add debug information to help users understand what caused the assertion. Actual results: RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929- 48BCD90AD31A - 0x0003 - 0x7E CommonVariableSpace = 0x3FF9C - CommonVariableT

[edk2-devel] [PATCH 1/1] MdeModulePkg:Add variable store exceed maximum debug info

From: "Zhenyu Zhang" When the variable store is full, edk2 will directly assert. Add debug information to help users understand what caused the assertion. Actual results: RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929- 48BCD90AD31A - 0x0003 - 0x7E CommonVariableSpace = 0x

[edk2-devel] [PATCH 1/1] MdeModulePkg:Add variable store exceed maximum debug info

When the variable store is full, edk2 will directly assert. Add debug information to help users understand what caused the assertion. Actual results: RecordVarErrorFlag (0xEF) 9A144FE2A47E:937FE521-95AE-4D1A-8929- 48BCD90AD31A - 0x0003 - 0x7E CommonVariableSpace = 0x3FF9C - CommonVariableT

Re: [edk2-devel] [PATCH v1 1/1] OvmfPkg/Bhyve: build platform info HOB

On Tue, 8 Aug 2023 at 15:33, Rebecca Cran wrote: > > Nit: "sizeof" is normally used like a function. And this patch mixes the > two styles. > Actually, this is not unidiomatic for OVMF - sizeof takes either a type name (in which case the () are required) or an expression (in which case they are o

Re: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM Parser

Hi Pierre > -Original Message- > From: Rohit Mathew > Sent: Monday, August 7, 2023 1:45 PM > To: Pierre Gondois ; devel@edk2.groups.io > Cc: Thomas Abraham ; Sami Mujawar > ; James Morse ; Ray Ni > ; Zhichao Gao ; nd > > Subject: RE: [edk2-devel] [PATCH V3 3/3] ShellPkg/AcpiView: Add MPAM

Re: [edk2-devel] [PATCH] SecurityPkg: DxeTcg2PhysicalPresenceLib for Clear Graphics Screen To unblock and Display TPM messages

Hi @Yao, Jiewen, Thanks for your review and feedback. When there is a pending Tcg request, the control will be in Tcg2 library and it will not reach to BDS until user press the input key. As there is no information the screen because of screen is blocked by some othe

Re: [edk2-devel] [PATCH] Intel/MinPlatformPkg:Add MmSaveStateLib required by PiSmmCpuDxe

Reviewed-by: Nate DeSimone > -Original Message- > From: Tan, Dun > Sent: Wednesday, July 26, 2023 7:22 PM > To: devel@edk2.groups.io > Cc: Ni, Ray ; Chiu, Chasel ; > Desimone, Nathaniel L ; Oram, Isaac W > ; Gao, Liming ; Dong, > Eric > Subject: [PATCH] Intel/MinPlatformPkg:Add MmSaveSt

Re: [edk2-devel] [PATCH] ASpeed/ASpeedGopBinPkg: Update X64/AArch Gop UEFI Driver

Reviewed-by: Nate DeSimone > -Original Message- > From: Tommy Huang > Sent: Monday, August 7, 2023 11:12 PM > To: devel@edk2.groups.io > Cc: a...@kernel.org; Oram, Isaac W ; Desimone, > Nathaniel L ; quic_llind...@quicinc.com; > Kinney, Michael D ; Chen, Ryan > ; bmc...@aspeedtech.com >

Re: [edk2-devel] [edk2-platforms: PATCH] MinPlatformPkg: Add FSP 2.4 MultiPhase library.

Yes: https://www.intel.com/content/www/us/en/content-details/736809/content-details.html > -Original Message- > From: Tim Lewis > Sent: Thursday, September 1, 2022 1:55 PM > To: devel@edk2.groups.io; Chiu, Chasel > Cc: Desimone, Nathaniel L ; Oram, Isaac W > ; Gao, Liming ; Dong, > Eric

Re: [edk2-devel] [PATCH] SecurityPkg: DxeTcg2PhysicalPresenceLib for Clear Graphics Screen To unblock and Display TPM messages

My concern is that you unconditionally clear the screen. What if someone did want to show something on the screen? This seems an incompatible change. That is why I think it should be a platform policy. Another way is that you may consider to duplicate the library for your platform and clear it

Re: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9

Hi Ken Do you have any additional feedback for the patch set? We are waiting for that since this is a feature needed for 202308 tag. Thank you Yao, Jiewen > -Original Message- > From: Michael Kubacki > Sent: Saturday, August 5, 2023 6:55 AM > To: devel@edk2.groups.io; Johnson, Brian ; G

Re: 回复: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9

Hi Jiewen, I've tested the changes on our physical and virtual platforms to make sure metrics aren't deviating from our current expectations. Our PEI module roughly doubles in size (34.8 KB to 64.5 KB) and our DXE and SMM modules grow by around 300 KB (1100 KB to 1424.5 KB for DXE and 816 KB to