On Tue, 8 Aug 2023 at 15:33, Rebecca Cran <rebe...@bsdio.com> wrote: > > Nit: "sizeof" is normally used like a function. And this patch mixes the > two styles. >
Actually, this is not unidiomatic for OVMF - sizeof takes either a type name (in which case the () are required) or an expression (in which case they are optional), and we have always permitted both idioms for the latter case. $ git grep -cE 'sizeof\s*[:alnum:]' OvmfPkg/ OvmfPkg/Bhyve/BhyveRfbDxe/VbeShim.c:4 OvmfPkg/EnrollDefaultKeys/AuthData.c:4 OvmfPkg/IncompatiblePciDeviceSupportDxe/IncompatiblePciDeviceSupport.c:7 OvmfPkg/Library/PciHostBridgeUtilityLib/PciHostBridgeUtilityLib.c:1 OvmfPkg/PlatformPei/MemTypeInfo.c:1 OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.c:5 OvmfPkg/QemuVideoDxe/VbeShim.c:4 OvmfPkg/SmmControl2Dxe/SmiFeatures.c:4 OvmfPkg/Virtio10Dxe/Virtio10.c:1 OvmfPkg/VirtioGpuDxe/DriverBinding.c:4 > Other than that: > > > Reviewed-by: Rebecca Cran <rebe...@bsdio.com> > Thanks I've tried to merge this but I am getting errors and I cannot figure out what they are: https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=99505&view=results -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107642): https://edk2.groups.io/g/devel/message/107642 Mute This Topic: https://groups.io/mt/100327419/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
