Re: [edk2-devel] [PATCH edk2-platforms v1 2/3] Platform/ARM: FVP: Specify TRBE interrupt in MADT GICC

2023-08-03 Thread Sami Mujawar
Hi Jeshua, On Wed, Aug 2, 2023 at 02:48 PM, Jeshua Smith wrote: > > This code depends on ArmReadIdAA64Dfr0(), which as far as I can tell is > not present in the EDK2 repo or the patch series mentioned in your 0/3 > message. > toggle quoted message Show quoted text ( #quoted-225764875 ) Apparentl

Re: [edk2-devel] [PATCH v1 05/11] DynamicTablesPkg: Update MADT generator for ACPI 6.5

2023-08-03 Thread Sami Mujawar
Hi Jeshua, Thank you for the feedback. On Tue, Aug 1, 2023 at 08:44 AM, Jeshua Smith wrote: > > It looks like you are setting the wrong field here (should be > TrbeInterrupt, not SpeOverflowInterrupt): > + // Setting TrbeInterrupt to 0 ensures backward compatibility with > + // ACPI 6.4 > + Gic

Re: [edk2-devel] [PATCH V5 1/3] MdePkg/Include: Add GUID for CERT_RSA3072 and CERT_RSA4096

2023-08-03 Thread Sheng Wei
Hi Liming, Sorry for the late response. The two new GUID are not in the public UEFI spec yet. Do we have any process to add these 2 new GUIDs ? Thank you. BR Sheng Wei > -Original Message- > From: gaoliming > Sent: 2023年8月2日 17:12 > To: Sheng, W ; devel@edk2.groups.io > Cc: Yao, Jiewen

Re: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9

2023-08-03 Thread Yao, Jiewen
Acked-by: Jiewen Yao Since this is a very big patch, I would wait for another week to give people chance to review, try and test. Please comment if you have any feedback. If no additional feedback is received, I will try to merge next week. Thank you Yao, Jiewen > -Original Message-

Re: [edk2-devel] [PATCH V5 1/3] MdePkg/Include: Add GUID for CERT_RSA3072 and CERT_RSA4096

2023-08-03 Thread Yao, Jiewen
Hey We cannot add anything not defined in UEFI spec yet. Thanks Liming to catch that. Can you remove CERT_RSA3072 and CERT_RSA4096? I think we need to use EFI_CERT_TYPE_PKCS7_GUID + EFI_CERT_X509_GUID to support RSA3072 and RSA4096. Have you validated that configuration? > -Original Messa

Re: [edk2-devel] [PATCH V1 1/1] UefiCpuPkg/ResetVector: Cache Disable should not be set by default in CR0

2023-08-03 Thread Ni, Ray
The patch resolves an issue in Boot Guard enabled system that NEM is already enabled by Boot Guard, disabling cache evicts all cache content which is unexpected. Reviewed-by: Ray Ni > -Original Message- > From: devel@edk2.groups.io On Behalf Of Ni, Ray > Sent: Wednesday, July 26, 2023

Re: [edk2-devel] [PATCH 00/29] CryptoPkg: Update OpenSSL submodule to 3.0.9

2023-08-03 Thread Ard Biesheuvel
On Thu, 3 Aug 2023 at 09:58, Yao, Jiewen wrote: > > Acked-by: Jiewen Yao > > Since this is a very big patch, I would wait for another week to give people > chance to review, try and test. > > Please comment if you have any feedback. > > If no additional feedback is received, I will try to merge

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishRestExDxe: return HTTP status code to caller.

2023-08-03 Thread Mike Maslenkin
Yes. I suggest not to release ResponseMessage->Body There is a function RestConfigFreeHttpMessage releasing Message->Body as well as Message->Data.Response https://github.com/tianocore/edk2/blob/master/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c#L134 called from: https://git

Re: [edk2-devel] [PATCH v2] MdeModulePkg: AllocatePages for TranslateBmpToGopBlt

2023-08-03 Thread Pedro Falcato
On Thu, Aug 3, 2023 at 6:00 AM chitralekha ck wrote: > > https://bugzilla.tianocore.org/show_bug.cgi?id=4507 > AllocatePool limits to allocate memory of 64 KB at most in PEI Phase. > AllocatePool() is being avoided due to its 64k allocation size limit > when the library is incorporated into a PEI

回复: [edk2-devel] [PATCH V2 1/6] MdePkg/Include: Update definitions of SPI related header files

2023-08-03 Thread gaoliming via groups.io
Abner: The rule bases on the public spec. So, we need to wait for the spec. Thanks Liming > -邮件原件- > 发件人: devel@edk2.groups.io 代表 Chang, Abner > via groups.io > 发送时间: 2023年8月2日 15:49 > 收件人: gaoliming ; devel@edk2.groups.io > 抄送: 'Michael D Kinney' ; 'Zhiguang Liu' > ; Attar, AbdulLatee

[edk2-devel] 回复: [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore

2023-08-03 Thread gaoliming via groups.io
Reviewed-by: Liming Gao > -邮件原件- > 发件人: Bi, Dandan > 发送时间: 2023年8月3日 12:53 > 收件人: Gao, Liming ; Dong, Eric > ; devel@edk2.groups.io > 主题: RE: [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via > GetVariable for EfiVarStore > > Hi Liming, > > Yes, with this change, the performance i

[edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-03 Thread Oliver Steffen
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 PR: https://github.com/tianocore/edk2/pull/4711 This series switches the OVMF CI jobs on Windows to a recent Qemu version and re-enables SMP in the Qemu "Run to shell" CI jobs. The Qemu tests run a little bit slower in SMP mode and sometime

[edk2-devel] [PATCH v1 2/4] OvmfPkg/PlatformCI VS2019: Disable workaround for cpuhp bugfix

2023-08-03 Thread Oliver Steffen
This reverts commit 3beb8c965455f4c1cc3184e36c627ef1d9bfe5f9. Both Windows and Linux CI jobs are now using Qemu 8, this workaround is no longer needed. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 Signed-off-by: Oliver Steffen --- .../PlatformCI/.azurepipelines/Windows-VS2019.yml

[edk2-devel] [PATCH v1 1/4] OvmfPkg/PlatformCI: Use recent Qemu on Windows

2023-08-03 Thread Oliver Steffen
Bump the version of the Qemu chocolatey package up to 2023.7.25. The Linux CI is already using Qemu 8. REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 Signed-off-by: Oliver Steffen --- OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +- 1 file changed, 1 insertion(+), 1 delet

[edk2-devel] [PATCH v1 3/4] OvmfPkg/PlatformCI: Boot OVMF in SMP mode.

2023-08-03 Thread Oliver Steffen
From: Gerd Hoffmann Increase the chance that CI finds bugs in MP changes. Signed-off-by: Gerd Hoffmann (cherry picked from commit f92a9dce10281c103b04d6b38283e0ff1d677b91) Reapplying, since the CI (Windows and Linux) use Qemu 8 now, which works with SMP again. REF: https://bugzilla.tianocore.

[edk2-devel] [PATCH v1 4/4] CI: Increase time limit of "Run to shell" task to 4 minutes

2023-08-03 Thread Oliver Steffen
The current job time limit of 2 minutes is just a little bit too short for running Qemu in SMP mode. Signed-off-by: Oliver Steffen --- .azurepipelines/templates/platform-build-run-steps.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.azurepipelines/templates/platform-bui

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-03 Thread Ard Biesheuvel
On Thu, 3 Aug 2023 at 13:44, Oliver Steffen wrote: > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 > PR: https://github.com/tianocore/edk2/pull/4711 > > This series switches the OVMF CI jobs on Windows to a recent Qemu > version and re-enables SMP in the Qemu "Run to shell" CI jobs.

Re: [edk2-devel] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue.

2023-08-03 Thread Igor Kulchytskyy via groups.io
Thank you, Nickle. -Original Message- From: Nickle Wang Sent: Thursday, August 03, 2023 2:00 AM To: Igor Kulchytskyy ; devel@edk2.groups.io Cc: Abner Chang ; Nick Ramirez Subject: RE: [EXTERNAL] [PATCH] RedfishPkg/RedfishPlatformConfigDxe: fix can not set one-of option issue. Hi Igor,

Re: [edk2-devel] [PATCH edk2-platforms v3 0/3] Platform/QemuSbsa: add GIC ITS

2023-08-03 Thread Ard Biesheuvel
On Wed, 19 Jul 2023 at 14:09, Marcin Juszkiewicz wrote: > > SBSA Reference Platform can have GIC ITS present. And when it has then > we can have complex PCI Express setup (and some other things). > > First patch adds support for GIC ITS. Address is read from TF-A via SMC > call. IORT is generated,

[edk2-devel] Event: TianoCore edk2-test Bug Triage Meeting - Thursday, August 3, 2023 #cal-reminder

2023-08-03 Thread Group Notification
*Reminder: TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, August 3, 2023 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@a

Re: [edk2-devel] [PATCH edk2-platforms] SbsaQemu: fix typo

2023-08-03 Thread Ard Biesheuvel
On Tue, 18 Jul 2023 at 12:22, Marcin Juszkiewicz wrote: > > From: Masahisa Kojima > > Fix typo in Readme.md > > Signed-off-by: Masahisa Kojima > Signed-off-by: Marcin Juszkiewicz > --- > Platform/Qemu/SbsaQemu/Readme.md | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Pushed, thanks.

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-03 Thread Laszlo Ersek
On 8/3/23 15:03, Ard Biesheuvel wrote: > On Thu, 3 Aug 2023 at 13:44, Oliver Steffen wrote: >> >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 >> PR: https://github.com/tianocore/edk2/pull/4711 >> >> This series switches the OVMF CI jobs on Windows to a recent Qemu >> version and re-e

[edk2-devel] Now: TianoCore edk2-test Bug Triage Meeting - Thursday, August 3, 2023 #cal-notice

2023-08-03 Thread Group Notification
*TianoCore edk2-test Bug Triage Meeting* *When:* Thursday, August 3, 2023 10:00pm to 11:00pm (UTC+08:00) Asia/Shanghai *Where:* https://armltd.zoom.us/j/91247522013?pwd=ei9nUndTbG9oWEROS2M1aVREZkpiQT09&from=addon *Organizer:* Edhaya Chandran edhaya.chand...@arm.com ( edhaya.chand...@arm.com?sub

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-03 Thread Oliver Steffen
On Thu, Aug 3, 2023 at 3:51 PM Laszlo Ersek wrote: > > On 8/3/23 15:03, Ard Biesheuvel wrote: > > On Thu, 3 Aug 2023 at 13:44, Oliver Steffen wrote: > >> > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 > >> PR: https://github.com/tianocore/edk2/pull/4711 > >> > >> This series switc

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-03 Thread Michael Kubacki
For the series. Reviewed-by: Michael Kubacki On 8/3/2023 7:44 AM, Oliver Steffen wrote: REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4324 PR: https://github.com/tianocore/edk2/pull/4711 This series switches the OVMF CI jobs on Windows to a recent Qemu version and re-enables SMP in the

Re: [edk2-devel] [PATCH v2 1/1] ArmPkg: DefaultExceptionHandlerLib: Do Not Allocate Memory

2023-08-03 Thread Ard Biesheuvel
On Wed, 2 Aug 2023 at 20:59, Oliver Smith-Denny wrote: > > Changes since v1: > - Move OutputString write to after serial logging > - Drop sending "Recursive Exception" to ConOut > > If gST->ConOut is available when Arm's DefaultExceptionHandler > is running, AsciiPrint will get called to attempt t

Re: [edk2-devel] [PATCH edk2-platforms v1 2/3] Platform/ARM: FVP: Specify TRBE interrupt in MADT GICC

2023-08-03 Thread Jeshua Smith via groups.io
My apologies, I see it there now. I had gotten zero results when I searched for it on github.com/tianocore/edk2, but it looks like that was user error on my part. From: Sami Mujawar Sent: Thursday, August 3, 2023 1:01 AM To: Jeshua Smith ; devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH e

[edk2-devel] Event: TianoCore Community Meeting EMEA/NAMO - Thursday, August 3, 2023 #cal-reminder

2023-08-03 Thread Group Notification
*Reminder: TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, August 3, 2023 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Jo

[edk2-devel] Now: TianoCore Community Meeting EMEA/NAMO - Thursday, August 3, 2023 #cal-notice

2023-08-03 Thread Group Notification
*TianoCore Community Meeting EMEA/NAMO* *When:* Thursday, August 3, 2023 8:00am to 9:00am (UTC-07:00) America/Los Angeles *Where:* Microsoft Teams meeting Join on your computer or mobile app Click here to join the meeting Meeting ID: 226 323 011 029 Passcode: hMRCj6 Download Teams | Join on the

Re: [edk2-devel] [PATCH v1 0/3] Add support for handling SGI and pending interrupts

2023-08-03 Thread Ard Biesheuvel
On Wed, 26 Jul 2023 at 20:45, Kun Qin wrote: > > Hi Ard, > > Our current use case is around AP core suspension and wake-ups. > > The program can suspend the secondary cores through PSCI interfaces > (after powering > them on). BSP can then wake up the suspended cores through SGI on demand. > The

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-03 Thread Ard Biesheuvel
On Thu, 3 Aug 2023 at 16:37, Michael Kubacki wrote: > > For the series. > > Reviewed-by: Michael Kubacki > Thanks I've pushed this to the CI but Platform_CI OVMF_IA32X64_FULL_DEBUG keeps timing out for me https://github.com/tianocore/edk2/pull/4718 Might it help if we restrict SMP to a subset

Re: [edk2-devel] [PATCH v1 0/3] Add support for handling SGI and pending interrupts

2023-08-03 Thread Leif Lindholm
On 2023-08-03 16:33, Ard Biesheuvel wrote: On Wed, 26 Jul 2023 at 20:45, Kun Qin wrote: Hi Ard, Our current use case is around AP core suspension and wake-ups. The program can suspend the secondary cores through PSCI interfaces (after powering them on). BSP can then wake up the suspended cor

Re: [edk2-devel] [PATCH v1 0/3] Add support for handling SGI and pending interrupts

2023-08-03 Thread Kun Qin
Hi Leif & Ard, You are correct. The main use case is around silicon testing. There is currently no UEFI or PI spec around such functionality though. Manipulating pending interrupts might be a far fetch, but can we fix "ArmGicSendSgiTo" function on GIC v3 and v4? It is declared as a public inter

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-03 Thread Michael D Kinney
Hi Ard, This is the email with the analysis and the flag setting required for SMP to work with SMM enabled for IA32/X64 QEMU. https://edk2.groups.io/g/devel/message/102364 I tried latest version of QEMU earlier in the Summer and did not see any improvements. Mike > -Original Message-

Re: [edk2-devel] [PATCH v1 0/4] Use Qemu 8 in CI and enable SMP in tests

2023-08-03 Thread Ard Biesheuvel
On Thu, 3 Aug 2023 at 21:21, Kinney, Michael D wrote: > > Hi Ard, > > This is the email with the analysis and the flag > setting required for SMP to work with SMM enabled for > IA32/X64 QEMU. > > https://edk2.groups.io/g/devel/message/102364 > > > I tried latest version of QEMU earlier in the Summ

[edk2-devel] Event: TianoCore Community Meeting - APAC/NAMO - Thursday, August 3, 2023 #cal-reminder

2023-08-03 Thread Group Notification
*Reminder: TianoCore Community Meeting - APAC/NAMO* *When:* Thursday, August 3, 2023 7:30pm to 8:30pm (UTC-07:00) America/Los Angeles *Where:* https://teams.microsoft.com/l/meetup-join/19%3ameeting_Y2M1NDE3ODYtN2M3Yy00MDMxLTk3OWYtMTlkNjhlNWFlMjA2%40thread.v2/0?context=%7b%22Tid%22%3a%2246c98d88-e

Re: [edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore

2023-08-03 Thread Ni, Ray
+ @Rothman, Michael A who designed UEFI HII. The patch moves the variable access from implementation of ConfigAccess protocol to Setup driver for efivarstore. Is it a valid assumption? Thanks, Ray > -Original Message- > From: devel@edk2.groups.io On Behalf Of Dandan > Bi > Sent: Thursd

Re: [edk2-devel] [PATCH v2] MdeModulePkg/SetupBrowser: Load storage via GetVariable for EfiVarStore

2023-08-03 Thread Ni, Ray
The specific ask is: does the change cause any flexibility lost in HiiConfigAccess implementation? E.g.: something was possible to be done in HiiConfigAccess implementation even for efivarstore but cannot be done with this change. > -Original Message- > From: Ni, Ray > Sent: Friday, Aug

Re: [edk2-devel] [PATCH] OvmfPkg/BaseMemEncryptTdxLib: Make SetOrClearSharedBit() handle retry error

2023-08-03 Thread Min Xu
Reviewed-by: Min Xu > -Original Message- > From: Yamahata, Isaku > Sent: Thursday, August 3, 2023 5:09 AM > To: devel@edk2.groups.io > Cc: isaku.yamah...@gmail.com; Yamahata, Isaku > ; Yao, Jiewen ; Xu, Min > M > Subject: [PATCH] OvmfPkg/BaseMemEncryptTdxLib: Make > SetOrClearSharedBit(