Yes. I suggest not to release ResponseMessage->Body There is a function RestConfigFreeHttpMessage releasing Message->Body as well as Message->Data.Response https://github.com/tianocore/edk2/blob/master/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c#L134
called from: https://github.com/tianocore/edk2/blob/master/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c#L555 https://github.com/tianocore/edk2/blob/master/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c#L734 https://github.com/tianocore/edk2/blob/master/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c#L921 https://github.com/tianocore/edk2/blob/master/RedfishPkg/PrivateLibrary/RedfishLib/edk2libredfish/src/service.c#L1080 So I guess RestConfigFreeHttpMessage() makes a proper resource deallocation otherwise patch introduces a memory leak for error handling path, for example here: https://github.com/tianocore/edk2/blob/master/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c#L429 and https://github.com/tianocore/edk2/blob/master/RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c#L364 and so on. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107529): https://edk2.groups.io/g/devel/message/107529 Mute This Topic: https://groups.io/mt/100292372/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
